Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/1261088/?format=api
{ "id": 1261088, "url": "http://patchwork.ozlabs.org/api/patches/1261088/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20200325003824.5487-8-andre.guedes@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20200325003824.5487-8-andre.guedes@intel.com>", "list_archive_url": null, "date": "2020-03-25T00:38:21", "name": "[07/10] igc: Remove '\\n' from log strings in igc_i225.c", "commit_ref": null, "pull_url": null, "state": "rejected", "archived": false, "hash": "58a9d833d14a2eef54acd71ad6ef57a9bb3f980f", "submitter": { "id": 72323, "url": "http://patchwork.ozlabs.org/api/people/72323/?format=api", "name": "Andre Guedes", "email": "andre.guedes@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20200325003824.5487-8-andre.guedes@intel.com/mbox/", "series": [ { "id": 166478, "url": "http://patchwork.ozlabs.org/api/series/166478/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=166478", "date": "2020-03-25T00:38:14", "name": "igc: Align log messages", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/166478/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/1261088/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/1261088/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": [ "ozlabs.org; spf=pass (sender SPF authorized)\n\tsmtp.mailfrom=osuosl.org (client-ip=140.211.166.136;\n\thelo=silver.osuosl.org;\n\tenvelope-from=intel-wired-lan-bounces@osuosl.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org;\n\tdmarc=fail (p=none dis=none) header.from=intel.com" ], "Received": [ "from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 48n8PV0qmdz9sR4\n\tfor <incoming@patchwork.ozlabs.org>;\n\tWed, 25 Mar 2020 11:38:54 +1100 (AEDT)", "from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id 70E4A20009;\n\tWed, 25 Mar 2020 00:38:52 +0000 (UTC)", "from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id Uim8+6mSJhpn; Wed, 25 Mar 2020 00:38:44 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby silver.osuosl.org (Postfix) with ESMTP id E8FA4235B8;\n\tWed, 25 Mar 2020 00:38:40 +0000 (UTC)", "from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\tby ash.osuosl.org (Postfix) with ESMTP id BC5621BF999\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 25 Mar 2020 00:38:37 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id B99D620028\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 25 Mar 2020 00:38:37 +0000 (UTC)", "from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id 1L-8MNoEDn8z for <intel-wired-lan@lists.osuosl.org>;\n\tWed, 25 Mar 2020 00:38:36 +0000 (UTC)", "from mga05.intel.com (mga05.intel.com [192.55.52.43])\n\tby silver.osuosl.org (Postfix) with ESMTPS id B49F42012F\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 25 Mar 2020 00:38:36 +0000 (UTC)", "from fmsmga006.fm.intel.com ([10.253.24.20])\n\tby fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; \n\t24 Mar 2020 17:38:36 -0700", "from johnorte-mobl2.amr.corp.intel.com ([10.251.10.249])\n\tby fmsmga006.fm.intel.com with ESMTP; 24 Mar 2020 17:38:36 -0700" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "IronPort-SDR": [ "CSknj1UlMFT/3NI7vh+D8IacTYqrOTyZ0aapA/OG+JaJQpOad4NEfIqLNI1Utlvl9zXFMbEoHJ\n\tD6X/Av1deR1w==", "ee+aGW3VCGxCZprw+l6K5X0yE4YG3gETu9Gjk/mhpSZ0VDE6mJpsd7sqW/fVxHojIdJ+61UZPb\n\t2EbNo+vcN1jA==" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.72,302,1580803200\"; d=\"scan'208\";a=\"448099349\"", "From": "Andre Guedes <andre.guedes@intel.com>", "To": "intel-wired-lan@lists.osuosl.org", "Date": "Tue, 24 Mar 2020 17:38:21 -0700", "Message-Id": "<20200325003824.5487-8-andre.guedes@intel.com>", "X-Mailer": "git-send-email 2.25.0", "In-Reply-To": "<20200325003824.5487-1-andre.guedes@intel.com>", "References": "<20200325003824.5487-1-andre.guedes@intel.com>", "MIME-Version": "1.0", "Subject": "[Intel-wired-lan] [PATCH 07/10] igc: Remove '\\n' from log strings\n\tin igc_i225.c", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "To keep log strings in igc_i225.c consistent with the rest of the driver\ncode, this patch removes the '\\n' character at the end. The newline\ncharacter is automatically added by netdev_dbg() so there is no changes\nin the output.\n\nNote: hw_dbg() is a macro that expands to netdev_dbg().\n\nSigned-off-by: Andre Guedes <andre.guedes@intel.com>\n---\n drivers/net/ethernet/intel/igc/igc_i225.c | 22 +++++++++++-----------\n 1 file changed, 11 insertions(+), 11 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/igc/igc_i225.c b/drivers/net/ethernet/intel/igc/igc_i225.c\nindex c25f555aaf82..a5856ae87a7e 100644\n--- a/drivers/net/ethernet/intel/igc/igc_i225.c\n+++ b/drivers/net/ethernet/intel/igc/igc_i225.c\n@@ -71,7 +71,7 @@ static s32 igc_get_hw_semaphore_i225(struct igc_hw *hw)\n \n \t\t/* If we do not have the semaphore here, we have to give up. */\n \t\tif (i == timeout) {\n-\t\t\thw_dbg(\"Driver can't access device - SMBI bit is set.\\n\");\n+\t\t\thw_dbg(\"Driver can't access device - SMBI bit is set\");\n \t\t\treturn -IGC_ERR_NVM;\n \t\t}\n \t}\n@@ -91,7 +91,7 @@ static s32 igc_get_hw_semaphore_i225(struct igc_hw *hw)\n \tif (i == timeout) {\n \t\t/* Release semaphores */\n \t\tigc_put_hw_semaphore(hw);\n-\t\thw_dbg(\"Driver can't access the NVM\\n\");\n+\t\thw_dbg(\"Driver can't access the NVM\");\n \t\treturn -IGC_ERR_NVM;\n \t}\n \n@@ -131,7 +131,7 @@ s32 igc_acquire_swfw_sync_i225(struct igc_hw *hw, u16 mask)\n \t}\n \n \tif (i == timeout) {\n-\t\thw_dbg(\"Driver can't access resource, SW_FW_SYNC timeout.\\n\");\n+\t\thw_dbg(\"Driver can't access resource, SW_FW_SYNC timeout\");\n \t\tret_val = -IGC_ERR_SWFW_SYNC;\n \t\tgoto out;\n \t}\n@@ -228,7 +228,7 @@ static s32 igc_write_nvm_srwr(struct igc_hw *hw, u16 offset, u16 words,\n \t */\n \tif (offset >= nvm->word_size || (words > (nvm->word_size - offset)) ||\n \t words == 0) {\n-\t\thw_dbg(\"nvm parameter(s) out of bounds\\n\");\n+\t\thw_dbg(\"nvm parameter(s) out of bounds\");\n \t\tret_val = -IGC_ERR_NVM;\n \t\tgoto out;\n \t}\n@@ -250,7 +250,7 @@ static s32 igc_write_nvm_srwr(struct igc_hw *hw, u16 offset, u16 words,\n \t\t}\n \n \t\tif (ret_val) {\n-\t\t\thw_dbg(\"Shadow RAM write EEWR timed out\\n\");\n+\t\t\thw_dbg(\"Shadow RAM write EEWR timed out\");\n \t\t\tbreak;\n \t\t}\n \t}\n@@ -369,7 +369,7 @@ static s32 igc_update_flash_i225(struct igc_hw *hw)\n \n \tret_val = igc_pool_flash_update_done_i225(hw);\n \tif (ret_val == -IGC_ERR_NVM) {\n-\t\thw_dbg(\"Flash update time out\\n\");\n+\t\thw_dbg(\"Flash update time out\");\n \t\tgoto out;\n \t}\n \n@@ -378,9 +378,9 @@ static s32 igc_update_flash_i225(struct igc_hw *hw)\n \n \tret_val = igc_pool_flash_update_done_i225(hw);\n \tif (ret_val)\n-\t\thw_dbg(\"Flash update time out\\n\");\n+\t\thw_dbg(\"Flash update time out\");\n \telse\n-\t\thw_dbg(\"Flash update complete\\n\");\n+\t\thw_dbg(\"Flash update complete\");\n \n out:\n \treturn ret_val;\n@@ -406,7 +406,7 @@ static s32 igc_update_nvm_checksum_i225(struct igc_hw *hw)\n \t */\n \tret_val = igc_read_nvm_eerd(hw, 0, 1, &nvm_data);\n \tif (ret_val) {\n-\t\thw_dbg(\"EEPROM read failed\\n\");\n+\t\thw_dbg(\"EEPROM read failed\");\n \t\tgoto out;\n \t}\n \n@@ -423,7 +423,7 @@ static s32 igc_update_nvm_checksum_i225(struct igc_hw *hw)\n \t\tret_val = igc_read_nvm_eerd(hw, i, 1, &nvm_data);\n \t\tif (ret_val) {\n \t\t\thw->nvm.ops.release(hw);\n-\t\t\thw_dbg(\"NVM Read Error while updating checksum.\\n\");\n+\t\t\thw_dbg(\"NVM Read Error while updating checksum\");\n \t\t\tgoto out;\n \t\t}\n \t\tchecksum += nvm_data;\n@@ -433,7 +433,7 @@ static s32 igc_update_nvm_checksum_i225(struct igc_hw *hw)\n \t\t\t\t &checksum);\n \tif (ret_val) {\n \t\thw->nvm.ops.release(hw);\n-\t\thw_dbg(\"NVM Write Error while updating checksum.\\n\");\n+\t\thw_dbg(\"NVM Write Error while updating checksum\");\n \t\tgoto out;\n \t}\n \n", "prefixes": [ "07/10" ] }