Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/1261085/?format=api
{ "id": 1261085, "url": "http://patchwork.ozlabs.org/api/patches/1261085/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20200325003824.5487-7-andre.guedes@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20200325003824.5487-7-andre.guedes@intel.com>", "list_archive_url": null, "date": "2020-03-25T00:38:20", "name": "[06/10] igc: Use netdev log helpers in igc_diag.c", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": false, "hash": "dd181416de0290eafc630e8c9b52748442de18e5", "submitter": { "id": 72323, "url": "http://patchwork.ozlabs.org/api/people/72323/?format=api", "name": "Andre Guedes", "email": "andre.guedes@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20200325003824.5487-7-andre.guedes@intel.com/mbox/", "series": [ { "id": 166478, "url": "http://patchwork.ozlabs.org/api/series/166478/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=166478", "date": "2020-03-25T00:38:14", "name": "igc: Align log messages", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/166478/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/1261085/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/1261085/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": [ "ozlabs.org; spf=pass (sender SPF authorized)\n\tsmtp.mailfrom=osuosl.org (client-ip=140.211.166.136;\n\thelo=silver.osuosl.org;\n\tenvelope-from=intel-wired-lan-bounces@osuosl.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org;\n\tdmarc=fail (p=none dis=none) header.from=intel.com" ], "Received": [ "from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 48n8PL5050z9sRY\n\tfor <incoming@patchwork.ozlabs.org>;\n\tWed, 25 Mar 2020 11:38:46 +1100 (AEDT)", "from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id 9771720009;\n\tWed, 25 Mar 2020 00:38:44 +0000 (UTC)", "from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id in+f0zeUtDlD; Wed, 25 Mar 2020 00:38:40 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby silver.osuosl.org (Postfix) with ESMTP id 6654E2034C;\n\tWed, 25 Mar 2020 00:38:40 +0000 (UTC)", "from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\tby ash.osuosl.org (Postfix) with ESMTP id 93D3D1BF32A\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 25 Mar 2020 00:38:37 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id 8CD9E20028\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 25 Mar 2020 00:38:37 +0000 (UTC)", "from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id KYJv-t5bHgnw for <intel-wired-lan@lists.osuosl.org>;\n\tWed, 25 Mar 2020 00:38:36 +0000 (UTC)", "from mga05.intel.com (mga05.intel.com [192.55.52.43])\n\tby silver.osuosl.org (Postfix) with ESMTPS id 7664D20009\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 25 Mar 2020 00:38:36 +0000 (UTC)", "from fmsmga006.fm.intel.com ([10.253.24.20])\n\tby fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; \n\t24 Mar 2020 17:38:36 -0700", "from johnorte-mobl2.amr.corp.intel.com ([10.251.10.249])\n\tby fmsmga006.fm.intel.com with ESMTP; 24 Mar 2020 17:38:36 -0700" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "IronPort-SDR": [ "dvydxzp34ramyCGx7AxXrmTvGBYz/2R0VBTmwWCHau9Q1z7+T2wOOhQ9b8Mn1EYiDPV82/F7cy\n\t2D5wrBqslR9w==", "7mVBzSnXtBpF0pX/k+7QKPSCMnk3JBVOlTyvgbTZR5qdIqZ1uPNdSGiD0Wq7zu7Lv+qXQAJiJK\n\tjyBAoqcIkZaQ==" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.72,302,1580803200\"; d=\"scan'208\";a=\"448099348\"", "From": "Andre Guedes <andre.guedes@intel.com>", "To": "intel-wired-lan@lists.osuosl.org", "Date": "Tue, 24 Mar 2020 17:38:20 -0700", "Message-Id": "<20200325003824.5487-7-andre.guedes@intel.com>", "X-Mailer": "git-send-email 2.25.0", "In-Reply-To": "<20200325003824.5487-1-andre.guedes@intel.com>", "References": "<20200325003824.5487-1-andre.guedes@intel.com>", "MIME-Version": "1.0", "Subject": "[Intel-wired-lan] [PATCH 06/10] igc: Use netdev log helpers in\n\tigc_diag.c", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "In igc_diag.c we print log messages using dev_* helpers, generating\ninconsistent output with the rest of the driver. Since this is a network\ndevice driver, we should preferably use netdev_* helpers because they\nappend the interface name to the message, helping making sense out of\nthe logs.\n\nThis patch converts all dev_* calls to netdev_*. It also takes this\nopportunity to remove the '\\n' character at the end of messages since it\nis automatically added by netdev_* log helpers.\n\nSigned-off-by: Andre Guedes <andre.guedes@intel.com>\n---\n drivers/net/ethernet/intel/igc/igc_diag.c | 22 +++++++++++-----------\n 1 file changed, 11 insertions(+), 11 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/igc/igc_diag.c b/drivers/net/ethernet/intel/igc/igc_diag.c\nindex 56acc9b8447e..3532496bae34 100644\n--- a/drivers/net/ethernet/intel/igc/igc_diag.c\n+++ b/drivers/net/ethernet/intel/igc/igc_diag.c\n@@ -46,9 +46,9 @@ static bool reg_pattern_test(struct igc_adapter *adapter, u64 *data, int reg,\n \t\twr32(reg, test_pattern[pat] & write);\n \t\tval = rd32(reg);\n \t\tif (val != (test_pattern[pat] & write & mask)) {\n-\t\t\tdev_err(&adapter->pdev->dev,\n-\t\t\t\t\"pattern test reg %04X failed: got 0x%08X expected 0x%08X\\n\",\n-\t\t\t\treg, val, test_pattern[pat] & write & mask);\n+\t\t\tnetdev_err(adapter->netdev,\n+\t\t\t\t \"pattern test reg %04X failed: got 0x%08X expected 0x%08X\",\n+\t\t\t\t reg, val, test_pattern[pat] & write & mask);\n \t\t\t*data = reg;\n \t\t\twr32(reg, before);\n \t\t\treturn true;\n@@ -68,9 +68,9 @@ static bool reg_set_and_check(struct igc_adapter *adapter, u64 *data, int reg,\n \twr32(reg, write & mask);\n \tval = rd32(reg);\n \tif ((write & mask) != (val & mask)) {\n-\t\tdev_err(&adapter->pdev->dev,\n-\t\t\t\"set/check reg %04X test failed: got 0x%08X expected 0x%08X\\n\",\n-\t\t\treg, (val & mask), (write & mask));\n+\t\tnetdev_err(adapter->netdev,\n+\t\t\t \"set/check reg %04X test failed: got 0x%08X expected 0x%08X\",\n+\t\t\t reg, (val & mask), (write & mask));\n \t\t*data = reg;\n \t\twr32(reg, before);\n \t\treturn true;\n@@ -97,9 +97,9 @@ bool igc_reg_test(struct igc_adapter *adapter, u64 *data)\n \twr32(IGC_STATUS, toggle);\n \tafter = rd32(IGC_STATUS) & toggle;\n \tif (value != after) {\n-\t\tdev_err(&adapter->pdev->dev,\n-\t\t\t\"failed STATUS register test got: 0x%08X expected: 0x%08X\\n\",\n-\t\t\tafter, value);\n+\t\tnetdev_err(adapter->netdev,\n+\t\t\t \"failed STATUS register test got: 0x%08X expected: 0x%08X\",\n+\t\t\t after, value);\n \t\t*data = 1;\n \t\treturn true;\n \t}\n@@ -207,8 +207,8 @@ int igc_intr_test(struct igc_adapter *adapter, u64 *data)\n \t\t*data = 1;\n \t\treturn -1;\n \t}\n-\tdev_info(&adapter->pdev->dev, \"testing %s interrupt\\n\",\n-\t\t (shared_int ? \"shared\" : \"unshared\"));\n+\tnetdev_info(adapter->netdev, \"testing %s interrupt\",\n+\t\t (shared_int ? \"shared\" : \"unshared\"));\n \n \t/* Disable all the interrupts */\n \twr32(IGC_IMC, ~0);\n", "prefixes": [ "06/10" ] }