Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/1261083/?format=api
{ "id": 1261083, "url": "http://patchwork.ozlabs.org/api/patches/1261083/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20200325003824.5487-4-andre.guedes@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20200325003824.5487-4-andre.guedes@intel.com>", "list_archive_url": null, "date": "2020-03-25T00:38:17", "name": "[03/10] igc: Use netdev log helpers in igc_ptp.c", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "26542132a4c9d97ce91e4bb1586e61d5253af3e0", "submitter": { "id": 72323, "url": "http://patchwork.ozlabs.org/api/people/72323/?format=api", "name": "Andre Guedes", "email": "andre.guedes@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20200325003824.5487-4-andre.guedes@intel.com/mbox/", "series": [ { "id": 166478, "url": "http://patchwork.ozlabs.org/api/series/166478/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=166478", "date": "2020-03-25T00:38:14", "name": "igc: Align log messages", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/166478/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/1261083/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/1261083/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": [ "ozlabs.org; spf=pass (sender SPF authorized)\n\tsmtp.mailfrom=osuosl.org (client-ip=140.211.166.138;\n\thelo=whitealder.osuosl.org;\n\tenvelope-from=intel-wired-lan-bounces@osuosl.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org;\n\tdmarc=fail (p=none dis=none) header.from=intel.com" ], "Received": [ "from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 48n8PJ6yktz9sSG\n\tfor <incoming@patchwork.ozlabs.org>;\n\tWed, 25 Mar 2020 11:38:44 +1100 (AEDT)", "from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 405C384D6E;\n\tWed, 25 Mar 2020 00:38:42 +0000 (UTC)", "from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id AYEWBQUtSL8h; Wed, 25 Mar 2020 00:38:39 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 9C43D84D8E;\n\tWed, 25 Mar 2020 00:38:39 +0000 (UTC)", "from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\tby ash.osuosl.org (Postfix) with ESMTP id 533EB1BF999\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 25 Mar 2020 00:38:37 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id 6852620107\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 25 Mar 2020 00:38:36 +0000 (UTC)", "from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id AnFHTHvy9g-A for <intel-wired-lan@lists.osuosl.org>;\n\tWed, 25 Mar 2020 00:38:35 +0000 (UTC)", "from mga05.intel.com (mga05.intel.com [192.55.52.43])\n\tby silver.osuosl.org (Postfix) with ESMTPS id AC6F820009\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 25 Mar 2020 00:38:35 +0000 (UTC)", "from fmsmga006.fm.intel.com ([10.253.24.20])\n\tby fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; \n\t24 Mar 2020 17:38:35 -0700", "from johnorte-mobl2.amr.corp.intel.com ([10.251.10.249])\n\tby fmsmga006.fm.intel.com with ESMTP; 24 Mar 2020 17:38:34 -0700" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "IronPort-SDR": [ "HAKAyPkvYinJcP8tv7q1HUR3+/gccqy/2NfgVXbkL1BMLOpwpN0aLILebs8pUhym547zNQUNQf\n\tue5Pd8g5WOZw==", "/+JmPsrW62vGGY+FKZpgq+5SzYTvxRHPE9ZkAOgT0SbGE/dIAnGbvOuwoD2WFgO6Aggb7FOkOn\n\t5SVQrN/iWPoQ==" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.72,302,1580803200\"; d=\"scan'208\";a=\"448099344\"", "From": "Andre Guedes <andre.guedes@intel.com>", "To": "intel-wired-lan@lists.osuosl.org", "Date": "Tue, 24 Mar 2020 17:38:17 -0700", "Message-Id": "<20200325003824.5487-4-andre.guedes@intel.com>", "X-Mailer": "git-send-email 2.25.0", "In-Reply-To": "<20200325003824.5487-1-andre.guedes@intel.com>", "References": "<20200325003824.5487-1-andre.guedes@intel.com>", "MIME-Version": "1.0", "Subject": "[Intel-wired-lan] [PATCH 03/10] igc: Use netdev log helpers in\n\tigc_ptp.c", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "In igc_ptp.c we print log messages using dev_* helpers, generating\ninconsistent output with the rest of the driver. Since this is a network\ndevice driver, we should preferably use netdev_* helpers because they\nappend the interface name to the message, helping making sense out of\nthe logs.\n\nThis patch converts all dev_* calls to netdev_*. It also takes this\nopportunity to remove the '\\n' character at the end of messages since it\nis automatically added by netdev_* log helpers.\n\nSigned-off-by: Andre Guedes <andre.guedes@intel.com>\n---\n drivers/net/ethernet/intel/igc/igc_ptp.c | 12 +++++-------\n 1 file changed, 5 insertions(+), 7 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/igc/igc_ptp.c b/drivers/net/ethernet/intel/igc/igc_ptp.c\nindex f99c514ad0f4..c292aaf7c79d 100644\n--- a/drivers/net/ethernet/intel/igc/igc_ptp.c\n+++ b/drivers/net/ethernet/intel/igc/igc_ptp.c\n@@ -466,7 +466,7 @@ void igc_ptp_tx_hang(struct igc_adapter *adapter)\n \t\t * interrupt\n \t\t */\n \t\trd32(IGC_TXSTMPH);\n-\t\tdev_warn(&adapter->pdev->dev, \"clearing Tx timestamp hang\\n\");\n+\t\tnetdev_warn(adapter->netdev, \"Clearing Tx timestamp hang\");\n \t}\n }\n \n@@ -529,7 +529,7 @@ static void igc_ptp_tx_work(struct work_struct *work)\n \t\t * interrupt\n \t\t */\n \t\trd32(IGC_TXSTMPH);\n-\t\tdev_warn(&adapter->pdev->dev, \"clearing Tx timestamp hang\\n\");\n+\t\tnetdev_warn(adapter->netdev, \"Clearing Tx timestamp hang\");\n \t\treturn;\n \t}\n \n@@ -626,10 +626,9 @@ void igc_ptp_init(struct igc_adapter *adapter)\n \t\t\t\t\t\t&adapter->pdev->dev);\n \tif (IS_ERR(adapter->ptp_clock)) {\n \t\tadapter->ptp_clock = NULL;\n-\t\tdev_err(&adapter->pdev->dev, \"ptp_clock_register failed\\n\");\n+\t\tnetdev_err(netdev, \"ptp_clock_register failed\");\n \t} else if (adapter->ptp_clock) {\n-\t\tdev_info(&adapter->pdev->dev, \"added PHC on %s\\n\",\n-\t\t\t adapter->netdev->name);\n+\t\tnetdev_info(netdev, \"PHC added\");\n \t\tadapter->ptp_flags |= IGC_PTP_ENABLED;\n \t}\n }\n@@ -666,8 +665,7 @@ void igc_ptp_stop(struct igc_adapter *adapter)\n \n \tif (adapter->ptp_clock) {\n \t\tptp_clock_unregister(adapter->ptp_clock);\n-\t\tdev_info(&adapter->pdev->dev, \"removed PHC on %s\\n\",\n-\t\t\t adapter->netdev->name);\n+\t\tnetdev_info(adapter->netdev, \"PHC removed\");\n \t\tadapter->ptp_flags &= ~IGC_PTP_ENABLED;\n \t}\n }\n", "prefixes": [ "03/10" ] }