Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/1261082/?format=api
{ "id": 1261082, "url": "http://patchwork.ozlabs.org/api/patches/1261082/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20200325003824.5487-10-andre.guedes@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20200325003824.5487-10-andre.guedes@intel.com>", "list_archive_url": null, "date": "2020-03-25T00:38:23", "name": "[09/10] igc: Remove '\\n' from log messages in igc_nvm.c", "commit_ref": null, "pull_url": null, "state": "rejected", "archived": false, "hash": "e84c712962ad53c1cb20ee203c98ac3e9a87c422", "submitter": { "id": 72323, "url": "http://patchwork.ozlabs.org/api/people/72323/?format=api", "name": "Andre Guedes", "email": "andre.guedes@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20200325003824.5487-10-andre.guedes@intel.com/mbox/", "series": [ { "id": 166478, "url": "http://patchwork.ozlabs.org/api/series/166478/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=166478", "date": "2020-03-25T00:38:14", "name": "igc: Align log messages", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/166478/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/1261082/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/1261082/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": [ "ozlabs.org; spf=pass (sender SPF authorized)\n\tsmtp.mailfrom=osuosl.org (client-ip=140.211.166.133;\n\thelo=hemlock.osuosl.org;\n\tenvelope-from=intel-wired-lan-bounces@osuosl.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org;\n\tdmarc=fail (p=none dis=none) header.from=intel.com" ], "Received": [ "from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 48n8PJ4rHtz9sR4\n\tfor <incoming@patchwork.ozlabs.org>;\n\tWed, 25 Mar 2020 11:38:44 +1100 (AEDT)", "from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id D63B8884ED;\n\tWed, 25 Mar 2020 00:38:42 +0000 (UTC)", "from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id J1WCasmLYu19; Wed, 25 Mar 2020 00:38:42 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 36C358855E;\n\tWed, 25 Mar 2020 00:38:42 +0000 (UTC)", "from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\tby ash.osuosl.org (Postfix) with ESMTP id B33421BF32A\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 25 Mar 2020 00:38:38 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id AFA5320107\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 25 Mar 2020 00:38:38 +0000 (UTC)", "from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id jaPBjJ34AUgf for <intel-wired-lan@lists.osuosl.org>;\n\tWed, 25 Mar 2020 00:38:37 +0000 (UTC)", "from mga05.intel.com (mga05.intel.com [192.55.52.43])\n\tby silver.osuosl.org (Postfix) with ESMTPS id DF5F720028\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 25 Mar 2020 00:38:37 +0000 (UTC)", "from fmsmga006.fm.intel.com ([10.253.24.20])\n\tby fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; \n\t24 Mar 2020 17:38:37 -0700", "from johnorte-mobl2.amr.corp.intel.com ([10.251.10.249])\n\tby fmsmga006.fm.intel.com with ESMTP; 24 Mar 2020 17:38:37 -0700" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "IronPort-SDR": [ "ogI8Dtn7AQjEtrCj+4HBtGsZx/QqPqBvNwIl0dQRFeVPeT3T9B/gM/3KWfBx8SxdNT1OyFrbXX\n\t+6LxMK1lXmVw==", "roEd1z2yn47K4dTCBcDUZLZWGANw6BsF2Iu9/eOOHRuCbORzcpONnBfVqFM/SrijWgdEvwJ+2x\n\t8zXPd4z9Dk4g==" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.72,302,1580803200\"; d=\"scan'208\";a=\"448099356\"", "From": "Andre Guedes <andre.guedes@intel.com>", "To": "intel-wired-lan@lists.osuosl.org", "Date": "Tue, 24 Mar 2020 17:38:23 -0700", "Message-Id": "<20200325003824.5487-10-andre.guedes@intel.com>", "X-Mailer": "git-send-email 2.25.0", "In-Reply-To": "<20200325003824.5487-1-andre.guedes@intel.com>", "References": "<20200325003824.5487-1-andre.guedes@intel.com>", "MIME-Version": "1.0", "Subject": "[Intel-wired-lan] [PATCH 09/10] igc: Remove '\\n' from log messages\n\tin igc_nvm.c", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "To keep log strings in igc_nvm.c consistent with the rest of the driver\ncode, this patch removes the '\\n' character at the end. The newline\ncharacter is automatically added by netdev_dbg() so there is no changes\nin the output.\n\nNote: hw_dbg() is a macro that expands to netdev_dbg().\n\nSigned-off-by: Andre Guedes <andre.guedes@intel.com>\n---\n drivers/net/ethernet/intel/igc/igc_nvm.c | 12 ++++++------\n 1 file changed, 6 insertions(+), 6 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/igc/igc_nvm.c b/drivers/net/ethernet/intel/igc/igc_nvm.c\nindex 58f81aba0144..ac01330a8232 100644\n--- a/drivers/net/ethernet/intel/igc/igc_nvm.c\n+++ b/drivers/net/ethernet/intel/igc/igc_nvm.c\n@@ -63,7 +63,7 @@ s32 igc_acquire_nvm(struct igc_hw *hw)\n \tif (!timeout) {\n \t\teecd &= ~IGC_EECD_REQ;\n \t\twr32(IGC_EECD, eecd);\n-\t\thw_dbg(\"Could not acquire NVM grant\\n\");\n+\t\thw_dbg(\"Could not acquire NVM grant\");\n \t\tret_val = -IGC_ERR_NVM;\n \t}\n \n@@ -105,7 +105,7 @@ s32 igc_read_nvm_eerd(struct igc_hw *hw, u16 offset, u16 words, u16 *data)\n \t */\n \tif (offset >= nvm->word_size || (words > (nvm->word_size - offset)) ||\n \t words == 0) {\n-\t\thw_dbg(\"nvm parameter(s) out of bounds\\n\");\n+\t\thw_dbg(\"nvm parameter(s) out of bounds\");\n \t\tret_val = -IGC_ERR_NVM;\n \t\tgoto out;\n \t}\n@@ -167,14 +167,14 @@ s32 igc_validate_nvm_checksum(struct igc_hw *hw)\n \tfor (i = 0; i < (NVM_CHECKSUM_REG + 1); i++) {\n \t\tret_val = hw->nvm.ops.read(hw, i, 1, &nvm_data);\n \t\tif (ret_val) {\n-\t\t\thw_dbg(\"NVM Read Error\\n\");\n+\t\t\thw_dbg(\"NVM Read Error\");\n \t\t\tgoto out;\n \t\t}\n \t\tchecksum += nvm_data;\n \t}\n \n \tif (checksum != (u16)NVM_SUM) {\n-\t\thw_dbg(\"NVM Checksum Invalid\\n\");\n+\t\thw_dbg(\"NVM Checksum Invalid\");\n \t\tret_val = -IGC_ERR_NVM;\n \t\tgoto out;\n \t}\n@@ -200,7 +200,7 @@ s32 igc_update_nvm_checksum(struct igc_hw *hw)\n \tfor (i = 0; i < NVM_CHECKSUM_REG; i++) {\n \t\tret_val = hw->nvm.ops.read(hw, i, 1, &nvm_data);\n \t\tif (ret_val) {\n-\t\t\thw_dbg(\"NVM Read Error while updating checksum.\\n\");\n+\t\t\thw_dbg(\"NVM Read Error while updating checksum\");\n \t\t\tgoto out;\n \t\t}\n \t\tchecksum += nvm_data;\n@@ -208,7 +208,7 @@ s32 igc_update_nvm_checksum(struct igc_hw *hw)\n \tchecksum = (u16)NVM_SUM - checksum;\n \tret_val = hw->nvm.ops.write(hw, NVM_CHECKSUM_REG, 1, &checksum);\n \tif (ret_val)\n-\t\thw_dbg(\"NVM Write Error while updating checksum.\\n\");\n+\t\thw_dbg(\"NVM Write Error while updating checksum\");\n \n out:\n \treturn ret_val;\n", "prefixes": [ "09/10" ] }