Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/1261081/?format=api
{ "id": 1261081, "url": "http://patchwork.ozlabs.org/api/patches/1261081/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20200325003824.5487-6-andre.guedes@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20200325003824.5487-6-andre.guedes@intel.com>", "list_archive_url": null, "date": "2020-03-25T00:38:19", "name": "[05/10] igc: Use netdev log helpers in igc_base.c", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "023f9810fd5d4b42ab3434b990dca10fde5f9c91", "submitter": { "id": 72323, "url": "http://patchwork.ozlabs.org/api/people/72323/?format=api", "name": "Andre Guedes", "email": "andre.guedes@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20200325003824.5487-6-andre.guedes@intel.com/mbox/", "series": [ { "id": 166478, "url": "http://patchwork.ozlabs.org/api/series/166478/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=166478", "date": "2020-03-25T00:38:14", "name": "igc: Align log messages", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/166478/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/1261081/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/1261081/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": [ "ozlabs.org; spf=pass (sender SPF authorized)\n\tsmtp.mailfrom=osuosl.org (client-ip=140.211.166.137;\n\thelo=fraxinus.osuosl.org;\n\tenvelope-from=intel-wired-lan-bounces@osuosl.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org;\n\tdmarc=fail (p=none dis=none) header.from=intel.com" ], "Received": [ "from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 48n8PJ0ZHDz9sRY\n\tfor <incoming@patchwork.ozlabs.org>;\n\tWed, 25 Mar 2020 11:38:44 +1100 (AEDT)", "from localhost (localhost [127.0.0.1])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id 5A678869F8;\n\tWed, 25 Mar 2020 00:38:42 +0000 (UTC)", "from fraxinus.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id TSCAy_1XGiis; Wed, 25 Mar 2020 00:38:41 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id A42CD8693F;\n\tWed, 25 Mar 2020 00:38:41 +0000 (UTC)", "from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\tby ash.osuosl.org (Postfix) with ESMTP id 583FE1BF32A\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 25 Mar 2020 00:38:38 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id 526F020107\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 25 Mar 2020 00:38:38 +0000 (UTC)", "from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id z-8tybABOPso for <intel-wired-lan@lists.osuosl.org>;\n\tWed, 25 Mar 2020 00:38:36 +0000 (UTC)", "from mga05.intel.com (mga05.intel.com [192.55.52.43])\n\tby silver.osuosl.org (Postfix) with ESMTPS id 3E07320035\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 25 Mar 2020 00:38:36 +0000 (UTC)", "from fmsmga006.fm.intel.com ([10.253.24.20])\n\tby fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; \n\t24 Mar 2020 17:38:36 -0700", "from johnorte-mobl2.amr.corp.intel.com ([10.251.10.249])\n\tby fmsmga006.fm.intel.com with ESMTP; 24 Mar 2020 17:38:35 -0700" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "IronPort-SDR": [ "41oQIM7+qjwqB0KJM4s+v0IxPsRrEgkAOg0mdw9mp7ioakoprr/4lfFaUri113mXbskLtCQshi\n\t+SQiik/TtbIA==", "kvmMbmNVPNzKQoqdCLmlbH6755eYnbH2D8eRDzwx+bueW1H1IDUsdriWMGw8OWfOT6CXRUrfsK\n\tnmAE+fX10JQA==" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.72,302,1580803200\"; d=\"scan'208\";a=\"448099347\"", "From": "Andre Guedes <andre.guedes@intel.com>", "To": "intel-wired-lan@lists.osuosl.org", "Date": "Tue, 24 Mar 2020 17:38:19 -0700", "Message-Id": "<20200325003824.5487-6-andre.guedes@intel.com>", "X-Mailer": "git-send-email 2.25.0", "In-Reply-To": "<20200325003824.5487-1-andre.guedes@intel.com>", "References": "<20200325003824.5487-1-andre.guedes@intel.com>", "MIME-Version": "1.0", "Subject": "[Intel-wired-lan] [PATCH 05/10] igc: Use netdev log helpers in\n\tigc_base.c", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "This patch coverts one pr_debug() call to hw_dbg() in order to keep log\noutput aligned with the rest of the driver. hw_dbg() is actually a macro\ndefined in igc_hw.h that expands to netdev_dbg().\n\nIt also takes this opportunity to remove the '\\n' character at the end\nof messages since it is automatically added to by netdev_dbg().\n\nSigned-off-by: Andre Guedes <andre.guedes@intel.com>\n---\n drivers/net/ethernet/intel/igc/igc_base.c | 16 ++++++++--------\n 1 file changed, 8 insertions(+), 8 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/igc/igc_base.c b/drivers/net/ethernet/intel/igc/igc_base.c\nindex f7fb18d8d8f5..9722db75064f 100644\n--- a/drivers/net/ethernet/intel/igc/igc_base.c\n+++ b/drivers/net/ethernet/intel/igc/igc_base.c\n@@ -26,9 +26,9 @@ static s32 igc_reset_hw_base(struct igc_hw *hw)\n \t */\n \tret_val = igc_disable_pcie_master(hw);\n \tif (ret_val)\n-\t\thw_dbg(\"PCI-E Master disable polling has failed.\\n\");\n+\t\thw_dbg(\"PCI-E Master disable polling has failed\");\n \n-\thw_dbg(\"Masking off all interrupts\\n\");\n+\thw_dbg(\"Masking off all interrupts\");\n \twr32(IGC_IMC, 0xffffffff);\n \n \twr32(IGC_RCTL, 0);\n@@ -39,7 +39,7 @@ static s32 igc_reset_hw_base(struct igc_hw *hw)\n \n \tctrl = rd32(IGC_CTRL);\n \n-\thw_dbg(\"Issuing a global reset to MAC\\n\");\n+\thw_dbg(\"Issuing a global reset to MAC\");\n \twr32(IGC_CTRL, ctrl | IGC_CTRL_DEV_RST);\n \n \tret_val = igc_get_auto_rd_done(hw);\n@@ -48,7 +48,7 @@ static s32 igc_reset_hw_base(struct igc_hw *hw)\n \t\t * return with an error. This can happen in situations\n \t\t * where there is no eeprom and prevents getting link.\n \t\t */\n-\t\thw_dbg(\"Auto Read Done did not complete\\n\");\n+\t\thw_dbg(\"Auto Read Done did not complete\");\n \t}\n \n \t/* Clear any pending interrupt events. */\n@@ -177,7 +177,7 @@ static s32 igc_init_phy_params_base(struct igc_hw *hw)\n \t */\n \tret_val = hw->phy.ops.reset(hw);\n \tif (ret_val) {\n-\t\thw_dbg(\"Error resetting the PHY.\\n\");\n+\t\thw_dbg(\"Error resetting the PHY\");\n \t\tgoto out;\n \t}\n \n@@ -292,12 +292,12 @@ static s32 igc_init_hw_base(struct igc_hw *hw)\n \tigc_init_rx_addrs(hw, rar_count);\n \n \t/* Zero out the Multicast HASH table */\n-\thw_dbg(\"Zeroing the MTA\\n\");\n+\thw_dbg(\"Zeroing the MTA\");\n \tfor (i = 0; i < mac->mta_reg_count; i++)\n \t\tarray_wr32(IGC_MTA, i, 0);\n \n \t/* Zero out the Unicast HASH table */\n-\thw_dbg(\"Zeroing the UTA\\n\");\n+\thw_dbg(\"Zeroing the UTA\");\n \tfor (i = 0; i < mac->uta_reg_count; i++)\n \t\tarray_wr32(IGC_UTA, i, 0);\n \n@@ -367,7 +367,7 @@ void igc_rx_fifo_flush_base(struct igc_hw *hw)\n \t}\n \n \tif (ms_wait == 10)\n-\t\tpr_debug(\"Queue disable timed out after 10ms\\n\");\n+\t\thw_dbg(\"Queue disable timed out after 10ms\");\n \n \t/* Clear RLPML, RCTL.SBP, RFCTL.LEF, and set RCTL.LPE so that all\n \t * incoming packets are rejected. Set enable and wait 2ms so that\n", "prefixes": [ "05/10" ] }