Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/1257853/?format=api
{ "id": 1257853, "url": "http://patchwork.ozlabs.org/api/patches/1257853/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20200318230102.36952-13-andre.guedes@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20200318230102.36952-13-andre.guedes@intel.com>", "list_archive_url": null, "date": "2020-03-18T23:01:02", "name": "[12/12] igc: Add debug messages to MAC filter code", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "a199b1b151c22f731bf82f2c35d4903cbf2151c0", "submitter": { "id": 72323, "url": "http://patchwork.ozlabs.org/api/people/72323/?format=api", "name": "Andre Guedes", "email": "andre.guedes@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20200318230102.36952-13-andre.guedes@intel.com/mbox/", "series": [ { "id": 165243, "url": "http://patchwork.ozlabs.org/api/series/165243/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=165243", "date": "2020-03-18T23:00:52", "name": "igc: Refactor MAC address filtering code", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/165243/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/1257853/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/1257853/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": [ "ozlabs.org; spf=pass (sender SPF authorized)\n\tsmtp.mailfrom=osuosl.org (client-ip=140.211.166.138;\n\thelo=whitealder.osuosl.org;\n\tenvelope-from=intel-wired-lan-bounces@osuosl.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org;\n\tdmarc=fail (p=none dis=none) header.from=intel.com" ], "Received": [ "from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 48jQXx3VtCz9sPF\n\tfor <incoming@patchwork.ozlabs.org>;\n\tThu, 19 Mar 2020 10:02:25 +1100 (AEDT)", "from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 0F41887D39;\n\tWed, 18 Mar 2020 23:02:24 +0000 (UTC)", "from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id lQcbNvDTgz9h; Wed, 18 Mar 2020 23:02:20 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 9218387D31;\n\tWed, 18 Mar 2020 23:02:19 +0000 (UTC)", "from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\tby ash.osuosl.org (Postfix) with ESMTP id F205F1BF9AD\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 18 Mar 2020 23:02:15 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id EA4C420403\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 18 Mar 2020 23:02:15 +0000 (UTC)", "from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id CMJD5WQCWoom for <intel-wired-lan@lists.osuosl.org>;\n\tWed, 18 Mar 2020 23:02:14 +0000 (UTC)", "from mga09.intel.com (mga09.intel.com [134.134.136.24])\n\tby silver.osuosl.org (Postfix) with ESMTPS id 3C334203E5\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 18 Mar 2020 23:02:12 +0000 (UTC)", "from orsmga006.jf.intel.com ([10.7.209.51])\n\tby orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; \n\t18 Mar 2020 16:02:11 -0700", "from ymtomada-mobl.amr.corp.intel.com ([10.251.21.179])\n\tby orsmga006.jf.intel.com with ESMTP; 18 Mar 2020 16:02:11 -0700" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "IronPort-SDR": [ "58RM4UPdRmnnr8J7iNYLN6uoiWnJN74ENoMA8xsEXnwTI2h5FWKvzhRwnR6W3cYMEnY7me2LJS\n\tr6fvVuX+YidA==", "r/P+MlEacw619zIOTbq700FR4mw0ky7zAJMkpJgiFpNKXDEsmD1sCLsyXoeTO8+u+pBhVgjusw\n\tyqrCsGi6Q9Lg==" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.70,569,1574150400\"; d=\"scan'208\";a=\"248341792\"", "From": "Andre Guedes <andre.guedes@intel.com>", "To": "intel-wired-lan@lists.osuosl.org", "Date": "Wed, 18 Mar 2020 16:01:02 -0700", "Message-Id": "<20200318230102.36952-13-andre.guedes@intel.com>", "X-Mailer": "git-send-email 2.25.0", "In-Reply-To": "<20200318230102.36952-1-andre.guedes@intel.com>", "References": "<20200318230102.36952-1-andre.guedes@intel.com>", "MIME-Version": "1.0", "Subject": "[Intel-wired-lan] [PATCH 12/12] igc: Add debug messages to MAC\n\tfilter code", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "This patch adds log messages to functions related to the MAC address\nfiltering code to ease debugging.\n\nSigned-off-by: Andre Guedes <andre.guedes@intel.com>\n---\n drivers/net/ethernet/intel/igc/igc_main.c | 24 +++++++++++++++++++++--\n 1 file changed, 22 insertions(+), 2 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/igc/igc_main.c b/drivers/net/ethernet/intel/igc/igc_main.c\nindex fa7cf33c58a9..abbe0e1e0cf5 100644\n--- a/drivers/net/ethernet/intel/igc/igc_main.c\n+++ b/drivers/net/ethernet/intel/igc/igc_main.c\n@@ -776,6 +776,7 @@ static void igc_setup_tctl(struct igc_adapter *adapter)\n static void igc_set_mac_filter_hw(struct igc_adapter *adapter, int index,\n \t\t\t\t const u8 *addr, int queue)\n {\n+\tstruct net_device *dev = adapter->netdev;\n \tstruct igc_hw *hw = &adapter->hw;\n \tu32 ral, rah;\n \n@@ -795,6 +796,8 @@ static void igc_set_mac_filter_hw(struct igc_adapter *adapter, int index,\n \n \twr32(IGC_RAL(index), ral);\n \twr32(IGC_RAH(index), rah);\n+\n+\tnetdev_dbg(dev, \"MAC address filter set in HW: index %d\", index);\n }\n \n /* Clear MAC address filter in hardware.\n@@ -804,6 +807,7 @@ static void igc_set_mac_filter_hw(struct igc_adapter *adapter, int index,\n */\n static void igc_clear_mac_filter_hw(struct igc_adapter *adapter, int index)\n {\n+\tstruct net_device *dev = adapter->netdev;\n \tstruct igc_hw *hw = &adapter->hw;\n \n \tif (WARN_ON(index >= hw->mac.rar_entry_count))\n@@ -811,18 +815,24 @@ static void igc_clear_mac_filter_hw(struct igc_adapter *adapter, int index)\n \n \twr32(IGC_RAL(index), 0);\n \twr32(IGC_RAH(index), 0);\n+\n+\tnetdev_dbg(dev, \"MAC address filter cleared in HW: index %d\", index);\n }\n \n /* Set default MAC address for the PF in the first RAR entry */\n static void igc_set_default_mac_filter(struct igc_adapter *adapter)\n {\n \tstruct igc_mac_addr *mac_table = &adapter->mac_table[0];\n+\tstruct net_device *dev = adapter->netdev;\n+\tu8 *addr = adapter->hw.mac.addr;\n+\n+\tnetdev_dbg(dev, \"Set default MAC address filter: address %pM\", addr);\n \n-\tether_addr_copy(mac_table->addr, adapter->hw.mac.addr);\n+\tether_addr_copy(mac_table->addr, addr);\n \tmac_table->state = IGC_MAC_STATE_DEFAULT | IGC_MAC_STATE_IN_USE;\n \tmac_table->queue = -1;\n \n-\tigc_set_mac_filter_hw(adapter, 0, mac_table->addr, mac_table->queue);\n+\tigc_set_mac_filter_hw(adapter, 0, addr, mac_table->queue);\n }\n \n /**\n@@ -2232,6 +2242,7 @@ static int igc_get_avail_mac_filter_slot(struct igc_adapter *adapter)\n int igc_add_mac_filter(struct igc_adapter *adapter, const u8 *addr,\n \t\t const s8 queue, const u8 flags)\n {\n+\tstruct net_device *dev = adapter->netdev;\n \tint index;\n \n \tif (!is_valid_ether_addr(addr))\n@@ -2247,6 +2258,9 @@ int igc_add_mac_filter(struct igc_adapter *adapter, const u8 *addr,\n \tif (index < 0)\n \t\treturn -ENOSPC;\n \n+\tnetdev_dbg(dev, \"Add MAC address filter: index %d address %pM queue %d\",\n+\t\t index, addr, queue);\n+\n \tether_addr_copy(adapter->mac_table[index].addr, addr);\n \tadapter->mac_table[index].state |= IGC_MAC_STATE_IN_USE | flags;\n update_queue_assignment:\n@@ -2268,6 +2282,7 @@ int igc_add_mac_filter(struct igc_adapter *adapter, const u8 *addr,\n int igc_del_mac_filter(struct igc_adapter *adapter, const u8 *addr,\n \t\t const u8 flags)\n {\n+\tstruct net_device *dev = adapter->netdev;\n \tstruct igc_mac_addr *entry;\n \tint index;\n \n@@ -2285,9 +2300,14 @@ int igc_del_mac_filter(struct igc_adapter *adapter, const u8 *addr,\n \t\t * We just reset to its default value i.e. disable queue\n \t\t * assignment.\n \t\t */\n+\t\tnetdev_dbg(dev, \"Disable default MAC filter queue assignment\");\n+\n \t\tentry->queue = -1;\n \t\tigc_set_mac_filter_hw(adapter, 0, addr, entry->queue);\n \t} else {\n+\t\tnetdev_dbg(dev, \"Delete MAC address filter: index %d address %pM\",\n+\t\t\t index, addr);\n+\n \t\tentry->state = 0;\n \t\tentry->queue = -1;\n \t\tmemset(entry->addr, 0, ETH_ALEN);\n", "prefixes": [ "12/12" ] }