Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/1248691/?format=api
{ "id": 1248691, "url": "http://patchwork.ozlabs.org/api/patches/1248691/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20200228081957.61782-1-andre.guedes@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20200228081957.61782-1-andre.guedes@intel.com>", "list_archive_url": null, "date": "2020-02-28T08:19:57", "name": "igc: Fix overwrites when dumping registers", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "172e1147532e63b4594b845cadd095aea7c80038", "submitter": { "id": 72323, "url": "http://patchwork.ozlabs.org/api/people/72323/?format=api", "name": "Andre Guedes", "email": "andre.guedes@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20200228081957.61782-1-andre.guedes@intel.com/mbox/", "series": [ { "id": 162260, "url": "http://patchwork.ozlabs.org/api/series/162260/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=162260", "date": "2020-02-28T08:19:57", "name": "igc: Fix overwrites when dumping registers", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/162260/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/1248691/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/1248691/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": [ "ozlabs.org; spf=pass (sender SPF authorized)\n\tsmtp.mailfrom=osuosl.org (client-ip=140.211.166.133;\n\thelo=hemlock.osuosl.org;\n\tenvelope-from=intel-wired-lan-bounces@osuosl.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org;\n\tdmarc=fail (p=none dis=none) header.from=intel.com" ], "Received": [ "from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 48XG7K6Jw4z9sP7\n\tfor <incoming@patchwork.ozlabs.org>;\n\tWed, 4 Mar 2020 12:11:55 +1100 (AEDT)", "from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 11787850A3;\n\tWed, 4 Mar 2020 01:11:52 +0000 (UTC)", "from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id lIAWFAjhKZkg; Wed, 4 Mar 2020 01:11:48 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 16B8B84F53;\n\tWed, 4 Mar 2020 01:11:48 +0000 (UTC)", "from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\tby ash.osuosl.org (Postfix) with ESMTP id 32DEB1BF34A\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 4 Mar 2020 01:11:47 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id 2F0D820552\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 4 Mar 2020 01:11:47 +0000 (UTC)", "from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id s+GJJFb53vzk for <intel-wired-lan@lists.osuosl.org>;\n\tWed, 4 Mar 2020 01:11:46 +0000 (UTC)", "from mga04.intel.com (mga04.intel.com [192.55.52.120])\n\tby silver.osuosl.org (Postfix) with ESMTPS id D420620526\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 4 Mar 2020 01:11:45 +0000 (UTC)", "from orsmga008.jf.intel.com ([10.7.209.65])\n\tby fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t03 Mar 2020 17:11:45 -0800", "from aguedesl-mac01.jf.intel.com (HELO localhost) ([10.24.12.166])\n\tby orsmga008-auth.jf.intel.com with\n\tESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 03 Mar 2020 17:11:44 -0800" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-IronPort-AV": "E=Sophos;i=\"5.70,511,1574150400\"; d=\"scan'208\";a=\"233839070\"", "From": "Andre Guedes <andre.guedes@intel.com>", "To": "intel-wired-lan@lists.osuosl.org", "Date": "Fri, 28 Feb 2020 00:19:57 -0800", "Message-Id": "<20200228081957.61782-1-andre.guedes@intel.com>", "X-Mailer": "git-send-email 2.25.0", "MIME-Version": "1.0", "Subject": "[Intel-wired-lan] [PATCH] igc: Fix overwrites when dumping registers", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "This patch fixes some register overwriting when dumping registers via\nethtool.\n\nWe have a total of 16 RAL registers, starting at offset 139. So RAH\noffset should be 139 + 16 = 155, not 145. As result some RAL registers\nare overwritten. Likewise, RAH registers are also overwritten by TDBAL,\nTDBAH, TDLEN, and TDH registers.\n\nTo fix this bug while preserving the ABI, this patch re-writes RAL and\nRAH registers at the end of 'regs_buff' and bumps regs->version. It also\nremoves some pointless comments in the middle of igc_set_regs().\n\nSigned-off-by: Andre Guedes <andre.guedes@intel.com>\n---\n drivers/net/ethernet/intel/igc/igc_ethtool.c | 11 ++++++++++-\n 1 file changed, 10 insertions(+), 1 deletion(-)", "diff": "diff --git a/drivers/net/ethernet/intel/igc/igc_ethtool.c b/drivers/net/ethernet/intel/igc/igc_ethtool.c\nindex 69f50b8e2af3..7e4ad4e9f8ad 100644\n--- a/drivers/net/ethernet/intel/igc/igc_ethtool.c\n+++ b/drivers/net/ethernet/intel/igc/igc_ethtool.c\n@@ -153,7 +153,7 @@ static void igc_get_regs(struct net_device *netdev,\n \n \tmemset(p, 0, IGC_REGS_LEN * sizeof(u32));\n \n-\tregs->version = (1u << 24) | (hw->revision_id << 16) | hw->device_id;\n+\tregs->version = (2u << 24) | (hw->revision_id << 16) | hw->device_id;\n \n \t/* General Registers */\n \tregs_buff[0] = rd32(IGC_CTRL);\n@@ -306,6 +306,15 @@ static void igc_get_regs(struct net_device *netdev,\n \t\tregs_buff[164 + i] = rd32(IGC_TDT(i));\n \tfor (i = 0; i < 4; i++)\n \t\tregs_buff[168 + i] = rd32(IGC_TXDCTL(i));\n+\n+\t/* XXX: Due to a bug few lines above, RAL and RAH registers are\n+\t * overwritten. To preserve the ABI, we write these registers again in\n+\t * regs_buff.\n+\t */\n+\tfor (i = 0; i < 16; i++)\n+\t\tregs_buff[172 + i] = rd32(IGC_RAL(i));\n+\tfor (i = 0; i < 16; i++)\n+\t\tregs_buff[188 + i] = rd32(IGC_RAH(i));\n }\n \n static void igc_get_wol(struct net_device *netdev, struct ethtool_wolinfo *wol)\n", "prefixes": [] }