Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/1248/?format=api
{ "id": 1248, "url": "http://patchwork.ozlabs.org/api/patches/1248/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linux-ext4/patch/20080924171439t-sato@mail.jp.nec.com/", "project": { "id": 8, "url": "http://patchwork.ozlabs.org/api/projects/8/?format=api", "name": "Linux ext4 filesystem development", "link_name": "linux-ext4", "list_id": "linux-ext4.vger.kernel.org", "list_email": "linux-ext4@vger.kernel.org", "web_url": null, "scm_url": null, "webscm_url": null, "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20080924171439t-sato@mail.jp.nec.com>", "list_archive_url": null, "date": "2008-09-24T08:14:39", "name": "[4/10] xfs: Fix error handling inwrite_super_lockfs/unlockfs", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "d7bcff2ee8e34823b87ac9bbdae2d5995bd2d463", "submitter": { "id": 391, "url": "http://patchwork.ozlabs.org/api/people/391/?format=api", "name": "Takashi Sato", "email": "t-sato@yk.jp.nec.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/linux-ext4/patch/20080924171439t-sato@mail.jp.nec.com/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/1248/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/1248/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<linux-ext4-owner@vger.kernel.org>", "X-Original-To": "patchwork-incoming@ozlabs.org", "Delivered-To": "patchwork-incoming@ozlabs.org", "Received": [ "from vger.kernel.org (vger.kernel.org [209.132.176.167])\n\tby ozlabs.org (Postfix) with ESMTP id B0FFBDDE06\n\tfor <patchwork-incoming@ozlabs.org>;\n\tWed, 24 Sep 2008 18:16:22 +1000 (EST)", "(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751151AbYIXIQQ (ORCPT <rfc822;patchwork-incoming@ozlabs.org>);\n\tWed, 24 Sep 2008 04:16:16 -0400", "(majordomo@vger.kernel.org) by vger.kernel.org id S1751323AbYIXIQP\n\t(ORCPT <rfc822;linux-ext4-outgoing>);\n\tWed, 24 Sep 2008 04:16:15 -0400", "from TYO202.gate.nec.co.jp ([202.32.8.206]:55787 \"EHLO\n\ttyo202.gate.nec.co.jp\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1750991AbYIXIQN (ORCPT\n\t<rfc822; linux-ext4@vger.kernel.org>); Wed, 24 Sep 2008 04:16:13 -0400", "from mailgate3.nec.co.jp ([10.7.69.197])\n\tby tyo202.gate.nec.co.jp (8.13.8/8.13.4) with ESMTP id m8O8EeW8000257;\n\tWed, 24 Sep 2008 17:14:40 +0900 (JST)", "(from root@localhost) by mailgate3.nec.co.jp\n\t(8.11.7/3.7W-MAILGATE-NEC)\n\tid m8O8Eef15768; Wed, 24 Sep 2008 17:14:40 +0900 (JST)", "from kuichi.jp.nec.com (kuichi.jp.nec.com [10.26.220.17])\n\tby mailsv4.nec.co.jp (8.13.8/8.13.4) with ESMTP id m8O8EegB000021;\n\tWed, 24 Sep 2008 17:14:40 +0900 (JST)", "from TNESB07336 ([10.64.168.65] [10.64.168.65]) by mail.jp.nec.com\n\twith ESMTP; Wed, 24 Sep 2008 17:14:39 +0900" ], "To": "Dave Chinner <david@fromorbit.com>", "Cc": "Andrew Morton <akpm@linux-foundation.org>,\n\tChristoph Hellwig <hch@infradead.org>,\n\t\"linux-fsdevel@vger.kernel.org\" <linux-fsdevel@vger.kernel.org>,\n\t\"dm-devel@redhat.com\" <dm-devel@redhat.com>,\n\t\"viro@ZenIV.linux.org.uk\" <viro@ZenIV.linux.org.uk>,\n\t\"linux-ext4@vger.kernel.org\" <linux-ext4@vger.kernel.org>,\n\t\"xfs@oss.sgi.com\" <xfs@oss.sgi.com>,\n\t\"linux-kernel@vger.kernel.org\" <linux-kernel@vger.kernel.org>", "Subject": "Re: [PATCH 4/10] xfs: Fix error handling\n\tinwrite_super_lockfs/unlockfs", "Message-Id": "<20080924171439t-sato@mail.jp.nec.com>", "Mime-Version": "1.0", "X-Mailer": "WeMail32[2.51] ID:1K0086", "From": "Takashi Sato <t-sato@yk.jp.nec.com>", "Date": "Wed, 24 Sep 2008 17:14:39 +0900", "Content-Type": "text/plain; charset=us-ascii", "Content-Transfer-Encoding": "7bit", "Sender": "linux-ext4-owner@vger.kernel.org", "Precedence": "bulk", "List-ID": "<linux-ext4.vger.kernel.org>", "X-Mailing-List": "linux-ext4@vger.kernel.org" }, "content": "Hi,\n\nDave Chinner wrote:\n>> diff -uprN -X linux-2.6.27-rc7-lockfs/Documentation/dontdiff linux-2.6.27-rc7-lockfs/fs/xfs/linux-2.6/xfs_super.c lin\nux-\n>> 2.6.27-rc7-lockfs-xfs/fs/xfs/linux-2.6/xfs_super.c\n>> --- linux-2.6.27-rc7-lockfs/fs/xfs/linux-2.6/xfs_super.c 2008-09-22 07:29:55.000000000 +0900\n>> +++ linux-2.6.27-rc7-lockfs-xfs/fs/xfs/linux-2.6/xfs_super.c 2008-09-22 10:13:39.000000000 +0900\n>> @@ -1351,7 +1351,7 @@ xfs_fs_remount(\n>> * need to take care of themetadata. Once that's done write a dummy\n>> * record to dirty the log in case of a crash while frozen.\n>> */\n>> -STATIC void\n>> +STATIC int\n>> xfs_fs_lockfs(\n>> \tstruct super_block *sb)\n>> {\n>> @@ -1359,6 +1359,7 @@ xfs_fs_lockfs(\n>> \n>> \txfs_attr_quiesce(mp);\n>> \txfs_fs_log_dummy(mp);\n>> + \treturn 0;\n>> }\n> \n> xfs_fs_log_dummy() currently is void because it had nowhere to\n> return errors to. It silently throws away errors because of this.\n> Hence the correct thing to do here is to fix xfs_fs_log_dummy()\n> to return the errors it currently ignores. i.e. catch the errors\n> from xfs_trans_reserve() and xfs_trans_commit() calls in\n> xfs_fs_log_dummy().\n\nOK.\nI've fixed the patch for xfs as following.\nCould you review it?\nIf it's OK, I will include it in new freeze patch-set.\n\nSigned-off-by: Takashi Sato <t-sato@yk.jp.nec.com>\nSigned-off-by: Masayuki Hamaguchi <m-hamaguchi@ys.jp.nec.com>\n---\n--\nTo unsubscribe from this list: send the line \"unsubscribe linux-ext4\" in\nthe body of a message to majordomo@vger.kernel.org\nMore majordomo info at http://vger.kernel.org/majordomo-info.html", "diff": "diff -uprN -X linux-2.6.27-rc7.org/Documentation/dontdiff linux-2.6.27-rc7-ext4_3/fs/xfs/linux-2.6/xfs_super.c linux-2.6\n.27-rc7-xfs_4/fs/xfs/linux-2.6/xfs_super.c\n--- linux-2.6.27-rc7-ext4_3/fs/xfs/linux-2.6/xfs_super.c\t2008-09-24 10:48:02.000000000 +0900\n+++ linux-2.6.27-rc7-xfs_4/fs/xfs/linux-2.6/xfs_super.c\t2008-09-24 11:24:08.000000000 +0900\n@@ -1351,14 +1351,14 @@ xfs_fs_remount(\n * need to take care of themetadata. Once that's done write a dummy\n * record to dirty the log in case of a crash while frozen.\n */\n-STATIC void\n+STATIC int\n xfs_fs_lockfs(\n \tstruct super_block\t*sb)\n {\n \tstruct xfs_mount\t*mp = XFS_M(sb);\n \n \txfs_attr_quiesce(mp);\n-\txfs_fs_log_dummy(mp);\n+\treturn -xfs_fs_log_dummy(mp);\n }\n \n STATIC int\ndiff -uprN -X linux-2.6.27-rc7.org/Documentation/dontdiff linux-2.6.27-rc7-ext4_3/fs/xfs/xfs_fsops.c linux-2.6.27-rc7-xf\ns_4/fs/xfs/xfs_fsops.c\n--- linux-2.6.27-rc7-ext4_3/fs/xfs/xfs_fsops.c\t2008-09-24 10:48:02.000000000 +0900\n+++ linux-2.6.27-rc7-xfs_4/fs/xfs/xfs_fsops.c\t2008-09-24 11:47:08.000000000 +0900\n@@ -589,17 +589,19 @@ out:\n \treturn 0;\n }\n \n-void\n+int\n xfs_fs_log_dummy(\n \txfs_mount_t\t*mp)\n {\n \txfs_trans_t\t*tp;\n \txfs_inode_t\t*ip;\n+\tint\t\terror;\n \n \ttp = _xfs_trans_alloc(mp, XFS_TRANS_DUMMY1);\n-\tif (xfs_trans_reserve(tp, 0, XFS_ICHANGE_LOG_RES(mp), 0, 0, 0)) {\n+\terror = xfs_trans_reserve(tp, 0, XFS_ICHANGE_LOG_RES(mp), 0, 0, 0);\n+\tif (error) {\n \t\txfs_trans_cancel(tp, 0);\n-\t\treturn;\n+\t\treturn error;\n \t}\n \n \tip = mp->m_rootip;\n@@ -609,9 +611,10 @@ xfs_fs_log_dummy(\n \txfs_trans_ihold(tp, ip);\n \txfs_trans_log_inode(tp, ip, XFS_ILOG_CORE);\n \txfs_trans_set_sync(tp);\n-\txfs_trans_commit(tp, 0);\n+\terror = xfs_trans_commit(tp, 0);\n \n \txfs_iunlock(ip, XFS_ILOCK_EXCL);\n+\treturn error;\n }\n \n int\ndiff -uprN -X linux-2.6.27-rc7.org/Documentation/dontdiff linux-2.6.27-rc7-ext4_3/fs/xfs/xfs_fsops.h linux-2.6.27-rc7-xf\ns_4/fs/xfs/xfs_fsops.h\n--- linux-2.6.27-rc7-ext4_3/fs/xfs/xfs_fsops.h\t2008-09-24 10:48:02.000000000 +0900\n+++ linux-2.6.27-rc7-xfs_4/fs/xfs/xfs_fsops.h\t2008-09-24 11:36:29.000000000 +0900\n@@ -25,6 +25,6 @@ extern int xfs_fs_counts(xfs_mount_t *mp\n extern int xfs_reserve_blocks(xfs_mount_t *mp, __uint64_t *inval,\n \t\t\t\txfs_fsop_resblks_t *outval);\n extern int xfs_fs_goingdown(xfs_mount_t *mp, __uint32_t inflags);\n-extern void xfs_fs_log_dummy(xfs_mount_t *mp);\n+extern int xfs_fs_log_dummy(xfs_mount_t *mp);\n \n #endif\t/* __XFS_FSOPS_H__ */\n", "prefixes": [ "4/10" ] }