Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/1246469/?format=api
{ "id": 1246469, "url": "http://patchwork.ozlabs.org/api/patches/1246469/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/158289240414.1877500.8426359194461700361.stgit@firesoul/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<158289240414.1877500.8426359194461700361.stgit@firesoul>", "list_archive_url": null, "date": "2020-02-28T12:20:04", "name": "[net-next] ixgbe: fix XDP redirect on archs with PAGE_SIZE above 4K", "commit_ref": null, "pull_url": null, "state": "deferred", "archived": false, "hash": "57782b9c8eb18c25ddf7dbfb7527da6115d67147", "submitter": { "id": 13625, "url": "http://patchwork.ozlabs.org/api/people/13625/?format=api", "name": "Jesper Dangaard Brouer", "email": "brouer@redhat.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/158289240414.1877500.8426359194461700361.stgit@firesoul/mbox/", "series": [ { "id": 161456, "url": "http://patchwork.ozlabs.org/api/series/161456/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=161456", "date": "2020-02-28T12:20:04", "name": "[net-next] ixgbe: fix XDP redirect on archs with PAGE_SIZE above 4K", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/161456/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/1246469/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/1246469/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": [ "ozlabs.org; spf=pass (sender SPF authorized)\n\tsmtp.mailfrom=osuosl.org (client-ip=140.211.166.133;\n\thelo=hemlock.osuosl.org;\n\tenvelope-from=intel-wired-lan-bounces@osuosl.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org;\n\tdmarc=fail (p=none dis=none) header.from=redhat.com", "ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=redhat.com header.i=@redhat.com\n\theader.a=rsa-sha256 header.s=mimecast20190719\n\theader.b=WSaKPT1J; dkim-atps=neutral" ], "Received": [ "from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 48TTBt55vhz9sPg\n\tfor <incoming@patchwork.ozlabs.org>;\n\tFri, 28 Feb 2020 23:20:21 +1100 (AEDT)", "from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id ABBCE87E0A;\n\tFri, 28 Feb 2020 12:20:19 +0000 (UTC)", "from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id 34HAm-NT9dMs; Fri, 28 Feb 2020 12:20:18 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 2638B87B62;\n\tFri, 28 Feb 2020 12:20:18 +0000 (UTC)", "from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\tby ash.osuosl.org (Postfix) with ESMTP id 3534D1BF2F0\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tFri, 28 Feb 2020 12:20:16 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 2952587B62\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tFri, 28 Feb 2020 12:20:16 +0000 (UTC)", "from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id mWw0x2NT5EOM for <intel-wired-lan@lists.osuosl.org>;\n\tFri, 28 Feb 2020 12:20:15 +0000 (UTC)", "from us-smtp-delivery-1.mimecast.com (us-smtp-2.mimecast.com\n\t[207.211.31.81])\n\tby hemlock.osuosl.org (Postfix) with ESMTPS id 4957087AAE\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tFri, 28 Feb 2020 12:20:15 +0000 (UTC)", "from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com\n\t[209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id\n\tus-mta-293-L8ZPG99NPxWSgrPGihX6Ag-1; Fri, 28 Feb 2020 07:20:09 -0500", "from smtp.corp.redhat.com\n\t(int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mimecast-mx01.redhat.com (Postfix) with ESMTPS id 854C81882CDD;\n\tFri, 28 Feb 2020 12:20:08 +0000 (UTC)", "from firesoul.localdomain (ovpn-200-20.brq.redhat.com\n\t[10.40.200.20])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id AA9BC1CB;\n\tFri, 28 Feb 2020 12:20:05 +0000 (UTC)", "from [10.1.1.1] (localhost [IPv6:::1])\n\tby firesoul.localdomain (Postfix) with ESMTP id 42BB130737E05;\n\tFri, 28 Feb 2020 13:20:04 +0100 (CET)" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n\ts=mimecast20190719; t=1582892414;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\tto:to:cc:cc:mime-version:mime-version:content-type:content-type:\n\tcontent-transfer-encoding:content-transfer-encoding;\n\tbh=w9cxFp8LDEAVTHlgkfdjkdM6yZMYvsET80U5OR5BNZU=;\n\tb=WSaKPT1J22S9bRoH6Dc7OY4klXbEYw5JC8tWKtiYU2A0uSdQRXSffRiVADczYohcSUUwfN\n\t+DSZVcjZPAMwEluY906y3c16cq7YcbqIoIsmHvVIooYnUsMY+hyfJVx8hb+gDdIqN72+dN\n\tWInQ7//uH4oFcUXpbNc3RDFYozCRR+4=", "X-MC-Unique": "L8ZPG99NPxWSgrPGihX6Ag-1", "From": "Jesper Dangaard Brouer <brouer@redhat.com>", "To": "Jesper Dangaard Brouer <brouer@redhat.com>, netdev@vger.kernel.org", "Date": "Fri, 28 Feb 2020 13:20:04 +0100", "Message-ID": "<158289240414.1877500.8426359194461700361.stgit@firesoul>", "User-Agent": "StGit/0.19", "MIME-Version": "1.0", "X-Scanned-By": "MIMEDefang 2.79 on 10.5.11.11", "Subject": "[Intel-wired-lan] [net-next PATCH] ixgbe: fix XDP redirect on archs\n\twith PAGE_SIZE above 4K", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "Cc": "intel-wired-lan@lists.osuosl.org", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "The ixgbe driver have another memory model when compiled on archs with\nPAGE_SIZE above 4096 bytes. In this mode it doesn't split the page in\ntwo halves, but instead increment rx_buffer->page_offset by truesize of\npacket (which include headroom and tailroom for skb_shared_info).\n\nThis is done correctly in ixgbe_build_skb(), but in ixgbe_rx_buffer_flip\nwhich is currently only called on XDP_TX and XDP_REDIRECT, it forgets\nto add the tailroom for skb_shared_info. This breaks XDP_REDIRECT, for\nveth and cpumap. Fix by adding size of skb_shared_info tailroom.\n\nFixes: 6453073987ba (\"ixgbe: add initial support for xdp redirect\")\nSigned-off-by: Jesper Dangaard Brouer <brouer@redhat.com>\n---\n drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | 3 ++-\n 1 file changed, 2 insertions(+), 1 deletion(-)", "diff": "diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c\nindex 718931d951bc..ea6834bae04c 100644\n--- a/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c\n+++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c\n@@ -2254,7 +2254,8 @@ static void ixgbe_rx_buffer_flip(struct ixgbe_ring *rx_ring,\n \trx_buffer->page_offset ^= truesize;\n #else\n \tunsigned int truesize = ring_uses_build_skb(rx_ring) ?\n-\t\t\t\tSKB_DATA_ALIGN(IXGBE_SKB_PAD + size) :\n+\t\t\t\tSKB_DATA_ALIGN(IXGBE_SKB_PAD + size) +\n+\t\t\t\tSKB_DATA_ALIGN(sizeof(struct skb_shared_info)) :\n \t\t\t\tSKB_DATA_ALIGN(size);\n \n \trx_buffer->page_offset += truesize;\n", "prefixes": [ "net-next" ] }