Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/1245986/?format=api
{ "id": 1245986, "url": "http://patchwork.ozlabs.org/api/patches/1245986/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20200227181505.61720-8-anthony.l.nguyen@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20200227181505.61720-8-anthony.l.nguyen@intel.com>", "list_archive_url": null, "date": "2020-02-27T18:14:58", "name": "[S40,08/15] ice: renegotiate link after FW DCB on", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "8af61cafc67389176d5290639a3b94005d859261", "submitter": { "id": 68875, "url": "http://patchwork.ozlabs.org/api/people/68875/?format=api", "name": "Tony Nguyen", "email": "anthony.l.nguyen@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20200227181505.61720-8-anthony.l.nguyen@intel.com/mbox/", "series": [ { "id": 161280, "url": "http://patchwork.ozlabs.org/api/series/161280/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=161280", "date": "2020-02-27T18:14:51", "name": "[S40,01/15] iavf: Enable support for up to 16 queues", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/161280/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/1245986/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/1245986/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": [ "ozlabs.org; spf=pass (sender SPF authorized)\n\tsmtp.mailfrom=osuosl.org (client-ip=140.211.166.133;\n\thelo=hemlock.osuosl.org;\n\tenvelope-from=intel-wired-lan-bounces@osuosl.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org;\n\tdmarc=fail (p=none dis=none) header.from=intel.com" ], "Received": [ "from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 48T17g2zmgz9sRm\n\tfor <incoming@patchwork.ozlabs.org>;\n\tFri, 28 Feb 2020 05:15:59 +1100 (AEDT)", "from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id B78D985AA0;\n\tThu, 27 Feb 2020 18:15:57 +0000 (UTC)", "from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id ug8CrsMmYlhy; Thu, 27 Feb 2020 18:15:56 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 1ED2987FF7;\n\tThu, 27 Feb 2020 18:15:56 +0000 (UTC)", "from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\tby ash.osuosl.org (Postfix) with ESMTP id 9EF601BF3D2\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 27 Feb 2020 18:15:54 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 9C06188020\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 27 Feb 2020 18:15:54 +0000 (UTC)", "from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id dFsWPxh6sCfF for <intel-wired-lan@lists.osuosl.org>;\n\tThu, 27 Feb 2020 18:15:53 +0000 (UTC)", "from mga06.intel.com (mga06.intel.com [134.134.136.31])\n\tby hemlock.osuosl.org (Postfix) with ESMTPS id 922C288002\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 27 Feb 2020 18:15:53 +0000 (UTC)", "from fmsmga003.fm.intel.com ([10.253.24.29])\n\tby orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t27 Feb 2020 10:15:52 -0800", "from unknown (HELO localhost.jf.intel.com) ([10.166.244.174])\n\tby FMSMGA003.fm.intel.com with ESMTP; 27 Feb 2020 10:15:52 -0800" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.70,492,1574150400\"; d=\"scan'208\";a=\"285408851\"", "From": "Tony Nguyen <anthony.l.nguyen@intel.com>", "To": "intel-wired-lan@lists.osuosl.org", "Date": "Thu, 27 Feb 2020 10:14:58 -0800", "Message-Id": "<20200227181505.61720-8-anthony.l.nguyen@intel.com>", "X-Mailer": "git-send-email 2.20.1", "In-Reply-To": "<20200227181505.61720-1-anthony.l.nguyen@intel.com>", "References": "<20200227181505.61720-1-anthony.l.nguyen@intel.com>", "MIME-Version": "1.0", "Subject": "[Intel-wired-lan] [PATCH S40 08/15] ice: renegotiate link after FW\n\tDCB on", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "From: Dave Ertman <david.m.ertman@intel.com>\n\nWhen switching from SW DCB to FW DCB it is necessary\nto renegotiate DCBx so that the FW agent can have up\nto date information about the DCB settings of the link\npartner.\n\nPerform an autoneg restart on the link when activating\nFW DCB.\n\nSigned-off-by: Dave Ertman <david.m.ertman@intel.com>\n---\n drivers/net/ethernet/intel/ice/ice_ethtool.c | 53 +++++++++++---------\n 1 file changed, 29 insertions(+), 24 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/ice/ice_ethtool.c b/drivers/net/ethernet/intel/ice/ice_ethtool.c\nindex c9c217202046..c67cfae64f2b 100644\n--- a/drivers/net/ethernet/intel/ice/ice_ethtool.c\n+++ b/drivers/net/ethernet/intel/ice/ice_ethtool.c\n@@ -1131,6 +1131,33 @@ ice_get_fecparam(struct net_device *netdev, struct ethtool_fecparam *fecparam)\n \treturn err;\n }\n \n+/**\n+ * ice_nway_reset - restart autonegotiation\n+ * @netdev: network interface device structure\n+ */\n+static int ice_nway_reset(struct net_device *netdev)\n+{\n+\tstruct ice_netdev_priv *np = netdev_priv(netdev);\n+\tstruct ice_vsi *vsi = np->vsi;\n+\tstruct ice_port_info *pi;\n+\tenum ice_status status;\n+\n+\tpi = vsi->port_info;\n+\t/* If VSI state is up, then restart autoneg with link up */\n+\tif (!test_bit(__ICE_DOWN, vsi->back->state))\n+\t\tstatus = ice_aq_set_link_restart_an(pi, true, NULL);\n+\telse\n+\t\tstatus = ice_aq_set_link_restart_an(pi, false, NULL);\n+\n+\tif (status) {\n+\t\tnetdev_info(netdev, \"link restart failed, err %d aq_err %d\\n\",\n+\t\t\t status, pi->hw->adminq.sq_last_status);\n+\t\treturn -EIO;\n+\t}\n+\n+\treturn 0;\n+}\n+\n /**\n * ice_get_priv_flags - report device private flags\n * @netdev: network interface device structure\n@@ -1264,6 +1291,8 @@ static int ice_set_priv_flags(struct net_device *netdev, u32 flags)\n \t\t\tstatus = ice_cfg_lldp_mib_change(&pf->hw, true);\n \t\t\tif (status)\n \t\t\t\tdev_dbg(dev, \"Fail to enable MIB change events\\n\");\n+\n+\t\t\tice_nway_reset(netdev);\n \t\t}\n \t}\n \tif (test_bit(ICE_FLAG_LEGACY_RX, change_flags)) {\n@@ -2775,30 +2804,6 @@ ice_set_ringparam(struct net_device *netdev, struct ethtool_ringparam *ring)\n \treturn err;\n }\n \n-static int ice_nway_reset(struct net_device *netdev)\n-{\n-\t/* restart autonegotiation */\n-\tstruct ice_netdev_priv *np = netdev_priv(netdev);\n-\tstruct ice_vsi *vsi = np->vsi;\n-\tstruct ice_port_info *pi;\n-\tenum ice_status status;\n-\n-\tpi = vsi->port_info;\n-\t/* If VSI state is up, then restart autoneg with link up */\n-\tif (!test_bit(__ICE_DOWN, vsi->back->state))\n-\t\tstatus = ice_aq_set_link_restart_an(pi, true, NULL);\n-\telse\n-\t\tstatus = ice_aq_set_link_restart_an(pi, false, NULL);\n-\n-\tif (status) {\n-\t\tnetdev_info(netdev, \"link restart failed, err %d aq_err %d\\n\",\n-\t\t\t status, pi->hw->adminq.sq_last_status);\n-\t\treturn -EIO;\n-\t}\n-\n-\treturn 0;\n-}\n-\n /**\n * ice_get_pauseparam - Get Flow Control status\n * @netdev: network interface device structure\n", "prefixes": [ "S40", "08/15" ] }