Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/1237762/?format=api
{ "id": 1237762, "url": "http://patchwork.ozlabs.org/api/patches/1237762/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20200213213129.34023-3-anthony.l.nguyen@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20200213213129.34023-3-anthony.l.nguyen@intel.com>", "list_archive_url": null, "date": "2020-02-13T21:31:18", "name": "[S39,v2,04/15] ice: Always clear the QRXFLXP_CNTXT register for VF Rx queues", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "d1fb0f7fafdd4724f8e2f2d4103927d134b70b69", "submitter": { "id": 68875, "url": "http://patchwork.ozlabs.org/api/people/68875/?format=api", "name": "Tony Nguyen", "email": "anthony.l.nguyen@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20200213213129.34023-3-anthony.l.nguyen@intel.com/mbox/", "series": [ { "id": 158447, "url": "http://patchwork.ozlabs.org/api/series/158447/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=158447", "date": "2020-02-13T21:30:59", "name": "[S39,v2,01/15] ice: Validate config for SW DCB map", "version": 2, "mbox": "http://patchwork.ozlabs.org/series/158447/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/1237762/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/1237762/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": [ "ozlabs.org; spf=pass (sender SPF authorized)\n\tsmtp.mailfrom=osuosl.org (client-ip=140.211.166.133;\n\thelo=hemlock.osuosl.org;\n\tenvelope-from=intel-wired-lan-bounces@osuosl.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org;\n\tdmarc=fail (p=none dis=none) header.from=intel.com" ], "Received": [ "from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 48JV8M6VnRz9sPk\n\tfor <incoming@patchwork.ozlabs.org>;\n\tFri, 14 Feb 2020 08:32:03 +1100 (AEDT)", "from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 48E1987EA6;\n\tThu, 13 Feb 2020 21:32:02 +0000 (UTC)", "from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id t3Vy5-gIzGeP; Thu, 13 Feb 2020 21:32:01 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 9388B87F1F;\n\tThu, 13 Feb 2020 21:32:00 +0000 (UTC)", "from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n\tby ash.osuosl.org (Postfix) with ESMTP id 107CF1BF9BA\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 13 Feb 2020 21:31:55 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id 0C813862B4\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 13 Feb 2020 21:31:55 +0000 (UTC)", "from fraxinus.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id MYQ3pW3EZkbg for <intel-wired-lan@lists.osuosl.org>;\n\tThu, 13 Feb 2020 21:31:54 +0000 (UTC)", "from mga06.intel.com (mga06.intel.com [134.134.136.31])\n\tby fraxinus.osuosl.org (Postfix) with ESMTPS id 787B9862DB\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 13 Feb 2020 21:31:54 +0000 (UTC)", "from orsmga008.jf.intel.com ([10.7.209.65])\n\tby orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t13 Feb 2020 13:31:51 -0800", "from unknown (HELO localhost.jf.intel.com) ([10.166.244.174])\n\tby orsmga008.jf.intel.com with ESMTP; 13 Feb 2020 13:31:50 -0800" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.70,438,1574150400\"; d=\"scan'208\";a=\"227382407\"", "From": "Tony Nguyen <anthony.l.nguyen@intel.com>", "To": "intel-wired-lan@lists.osuosl.org", "Date": "Thu, 13 Feb 2020 13:31:18 -0800", "Message-Id": "<20200213213129.34023-3-anthony.l.nguyen@intel.com>", "X-Mailer": "git-send-email 2.20.1", "In-Reply-To": "<20200213213129.34023-1-anthony.l.nguyen@intel.com>", "References": "<20200213213129.34023-1-anthony.l.nguyen@intel.com>", "MIME-Version": "1.0", "Subject": "[Intel-wired-lan] [PATCH S39 v2 04/15] ice: Always clear the\n\tQRXFLXP_CNTXT register for VF Rx queues", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "From: Brett Creeley <brett.creeley@intel.com>\n\nCurrently when the PF reduces its number of channels via ethtool and\nthen VFs are created there may be stale data for some of the Rx queues\nbelonging to VFs. This happens when a VF reuses an Rx queue that was\npreviously used by the PF. Specifically, the QRXFLXP_CNTXT register\nwill have incorrect values. Fix this by always clearing the relevant\nvalues in the QRXFLXP_CNTXT register for VF queues.\n\nSigned-off-by: Brett Creeley <brett.creeley@intel.com>\nSigned-off-by: Tony Nguyen <anthony.l.nguyen@intel.com>\n---\n drivers/net/ethernet/intel/ice/ice_base.c | 8 ++++++--\n drivers/net/ethernet/intel/ice/ice_hw_autogen.h | 1 +\n 2 files changed, 7 insertions(+), 2 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/ice/ice_base.c b/drivers/net/ethernet/intel/ice/ice_base.c\nindex 75cc5a366b26..54aa533f36d4 100644\n--- a/drivers/net/ethernet/intel/ice/ice_base.c\n+++ b/drivers/net/ethernet/intel/ice/ice_base.c\n@@ -386,8 +386,8 @@ int ice_setup_rx_ctx(struct ice_ring *ring)\n \t /* Enable Flexible Descriptors in the queue context which\n \t * allows this driver to select a specific receive descriptor format\n \t */\n+\tregval = rd32(hw, QRXFLXP_CNTXT(pf_q));\n \tif (vsi->type != ICE_VSI_VF) {\n-\t\tregval = rd32(hw, QRXFLXP_CNTXT(pf_q));\n \t\tregval |= (rxdid << QRXFLXP_CNTXT_RXDID_IDX_S) &\n \t\t\tQRXFLXP_CNTXT_RXDID_IDX_M;\n \n@@ -398,8 +398,12 @@ int ice_setup_rx_ctx(struct ice_ring *ring)\n \t\tregval |= (0x03 << QRXFLXP_CNTXT_RXDID_PRIO_S) &\n \t\t\tQRXFLXP_CNTXT_RXDID_PRIO_M;\n \n-\t\twr32(hw, QRXFLXP_CNTXT(pf_q), regval);\n+\t} else {\n+\t\tregval &= ~(QRXFLXP_CNTXT_RXDID_IDX_M |\n+\t\t\t QRXFLXP_CNTXT_RXDID_PRIO_M |\n+\t\t\t QRXFLXP_CNTXT_TS_M);\n \t}\n+\twr32(hw, QRXFLXP_CNTXT(pf_q), regval);\n \n \t/* Absolute queue number out of 2K needs to be passed */\n \terr = ice_write_rxq_ctx(hw, &rlan_ctx, pf_q);\ndiff --git a/drivers/net/ethernet/intel/ice/ice_hw_autogen.h b/drivers/net/ethernet/intel/ice/ice_hw_autogen.h\nindex 57f1c4513c0b..3f40736a8295 100644\n--- a/drivers/net/ethernet/intel/ice/ice_hw_autogen.h\n+++ b/drivers/net/ethernet/intel/ice/ice_hw_autogen.h\n@@ -86,6 +86,7 @@\n #define QRXFLXP_CNTXT_RXDID_IDX_M\t\tICE_M(0x3F, 0)\n #define QRXFLXP_CNTXT_RXDID_PRIO_S\t\t8\n #define QRXFLXP_CNTXT_RXDID_PRIO_M\t\tICE_M(0x7, 8)\n+#define QRXFLXP_CNTXT_TS_M\t\t\tBIT(11)\n #define GLGEN_RSTAT\t\t\t\t0x000B8188\n #define GLGEN_RSTAT_DEVSTATE_M\t\t\tICE_M(0x3, 0)\n #define GLGEN_RSTCTL\t\t\t\t0x000B8180\n", "prefixes": [ "S39", "v2", "04/15" ] }