Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/1237760/?format=api
{ "id": 1237760, "url": "http://patchwork.ozlabs.org/api/patches/1237760/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20200213213129.34023-9-anthony.l.nguyen@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20200213213129.34023-9-anthony.l.nguyen@intel.com>", "list_archive_url": null, "date": "2020-02-13T21:31:24", "name": "[S39,v2,10/15] ice: Don't tell the OS that link is going down", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "d5d236ac70b9c567e9ce7022e3fec5a414ba3c16", "submitter": { "id": 68875, "url": "http://patchwork.ozlabs.org/api/people/68875/?format=api", "name": "Tony Nguyen", "email": "anthony.l.nguyen@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20200213213129.34023-9-anthony.l.nguyen@intel.com/mbox/", "series": [ { "id": 158447, "url": "http://patchwork.ozlabs.org/api/series/158447/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=158447", "date": "2020-02-13T21:30:59", "name": "[S39,v2,01/15] ice: Validate config for SW DCB map", "version": 2, "mbox": "http://patchwork.ozlabs.org/series/158447/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/1237760/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/1237760/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": [ "ozlabs.org; spf=pass (sender SPF authorized)\n\tsmtp.mailfrom=osuosl.org (client-ip=140.211.166.136;\n\thelo=silver.osuosl.org;\n\tenvelope-from=intel-wired-lan-bounces@osuosl.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org;\n\tdmarc=fail (p=none dis=none) header.from=intel.com" ], "Received": [ "from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 48JV8L1Z7lz9sPk\n\tfor <incoming@patchwork.ozlabs.org>;\n\tFri, 14 Feb 2020 08:32:02 +1100 (AEDT)", "from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id 958A421561;\n\tThu, 13 Feb 2020 21:32:00 +0000 (UTC)", "from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id W640VY4I3BuW; Thu, 13 Feb 2020 21:31:59 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby silver.osuosl.org (Postfix) with ESMTP id 7277F2156E;\n\tThu, 13 Feb 2020 21:31:59 +0000 (UTC)", "from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\tby ash.osuosl.org (Postfix) with ESMTP id E2F111BF338\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 13 Feb 2020 21:31:54 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id E051C21F69\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 13 Feb 2020 21:31:54 +0000 (UTC)", "from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id 9UkP8aXpN9C6 for <intel-wired-lan@lists.osuosl.org>;\n\tThu, 13 Feb 2020 21:31:53 +0000 (UTC)", "from mga06.intel.com (mga06.intel.com [134.134.136.31])\n\tby silver.osuosl.org (Postfix) with ESMTPS id 1098D21561\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 13 Feb 2020 21:31:53 +0000 (UTC)", "from orsmga008.jf.intel.com ([10.7.209.65])\n\tby orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t13 Feb 2020 13:31:51 -0800", "from unknown (HELO localhost.jf.intel.com) ([10.166.244.174])\n\tby orsmga008.jf.intel.com with ESMTP; 13 Feb 2020 13:31:51 -0800" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.70,438,1574150400\"; d=\"scan'208\";a=\"227382413\"", "From": "Tony Nguyen <anthony.l.nguyen@intel.com>", "To": "intel-wired-lan@lists.osuosl.org", "Date": "Thu, 13 Feb 2020 13:31:24 -0800", "Message-Id": "<20200213213129.34023-9-anthony.l.nguyen@intel.com>", "X-Mailer": "git-send-email 2.20.1", "In-Reply-To": "<20200213213129.34023-1-anthony.l.nguyen@intel.com>", "References": "<20200213213129.34023-1-anthony.l.nguyen@intel.com>", "MIME-Version": "1.0", "Subject": "[Intel-wired-lan] [PATCH S39 v2 10/15] ice: Don't tell the OS that\n\tlink is going down", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "From: Michal Swiatkowski <michal.swiatkowski@intel.com>\n\nRemove code that tell the OS that link is going down when user\nchange flow control via ethtool. When link is up it isn't certain\nthat link goes down after 0x0605 aq command. If link doesn't go\ndown, OS thinks that link is down, but physical link is up. To\nreset this state user have to take interface down and up.\n\nIf link goes down after 0x0605 command, FW send information\nabout that and after that driver tells the OS that the link goes\ndown. So this code in ethtool is unnecessary.\n\nSigned-off-by: Michal Swiatkowski <michal.swiatkowski@intel.com>\n---\n drivers/net/ethernet/intel/ice/ice_ethtool.c | 7 -------\n 1 file changed, 7 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/ice/ice_ethtool.c b/drivers/net/ethernet/intel/ice/ice_ethtool.c\nindex 22a9f59e7218..135d5bfc6e11 100644\n--- a/drivers/net/ethernet/intel/ice/ice_ethtool.c\n+++ b/drivers/net/ethernet/intel/ice/ice_ethtool.c\n@@ -2935,13 +2935,6 @@ ice_set_pauseparam(struct net_device *netdev, struct ethtool_pauseparam *pause)\n \telse\n \t\treturn -EINVAL;\n \n-\t/* Tell the OS link is going down, the link will go back up when fw\n-\t * says it is ready asynchronously\n-\t */\n-\tice_print_link_msg(vsi, false);\n-\tnetif_carrier_off(netdev);\n-\tnetif_tx_stop_all_queues(netdev);\n-\n \t/* Set the FC mode and only restart AN if link is up */\n \tstatus = ice_set_fc(pi, &aq_failures, link_up);\n \n", "prefixes": [ "S39", "v2", "10/15" ] }