Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/1234849/?format=api
{ "id": 1234849, "url": "http://patchwork.ozlabs.org/api/patches/1234849/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20200207101005.4454-1-kai.heng.feng@canonical.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20200207101005.4454-1-kai.heng.feng@canonical.com>", "list_archive_url": null, "date": "2020-02-07T10:10:03", "name": "[v3,1/2] igb: Use device_lock() insead of rtnl_lock()", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "d1092091c55f3d162b8bf59352c49c639e6019d2", "submitter": { "id": 70328, "url": "http://patchwork.ozlabs.org/api/people/70328/?format=api", "name": "Kai-Heng Feng", "email": "kai.heng.feng@canonical.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20200207101005.4454-1-kai.heng.feng@canonical.com/mbox/", "series": [ { "id": 157298, "url": "http://patchwork.ozlabs.org/api/series/157298/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=157298", "date": "2020-02-07T10:10:03", "name": "[v3,1/2] igb: Use device_lock() insead of rtnl_lock()", "version": 3, "mbox": "http://patchwork.ozlabs.org/series/157298/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/1234849/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/1234849/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": [ "ozlabs.org; spf=pass (sender SPF authorized)\n\tsmtp.mailfrom=osuosl.org (client-ip=140.211.166.133;\n\thelo=hemlock.osuosl.org;\n\tenvelope-from=intel-wired-lan-bounces@osuosl.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org; dmarc=fail (p=none dis=none)\n\theader.from=canonical.com" ], "Received": [ "from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 48DWJd4lZ2z9sRK\n\tfor <incoming@patchwork.ozlabs.org>;\n\tFri, 7 Feb 2020 21:10:25 +1100 (AEDT)", "from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 916F587DA1;\n\tFri, 7 Feb 2020 10:10:23 +0000 (UTC)", "from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id aZ-nQfrDO8vT; Fri, 7 Feb 2020 10:10:21 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id CA73987DA2;\n\tFri, 7 Feb 2020 10:10:21 +0000 (UTC)", "from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\tby ash.osuosl.org (Postfix) with ESMTP id EC2DD1BF3C8\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tFri, 7 Feb 2020 10:10:20 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id E84D32037E\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tFri, 7 Feb 2020 10:10:20 +0000 (UTC)", "from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id jxun98zF-Z43 for <intel-wired-lan@lists.osuosl.org>;\n\tFri, 7 Feb 2020 10:10:20 +0000 (UTC)", "from youngberry.canonical.com (youngberry.canonical.com\n\t[91.189.89.112])\n\tby silver.osuosl.org (Postfix) with ESMTPS id EDA9120373\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tFri, 7 Feb 2020 10:10:19 +0000 (UTC)", "from 61-220-137-37.hinet-ip.hinet.net ([61.220.137.37]\n\thelo=localhost) by youngberry.canonical.com with esmtpsa\n\t(TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.86_2)\n\t(envelope-from <kai.heng.feng@canonical.com>)\n\tid 1j00aS-0007Hs-5H; Fri, 07 Feb 2020 10:10:12 +0000" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "From": "Kai-Heng Feng <kai.heng.feng@canonical.com>", "To": "davem@davemloft.net,\n\tmkubecek@suse.cz,\n\tjeffrey.t.kirsher@intel.com", "Date": "Fri, 7 Feb 2020 18:10:03 +0800", "Message-Id": "<20200207101005.4454-1-kai.heng.feng@canonical.com>", "X-Mailer": "git-send-email 2.17.1", "Subject": "[Intel-wired-lan] [PATCH v3 1/2] igb: Use device_lock() insead of\n\trtnl_lock()", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "Cc": "\"open list:NETWORKING DRIVERS\" <netdev@vger.kernel.org>,\n\tKai-Heng Feng <kai.heng.feng@canonical.com>,\n\t\"moderated list:INTEL ETHERNET DRIVERS\"\n\t<intel-wired-lan@lists.osuosl.org>, \n\topen list <linux-kernel@vger.kernel.org>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "Commit 9474933caf21 (\"igb: close/suspend race in netif_device_detach\")\nfixed race condition between close and power management ops by using\nrtnl_lock().\n\nHowever we can achieve the same by using device_lock() since all power\nmanagement ops are protected by device_lock().\n\nThis fix is a preparation for next patch, to prevent a dead lock under\nrtnl_lock() when calling runtime resume routine.\n\nSigned-off-by: Kai-Heng Feng <kai.heng.feng@canonical.com>\n---\nv3:\n - Fix unreleased lock reported by 0-day test bot.\nv2:\n - No change.\n\n drivers/net/ethernet/intel/igb/igb_main.c | 14 ++++++++------\n 1 file changed, 8 insertions(+), 6 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/igb/igb_main.c b/drivers/net/ethernet/intel/igb/igb_main.c\nindex b46bff8fe056..661255500d66 100644\n--- a/drivers/net/ethernet/intel/igb/igb_main.c\n+++ b/drivers/net/ethernet/intel/igb/igb_main.c\n@@ -4026,9 +4026,15 @@ static int __igb_close(struct net_device *netdev, bool suspending)\n \n int igb_close(struct net_device *netdev)\n {\n+\tstruct igb_adapter *adapter = netdev_priv(netdev);\n+\tstruct device *dev = &adapter->pdev->dev;\n+\tint err = 0;\n+\n+\tdevice_lock(dev);\n \tif (netif_device_present(netdev) || netdev->dismantle)\n-\t\treturn __igb_close(netdev, false);\n-\treturn 0;\n+\t\terr = __igb_close(netdev, false);\n+\tdevice_unlock(dev);\n+\treturn err;\n }\n \n /**\n@@ -8760,7 +8766,6 @@ static int __igb_shutdown(struct pci_dev *pdev, bool *enable_wake,\n \tu32 wufc = runtime ? E1000_WUFC_LNKC : adapter->wol;\n \tbool wake;\n \n-\trtnl_lock();\n \tnetif_device_detach(netdev);\n \n \tif (netif_running(netdev))\n@@ -8769,7 +8774,6 @@ static int __igb_shutdown(struct pci_dev *pdev, bool *enable_wake,\n \tigb_ptp_suspend(adapter);\n \n \tigb_clear_interrupt_scheme(adapter);\n-\trtnl_unlock();\n \n \tstatus = rd32(E1000_STATUS);\n \tif (status & E1000_STATUS_LU)\n@@ -8897,13 +8901,11 @@ static int __maybe_unused igb_resume(struct device *dev)\n \n \twr32(E1000_WUS, ~0);\n \n-\trtnl_lock();\n \tif (!err && netif_running(netdev))\n \t\terr = __igb_open(netdev, true);\n \n \tif (!err)\n \t\tnetif_device_attach(netdev);\n-\trtnl_unlock();\n \n \treturn err;\n }\n", "prefixes": [ "v3", "1/2" ] }