Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/1231760/?format=api
{ "id": 1231760, "url": "http://patchwork.ozlabs.org/api/patches/1231760/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20200131045658.ahliv7jvubpwoeru@kili.mountain/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20200131045658.ahliv7jvubpwoeru@kili.mountain>", "list_archive_url": null, "date": "2020-01-31T04:56:59", "name": "[net] ice: Fix a couple off by one bugs", "commit_ref": null, "pull_url": null, "state": "deferred", "archived": false, "hash": "208aeb6fe82518e3504bfe79db4c9716267155f5", "submitter": { "id": 9327, "url": "http://patchwork.ozlabs.org/api/people/9327/?format=api", "name": "Dan Carpenter", "email": "dan.carpenter@oracle.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20200131045658.ahliv7jvubpwoeru@kili.mountain/mbox/", "series": [ { "id": 156137, "url": "http://patchwork.ozlabs.org/api/series/156137/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=156137", "date": "2020-01-31T04:56:59", "name": "[net] ice: Fix a couple off by one bugs", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/156137/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/1231760/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/1231760/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": [ "ozlabs.org; spf=pass (sender SPF authorized)\n\tsmtp.mailfrom=osuosl.org (client-ip=140.211.166.138;\n\thelo=whitealder.osuosl.org;\n\tenvelope-from=intel-wired-lan-bounces@osuosl.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org;\n\tdmarc=fail (p=none dis=none) header.from=oracle.com", "ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=oracle.com header.i=@oracle.com\n\theader.a=rsa-sha256 header.s=corp-2019-08-05\n\theader.b=qDrw86Ze; dkim-atps=neutral" ], "Received": [ "from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 4884hk2PKjz9sRQ\n\tfor <incoming@patchwork.ozlabs.org>;\n\tFri, 31 Jan 2020 15:57:23 +1100 (AEDT)", "from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 591F386788;\n\tFri, 31 Jan 2020 04:57:21 +0000 (UTC)", "from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id UTX74UKZJUDF; Fri, 31 Jan 2020 04:57:20 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 7A71D86746;\n\tFri, 31 Jan 2020 04:57:20 +0000 (UTC)", "from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\tby ash.osuosl.org (Postfix) with ESMTP id 982921BF869\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tFri, 31 Jan 2020 04:57:18 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id 8AE1F2035B\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tFri, 31 Jan 2020 04:57:18 +0000 (UTC)", "from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id YNoCbUwInWmA for <intel-wired-lan@lists.osuosl.org>;\n\tFri, 31 Jan 2020 04:57:17 +0000 (UTC)", "from userp2120.oracle.com (userp2120.oracle.com [156.151.31.85])\n\tby silver.osuosl.org (Postfix) with ESMTPS id 9B91D2034D\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tFri, 31 Jan 2020 04:57:17 +0000 (UTC)", "from pps.filterd (userp2120.oracle.com [127.0.0.1])\n\tby userp2120.oracle.com (8.16.0.27/8.16.0.27) with SMTP id\n\t00V4t9S2169776; Fri, 31 Jan 2020 04:57:10 GMT", "from userp3020.oracle.com (userp3020.oracle.com [156.151.31.79])\n\tby userp2120.oracle.com with ESMTP id 2xrearqyj3-1\n\t(version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256\n\tverify=OK); Fri, 31 Jan 2020 04:57:10 +0000", "from pps.filterd (userp3020.oracle.com [127.0.0.1])\n\tby userp3020.oracle.com (8.16.0.27/8.16.0.27) with SMTP id\n\t00V4sPgm071523; Fri, 31 Jan 2020 04:57:10 GMT", "from aserv0122.oracle.com (aserv0122.oracle.com [141.146.126.236])\n\tby userp3020.oracle.com with ESMTP id 2xva6pnhee-1\n\t(version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256\n\tverify=OK); Fri, 31 Jan 2020 04:57:09 +0000", "from abhmp0013.oracle.com (abhmp0013.oracle.com [141.146.116.19])\n\tby aserv0122.oracle.com (8.14.4/8.14.4) with ESMTP id\n\t00V4v8VD009079; Fri, 31 Jan 2020 04:57:08 GMT", "from kili.mountain (/129.205.23.165)\n\tby default (Oracle Beehive Gateway v4.0)\n\twith ESMTP ; Thu, 30 Jan 2020 20:57:07 -0800" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com;\n\th=date : from : to : cc\n\t: subject : message-id : mime-version : content-type;\n\ts=corp-2019-08-05; \n\tbh=vhZBZHYwVQzRkRLs8F0bVp2acAD00tQ4dSXfaT080og=;\n\tb=qDrw86Zex1TwokPNvN+0PXezdzAZPyaWWLNKVuV+PRjFRyVEQYqwBnZgJ76oyV1TKxSK\n\tm4KmMs+1nhgiXbuOp3yAlkHnVAkZ3Z8b6WRMSs7POX4L4+5LPCwTd8ON360Zde6jHoVj\n\tzkB2erApNm2mKH6PNSaDTzuOT3/+BExbBJ35RhxorPpi5kzPFkN2A41XwtmRD+Q+aCTM\n\t2AyHX3EdGNBIW+lvkjYdSdQ2Fa/Pq1eOdYYn81JlGJdPZPBnJmnDsh0YwnstoAnF0ety\n\tJq4f3L2DZJYBg4XVNAoHAaod48FAmYEk3vGACbjtIAX2CNA2CmfOZpqy7wkTE0GrCqId\n\tTg== ", "Date": "Fri, 31 Jan 2020 07:56:59 +0300", "From": "Dan Carpenter <dan.carpenter@oracle.com>", "To": "Jeff Kirsher <jeffrey.t.kirsher@intel.com>,\n\tTony Nguyen <anthony.l.nguyen@intel.com>", "Message-ID": "<20200131045658.ahliv7jvubpwoeru@kili.mountain>", "MIME-Version": "1.0", "Content-Disposition": "inline", "X-Mailer": "git-send-email haha only kidding", "User-Agent": "NeoMutt/20170113 (1.7.2)", "X-Proofpoint-Virus-Version": [ "vendor=nai engine=6000 definitions=9516\n\tsignatures=668685", "vendor=nai engine=6000 definitions=9516\n\tsignatures=668685" ], "X-Proofpoint-Spam-Details": [ "rule=notspam policy=default score=0 suspectscore=2\n\tmalwarescore=0\n\tphishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=999\n\tadultscore=0 classifier=spam adjust=0 reason=mlx scancount=1\n\tengine=8.0.1-1911140001 definitions=main-2001310042", "rule=notspam policy=default score=0\n\tpriorityscore=1501 malwarescore=0\n\tsuspectscore=2 phishscore=0 bulkscore=0 spamscore=0 clxscore=1011\n\tlowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=999\n\tadultscore=0\n\tclassifier=spam adjust=0 reason=mlx scancount=1\n\tengine=8.0.1-1911140001\n\tdefinitions=main-2001310042" ], "Subject": "[Intel-wired-lan] [PATCH net] ice: Fix a couple off by one bugs", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "Cc": "netdev@vger.kernel.org, kernel-janitors@vger.kernel.org,\n\tintel-wired-lan@lists.osuosl.org, \"David S. Miller\" <davem@davemloft.net>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "The hw->blk[blk]->es.ref_count[] array has hw->blk[blk].es.count\nelements. It gets allocated in ice_init_hw_tbls(). So the > should be\n>= to prevent accessing one element beyond the end of the array.\n\nFixes: 2c61054c5fda (\"ice: Optimize table usage\")\nSigned-off-by: Dan Carpenter <dan.carpenter@oracle.com>\n---\n drivers/net/ethernet/intel/ice/ice_flex_pipe.c | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/ice/ice_flex_pipe.c b/drivers/net/ethernet/intel/ice/ice_flex_pipe.c\nindex 99208946224c..38a7041fe774 100644\n--- a/drivers/net/ethernet/intel/ice/ice_flex_pipe.c\n+++ b/drivers/net/ethernet/intel/ice/ice_flex_pipe.c\n@@ -1950,7 +1950,7 @@ ice_free_prof_id(struct ice_hw *hw, enum ice_block blk, u8 prof_id)\n static enum ice_status\n ice_prof_inc_ref(struct ice_hw *hw, enum ice_block blk, u8 prof_id)\n {\n-\tif (prof_id > hw->blk[blk].es.count)\n+\tif (prof_id >= hw->blk[blk].es.count)\n \t\treturn ICE_ERR_PARAM;\n \n \thw->blk[blk].es.ref_count[prof_id]++;\n@@ -1991,7 +1991,7 @@ ice_write_es(struct ice_hw *hw, enum ice_block blk, u8 prof_id,\n static enum ice_status\n ice_prof_dec_ref(struct ice_hw *hw, enum ice_block blk, u8 prof_id)\n {\n-\tif (prof_id > hw->blk[blk].es.count)\n+\tif (prof_id >= hw->blk[blk].es.count)\n \t\treturn ICE_ERR_PARAM;\n \n \tif (hw->blk[blk].es.ref_count[prof_id] > 0) {\n", "prefixes": [ "net" ] }