Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/1229956/?format=api
{ "id": 1229956, "url": "http://patchwork.ozlabs.org/api/patches/1229956/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20200127085927.13999-12-anthony.l.nguyen@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20200127085927.13999-12-anthony.l.nguyen@intel.com>", "list_archive_url": null, "date": "2020-01-27T08:59:24", "name": "[S39,12/15] ice: add backslash-n to strings", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "428d33b6066f4b5816cd58ad0bf060b6998acda6", "submitter": { "id": 68875, "url": "http://patchwork.ozlabs.org/api/people/68875/?format=api", "name": "Tony Nguyen", "email": "anthony.l.nguyen@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20200127085927.13999-12-anthony.l.nguyen@intel.com/mbox/", "series": [ { "id": 155506, "url": "http://patchwork.ozlabs.org/api/series/155506/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=155506", "date": "2020-01-27T08:59:25", "name": "[S39,01/15] ice: Validate config for SW DCB map", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/155506/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/1229956/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/1229956/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": [ "ozlabs.org; spf=pass (sender SPF authorized)\n\tsmtp.mailfrom=osuosl.org (client-ip=140.211.166.136;\n\thelo=silver.osuosl.org;\n\tenvelope-from=intel-wired-lan-bounces@osuosl.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org;\n\tdmarc=fail (p=none dis=none) header.from=intel.com" ], "Received": [ "from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 485xdX5ymtz9sRR\n\tfor <incoming@patchwork.ozlabs.org>;\n\tTue, 28 Jan 2020 04:32:16 +1100 (AEDT)", "from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id 5914720486;\n\tMon, 27 Jan 2020 17:32:15 +0000 (UTC)", "from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id bHUBZAH-VevL; Mon, 27 Jan 2020 17:32:13 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby silver.osuosl.org (Postfix) with ESMTP id 719732038A;\n\tMon, 27 Jan 2020 17:32:13 +0000 (UTC)", "from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\tby ash.osuosl.org (Postfix) with ESMTP id 014131BF283\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tMon, 27 Jan 2020 17:32:12 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id ED3D8879A6\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tMon, 27 Jan 2020 17:32:11 +0000 (UTC)", "from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id Pu4YiMc5xW8p for <intel-wired-lan@lists.osuosl.org>;\n\tMon, 27 Jan 2020 17:32:11 +0000 (UTC)", "from mga14.intel.com (mga14.intel.com [192.55.52.115])\n\tby hemlock.osuosl.org (Postfix) with ESMTPS id EAE908796C\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tMon, 27 Jan 2020 17:32:10 +0000 (UTC)", "from fmsmga005.fm.intel.com ([10.253.24.32])\n\tby fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t27 Jan 2020 09:32:10 -0800", "from unknown (HELO localhost.jf.intel.com) ([10.166.244.174])\n\tby fmsmga005.fm.intel.com with ESMTP; 27 Jan 2020 09:32:10 -0800" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.70,370,1574150400\"; d=\"scan'208\";a=\"427350658\"", "From": "Tony Nguyen <anthony.l.nguyen@intel.com>", "To": "intel-wired-lan@lists.osuosl.org", "Date": "Mon, 27 Jan 2020 00:59:24 -0800", "Message-Id": "<20200127085927.13999-12-anthony.l.nguyen@intel.com>", "X-Mailer": "git-send-email 2.20.1", "In-Reply-To": "<20200127085927.13999-1-anthony.l.nguyen@intel.com>", "References": "<20200127085927.13999-1-anthony.l.nguyen@intel.com>", "MIME-Version": "1.0", "Subject": "[Intel-wired-lan] [PATCH S39 12/15] ice: add backslash-n to strings", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "From: Jesse Brandeburg <jesse.brandeburg@intel.com>\n\nThere were several strings found without line feeds, fix\nthem by adding a line feed, as is typical. Without this\nlotsofmessagescanbejumbledtogether.\n\nThis patch has known checkpatch warnings from long lines\nfor the NL_* messages, because checkpatch doesn't know\nhow to ignore them.\n\nSigned-off-by: Jesse Brandeburg <jesse.brandeburg@intel.com>\n---\n drivers/net/ethernet/intel/ice/ice_base.c | 3 +--\n drivers/net/ethernet/intel/ice/ice_ethtool.c | 8 ++++----\n drivers/net/ethernet/intel/ice/ice_main.c | 12 ++++--------\n drivers/net/ethernet/intel/ice/ice_virtchnl_pf.c | 2 +-\n drivers/net/ethernet/intel/ice/ice_xsk.c | 6 +++---\n 5 files changed, 13 insertions(+), 18 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/ice/ice_base.c b/drivers/net/ethernet/intel/ice/ice_base.c\nindex 54aa533f36d4..a19cd6f5436b 100644\n--- a/drivers/net/ethernet/intel/ice/ice_base.c\n+++ b/drivers/net/ethernet/intel/ice/ice_base.c\n@@ -203,8 +203,7 @@ static void ice_cfg_itr_gran(struct ice_hw *hw)\n */\n static u16 ice_calc_q_handle(struct ice_vsi *vsi, struct ice_ring *ring, u8 tc)\n {\n-\tWARN_ONCE(ice_ring_is_xdp(ring) && tc,\n-\t\t \"XDP ring can't belong to TC other than 0\");\n+\tWARN_ONCE(ice_ring_is_xdp(ring) && tc, \"XDP ring can't belong to TC other than 0\\n\");\n \n \t/* Idea here for calculation is that we subtract the number of queue\n \t * count from TC that ring belongs to from it's absolute queue index\ndiff --git a/drivers/net/ethernet/intel/ice/ice_ethtool.c b/drivers/net/ethernet/intel/ice/ice_ethtool.c\nindex c302470b095b..6d7089534d42 100644\n--- a/drivers/net/ethernet/intel/ice/ice_ethtool.c\n+++ b/drivers/net/ethernet/intel/ice/ice_ethtool.c\n@@ -673,7 +673,7 @@ static u64 ice_loopback_test(struct net_device *netdev)\n \n \ttest_vsi = ice_lb_vsi_setup(pf, pf->hw.port_info);\n \tif (!test_vsi) {\n-\t\tnetdev_err(netdev, \"Failed to create a VSI for the loopback test\");\n+\t\tnetdev_err(netdev, \"Failed to create a VSI for the loopback test\\n\");\n \t\treturn 1;\n \t}\n \n@@ -732,7 +732,7 @@ static u64 ice_loopback_test(struct net_device *netdev)\n \tdevm_kfree(dev, tx_frame);\n remove_mac_filters:\n \tif (ice_remove_mac(&pf->hw, &tmp_list))\n-\t\tnetdev_err(netdev, \"Could not remove MAC filter for the test VSI\");\n+\t\tnetdev_err(netdev, \"Could not remove MAC filter for the test VSI\\n\");\n free_mac_list:\n \tice_free_fltr_list(dev, &tmp_list);\n lbtest_mac_dis:\n@@ -745,7 +745,7 @@ static u64 ice_loopback_test(struct net_device *netdev)\n lbtest_vsi_close:\n \ttest_vsi->netdev = NULL;\n \tif (ice_vsi_release(test_vsi))\n-\t\tnetdev_err(netdev, \"Failed to remove the test VSI\");\n+\t\tnetdev_err(netdev, \"Failed to remove the test VSI\\n\");\n \n \treturn ret;\n }\n@@ -835,7 +835,7 @@ ice_self_test(struct net_device *netdev, struct ethtool_test *eth_test,\n \t\t\tint status = ice_open(netdev);\n \n \t\t\tif (status) {\n-\t\t\t\tdev_err(dev, \"Could not open device %s, err %d\",\n+\t\t\t\tdev_err(dev, \"Could not open device %s, err %d\\n\",\n \t\t\t\t\tpf->int_name, status);\n \t\t\t}\n \t\t}\ndiff --git a/drivers/net/ethernet/intel/ice/ice_main.c b/drivers/net/ethernet/intel/ice/ice_main.c\nindex bbc428c4ec07..b695a65b2b3c 100644\n--- a/drivers/net/ethernet/intel/ice/ice_main.c\n+++ b/drivers/net/ethernet/intel/ice/ice_main.c\n@@ -1930,8 +1930,7 @@ ice_xdp_setup_prog(struct ice_vsi *vsi, struct bpf_prog *prog,\n \tif (if_running && !test_and_set_bit(__ICE_DOWN, vsi->state)) {\n \t\tret = ice_down(vsi);\n \t\tif (ret) {\n-\t\t\tNL_SET_ERR_MSG_MOD(extack,\n-\t\t\t\t\t \"Preparing device for XDP attach failed\");\n+\t\t\tNL_SET_ERR_MSG_MOD(extack, \"Preparing device for XDP attach failed\");\n \t\t\treturn ret;\n \t\t}\n \t}\n@@ -1940,13 +1939,11 @@ ice_xdp_setup_prog(struct ice_vsi *vsi, struct bpf_prog *prog,\n \t\tvsi->num_xdp_txq = vsi->alloc_txq;\n \t\txdp_ring_err = ice_prepare_xdp_rings(vsi, prog);\n \t\tif (xdp_ring_err)\n-\t\t\tNL_SET_ERR_MSG_MOD(extack,\n-\t\t\t\t\t \"Setting up XDP Tx resources failed\");\n+\t\t\tNL_SET_ERR_MSG_MOD(extack, \"Setting up XDP Tx resources failed\");\n \t} else if (ice_is_xdp_ena_vsi(vsi) && !prog) {\n \t\txdp_ring_err = ice_destroy_xdp_rings(vsi);\n \t\tif (xdp_ring_err)\n-\t\t\tNL_SET_ERR_MSG_MOD(extack,\n-\t\t\t\t\t \"Freeing XDP Tx resources failed\");\n+\t\t\tNL_SET_ERR_MSG_MOD(extack, \"Freeing XDP Tx resources failed\");\n \t} else {\n \t\tice_vsi_assign_bpf_prog(vsi, prog);\n \t}\n@@ -1979,8 +1976,7 @@ static int ice_xdp(struct net_device *dev, struct netdev_bpf *xdp)\n \tstruct ice_vsi *vsi = np->vsi;\n \n \tif (vsi->type != ICE_VSI_PF) {\n-\t\tNL_SET_ERR_MSG_MOD(xdp->extack,\n-\t\t\t\t \"XDP can be loaded only on PF VSI\");\n+\t\tNL_SET_ERR_MSG_MOD(xdp->extack, \"XDP can be loaded only on PF VSI\");\n \t\treturn -EINVAL;\n \t}\n \ndiff --git a/drivers/net/ethernet/intel/ice/ice_virtchnl_pf.c b/drivers/net/ethernet/intel/ice/ice_virtchnl_pf.c\nindex c84ac00a316e..5f9ef7d1d3a8 100644\n--- a/drivers/net/ethernet/intel/ice/ice_virtchnl_pf.c\n+++ b/drivers/net/ethernet/intel/ice/ice_virtchnl_pf.c\n@@ -1993,7 +1993,7 @@ int ice_set_vf_spoofchk(struct net_device *netdev, int vf_id, bool ena)\n \n \tstatus = ice_update_vsi(&pf->hw, vf_vsi->idx, ctx, NULL);\n \tif (status) {\n-\t\tdev_err(dev, \"Failed to %sable spoofchk on VF %d VSI %d\\n error %d\",\n+\t\tdev_err(dev, \"Failed to %sable spoofchk on VF %d VSI %d\\n error %d\\n\",\n \t\t\tena ? \"en\" : \"dis\", vf->vf_id, vf_vsi->vsi_num, status);\n \t\tret = -EIO;\n \t\tgoto out;\ndiff --git a/drivers/net/ethernet/intel/ice/ice_xsk.c b/drivers/net/ethernet/intel/ice/ice_xsk.c\nindex 3fd31ad73e0e..8279db15e870 100644\n--- a/drivers/net/ethernet/intel/ice/ice_xsk.c\n+++ b/drivers/net/ethernet/intel/ice/ice_xsk.c\n@@ -457,7 +457,7 @@ int ice_xsk_umem_setup(struct ice_vsi *vsi, struct xdp_umem *umem, u16 qid)\n \tif (if_running) {\n \t\tret = ice_qp_dis(vsi, qid);\n \t\tif (ret) {\n-\t\t\tnetdev_err(vsi->netdev, \"ice_qp_dis error = %d\", ret);\n+\t\t\tnetdev_err(vsi->netdev, \"ice_qp_dis error = %d\\n\", ret);\n \t\t\tgoto xsk_umem_if_up;\n \t\t}\n \t}\n@@ -471,11 +471,11 @@ int ice_xsk_umem_setup(struct ice_vsi *vsi, struct xdp_umem *umem, u16 qid)\n \t\tif (!ret && umem_present)\n \t\t\tnapi_schedule(&vsi->xdp_rings[qid]->q_vector->napi);\n \t\telse if (ret)\n-\t\t\tnetdev_err(vsi->netdev, \"ice_qp_ena error = %d\", ret);\n+\t\t\tnetdev_err(vsi->netdev, \"ice_qp_ena error = %d\\n\", ret);\n \t}\n \n \tif (umem_failure) {\n-\t\tnetdev_err(vsi->netdev, \"Could not %sable UMEM, error = %d\",\n+\t\tnetdev_err(vsi->netdev, \"Could not %sable UMEM, error = %d\\n\",\n \t\t\t umem_present ? \"en\" : \"dis\", umem_failure);\n \t\treturn umem_failure;\n \t}\n", "prefixes": [ "S39", "12/15" ] }