Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/1227521/?format=api
{ "id": 1227521, "url": "http://patchwork.ozlabs.org/api/patches/1227521/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20200122152138.41585-11-anthony.l.nguyen@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20200122152138.41585-11-anthony.l.nguyen@intel.com>", "list_archive_url": null, "date": "2020-01-22T15:21:34", "name": "[S38,11/15] ice: remove unnecessary fallthrough comments", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "fb13d40b3d5581574b0f1642630a1b6f5c2f9cc1", "submitter": { "id": 68875, "url": "http://patchwork.ozlabs.org/api/people/68875/?format=api", "name": "Tony Nguyen", "email": "anthony.l.nguyen@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20200122152138.41585-11-anthony.l.nguyen@intel.com/mbox/", "series": [ { "id": 154777, "url": "http://patchwork.ozlabs.org/api/series/154777/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=154777", "date": "2020-01-22T15:21:26", "name": "[S38,01/15] ice: Add initial support for QinQ", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/154777/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/1227521/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/1227521/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": [ "ozlabs.org; spf=pass (sender SPF authorized)\n\tsmtp.mailfrom=osuosl.org (client-ip=140.211.166.138;\n\thelo=whitealder.osuosl.org;\n\tenvelope-from=intel-wired-lan-bounces@osuosl.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org;\n\tdmarc=fail (p=none dis=none) header.from=intel.com" ], "Received": [ "from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 4832MR3zCBz9sR0\n\tfor <incoming@patchwork.ozlabs.org>;\n\tThu, 23 Jan 2020 10:54:59 +1100 (AEDT)", "from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 20FC38506D;\n\tWed, 22 Jan 2020 23:54:58 +0000 (UTC)", "from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id RIiX7gSd00dV; Wed, 22 Jan 2020 23:54:54 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 15EAB8636A;\n\tWed, 22 Jan 2020 23:54:52 +0000 (UTC)", "from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\tby ash.osuosl.org (Postfix) with ESMTP id 5AC511BF9B4\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 22 Jan 2020 23:54:25 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 5665184C63\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 22 Jan 2020 23:54:25 +0000 (UTC)", "from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id Uj3Zylfxn7Cx for <intel-wired-lan@lists.osuosl.org>;\n\tWed, 22 Jan 2020 23:54:23 +0000 (UTC)", "from mga17.intel.com (mga17.intel.com [192.55.52.151])\n\tby whitealder.osuosl.org (Postfix) with ESMTPS id 4D23784397\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 22 Jan 2020 23:54:23 +0000 (UTC)", "from fmsmga002.fm.intel.com ([10.253.24.26])\n\tby fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t22 Jan 2020 15:54:22 -0800", "from unknown (HELO localhost.jf.intel.com) ([10.166.244.174])\n\tby fmsmga002.fm.intel.com with ESMTP; 22 Jan 2020 15:54:22 -0800" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.70,351,1574150400\"; d=\"scan'208\";a=\"259651620\"", "From": "Tony Nguyen <anthony.l.nguyen@intel.com>", "To": "intel-wired-lan@lists.osuosl.org", "Date": "Wed, 22 Jan 2020 07:21:34 -0800", "Message-Id": "<20200122152138.41585-11-anthony.l.nguyen@intel.com>", "X-Mailer": "git-send-email 2.20.1", "In-Reply-To": "<20200122152138.41585-1-anthony.l.nguyen@intel.com>", "References": "<20200122152138.41585-1-anthony.l.nguyen@intel.com>", "MIME-Version": "1.0", "Subject": "[Intel-wired-lan] [PATCH S38 11/15] ice: remove unnecessary\n\tfallthrough comments", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "From: Bruce Allan <bruce.w.allan@intel.com>\n\nFallthrough comments are used to explicitly indicate the code is intended\nto flow from one case statement to the next in a switch statement rather\nthan break out of the switch statement. They are only needed when a case\nhas one or more statements to execute before falling through to the next\ncase, not when there is a list of cases for which the same statement(s)\nshould be executed.\n\nSigned-off-by: Bruce Allan <bruce.w.allan@intel.com>\nSigned-off-by: Tony Nguyen <anthony.l.nguyen@intel.com>\n---\n drivers/net/ethernet/intel/ice/ice_base.c | 1 -\n drivers/net/ethernet/intel/ice/ice_ethtool.c | 2 --\n drivers/net/ethernet/intel/ice/ice_lib.c | 2 --\n drivers/net/ethernet/intel/ice/ice_main.c | 2 --\n drivers/net/ethernet/intel/ice/ice_sriov.c | 2 --\n drivers/net/ethernet/intel/ice/ice_txrx.c | 1 -\n 6 files changed, 10 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/ice/ice_base.c b/drivers/net/ethernet/intel/ice/ice_base.c\nindex 1c41e7e6d548..75cc5a366b26 100644\n--- a/drivers/net/ethernet/intel/ice/ice_base.c\n+++ b/drivers/net/ethernet/intel/ice/ice_base.c\n@@ -247,7 +247,6 @@ ice_setup_tx_ctx(struct ice_ring *ring, struct ice_tlan_ctx *tlan_ctx, u16 pf_q)\n \t */\n \tswitch (vsi->type) {\n \tcase ICE_VSI_LB:\n-\t\t/* fall through */\n \tcase ICE_VSI_PF:\n \t\ttlan_ctx->vmvf_type = ICE_TLAN_CTX_VMVF_TYPE_PF;\n \t\tbreak;\ndiff --git a/drivers/net/ethernet/intel/ice/ice_ethtool.c b/drivers/net/ethernet/intel/ice/ice_ethtool.c\nindex 8da99e576d4e..7b34c7c04547 100644\n--- a/drivers/net/ethernet/intel/ice/ice_ethtool.c\n+++ b/drivers/net/ethernet/intel/ice/ice_ethtool.c\n@@ -1091,7 +1091,6 @@ ice_get_fecparam(struct net_device *netdev, struct ethtool_fecparam *fecparam)\n \t\tfecparam->active_fec = ETHTOOL_FEC_BASER;\n \t\tbreak;\n \tcase ICE_AQ_LINK_25G_RS_528_FEC_EN:\n-\t\t/* fall through */\n \tcase ICE_AQ_LINK_25G_RS_544_FEC_EN:\n \t\tfecparam->active_fec = ETHTOOL_FEC_RS;\n \t\tbreak;\n@@ -1781,7 +1780,6 @@ ice_get_settings_link_up(struct ethtool_link_ksettings *ks,\n \t\t\t\t\t\t Asym_Pause);\n \t\tbreak;\n \tcase ICE_FC_PFC:\n-\t\t/* fall through */\n \tdefault:\n \t\tethtool_link_ksettings_del_link_mode(ks, lp_advertising, Pause);\n \t\tethtool_link_ksettings_del_link_mode(ks, lp_advertising,\ndiff --git a/drivers/net/ethernet/intel/ice/ice_lib.c b/drivers/net/ethernet/intel/ice/ice_lib.c\nindex cea664da9b94..1ab5fb20523b 100644\n--- a/drivers/net/ethernet/intel/ice/ice_lib.c\n+++ b/drivers/net/ethernet/intel/ice/ice_lib.c\n@@ -121,7 +121,6 @@ static void ice_vsi_set_num_desc(struct ice_vsi *vsi)\n {\n \tswitch (vsi->type) {\n \tcase ICE_VSI_PF:\n-\t\t/* fall through */\n \tcase ICE_VSI_LB:\n \t\tvsi->num_rx_desc = ICE_DFLT_NUM_RX_DESC;\n \t\tvsi->num_tx_desc = ICE_DFLT_NUM_TX_DESC;\n@@ -828,7 +827,6 @@ static int ice_vsi_init(struct ice_vsi *vsi, bool init_vsi)\n \tctxt->info = vsi->info;\n \tswitch (vsi->type) {\n \tcase ICE_VSI_LB:\n-\t\t/* fall through */\n \tcase ICE_VSI_PF:\n \t\tctxt->flags = ICE_AQ_VSI_TYPE_PF;\n \t\tbreak;\ndiff --git a/drivers/net/ethernet/intel/ice/ice_main.c b/drivers/net/ethernet/intel/ice/ice_main.c\nindex 4add2c3e830e..09458455df41 100644\n--- a/drivers/net/ethernet/intel/ice/ice_main.c\n+++ b/drivers/net/ethernet/intel/ice/ice_main.c\n@@ -709,7 +709,6 @@ void ice_print_link_msg(struct ice_vsi *vsi, bool isup)\n \t/* Get FEC mode based on negotiated link info */\n \tswitch (vsi->port_info->phy.link_info.fec_info) {\n \tcase ICE_AQ_LINK_25G_RS_528_FEC_EN:\n-\t\t/* fall through */\n \tcase ICE_AQ_LINK_25G_RS_544_FEC_EN:\n \t\tfec = \"RS-FEC\";\n \t\tbreak;\n@@ -2981,7 +2980,6 @@ ice_log_pkg_init(struct ice_hw *hw, enum ice_status *status)\n \t\t}\n \t\tbreak;\n \tcase ICE_ERR_BUF_TOO_SHORT:\n-\t\t/* fall-through */\n \tcase ICE_ERR_CFG:\n \t\tdev_err(dev, \"The DDP package file is invalid. Entering Safe Mode.\\n\");\n \t\tbreak;\ndiff --git a/drivers/net/ethernet/intel/ice/ice_sriov.c b/drivers/net/ethernet/intel/ice/ice_sriov.c\nindex d2db0d04e117..554f567476f3 100644\n--- a/drivers/net/ethernet/intel/ice/ice_sriov.c\n+++ b/drivers/net/ethernet/intel/ice/ice_sriov.c\n@@ -121,9 +121,7 @@ u32 ice_conv_link_speed_to_virtchnl(bool adv_link_support, u16 link_speed)\n \t\t\tspeed = (u32)VIRTCHNL_LINK_SPEED_25GB;\n \t\t\tbreak;\n \t\tcase ICE_AQ_LINK_SPEED_40GB:\n-\t\t\t/* fall through */\n \t\tcase ICE_AQ_LINK_SPEED_50GB:\n-\t\t\t/* fall through */\n \t\tcase ICE_AQ_LINK_SPEED_100GB:\n \t\t\tspeed = (u32)VIRTCHNL_LINK_SPEED_40GB;\n \t\t\tbreak;\ndiff --git a/drivers/net/ethernet/intel/ice/ice_txrx.c b/drivers/net/ethernet/intel/ice/ice_txrx.c\nindex 4de61dbedd36..0c08ab0462df 100644\n--- a/drivers/net/ethernet/intel/ice/ice_txrx.c\n+++ b/drivers/net/ethernet/intel/ice/ice_txrx.c\n@@ -1188,7 +1188,6 @@ ice_adjust_itr_by_size_and_speed(struct ice_port_info *port_info,\n \t\t\t\t avg_pkt_size + 640);\n \t\tbreak;\n \tcase ICE_AQ_LINK_SPEED_10GB:\n-\t\t/* fall through */\n \tdefault:\n \t\titr += DIV_ROUND_UP(170 * (avg_pkt_size + 24),\n \t\t\t\t avg_pkt_size + 640);\n", "prefixes": [ "S38", "11/15" ] }