Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/1227516/?format=api
{ "id": 1227516, "url": "http://patchwork.ozlabs.org/api/patches/1227516/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20200122152138.41585-7-anthony.l.nguyen@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20200122152138.41585-7-anthony.l.nguyen@intel.com>", "list_archive_url": null, "date": "2020-01-22T15:21:30", "name": "[S38,07/15] ice: Fix implicit queue mapping mode in ice_vsi_get_qs", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "791975ab81060d93b5021c1394a1f0d43b4c59c5", "submitter": { "id": 68875, "url": "http://patchwork.ozlabs.org/api/people/68875/?format=api", "name": "Tony Nguyen", "email": "anthony.l.nguyen@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20200122152138.41585-7-anthony.l.nguyen@intel.com/mbox/", "series": [ { "id": 154777, "url": "http://patchwork.ozlabs.org/api/series/154777/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=154777", "date": "2020-01-22T15:21:26", "name": "[S38,01/15] ice: Add initial support for QinQ", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/154777/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/1227516/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/1227516/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": [ "ozlabs.org; spf=pass (sender SPF authorized)\n\tsmtp.mailfrom=osuosl.org (client-ip=140.211.166.138;\n\thelo=whitealder.osuosl.org;\n\tenvelope-from=intel-wired-lan-bounces@osuosl.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org;\n\tdmarc=fail (p=none dis=none) header.from=intel.com" ], "Received": [ "from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 4832ML0jdyz9sRW\n\tfor <incoming@patchwork.ozlabs.org>;\n\tThu, 23 Jan 2020 10:54:53 +1100 (AEDT)", "from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 70BFF86ED5;\n\tWed, 22 Jan 2020 23:54:52 +0000 (UTC)", "from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id FfPWK2VAhAVM; Wed, 22 Jan 2020 23:54:51 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 73A2781EAA;\n\tWed, 22 Jan 2020 23:54:51 +0000 (UTC)", "from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n\tby ash.osuosl.org (Postfix) with ESMTP id 47EB91BF977\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 22 Jan 2020 23:54:25 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id 41B1581A67\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 22 Jan 2020 23:54:25 +0000 (UTC)", "from fraxinus.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id nh9grAVuJxt9 for <intel-wired-lan@lists.osuosl.org>;\n\tWed, 22 Jan 2020 23:54:23 +0000 (UTC)", "from mga17.intel.com (mga17.intel.com [192.55.52.151])\n\tby fraxinus.osuosl.org (Postfix) with ESMTPS id 16DC583456\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 22 Jan 2020 23:54:23 +0000 (UTC)", "from fmsmga002.fm.intel.com ([10.253.24.26])\n\tby fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t22 Jan 2020 15:54:22 -0800", "from unknown (HELO localhost.jf.intel.com) ([10.166.244.174])\n\tby fmsmga002.fm.intel.com with ESMTP; 22 Jan 2020 15:54:22 -0800" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.70,351,1574150400\"; d=\"scan'208\";a=\"259651616\"", "From": "Tony Nguyen <anthony.l.nguyen@intel.com>", "To": "intel-wired-lan@lists.osuosl.org", "Date": "Wed, 22 Jan 2020 07:21:30 -0800", "Message-Id": "<20200122152138.41585-7-anthony.l.nguyen@intel.com>", "X-Mailer": "git-send-email 2.20.1", "In-Reply-To": "<20200122152138.41585-1-anthony.l.nguyen@intel.com>", "References": "<20200122152138.41585-1-anthony.l.nguyen@intel.com>", "MIME-Version": "1.0", "Subject": "[Intel-wired-lan] [PATCH S38 07/15] ice: Fix implicit queue mapping\n\tmode in ice_vsi_get_qs", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "From: Brett Creeley <brett.creeley@intel.com>\n\nCurrently in ice_vsi_get_qs() we set the mapping_mode for Tx and Rx to\nvsi->[tx|rx]_mapping_mode, but the problem is vsi->[tx|rx]_mapping_mode\nhave not been set yet. This was working because ICE_VSI_MAP_CONTIG is\ndefined to 0. Fix this by being explicit with our mapping mode by\ninitializing the Tx and Rx structure's mapping_mode to\nICE_VSI_MAP_CONTIG and then setting the vsi->[tx|rx]_mapping_mode to the\n[tx|rx]_qs_cfg.mapping_mode values.\n\nAlso, only assign the vsi->[tx|rx]_mapping_mode when the queues are\nsuccessfully mapped to the VSI. With this change there was no longer a\nneed to initialize the ret variable to 0 so remove that.\n\nSigned-off-by: Brett Creeley <brett.creeley@intel.com>\n---\n drivers/net/ethernet/intel/ice/ice_lib.c | 21 ++++++++++++---------\n 1 file changed, 12 insertions(+), 9 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/ice/ice_lib.c b/drivers/net/ethernet/intel/ice/ice_lib.c\nindex 7e927576fcf0..cea664da9b94 100644\n--- a/drivers/net/ethernet/intel/ice/ice_lib.c\n+++ b/drivers/net/ethernet/intel/ice/ice_lib.c\n@@ -443,7 +443,7 @@ static int ice_vsi_get_qs(struct ice_vsi *vsi)\n \t\t.scatter_count = ICE_MAX_SCATTER_TXQS,\n \t\t.vsi_map = vsi->txq_map,\n \t\t.vsi_map_offset = 0,\n-\t\t.mapping_mode = vsi->tx_mapping_mode\n+\t\t.mapping_mode = ICE_VSI_MAP_CONTIG\n \t};\n \tstruct ice_qs_cfg rx_qs_cfg = {\n \t\t.qs_mutex = &pf->avail_q_mutex,\n@@ -453,18 +453,21 @@ static int ice_vsi_get_qs(struct ice_vsi *vsi)\n \t\t.scatter_count = ICE_MAX_SCATTER_RXQS,\n \t\t.vsi_map = vsi->rxq_map,\n \t\t.vsi_map_offset = 0,\n-\t\t.mapping_mode = vsi->rx_mapping_mode\n+\t\t.mapping_mode = ICE_VSI_MAP_CONTIG\n \t};\n-\tint ret = 0;\n-\n-\tvsi->tx_mapping_mode = ICE_VSI_MAP_CONTIG;\n-\tvsi->rx_mapping_mode = ICE_VSI_MAP_CONTIG;\n+\tint ret;\n \n \tret = __ice_vsi_get_qs(&tx_qs_cfg);\n-\tif (!ret)\n-\t\tret = __ice_vsi_get_qs(&rx_qs_cfg);\n+\tif (ret)\n+\t\treturn ret;\n+\tvsi->tx_mapping_mode = tx_qs_cfg.mapping_mode;\n \n-\treturn ret;\n+\tret = __ice_vsi_get_qs(&rx_qs_cfg);\n+\tif (ret)\n+\t\treturn ret;\n+\tvsi->rx_mapping_mode = rx_qs_cfg.mapping_mode;\n+\n+\treturn 0;\n }\n \n /**\n", "prefixes": [ "S38", "07/15" ] }