Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/1227133/?format=api
{ "id": 1227133, "url": "http://patchwork.ozlabs.org/api/patches/1227133/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20200122092113.28381-1-sasha.neftin@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20200122092113.28381-1-sasha.neftin@intel.com>", "list_archive_url": null, "date": "2020-01-22T09:21:13", "name": "[v2] igc: Complete to commit Add basic skeleton for PTP", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "a1e363a62016f10adee1f52e70a1acba1db6b1a4", "submitter": { "id": 69860, "url": "http://patchwork.ozlabs.org/api/people/69860/?format=api", "name": "Sasha Neftin", "email": "sasha.neftin@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20200122092113.28381-1-sasha.neftin@intel.com/mbox/", "series": [ { "id": 154619, "url": "http://patchwork.ozlabs.org/api/series/154619/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=154619", "date": "2020-01-22T09:21:13", "name": "[v2] igc: Complete to commit Add basic skeleton for PTP", "version": 2, "mbox": "http://patchwork.ozlabs.org/series/154619/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/1227133/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/1227133/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": [ "ozlabs.org; spf=pass (sender SPF authorized)\n\tsmtp.mailfrom=osuosl.org (client-ip=140.211.166.137;\n\thelo=fraxinus.osuosl.org;\n\tenvelope-from=intel-wired-lan-bounces@osuosl.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org;\n\tdmarc=fail (p=none dis=none) header.from=intel.com" ], "Received": [ "from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 482fzM62MKz9sPn\n\tfor <incoming@patchwork.ozlabs.org>;\n\tWed, 22 Jan 2020 20:21:18 +1100 (AEDT)", "from localhost (localhost [127.0.0.1])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id 537FC85FDB;\n\tWed, 22 Jan 2020 09:21:17 +0000 (UTC)", "from fraxinus.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id zoE583EkZ5Vq; Wed, 22 Jan 2020 09:21:16 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id BF9FD85FD4;\n\tWed, 22 Jan 2020 09:21:16 +0000 (UTC)", "from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\tby ash.osuosl.org (Postfix) with ESMTP id 2198D1BF40E\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 22 Jan 2020 09:21:16 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 1D4C387BD3\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 22 Jan 2020 09:21:16 +0000 (UTC)", "from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id Ul+olIy2z6Sm for <intel-wired-lan@lists.osuosl.org>;\n\tWed, 22 Jan 2020 09:21:15 +0000 (UTC)", "from mga01.intel.com (mga01.intel.com [192.55.52.88])\n\tby hemlock.osuosl.org (Postfix) with ESMTPS id 7DCFD87B92\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 22 Jan 2020 09:21:15 +0000 (UTC)", "from orsmga007.jf.intel.com ([10.7.209.58])\n\tby fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t22 Jan 2020 01:21:15 -0800", "from ccdlinuxdev08.iil.intel.com ([143.185.161.150])\n\tby orsmga007.jf.intel.com with ESMTP; 22 Jan 2020 01:21:14 -0800" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.70,349,1574150400\"; d=\"scan'208\";a=\"215841602\"", "From": "Sasha Neftin <sasha.neftin@intel.com>", "To": "intel-wired-lan@lists.osuosl.org", "Date": "Wed, 22 Jan 2020 11:21:13 +0200", "Message-Id": "<20200122092113.28381-1-sasha.neftin@intel.com>", "X-Mailer": "git-send-email 2.11.0", "Subject": "[Intel-wired-lan] [PATCH v2] igc: Complete to commit Add basic\n\tskeleton for PTP", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "commit 5f2958052c58 (\"igc: Add basic skeleton for PTP\") added basic\nsupport for PTP, what's missing is support for suspending.\nLegacy power management has been added. Now we can add\nthe suspend method to the igc_shutdown.\nBy cleaning the runtime storage for timestamp this avoids a possible\ninvalid memory access when the system comes back from suspend state.\n\nv1->v2:\nAddress community comment\n\nSigned-off-by: Sasha Neftin <sasha.neftin@intel.com>\n---\n drivers/net/ethernet/intel/igc/igc.h | 1 +\n drivers/net/ethernet/intel/igc/igc_main.c | 2 ++\n drivers/net/ethernet/intel/igc/igc_ptp.c | 2 +-\n 3 files changed, 4 insertions(+), 1 deletion(-)", "diff": "diff --git a/drivers/net/ethernet/intel/igc/igc.h b/drivers/net/ethernet/intel/igc/igc.h\nindex cb1362188c2a..5e9c2dd8b8e4 100644\n--- a/drivers/net/ethernet/intel/igc/igc.h\n+++ b/drivers/net/ethernet/intel/igc/igc.h\n@@ -556,6 +556,7 @@ int igc_erase_filter(struct igc_adapter *adapter,\n \n void igc_ptp_init(struct igc_adapter *adapter);\n void igc_ptp_reset(struct igc_adapter *adapter);\n+void igc_ptp_suspend(struct igc_adapter *adapter);\n void igc_ptp_stop(struct igc_adapter *adapter);\n void igc_ptp_rx_rgtstamp(struct igc_q_vector *q_vector, struct sk_buff *skb);\n void igc_ptp_rx_pktstamp(struct igc_q_vector *q_vector, void *va,\ndiff --git a/drivers/net/ethernet/intel/igc/igc_main.c b/drivers/net/ethernet/intel/igc/igc_main.c\nindex 08ed9796d088..fa72460e255a 100644\n--- a/drivers/net/ethernet/intel/igc/igc_main.c\n+++ b/drivers/net/ethernet/intel/igc/igc_main.c\n@@ -4899,6 +4899,8 @@ static int __igc_shutdown(struct pci_dev *pdev, bool *enable_wake,\n \tif (netif_running(netdev))\n \t\t__igc_close(netdev, true);\n \n+\tigc_ptp_suspend(adapter);\n+\n \tigc_clear_interrupt_scheme(adapter);\n \trtnl_unlock();\n \ndiff --git a/drivers/net/ethernet/intel/igc/igc_ptp.c b/drivers/net/ethernet/intel/igc/igc_ptp.c\nindex 389a969fe5f4..f99c514ad0f4 100644\n--- a/drivers/net/ethernet/intel/igc/igc_ptp.c\n+++ b/drivers/net/ethernet/intel/igc/igc_ptp.c\n@@ -641,7 +641,7 @@ void igc_ptp_init(struct igc_adapter *adapter)\n * This function stops the overflow check work and PTP Tx timestamp work, and\n * will prepare the device for OS suspend.\n */\n-static void igc_ptp_suspend(struct igc_adapter *adapter)\n+void igc_ptp_suspend(struct igc_adapter *adapter)\n {\n \tif (!(adapter->ptp_flags & IGC_PTP_ENABLED))\n \t\treturn;\n", "prefixes": [ "v2" ] }