Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/1217715/?format=api
{ "id": 1217715, "url": "http://patchwork.ozlabs.org/api/patches/1217715/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20200105084600.4025394-1-jeffrey.t.kirsher@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20200105084600.4025394-1-jeffrey.t.kirsher@intel.com>", "list_archive_url": null, "date": "2020-01-05T08:46:00", "name": "[net] i40e: Fix receive buffer starvation for AF_XDP", "commit_ref": null, "pull_url": null, "state": "rejected", "archived": false, "hash": "8acc7f4f4d432d73c79b79d4f6e7a341327ec255", "submitter": { "id": 473, "url": "http://patchwork.ozlabs.org/api/people/473/?format=api", "name": "Kirsher, Jeffrey T", "email": "jeffrey.t.kirsher@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20200105084600.4025394-1-jeffrey.t.kirsher@intel.com/mbox/", "series": [ { "id": 151259, "url": "http://patchwork.ozlabs.org/api/series/151259/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=151259", "date": "2020-01-05T08:46:00", "name": "[net] i40e: Fix receive buffer starvation for AF_XDP", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/151259/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/1217715/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/1217715/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": [ "ozlabs.org; spf=pass (sender SPF authorized)\n\tsmtp.mailfrom=osuosl.org (client-ip=140.211.166.136;\n\thelo=silver.osuosl.org;\n\tenvelope-from=intel-wired-lan-bounces@osuosl.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org;\n\tdmarc=fail (p=none dis=none) header.from=intel.com" ], "Received": [ "from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 47rC0c6GMDz9s4Y\n\tfor <incoming@patchwork.ozlabs.org>;\n\tSun, 5 Jan 2020 19:46:08 +1100 (AEDT)", "from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id DAADF203EA;\n\tSun, 5 Jan 2020 08:46:06 +0000 (UTC)", "from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id u2ILzi3MTcCz; Sun, 5 Jan 2020 08:46:05 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby silver.osuosl.org (Postfix) with ESMTP id 0C03A203CE;\n\tSun, 5 Jan 2020 08:46:05 +0000 (UTC)", "from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\tby ash.osuosl.org (Postfix) with ESMTP id 0D1A11BF333\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tSun, 5 Jan 2020 08:46:04 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id D82AB8700E\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tSun, 5 Jan 2020 08:46:03 +0000 (UTC)", "from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id 0dzWIhhTvuy7 for <intel-wired-lan@lists.osuosl.org>;\n\tSun, 5 Jan 2020 08:46:03 +0000 (UTC)", "from mga12.intel.com (mga12.intel.com [192.55.52.136])\n\tby hemlock.osuosl.org (Postfix) with ESMTPS id 41BF686D11\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tSun, 5 Jan 2020 08:46:03 +0000 (UTC)", "from orsmga005.jf.intel.com ([10.7.209.41])\n\tby fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t05 Jan 2020 00:46:02 -0800", "from jtkirshe-desk1.jf.intel.com ([134.134.177.74])\n\tby orsmga005.jf.intel.com with ESMTP; 05 Jan 2020 00:46:02 -0800" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.69,398,1571727600\"; d=\"scan'208\";a=\"394731322\"", "From": "Jeff Kirsher <jeffrey.t.kirsher@intel.com>", "To": "intel-wired-lan@lists.osuosl.org", "Date": "Sun, 5 Jan 2020 00:46:00 -0800", "Message-Id": "<20200105084600.4025394-1-jeffrey.t.kirsher@intel.com>", "X-Mailer": "git-send-email 2.24.1", "MIME-Version": "1.0", "Subject": "[Intel-wired-lan] [net] i40e: Fix receive buffer starvation for\n\tAF_XDP", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "Cc": "Magnus Karlsson <magnus.karlsson@intel.com>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "Magnus's fix to resolve a potential receive buffer starvation for AF_XDP\ngot applied to both the i40e_xsk_umem_enable/disable() functions, when it\nshould have only been applied to the \"enable\". So clean up the undesired\ncode in the disable function.\n\nCC: Magnus Karlsson <magnus.karlsson@intel.com>\nFixes: 1f459bdc2007 (\"i40e: fix potential RX buffer starvation for AF_XDP\")\nSigned-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>\n---\n drivers/net/ethernet/intel/i40e/i40e_xsk.c | 5 -----\n 1 file changed, 5 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/i40e/i40e_xsk.c b/drivers/net/ethernet/intel/i40e/i40e_xsk.c\nindex 42058fad6a3c..1b13d8e0d67a 100644\n--- a/drivers/net/ethernet/intel/i40e/i40e_xsk.c\n+++ b/drivers/net/ethernet/intel/i40e/i40e_xsk.c\n@@ -114,11 +114,6 @@ static int i40e_xsk_umem_enable(struct i40e_vsi *vsi, struct xdp_umem *umem,\n \t\terr = i40e_queue_pair_enable(vsi, qid);\n \t\tif (err)\n \t\t\treturn err;\n-\n-\t\t/* Kick start the NAPI context so that receiving will start */\n-\t\terr = i40e_xsk_wakeup(vsi->netdev, qid, XDP_WAKEUP_RX);\n-\t\tif (err)\n-\t\t\treturn err;\n \t}\n \n \treturn 0;\n", "prefixes": [ "net" ] }