Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/1217186/?format=api
{ "id": 1217186, "url": "http://patchwork.ozlabs.org/api/patches/1217186/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20200103022342.820175-1-jesse.brandeburg@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20200103022342.820175-1-jesse.brandeburg@intel.com>", "list_archive_url": null, "date": "2020-01-03T02:23:42", "name": "[net,v2] i40e/iavf: use better trace path", "commit_ref": null, "pull_url": null, "state": "rejected", "archived": false, "hash": "ea56b500583b8b9e41ee5df42ab4e62ee462ed0a", "submitter": { "id": 189, "url": "http://patchwork.ozlabs.org/api/people/189/?format=api", "name": "Jesse Brandeburg", "email": "jesse.brandeburg@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20200103022342.820175-1-jesse.brandeburg@intel.com/mbox/", "series": [ { "id": 150994, "url": "http://patchwork.ozlabs.org/api/series/150994/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=150994", "date": "2020-01-03T02:23:42", "name": "[net,v2] i40e/iavf: use better trace path", "version": 2, "mbox": "http://patchwork.ozlabs.org/series/150994/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/1217186/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/1217186/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@osuosl.org" ], "Authentication-Results": [ "ozlabs.org; spf=pass (sender SPF authorized)\n\tsmtp.mailfrom=osuosl.org (client-ip=140.211.166.133;\n\thelo=hemlock.osuosl.org;\n\tenvelope-from=intel-wired-lan-bounces@osuosl.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org;\n\tdmarc=fail (p=none dis=none) header.from=intel.com" ], "Received": [ "from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 47ppcW1f1hz9sR0\n\tfor <incoming@patchwork.ozlabs.org>;\n\tFri, 3 Jan 2020 13:23:54 +1100 (AEDT)", "from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id B2CA187B8A;\n\tFri, 3 Jan 2020 02:23:52 +0000 (UTC)", "from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id e-TwVRe07OB1; Fri, 3 Jan 2020 02:23:51 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 84E8C87B81;\n\tFri, 3 Jan 2020 02:23:51 +0000 (UTC)", "from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\tby ash.osuosl.org (Postfix) with ESMTP id 729391BF20D\n\tfor <intel-wired-lan@osuosl.org>;\n\tFri, 3 Jan 2020 02:23:49 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 6C3CE864CB\n\tfor <intel-wired-lan@osuosl.org>;\n\tFri, 3 Jan 2020 02:23:49 +0000 (UTC)", "from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id aF7RSdHfcxoM for <intel-wired-lan@osuosl.org>;\n\tFri, 3 Jan 2020 02:23:48 +0000 (UTC)", "from mga18.intel.com (mga18.intel.com [134.134.136.126])\n\tby whitealder.osuosl.org (Postfix) with ESMTPS id 6814F86477\n\tfor <intel-wired-lan@osuosl.org>;\n\tFri, 3 Jan 2020 02:23:48 +0000 (UTC)", "from orsmga007.jf.intel.com ([10.7.209.58])\n\tby orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t02 Jan 2020 18:23:47 -0800", "from jbrandeb-desk.jf.intel.com ([10.166.244.152])\n\tby orsmga007-auth.jf.intel.com with\n\tESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 02 Jan 2020 18:23:47 -0800" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-IronPort-AV": "E=Sophos;i=\"5.69,389,1571727600\"; d=\"scan'208\";a=\"209957272\"", "From": "Jesse Brandeburg <jesse.brandeburg@intel.com>", "To": "intel-wired-lan@osuosl.org", "Date": "Thu, 2 Jan 2020 18:23:42 -0800", "Message-Id": "<20200103022342.820175-1-jesse.brandeburg@intel.com>", "X-Mailer": "git-send-email 2.24.1", "MIME-Version": "1.0", "Subject": "[Intel-wired-lan] [PATCH net v2] i40e/iavf: use better trace path", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "I'm seeing compilation fail of the i40e/iavf driver for some reason.\nI just checked 5.5-rc4 and the tip of net/net-next and all fail.\nFails all the way back to v5.1 at least, I didn't check further back.\n\nrepro steps:\n$ gcc -v\ngcc version 9.2.1 20190827 (Red Hat 9.2.1-1) (GCC)\n\n$ git checkout -b my-net davem-net/master\n$ make mrproper\n$ make O=../my-net.obj defconfig allmodconfig modules_prepare\n$ make O=../my-net.obj M=drivers/net/ethernet/intel/i40e\n\nmake[1]: Entering directory '/home/jbrandeb/git/my-net.obj'\n CC [M] drivers/net/ethernet/intel/i40e/i40e_main.o\nIn file included from\n/home/jbrandeb/git/linux2/drivers/net/ethernet/intel/i40e/i40e_trace.h:209,\n from /home/jbrandeb/git/linux2/drivers/net/ethernet/intel/i40e/i40e_main.c:20:\n/home/jbrandeb/git/linux2/include/trace/define_trace.h:95:42: fatal error: ./i40e_trace.h: No such file or directory\n 95 | #include TRACE_INCLUDE(TRACE_INCLUDE_FILE)\n | ^\ncompilation terminated.\nmake[2]: *** [/home/jbrandeb/git/linux2/scripts/Makefile.build:266: drivers/net/ethernet/intel/i40e/i40e_main.o] Error 1\nmake[1]: *** [/home/jbrandeb/git/linux2/Makefile:1693: drivers/net/ethernet/intel/i40e] Error 2\nmake[1]: Leaving directory '/home/jbrandeb/git/my-net.obj'\nmake: *** [Makefile:179: sub-make] Error 2\n\nJust for sanity, I tried building the ice driver the same as above and\nit succeeds, so the build does work for some drivers.\n\nSo fix the include path for the i40e driver trace file to be relative\nto the kernel root like (some) other drivers do.\n\nSigned-off-by: Jesse Brandeburg <jesse.brandeburg@intel.com>\n\n---\nv2: added iavf for the same fix\n---\n drivers/net/ethernet/intel/i40e/i40e_trace.h | 2 +-\n drivers/net/ethernet/intel/iavf/iavf_trace.h | 2 +-\n 2 files changed, 2 insertions(+), 2 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/i40e/i40e_trace.h b/drivers/net/ethernet/intel/i40e/i40e_trace.h\nindex 424f02077e2e..122a3fcb62b1 100644\n--- a/drivers/net/ethernet/intel/i40e/i40e_trace.h\n+++ b/drivers/net/ethernet/intel/i40e/i40e_trace.h\n@@ -203,7 +203,7 @@ DEFINE_EVENT(\n * module.\n */\n #undef TRACE_INCLUDE_PATH\n-#define TRACE_INCLUDE_PATH .\n+#define TRACE_INCLUDE_PATH ../../drivers/net/ethernet/intel/i40e\n #undef TRACE_INCLUDE_FILE\n #define TRACE_INCLUDE_FILE i40e_trace\n #include <trace/define_trace.h>\ndiff --git a/drivers/net/ethernet/intel/iavf/iavf_trace.h b/drivers/net/ethernet/intel/iavf/iavf_trace.h\nindex 1058e68a02b4..b2674c935c21 100644\n--- a/drivers/net/ethernet/intel/iavf/iavf_trace.h\n+++ b/drivers/net/ethernet/intel/iavf/iavf_trace.h\n@@ -203,7 +203,7 @@ DEFINE_EVENT(\n * module.\n */\n #undef TRACE_INCLUDE_PATH\n-#define TRACE_INCLUDE_PATH .\n+#define TRACE_INCLUDE_PATH ../../drivers/net/ethernet/intel/iavf\n #undef TRACE_INCLUDE_FILE\n #define TRACE_INCLUDE_FILE iavf_trace\n #include <trace/define_trace.h>\n", "prefixes": [ "net", "v2" ] }