Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/1213828/?format=api
{ "id": 1213828, "url": "http://patchwork.ozlabs.org/api/patches/1213828/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20191219234535.37103-1-colin.king@canonical.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20191219234535.37103-1-colin.king@canonical.com>", "list_archive_url": null, "date": "2019-12-19T23:45:35", "name": "ice: remove redundant assignment to variable xmit_done", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "13c462cbbda65fbcc94b4e47c41b39f19505ca4a", "submitter": { "id": 2900, "url": "http://patchwork.ozlabs.org/api/people/2900/?format=api", "name": "Colin Ian King", "email": "colin.king@canonical.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20191219234535.37103-1-colin.king@canonical.com/mbox/", "series": [ { "id": 149740, "url": "http://patchwork.ozlabs.org/api/series/149740/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=149740", "date": "2019-12-19T23:45:35", "name": "ice: remove redundant assignment to variable xmit_done", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/149740/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/1213828/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/1213828/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": [ "ozlabs.org; spf=pass (sender SPF authorized)\n\tsmtp.mailfrom=osuosl.org (client-ip=140.211.166.138;\n\thelo=whitealder.osuosl.org;\n\tenvelope-from=intel-wired-lan-bounces@osuosl.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org; dmarc=fail (p=none dis=none)\n\theader.from=canonical.com" ], "Received": [ "from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 47f7mY6Yz5z9sPW\n\tfor <incoming@patchwork.ozlabs.org>;\n\tFri, 20 Dec 2019 10:45:47 +1100 (AEDT)", "from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 04D4988117;\n\tThu, 19 Dec 2019 23:45:45 +0000 (UTC)", "from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id sqnR7Ow8QStE; Thu, 19 Dec 2019 23:45:44 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 45A3B88055;\n\tThu, 19 Dec 2019 23:45:44 +0000 (UTC)", "from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\tby ash.osuosl.org (Postfix) with ESMTP id 14D5E1BF315\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 19 Dec 2019 23:45:43 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id EF74388055\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 19 Dec 2019 23:45:42 +0000 (UTC)", "from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id OwbN-BygbZx9 for <intel-wired-lan@lists.osuosl.org>;\n\tThu, 19 Dec 2019 23:45:42 +0000 (UTC)", "from youngberry.canonical.com (youngberry.canonical.com\n\t[91.189.89.112])\n\tby whitealder.osuosl.org (Postfix) with ESMTPS id DD52588011\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 19 Dec 2019 23:45:41 +0000 (UTC)", "from 1.general.cking.uk.vpn ([10.172.193.212] helo=localhost)\n\tby youngberry.canonical.com with esmtpsa\n\t(TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.86_2)\n\t(envelope-from <colin.king@canonical.com>)\n\tid 1ii5U7-0002w7-Lq; Thu, 19 Dec 2019 23:45:35 +0000" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "From": "Colin King <colin.king@canonical.com>", "To": "Jeff Kirsher <jeffrey.t.kirsher@intel.com>,\n\t\"David S . Miller\" <davem@davemloft.net>,\n\tintel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org", "Date": "Thu, 19 Dec 2019 23:45:35 +0000", "Message-Id": "<20191219234535.37103-1-colin.king@canonical.com>", "X-Mailer": "git-send-email 2.24.0", "MIME-Version": "1.0", "Subject": "[Intel-wired-lan] [PATCH] ice: remove redundant assignment to\n\tvariable xmit_done", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "Cc": "kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "From: Colin Ian King <colin.king@canonical.com>\n\nThe variable xmit_done is being initialized with a value that is never\nread and it is being updated later with a new value. The initialization\nis redundant and can be removed.\n\nAddresses-Coverity: (\"Unused value\")\nSigned-off-by: Colin Ian King <colin.king@canonical.com>\n---\n drivers/net/ethernet/intel/ice/ice_xsk.c | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)", "diff": "diff --git a/drivers/net/ethernet/intel/ice/ice_xsk.c b/drivers/net/ethernet/intel/ice/ice_xsk.c\nindex cf9b8b22d24f..03c1e9bcf790 100644\n--- a/drivers/net/ethernet/intel/ice/ice_xsk.c\n+++ b/drivers/net/ethernet/intel/ice/ice_xsk.c\n@@ -1019,8 +1019,8 @@ bool ice_clean_tx_irq_zc(struct ice_ring *xdp_ring, int budget)\n \ts16 ntc = xdp_ring->next_to_clean;\n \tstruct ice_tx_desc *tx_desc;\n \tstruct ice_tx_buf *tx_buf;\n-\tbool xmit_done = true;\n \tu32 xsk_frames = 0;\n+\tbool xmit_done;\n \n \ttx_desc = ICE_TX_DESC(xdp_ring, ntc);\n \ttx_buf = &xdp_ring->tx_buf[ntc];\n", "prefixes": [] }