Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/1212926/?format=api
{ "id": 1212926, "url": "http://patchwork.ozlabs.org/api/patches/1212926/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20191218095308.2397408-1-ben.dooks@codethink.co.uk/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20191218095308.2397408-1-ben.dooks@codethink.co.uk>", "list_archive_url": null, "date": "2019-12-18T09:53:08", "name": "e1000e: fix missing cpu_to_le64 on buffer_addr", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "36e4f3194c738554cf29fca255ca7d4c1086f211", "submitter": { "id": 14023, "url": "http://patchwork.ozlabs.org/api/people/14023/?format=api", "name": "Ben Dooks", "email": "ben.dooks@codethink.co.uk" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20191218095308.2397408-1-ben.dooks@codethink.co.uk/mbox/", "series": [ { "id": 149485, "url": "http://patchwork.ozlabs.org/api/series/149485/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=149485", "date": "2019-12-18T09:53:08", "name": "e1000e: fix missing cpu_to_le64 on buffer_addr", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/149485/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/1212926/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/1212926/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": [ "ozlabs.org; spf=pass (sender SPF authorized)\n\tsmtp.mailfrom=osuosl.org (client-ip=140.211.166.137;\n\thelo=fraxinus.osuosl.org;\n\tenvelope-from=intel-wired-lan-bounces@osuosl.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org; dmarc=fail (p=none dis=none)\n\theader.from=codethink.co.uk" ], "Received": [ "from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 47dY1h0f0nz9sP6\n\tfor <incoming@patchwork.ozlabs.org>;\n\tThu, 19 Dec 2019 11:40:07 +1100 (AEDT)", "from localhost (localhost [127.0.0.1])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id 2984D86C94;\n\tThu, 19 Dec 2019 00:40:05 +0000 (UTC)", "from fraxinus.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id 4qHb8AqC6_vs; Thu, 19 Dec 2019 00:40:01 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id 9E1DA86B91;\n\tThu, 19 Dec 2019 00:40:01 +0000 (UTC)", "from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n\tby ash.osuosl.org (Postfix) with ESMTP id 210B71BF57F\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 18 Dec 2019 09:53:19 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id 1D447850DC\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 18 Dec 2019 09:53:19 +0000 (UTC)", "from fraxinus.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id qMpbNY9J721I for <intel-wired-lan@lists.osuosl.org>;\n\tWed, 18 Dec 2019 09:53:18 +0000 (UTC)", "from imap2.colo.codethink.co.uk (imap2.colo.codethink.co.uk\n\t[78.40.148.184])\n\tby fraxinus.osuosl.org (Postfix) with ESMTPS id 0E0918508E\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 18 Dec 2019 09:53:17 +0000 (UTC)", "from [167.98.27.226] (helo=rainbowdash.codethink.co.uk)\n\tby imap2.colo.codethink.co.uk with esmtpsa (Exim 4.92 #3 (Debian))\n\tid 1ihW0z-0006D0-GM; Wed, 18 Dec 2019 09:53:09 +0000", "from ben by rainbowdash.codethink.co.uk with local (Exim 4.92.3)\n\t(envelope-from <ben@rainbowdash.codethink.co.uk>)\n\tid 1ihW0z-00A3gg-7g; Wed, 18 Dec 2019 09:53:09 +0000" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "From": "\"Ben Dooks (Codethink)\" <ben.dooks@codethink.co.uk>", "To": "ben.dooks@codethink.co.uk", "Date": "Wed, 18 Dec 2019 09:53:08 +0000", "Message-Id": "<20191218095308.2397408-1-ben.dooks@codethink.co.uk>", "X-Mailer": "git-send-email 2.24.0", "MIME-Version": "1.0", "X-Mailman-Approved-At": "Thu, 19 Dec 2019 00:40:01 +0000", "Subject": "[Intel-wired-lan] [PATCH] e1000e: fix missing cpu_to_le64 on\n\tbuffer_addr", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "Cc": "netdev@vger.kernel.org, intel-wired-lan@lists.osuosl.org,\n\t\"David S. Miller\" <davem@davemloft.net>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "The following warning suggests there is a missing cpu_to_le64() in\nthe e1000_flush_tx_ring() function (it is also the behaviour\nelsewhere in the driver to do cpu_to_le64() on the buffer_addr\nwhen setting it)\n\ndrivers/net/ethernet/intel/e1000e/netdev.c:3813:30: warning: incorrect type in assignment (different base types)\ndrivers/net/ethernet/intel/e1000e/netdev.c:3813:30: expected restricted __le64 [usertype] buffer_addr\ndrivers/net/ethernet/intel/e1000e/netdev.c:3813:30: got unsigned long long [usertype] dma\n\nSigned-off-by: Ben Dooks (Codethink) <ben.dooks@codethink.co.uk>\n---\nCc: Jeff Kirsher <jeffrey.t.kirsher@intel.com>\nCc: \"David S. Miller\" <davem@davemloft.net>\nCc: intel-wired-lan@lists.osuosl.org\nCc: netdev@vger.kernel.org\n---\n drivers/net/ethernet/intel/e1000e/netdev.c | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)", "diff": "diff --git a/drivers/net/ethernet/intel/e1000e/netdev.c b/drivers/net/ethernet/intel/e1000e/netdev.c\nindex fe7997c18a10..b317ac024819 100644\n--- a/drivers/net/ethernet/intel/e1000e/netdev.c\n+++ b/drivers/net/ethernet/intel/e1000e/netdev.c\n@@ -3810,7 +3810,7 @@ static void e1000_flush_tx_ring(struct e1000_adapter *adapter)\n \ttdt = er32(TDT(0));\n \tBUG_ON(tdt != tx_ring->next_to_use);\n \ttx_desc = E1000_TX_DESC(*tx_ring, tx_ring->next_to_use);\n-\ttx_desc->buffer_addr = tx_ring->dma;\n+\ttx_desc->buffer_addr = cpu_to_le64(tx_ring->dma);\n \n \ttx_desc->lower.data = cpu_to_le32(txd_lower | size);\n \ttx_desc->upper.data = 0;\n", "prefixes": [] }