Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/1212924/?format=api
{ "id": 1212924, "url": "http://patchwork.ozlabs.org/api/patches/1212924/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20191218183845.20038-2-jcfaracco@gmail.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20191218183845.20038-2-jcfaracco@gmail.com>", "list_archive_url": null, "date": "2019-12-18T18:38:44", "name": "[net-next,1/2] drivers: net: i40e: Removing hung_queue variable to use txqueue function parameter", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "d053d885223c65f3727b9a187d2e9c9e24b65646", "submitter": { "id": 65615, "url": "http://patchwork.ozlabs.org/api/people/65615/?format=api", "name": "Julio Faracco", "email": "jcfaracco@gmail.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20191218183845.20038-2-jcfaracco@gmail.com/mbox/", "series": [ { "id": 149484, "url": "http://patchwork.ozlabs.org/api/series/149484/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=149484", "date": "2019-12-18T18:38:43", "name": "drivers: net: intel: update i40e and ice to use txqueue parameter from tx_timeout.", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/149484/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/1212924/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/1212924/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": [ "ozlabs.org; spf=pass (sender SPF authorized)\n\tsmtp.mailfrom=osuosl.org (client-ip=140.211.166.133;\n\thelo=hemlock.osuosl.org;\n\tenvelope-from=intel-wired-lan-bounces@osuosl.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org;\n\tdmarc=fail (p=none dis=none) header.from=gmail.com", "ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"ADTZFaSZ\"; dkim-atps=neutral" ], "Received": [ "from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 47dY1h0fx5z9sQp\n\tfor <incoming@patchwork.ozlabs.org>;\n\tThu, 19 Dec 2019 11:40:07 +1100 (AEDT)", "from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 005E4883D2;\n\tThu, 19 Dec 2019 00:40:06 +0000 (UTC)", "from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id OZT6dOQiS-93; Thu, 19 Dec 2019 00:40:05 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 18AF1885DC;\n\tThu, 19 Dec 2019 00:40:05 +0000 (UTC)", "from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n\tby ash.osuosl.org (Postfix) with ESMTP id B02371BF397\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 18 Dec 2019 18:38:54 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id ACE8C86BB5\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 18 Dec 2019 18:38:54 +0000 (UTC)", "from fraxinus.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id c7ZaV4ZFO7xm for <intel-wired-lan@lists.osuosl.org>;\n\tWed, 18 Dec 2019 18:38:53 +0000 (UTC)", "from mail-qk1-f194.google.com (mail-qk1-f194.google.com\n\t[209.85.222.194])\n\tby fraxinus.osuosl.org (Postfix) with ESMTPS id 5D65886B8E\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 18 Dec 2019 18:38:53 +0000 (UTC)", "by mail-qk1-f194.google.com with SMTP id 21so2439323qky.4\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 18 Dec 2019 10:38:53 -0800 (PST)", "from ubuntu.default (201-42-108-210.dsl.telesp.net.br.\n\t[201.42.108.210]) by smtp.gmail.com with ESMTPSA id\n\ts11sm890049qkg.99.2019.12.18.10.38.50\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tWed, 18 Dec 2019 10:38:51 -0800 (PST)" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references;\n\tbh=b0ybn8DuKtuB1EcL3f+qtWsIuALB19x61Jlk3bJVMfI=;\n\tb=ADTZFaSZJGOJUWHzgN/Cy370WYK5eyFQpHbiYqCqvc3FxECvME40KHKMiV+iqqcEDE\n\tMswTEXHwX9xQIJsspYmDlMMWhhLgqjQFo0i7Bssfpfg9suFdaMBZzQfeTgvZFjwrzXLa\n\tFT6a0grylHn64/b9DtahjlH4D4V2WwGBvt+fAFW5SwytWG2WaVqb4GFflsgXIJOJ9D61\n\t3FfP4/tzlcdXO8eOdFLQAfI7BG9o7rLxgfEMqC/coNzoUPFTvBubOsOVr3Z5WoAo5UI3\n\tKhd71eUTrAhO0pfMfg5lSr51pJgV8LLVzyNfSPpsfh4DUkmz8TF1H0zm6jJbGQgOASQm\n\tdXkA==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references;\n\tbh=b0ybn8DuKtuB1EcL3f+qtWsIuALB19x61Jlk3bJVMfI=;\n\tb=tH0Q68geKv3CGpO2wLBwfQJMcnm7UXfXywaaNT13z68gnghT2Ku8cleMvz01kNe/aS\n\tuTIXqOzk0PARPjLzZEQfxY9S06rYMsNJnH2XdeZW3pkqw+s1+/bDp39EkYG/o86mkKbp\n\tsPb5o8QaVcU14vPDWM49l1O0Z81qxjhtDgCXw5MHBRdq6UzS/I0DWbkEu5pg+PK6B/pe\n\ta2tBLaGs5trCZuiEMvQSA2zVDOzn1eyznou2svgYVzK89kk0YFNRmyH170NgOeWsvlr0\n\tqh4ZIqIfNO3j1q13R9cH6ssxpDdBs4GNODKKlQFghJqT8Fkb3NV1ziqXUvydCMolxT5z\n\t6i7g==", "X-Gm-Message-State": "APjAAAWgTUsVocVdoaFVulvObBPeU3dB6HdlBfgabCzI4O38PW9KHJhj\n\t/kSrp7i39lju/Ai2Hy4aAus=", "X-Google-Smtp-Source": "APXvYqwFxlMn2WZQ8whnAGXKDowPFy4vMN6IV3I72cyVS5ppiu/ab5cHjfYERpD6WgLViQ8yUBqIjQ==", "X-Received": "by 2002:a37:a70b:: with SMTP id\n\tq11mr4027437qke.393.1576694332281; \n\tWed, 18 Dec 2019 10:38:52 -0800 (PST)", "From": "Julio Faracco <jcfaracco@gmail.com>", "To": "netdev@vger.kernel.org", "Date": "Wed, 18 Dec 2019 15:38:44 -0300", "Message-Id": "<20191218183845.20038-2-jcfaracco@gmail.com>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": "<20191218183845.20038-1-jcfaracco@gmail.com>", "References": "<20191218183845.20038-1-jcfaracco@gmail.com>", "X-Mailman-Approved-At": "Thu, 19 Dec 2019 00:40:00 +0000", "Subject": "[Intel-wired-lan] [PATCH net-next 1/2] drivers: net: i40e: Removing\n\thung_queue variable to use txqueue function parameter", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "Cc": "intel-wired-lan@lists.osuosl.org, davem@davemloft.net", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "The scope of function .ndo_tx_timeout was changed to include the hang\nqueue when a TX timeout event occurs. See commit 0290bd291cc0\n(\"netdev: pass the stuck queue to the timeout handler\") for more\ndetails. Now, drivers don't need to identify which queue is stopped.\nDrivers can simply use the queue index provided bt dev_watchdog and\nexecute all actions needed to restore network traffic. This commit do\nsome cleanups into Intel i40e driver to remove a redundant loop to find\nstopped queue.\n\nSigned-off-by: Julio Faracco <jcfaracco@gmail.com>\n---\n drivers/net/ethernet/intel/i40e/i40e_main.c | 41 ++++++---------------\n 1 file changed, 11 insertions(+), 30 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/i40e/i40e_main.c b/drivers/net/ethernet/intel/i40e/i40e_main.c\nindex 4c9ac6c80eb8..71fedee21488 100644\n--- a/drivers/net/ethernet/intel/i40e/i40e_main.c\n+++ b/drivers/net/ethernet/intel/i40e/i40e_main.c\n@@ -307,37 +307,18 @@ static void i40e_tx_timeout(struct net_device *netdev, unsigned int txqueue)\n \tstruct i40e_vsi *vsi = np->vsi;\n \tstruct i40e_pf *pf = vsi->back;\n \tstruct i40e_ring *tx_ring = NULL;\n-\tunsigned int i, hung_queue = 0;\n+\tunsigned int i;\n \tu32 head, val;\n \n \tpf->tx_timeout_count++;\n \n-\t/* find the stopped queue the same way the stack does */\n-\tfor (i = 0; i < netdev->num_tx_queues; i++) {\n-\t\tstruct netdev_queue *q;\n-\t\tunsigned long trans_start;\n-\n-\t\tq = netdev_get_tx_queue(netdev, i);\n-\t\ttrans_start = q->trans_start;\n-\t\tif (netif_xmit_stopped(q) &&\n-\t\t time_after(jiffies,\n-\t\t\t (trans_start + netdev->watchdog_timeo))) {\n-\t\t\thung_queue = i;\n-\t\t\tbreak;\n-\t\t}\n-\t}\n-\n-\tif (i == netdev->num_tx_queues) {\n-\t\tnetdev_info(netdev, \"tx_timeout: no netdev hung queue found\\n\");\n-\t} else {\n-\t\t/* now that we have an index, find the tx_ring struct */\n-\t\tfor (i = 0; i < vsi->num_queue_pairs; i++) {\n-\t\t\tif (vsi->tx_rings[i] && vsi->tx_rings[i]->desc) {\n-\t\t\t\tif (hung_queue ==\n-\t\t\t\t vsi->tx_rings[i]->queue_index) {\n-\t\t\t\t\ttx_ring = vsi->tx_rings[i];\n-\t\t\t\t\tbreak;\n-\t\t\t\t}\n+\t/* with txqueue index, find the tx_ring struct */\n+\tfor (i = 0; i < vsi->num_queue_pairs; i++) {\n+\t\tif (vsi->tx_rings[i] && vsi->tx_rings[i]->desc) {\n+\t\t\tif (txqueue ==\n+\t\t\t vsi->tx_rings[i]->queue_index) {\n+\t\t\t\ttx_ring = vsi->tx_rings[i];\n+\t\t\t\tbreak;\n \t\t\t}\n \t\t}\n \t}\n@@ -363,14 +344,14 @@ static void i40e_tx_timeout(struct net_device *netdev, unsigned int txqueue)\n \t\t\tval = rd32(&pf->hw, I40E_PFINT_DYN_CTL0);\n \n \t\tnetdev_info(netdev, \"tx_timeout: VSI_seid: %d, Q %d, NTC: 0x%x, HWB: 0x%x, NTU: 0x%x, TAIL: 0x%x, INT: 0x%x\\n\",\n-\t\t\t vsi->seid, hung_queue, tx_ring->next_to_clean,\n+\t\t\t vsi->seid, txqueue, tx_ring->next_to_clean,\n \t\t\t head, tx_ring->next_to_use,\n \t\t\t readl(tx_ring->tail), val);\n \t}\n \n \tpf->tx_timeout_last_recovery = jiffies;\n-\tnetdev_info(netdev, \"tx_timeout recovery level %d, hung_queue %d\\n\",\n-\t\t pf->tx_timeout_recovery_level, hung_queue);\n+\tnetdev_info(netdev, \"tx_timeout recovery level %d, txqueue %d\\n\",\n+\t\t pf->tx_timeout_recovery_level, txqueue);\n \n \tswitch (pf->tx_timeout_recovery_level) {\n \tcase 1:\n", "prefixes": [ "net-next", "1/2" ] }