Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/1208819/?format=api
{ "id": 1208819, "url": "http://patchwork.ozlabs.org/api/patches/1208819/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20191212111307.33566-7-anthony.l.nguyen@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20191212111307.33566-7-anthony.l.nguyen@intel.com>", "list_archive_url": null, "date": "2019-12-12T11:12:59", "name": "[S35,07/15] ice: Return error on not supported ethtool -C parameters", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "44f51aa2f802306e90f6603316426d02f2db8a7f", "submitter": { "id": 68875, "url": "http://patchwork.ozlabs.org/api/people/68875/?format=api", "name": "Tony Nguyen", "email": "anthony.l.nguyen@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20191212111307.33566-7-anthony.l.nguyen@intel.com/mbox/", "series": [ { "id": 148168, "url": "http://patchwork.ozlabs.org/api/series/148168/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=148168", "date": "2019-12-12T11:12:59", "name": null, "version": 1, "mbox": "http://patchwork.ozlabs.org/series/148168/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/1208819/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/1208819/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": [ "ozlabs.org; spf=pass (sender SPF authorized)\n\tsmtp.mailfrom=osuosl.org (client-ip=140.211.166.133;\n\thelo=hemlock.osuosl.org;\n\tenvelope-from=intel-wired-lan-bounces@osuosl.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org;\n\tdmarc=fail (p=none dis=none) header.from=intel.com" ], "Received": [ "from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 47Yklb3TGcz9sPT\n\tfor <incoming@patchwork.ozlabs.org>;\n\tFri, 13 Dec 2019 06:44:43 +1100 (AEDT)", "from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id C0190888BE;\n\tThu, 12 Dec 2019 19:44:39 +0000 (UTC)", "from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id uhxyda2gPNfK; Thu, 12 Dec 2019 19:44:39 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 12DD5888C8;\n\tThu, 12 Dec 2019 19:44:39 +0000 (UTC)", "from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\tby ash.osuosl.org (Postfix) with ESMTP id 957A31BF340\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 12 Dec 2019 19:44:37 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 8A5668843F\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 12 Dec 2019 19:44:37 +0000 (UTC)", "from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id lsAzwlwKw2et for <intel-wired-lan@lists.osuosl.org>;\n\tThu, 12 Dec 2019 19:44:36 +0000 (UTC)", "from mga02.intel.com (mga02.intel.com [134.134.136.20])\n\tby whitealder.osuosl.org (Postfix) with ESMTPS id BDED6881A5\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 12 Dec 2019 19:44:36 +0000 (UTC)", "from orsmga001.jf.intel.com ([10.7.209.18])\n\tby orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t12 Dec 2019 11:44:36 -0800", "from unknown (HELO localhost.jf.intel.com) ([10.166.244.174])\n\tby orsmga001.jf.intel.com with ESMTP; 12 Dec 2019 11:44:34 -0800" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.69,306,1571727600\"; d=\"scan'208\";a=\"296698854\"", "From": "Tony Nguyen <anthony.l.nguyen@intel.com>", "To": "intel-wired-lan@lists.osuosl.org", "Date": "Thu, 12 Dec 2019 03:12:59 -0800", "Message-Id": "<20191212111307.33566-7-anthony.l.nguyen@intel.com>", "X-Mailer": "git-send-email 2.20.1", "In-Reply-To": "<20191212111307.33566-1-anthony.l.nguyen@intel.com>", "References": "<20191212111307.33566-1-anthony.l.nguyen@intel.com>", "MIME-Version": "1.0", "Subject": "[Intel-wired-lan] [PATCH S35 07/15] ice: Return error on not\n\tsupported ethtool -C parameters", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "From: Michal Swiatkowski <michal.swiatkowski@intel.com>\n\nCheck for all unused parameters, if ethtool sent one of them,\nprint info about that and return error.\n\nSigned-off-by: Michal Swiatkowski <michal.swiatkowski@intel.com>\n---\n drivers/net/ethernet/intel/ice/ice_ethtool.c | 50 ++++++++++++++++++++\n 1 file changed, 50 insertions(+)", "diff": "diff --git a/drivers/net/ethernet/intel/ice/ice_ethtool.c b/drivers/net/ethernet/intel/ice/ice_ethtool.c\nindex a421c616604c..6ecac824c31c 100644\n--- a/drivers/net/ethernet/intel/ice/ice_ethtool.c\n+++ b/drivers/net/ethernet/intel/ice/ice_ethtool.c\n@@ -3587,6 +3587,53 @@ ice_set_q_coalesce(struct ice_vsi *vsi, struct ethtool_coalesce *ec, int q_num)\n \treturn 0;\n }\n \n+/**\n+ * ice_is_coalesce_param_invalid - check for unsupported coalesce parameters\n+ * @netdev: pointer to the netdev associated with this query\n+ * @ec: ethtool structure to fill with driver's coalesce settings\n+ *\n+ * Print netdev info if driver doesn't support one of the parameters\n+ * and return error. When any parameters will be implemented, remove only\n+ * this parameter from param array.\n+ */\n+static int\n+ice_is_coalesce_param_invalid(struct net_device *netdev,\n+\t\t\t struct ethtool_coalesce *ec)\n+{\n+\tstruct ice_ethtool_not_used {\n+\t\tu32 value;\n+\t\tconst char *name;\n+\t} param[] = {\n+\t\t{ec->stats_block_coalesce_usecs, \"stats-block-usecs\"},\n+\t\t{ec->rate_sample_interval, \"sample-interval\"},\n+\t\t{ec->pkt_rate_low, \"pkt-rate-low\"},\n+\t\t{ec->pkt_rate_high, \"pkt-rate-high\"},\n+\t\t{ec->rx_max_coalesced_frames, \"rx-frames\"},\n+\t\t{ec->rx_coalesce_usecs_irq, \"rx-usecs-irq\"},\n+\t\t{ec->rx_max_coalesced_frames_irq, \"rx-frames-irq\"},\n+\t\t{ec->tx_max_coalesced_frames, \"tx-frames\"},\n+\t\t{ec->tx_coalesce_usecs_irq, \"tx-usecs-irq\"},\n+\t\t{ec->tx_max_coalesced_frames_irq, \"tx-frames-irq\"},\n+\t\t{ec->rx_coalesce_usecs_low, \"rx-usecs-low\"},\n+\t\t{ec->rx_max_coalesced_frames_low, \"rx-frames-low\"},\n+\t\t{ec->tx_coalesce_usecs_low, \"tx-usecs-low\"},\n+\t\t{ec->tx_max_coalesced_frames_low, \"tx-frames-low\"},\n+\t\t{ec->rx_max_coalesced_frames_high, \"rx-frames-high\"},\n+\t\t{ec->tx_max_coalesced_frames_high, \"tx-frames-high\"}\n+\t};\n+\tint i;\n+\n+\tfor (i = 0; i < ARRAY_SIZE(param); i++) {\n+\t\tif (param[i].value) {\n+\t\t\tnetdev_info(netdev, \"Setting %s not supported\\n\",\n+\t\t\t\t param[i].name);\n+\t\t\treturn -EINVAL;\n+\t\t}\n+\t}\n+\n+\treturn 0;\n+}\n+\n /**\n * __ice_set_coalesce - set ITR/INTRL values for the device\n * @netdev: pointer to the netdev associated with this query\n@@ -3603,6 +3650,9 @@ __ice_set_coalesce(struct net_device *netdev, struct ethtool_coalesce *ec,\n \tstruct ice_netdev_priv *np = netdev_priv(netdev);\n \tstruct ice_vsi *vsi = np->vsi;\n \n+\tif (ice_is_coalesce_param_invalid(netdev, ec))\n+\t\treturn -EINVAL;\n+\n \tif (q_num < 0) {\n \t\tint v_idx;\n \n", "prefixes": [ "S35", "07/15" ] }