Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/1197477/?format=api
{ "id": 1197477, "url": "http://patchwork.ozlabs.org/api/patches/1197477/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20191119141211.25716-8-clg@kaod.org/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20191119141211.25716-8-clg@kaod.org>", "list_archive_url": null, "date": "2019-11-19T14:12:01", "name": "[07/17] aspeed/scu: Fix W1C behavior", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "d52da643a2c5618108b1481eefc287582b911cd6", "submitter": { "id": 68548, "url": "http://patchwork.ozlabs.org/api/people/68548/?format=api", "name": "Cédric Le Goater", "email": "clg@kaod.org" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20191119141211.25716-8-clg@kaod.org/mbox/", "series": [ { "id": 143789, "url": "http://patchwork.ozlabs.org/api/series/143789/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=143789", "date": "2019-11-19T14:11:54", "name": "aspeed: extensions and fixes", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/143789/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/1197477/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/1197477/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@bilbo.ozlabs.org", "Authentication-Results": [ "ozlabs.org; spf=pass (sender SPF authorized)\n\tsmtp.mailfrom=nongnu.org (client-ip=209.51.188.17;\n\thelo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org;\n\tdmarc=none (p=none dis=none) header.from=kaod.org" ], "Received": [ "from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 47HSgD0ymyz9sPf\n\tfor <incoming@patchwork.ozlabs.org>;\n\tWed, 20 Nov 2019 01:21:27 +1100 (AEDT)", "from localhost ([::1]:46020 helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>)\n\tid 1iX4Ng-0006DI-OY\n\tfor incoming@patchwork.ozlabs.org; Tue, 19 Nov 2019 09:21:24 -0500", "from eggs.gnu.org ([2001:470:142:3::10]:42005)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <clg@kaod.org>) id 1iX4Fy-0006Qp-L7\n\tfor qemu-devel@nongnu.org; Tue, 19 Nov 2019 09:13:28 -0500", "from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from <clg@kaod.org>) id 1iX4Fw-0005R3-Hb\n\tfor qemu-devel@nongnu.org; Tue, 19 Nov 2019 09:13:26 -0500", "from 5.mo1.mail-out.ovh.net ([178.33.45.107]:60327)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from <clg@kaod.org>) id 1iX4Fv-0005Po-Hu\n\tfor qemu-devel@nongnu.org; Tue, 19 Nov 2019 09:13:24 -0500", "from player795.ha.ovh.net (unknown [10.108.57.211])\n\tby mo1.mail-out.ovh.net (Postfix) with ESMTP id 85C9319BC9B\n\tfor <qemu-devel@nongnu.org>; Tue, 19 Nov 2019 15:13:20 +0100 (CET)", "from kaod.org (deibp9eh1--blueice1n4.emea.ibm.com [195.212.29.166])\n\t(Authenticated sender: clg@kaod.org)\n\tby player795.ha.ovh.net (Postfix) with ESMTPSA id 9BA1DC18AAE1;\n\tTue, 19 Nov 2019 14:13:12 +0000 (UTC)" ], "From": "=?utf-8?q?C=C3=A9dric_Le_Goater?= <clg@kaod.org>", "To": "Peter Maydell <peter.maydell@linaro.org>", "Subject": "[PATCH 07/17] aspeed/scu: Fix W1C behavior", "Date": "Tue, 19 Nov 2019 15:12:01 +0100", "Message-Id": "<20191119141211.25716-8-clg@kaod.org>", "X-Mailer": "git-send-email 2.21.0", "In-Reply-To": "<20191119141211.25716-1-clg@kaod.org>", "References": "<20191119141211.25716-1-clg@kaod.org>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "X-Ovh-Tracer-Id": "17906312122056477457", "X-VR-SPAMSTATE": "OK", "X-VR-SPAMSCORE": "-100", "X-VR-SPAMCAUSE": "gggruggvucftvghtrhhoucdtuddrgedufedrudegkedgiedvucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuqfggjfdqfffguegfifdpvefjgfevmfevgfenuceurghilhhouhhtmecuhedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujfgurhephffvufffkffojghfgggtgfesthekredtredtjeenucfhrhhomhepveorughrihgtucfnvgcuifhorghtvghruceotghlgheskhgrohgurdhorhhgqeenucfkpheptddrtddrtddrtddpudelhedrvdduvddrvdelrdduieeinecurfgrrhgrmhepmhhouggvpehsmhhtphdqohhuthdphhgvlhhopehplhgrhigvrhejleehrdhhrgdrohhvhhdrnhgvthdpihhnvghtpedtrddtrddtrddtpdhmrghilhhfrhhomheptghlgheskhgrohgurdhorhhgpdhrtghpthhtohepqhgvmhhuqdguvghvvghlsehnohhnghhnuhdrohhrghenucevlhhushhtvghrufhiiigvpeef", "Content-Transfer-Encoding": "quoted-printable", "X-detected-operating-system": "by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]", "X-Received-From": "178.33.45.107", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.23", "Precedence": "list", "List-Id": "<qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<https://lists.nongnu.org/archive/html/qemu-devel>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Cc": "Andrew Jeffery <andrew@aj.id.au>, qemu-devel@nongnu.org,\n\tqemu-arm@nongnu.org, =?utf-8?q?C=C3=A9dric_Le_Goater?= <clg@kaod.org>,\n\t=?utf-8?q?Alex_Benn=C3=A9e?= <alex.bennee@linaro.org>,\n\tJoel Stanley <joel@jms.id.au>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "\"Qemu-devel\"\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>" }, "content": "From: Joel Stanley <joel@jms.id.au>\n\nThis models the clock write one to clear registers, and fixes up some\nincorrect behavior in all of the write to clear registers.\n\nThere was also a typo in one of the register definitions.\n\nReviewed-by: Cédric Le Goater <clg@kaod.org>\nReviewed-by: Alex Bennée <alex.bennee@linaro.org>\nSigned-off-by: Joel Stanley <joel@jms.id.au>\n[clg: checkpatch.pl fixes ]\nSigned-off-by: Cédric Le Goater <clg@kaod.org>\n---\n hw/misc/aspeed_scu.c | 19 ++++++++++++++-----\n 1 file changed, 14 insertions(+), 5 deletions(-)", "diff": "diff --git a/hw/misc/aspeed_scu.c b/hw/misc/aspeed_scu.c\nindex 717509bc5460..f62fa25e3474 100644\n--- a/hw/misc/aspeed_scu.c\n+++ b/hw/misc/aspeed_scu.c\n@@ -98,7 +98,7 @@\n #define AST2600_CLK_STOP_CTRL TO_REG(0x80)\n #define AST2600_CLK_STOP_CTRL_CLR TO_REG(0x84)\n #define AST2600_CLK_STOP_CTRL2 TO_REG(0x90)\n-#define AST2600_CLK_STOP_CTR2L_CLR TO_REG(0x94)\n+#define AST2600_CLK_STOP_CTRL2_CLR TO_REG(0x94)\n #define AST2600_SDRAM_HANDSHAKE TO_REG(0x100)\n #define AST2600_HPLL_PARAM TO_REG(0x200)\n #define AST2600_HPLL_EXT TO_REG(0x204)\n@@ -532,11 +532,13 @@ static uint64_t aspeed_ast2600_scu_read(void *opaque, hwaddr offset,\n return s->regs[reg];\n }\n \n-static void aspeed_ast2600_scu_write(void *opaque, hwaddr offset, uint64_t data,\n- unsigned size)\n+static void aspeed_ast2600_scu_write(void *opaque, hwaddr offset,\n+ uint64_t data64, unsigned size)\n {\n AspeedSCUState *s = ASPEED_SCU(opaque);\n int reg = TO_REG(offset);\n+ /* Truncate here so bitwise operations below behave as expected */\n+ uint32_t data = data64;\n \n if (reg >= ASPEED_AST2600_SCU_NR_REGS) {\n qemu_log_mask(LOG_GUEST_ERROR,\n@@ -563,15 +565,22 @@ static void aspeed_ast2600_scu_write(void *opaque, hwaddr offset, uint64_t data,\n /* fall through */\n case AST2600_SYS_RST_CTRL:\n case AST2600_SYS_RST_CTRL2:\n+ case AST2600_CLK_STOP_CTRL:\n+ case AST2600_CLK_STOP_CTRL2:\n /* W1S (Write 1 to set) registers */\n s->regs[reg] |= data;\n return;\n case AST2600_SYS_RST_CTRL_CLR:\n case AST2600_SYS_RST_CTRL2_CLR:\n+ case AST2600_CLK_STOP_CTRL_CLR:\n+ case AST2600_CLK_STOP_CTRL2_CLR:\n case AST2600_HW_STRAP1_CLR:\n case AST2600_HW_STRAP2_CLR:\n- /* W1C (Write 1 to clear) registers */\n- s->regs[reg] &= ~data;\n+ /*\n+ * W1C (Write 1 to clear) registers are offset by one address from\n+ * the data register\n+ */\n+ s->regs[reg - 1] &= ~data;\n return;\n \n case AST2600_RNG_DATA:\n", "prefixes": [ "07/17" ] }