Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/1197412/?format=api
{ "id": 1197412, "url": "http://patchwork.ozlabs.org/api/patches/1197412/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20191119114447.42241-1-sasha.neftin@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20191119114447.42241-1-sasha.neftin@intel.com>", "list_archive_url": null, "date": "2019-11-19T11:44:47", "name": "[v1,09/15] igc: Remove no need declaration of the igc_irq_enable", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "44c6764397bcccf08542bf524d98d50a438cffdc", "submitter": { "id": 69860, "url": "http://patchwork.ozlabs.org/api/people/69860/?format=api", "name": "Sasha Neftin", "email": "sasha.neftin@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20191119114447.42241-1-sasha.neftin@intel.com/mbox/", "series": [ { "id": 143759, "url": "http://patchwork.ozlabs.org/api/series/143759/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=143759", "date": "2019-11-19T11:43:32", "name": "[v1,01/15] igc: Remove no need declaration of the igc_clean_tx_ring", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/143759/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/1197412/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/1197412/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": [ "ozlabs.org; spf=pass (sender SPF authorized)\n\tsmtp.mailfrom=osuosl.org (client-ip=140.211.166.133;\n\thelo=hemlock.osuosl.org;\n\tenvelope-from=intel-wired-lan-bounces@osuosl.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org;\n\tdmarc=fail (p=none dis=none) header.from=intel.com" ], "Received": [ "from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 47HPBY1zMxz9sPj\n\tfor <incoming@patchwork.ozlabs.org>;\n\tTue, 19 Nov 2019 22:44:53 +1100 (AEDT)", "from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id D969888320;\n\tTue, 19 Nov 2019 11:44:51 +0000 (UTC)", "from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id Cn7-pHLV-82W; Tue, 19 Nov 2019 11:44:51 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 3D76888313;\n\tTue, 19 Nov 2019 11:44:51 +0000 (UTC)", "from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n\tby ash.osuosl.org (Postfix) with ESMTP id 1368D1BF83B\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tTue, 19 Nov 2019 11:44:50 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id 0AC578651D\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tTue, 19 Nov 2019 11:44:50 +0000 (UTC)", "from fraxinus.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id hUL1Tnbmntry for <intel-wired-lan@lists.osuosl.org>;\n\tTue, 19 Nov 2019 11:44:49 +0000 (UTC)", "from mga04.intel.com (mga04.intel.com [192.55.52.120])\n\tby fraxinus.osuosl.org (Postfix) with ESMTPS id 8225586508\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tTue, 19 Nov 2019 11:44:49 +0000 (UTC)", "from orsmga005.jf.intel.com ([10.7.209.41])\n\tby fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t19 Nov 2019 03:44:49 -0800", "from ccdlinuxdev08.iil.intel.com ([143.185.161.150])\n\tby orsmga005.jf.intel.com with ESMTP; 19 Nov 2019 03:44:48 -0800" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.68,322,1569308400\"; d=\"scan'208\";a=\"380991414\"", "From": "Sasha Neftin <sasha.neftin@intel.com>", "To": "intel-wired-lan@lists.osuosl.org", "Date": "Tue, 19 Nov 2019 13:44:47 +0200", "Message-Id": "<20191119114447.42241-1-sasha.neftin@intel.com>", "X-Mailer": "git-send-email 2.11.0", "Subject": "[Intel-wired-lan] [PATCH v1 09/15] igc: Remove no need declaration\n\tof the igc_irq_enable", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "We want to avoid forward-declarations of function if possible.\nRearrange the igc_irq_enable function implementation.\n\nSigned-off-by: Sasha Neftin <sasha.neftin@intel.com>\n---\n drivers/net/ethernet/intel/igc/igc_main.c | 47 +++++++++++++++----------------\n 1 file changed, 23 insertions(+), 24 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/igc/igc_main.c b/drivers/net/ethernet/intel/igc/igc_main.c\nindex 7be1e500bed5..4877161f2ea5 100644\n--- a/drivers/net/ethernet/intel/igc/igc_main.c\n+++ b/drivers/net/ethernet/intel/igc/igc_main.c\n@@ -58,7 +58,6 @@ static void igc_assign_vector(struct igc_q_vector *q_vector, int msix_vector);\n static void igc_free_q_vector(struct igc_adapter *adapter, int v_idx);\n static void igc_free_q_vectors(struct igc_adapter *adapter);\n static void igc_irq_disable(struct igc_adapter *adapter);\n-static void igc_irq_enable(struct igc_adapter *adapter);\n \n enum latency_range {\n \tlowest_latency = 0,\n@@ -2244,6 +2243,29 @@ static void igc_configure_msix(struct igc_adapter *adapter)\n }\n \n /**\n+ * igc_irq_enable - Enable default interrupt generation settings\n+ * @adapter: board private structure\n+ */\n+static void igc_irq_enable(struct igc_adapter *adapter)\n+{\n+\tstruct igc_hw *hw = &adapter->hw;\n+\n+\tif (adapter->msix_entries) {\n+\t\tu32 ims = IGC_IMS_LSC | IGC_IMS_DOUTSYNC | IGC_IMS_DRSTA;\n+\t\tu32 regval = rd32(IGC_EIAC);\n+\n+\t\twr32(IGC_EIAC, regval | adapter->eims_enable_mask);\n+\t\tregval = rd32(IGC_EIAM);\n+\t\twr32(IGC_EIAM, regval | adapter->eims_enable_mask);\n+\t\twr32(IGC_EIMS, adapter->eims_enable_mask);\n+\t\twr32(IGC_IMS, ims);\n+\t} else {\n+\t\twr32(IGC_IMS, IMS_ENABLE_MASK | IGC_IMS_DRSTA);\n+\t\twr32(IGC_IAM, IMS_ENABLE_MASK | IGC_IMS_DRSTA);\n+\t}\n+}\n+\n+/**\n * igc_up - Open the interface and prepare it to handle traffic\n * @adapter: board private structure\n */\n@@ -3973,29 +3995,6 @@ static void igc_irq_disable(struct igc_adapter *adapter)\n }\n \n /**\n- * igc_irq_enable - Enable default interrupt generation settings\n- * @adapter: board private structure\n- */\n-static void igc_irq_enable(struct igc_adapter *adapter)\n-{\n-\tstruct igc_hw *hw = &adapter->hw;\n-\n-\tif (adapter->msix_entries) {\n-\t\tu32 ims = IGC_IMS_LSC | IGC_IMS_DOUTSYNC | IGC_IMS_DRSTA;\n-\t\tu32 regval = rd32(IGC_EIAC);\n-\n-\t\twr32(IGC_EIAC, regval | adapter->eims_enable_mask);\n-\t\tregval = rd32(IGC_EIAM);\n-\t\twr32(IGC_EIAM, regval | adapter->eims_enable_mask);\n-\t\twr32(IGC_EIMS, adapter->eims_enable_mask);\n-\t\twr32(IGC_IMS, ims);\n-\t} else {\n-\t\twr32(IGC_IMS, IMS_ENABLE_MASK | IGC_IMS_DRSTA);\n-\t\twr32(IGC_IAM, IMS_ENABLE_MASK | IGC_IMS_DRSTA);\n-\t}\n-}\n-\n-/**\n * igc_request_irq - initialize interrupts\n * @adapter: Pointer to adapter structure\n *\n", "prefixes": [ "v1", "09/15" ] }