Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/1197411/?format=api
{ "id": 1197411, "url": "http://patchwork.ozlabs.org/api/patches/1197411/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20191119114438.42172-1-sasha.neftin@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20191119114438.42172-1-sasha.neftin@intel.com>", "list_archive_url": null, "date": "2019-11-19T11:44:38", "name": "[v1,08/15] igc: Remove no need declaration of the igc_configure_msix", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "01754269c322f7a4db4b767b98f8e6eb180e3235", "submitter": { "id": 69860, "url": "http://patchwork.ozlabs.org/api/people/69860/?format=api", "name": "Sasha Neftin", "email": "sasha.neftin@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20191119114438.42172-1-sasha.neftin@intel.com/mbox/", "series": [ { "id": 143759, "url": "http://patchwork.ozlabs.org/api/series/143759/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=143759", "date": "2019-11-19T11:43:32", "name": "[v1,01/15] igc: Remove no need declaration of the igc_clean_tx_ring", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/143759/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/1197411/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/1197411/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": [ "ozlabs.org; spf=pass (sender SPF authorized)\n\tsmtp.mailfrom=osuosl.org (client-ip=140.211.166.133;\n\thelo=hemlock.osuosl.org;\n\tenvelope-from=intel-wired-lan-bounces@osuosl.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org;\n\tdmarc=fail (p=none dis=none) header.from=intel.com" ], "Received": [ "from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 47HPBP5dWWz9sPj\n\tfor <incoming@patchwork.ozlabs.org>;\n\tTue, 19 Nov 2019 22:44:45 +1100 (AEDT)", "from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id AF1E188309;\n\tTue, 19 Nov 2019 11:44:43 +0000 (UTC)", "from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id 7BszAFTtapPT; Tue, 19 Nov 2019 11:44:42 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id DCF9B88303;\n\tTue, 19 Nov 2019 11:44:42 +0000 (UTC)", "from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\tby ash.osuosl.org (Postfix) with ESMTP id 272071BF83B\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tTue, 19 Nov 2019 11:44:42 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 23BC188303\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tTue, 19 Nov 2019 11:44:42 +0000 (UTC)", "from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id 1UXjOErnHVol for <intel-wired-lan@lists.osuosl.org>;\n\tTue, 19 Nov 2019 11:44:40 +0000 (UTC)", "from mga01.intel.com (mga01.intel.com [192.55.52.88])\n\tby hemlock.osuosl.org (Postfix) with ESMTPS id DA5EC86963\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tTue, 19 Nov 2019 11:44:40 +0000 (UTC)", "from orsmga007.jf.intel.com ([10.7.209.58])\n\tby fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t19 Nov 2019 03:44:40 -0800", "from ccdlinuxdev08.iil.intel.com ([143.185.161.150])\n\tby orsmga007.jf.intel.com with ESMTP; 19 Nov 2019 03:44:39 -0800" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.68,322,1569308400\"; d=\"scan'208\";a=\"196471759\"", "From": "Sasha Neftin <sasha.neftin@intel.com>", "To": "intel-wired-lan@lists.osuosl.org", "Date": "Tue, 19 Nov 2019 13:44:38 +0200", "Message-Id": "<20191119114438.42172-1-sasha.neftin@intel.com>", "X-Mailer": "git-send-email 2.11.0", "Subject": "[Intel-wired-lan] [PATCH v1 08/15] igc: Remove no need declaration\n\tof the igc_configure_msix", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "We want to avoid forward-declarations of function if possible.\nRearrange the igc_configure_msix function implementation.\n\nSigned-off-by: Sasha Neftin <sasha.neftin@intel.com>\n---\n drivers/net/ethernet/intel/igc/igc_main.c | 89 +++++++++++++++----------------\n 1 file changed, 44 insertions(+), 45 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/igc/igc_main.c b/drivers/net/ethernet/intel/igc/igc_main.c\nindex 7118a5605229..7be1e500bed5 100644\n--- a/drivers/net/ethernet/intel/igc/igc_main.c\n+++ b/drivers/net/ethernet/intel/igc/igc_main.c\n@@ -59,7 +59,6 @@ static void igc_free_q_vector(struct igc_adapter *adapter, int v_idx);\n static void igc_free_q_vectors(struct igc_adapter *adapter);\n static void igc_irq_disable(struct igc_adapter *adapter);\n static void igc_irq_enable(struct igc_adapter *adapter);\n-static void igc_configure_msix(struct igc_adapter *adapter);\n \n enum latency_range {\n \tlowest_latency = 0,\n@@ -2201,6 +2200,50 @@ static void igc_configure(struct igc_adapter *adapter)\n }\n \n /**\n+ * igc_configure_msix - Configure MSI-X hardware\n+ * @adapter: Pointer to adapter structure\n+ *\n+ * igc_configure_msix sets up the hardware to properly\n+ * generate MSI-X interrupts.\n+ */\n+static void igc_configure_msix(struct igc_adapter *adapter)\n+{\n+\tstruct igc_hw *hw = &adapter->hw;\n+\tint i, vector = 0;\n+\tu32 tmp;\n+\n+\tadapter->eims_enable_mask = 0;\n+\n+\t/* set vector for other causes, i.e. link changes */\n+\tswitch (hw->mac.type) {\n+\tcase igc_i225:\n+\t\t/* Turn on MSI-X capability first, or our settings\n+\t\t * won't stick. And it will take days to debug.\n+\t\t */\n+\t\twr32(IGC_GPIE, IGC_GPIE_MSIX_MODE |\n+\t\t IGC_GPIE_PBA | IGC_GPIE_EIAME |\n+\t\t IGC_GPIE_NSICR);\n+\n+\t\t/* enable msix_other interrupt */\n+\t\tadapter->eims_other = BIT(vector);\n+\t\ttmp = (vector++ | IGC_IVAR_VALID) << 8;\n+\n+\t\twr32(IGC_IVAR_MISC, tmp);\n+\t\tbreak;\n+\tdefault:\n+\t\t/* do nothing, since nothing else supports MSI-X */\n+\t\tbreak;\n+\t} /* switch (hw->mac.type) */\n+\n+\tadapter->eims_enable_mask |= adapter->eims_other;\n+\n+\tfor (i = 0; i < adapter->num_q_vectors; i++)\n+\t\tigc_assign_vector(adapter->q_vector[i], vector++);\n+\n+\twrfl();\n+}\n+\n+/**\n * igc_up - Open the interface and prepare it to handle traffic\n * @adapter: board private structure\n */\n@@ -2837,50 +2880,6 @@ static void igc_assign_vector(struct igc_q_vector *q_vector, int msix_vector)\n \tq_vector->set_itr = 1;\n }\n \n-/**\n- * igc_configure_msix - Configure MSI-X hardware\n- * @adapter: Pointer to adapter structure\n- *\n- * igc_configure_msix sets up the hardware to properly\n- * generate MSI-X interrupts.\n- */\n-static void igc_configure_msix(struct igc_adapter *adapter)\n-{\n-\tstruct igc_hw *hw = &adapter->hw;\n-\tint i, vector = 0;\n-\tu32 tmp;\n-\n-\tadapter->eims_enable_mask = 0;\n-\n-\t/* set vector for other causes, i.e. link changes */\n-\tswitch (hw->mac.type) {\n-\tcase igc_i225:\n-\t\t/* Turn on MSI-X capability first, or our settings\n-\t\t * won't stick. And it will take days to debug.\n-\t\t */\n-\t\twr32(IGC_GPIE, IGC_GPIE_MSIX_MODE |\n-\t\t IGC_GPIE_PBA | IGC_GPIE_EIAME |\n-\t\t IGC_GPIE_NSICR);\n-\n-\t\t/* enable msix_other interrupt */\n-\t\tadapter->eims_other = BIT(vector);\n-\t\ttmp = (vector++ | IGC_IVAR_VALID) << 8;\n-\n-\t\twr32(IGC_IVAR_MISC, tmp);\n-\t\tbreak;\n-\tdefault:\n-\t\t/* do nothing, since nothing else supports MSI-X */\n-\t\tbreak;\n-\t} /* switch (hw->mac.type) */\n-\n-\tadapter->eims_enable_mask |= adapter->eims_other;\n-\n-\tfor (i = 0; i < adapter->num_q_vectors; i++)\n-\t\tigc_assign_vector(adapter->q_vector[i], vector++);\n-\n-\twrfl();\n-}\n-\n static irqreturn_t igc_msix_ring(int irq, void *data)\n {\n \tstruct igc_q_vector *q_vector = data;\n", "prefixes": [ "v1", "08/15" ] }