Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/1197408/?format=api
{ "id": 1197408, "url": "http://patchwork.ozlabs.org/api/patches/1197408/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20191119114419.42064-1-sasha.neftin@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20191119114419.42064-1-sasha.neftin@intel.com>", "list_archive_url": null, "date": "2019-11-19T11:44:19", "name": "[v1,06/15] igc: Remove no need declaration of the igc_set_interrupt_capability", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "bfd067760269a4c5e1d03704729654e9ee1e0974", "submitter": { "id": 69860, "url": "http://patchwork.ozlabs.org/api/people/69860/?format=api", "name": "Sasha Neftin", "email": "sasha.neftin@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20191119114419.42064-1-sasha.neftin@intel.com/mbox/", "series": [ { "id": 143759, "url": "http://patchwork.ozlabs.org/api/series/143759/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=143759", "date": "2019-11-19T11:43:32", "name": "[v1,01/15] igc: Remove no need declaration of the igc_clean_tx_ring", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/143759/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/1197408/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/1197408/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": [ "ozlabs.org; spf=pass (sender SPF authorized)\n\tsmtp.mailfrom=osuosl.org (client-ip=140.211.166.137;\n\thelo=fraxinus.osuosl.org;\n\tenvelope-from=intel-wired-lan-bounces@osuosl.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org;\n\tdmarc=fail (p=none dis=none) header.from=intel.com" ], "Received": [ "from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 47HPB30Xt8z9sPj\n\tfor <incoming@patchwork.ozlabs.org>;\n\tTue, 19 Nov 2019 22:44:26 +1100 (AEDT)", "from localhost (localhost [127.0.0.1])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id E62E5868AB;\n\tTue, 19 Nov 2019 11:44:24 +0000 (UTC)", "from fraxinus.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id n9oiT2pWByWB; Tue, 19 Nov 2019 11:44:24 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id 4FD3386508;\n\tTue, 19 Nov 2019 11:44:24 +0000 (UTC)", "from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n\tby ash.osuosl.org (Postfix) with ESMTP id 1ABC01BF83B\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tTue, 19 Nov 2019 11:44:22 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id 175E486508\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tTue, 19 Nov 2019 11:44:22 +0000 (UTC)", "from fraxinus.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id r2JXApiDsvdz for <intel-wired-lan@lists.osuosl.org>;\n\tTue, 19 Nov 2019 11:44:21 +0000 (UTC)", "from mga04.intel.com (mga04.intel.com [192.55.52.120])\n\tby fraxinus.osuosl.org (Postfix) with ESMTPS id 5BB5E86505\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tTue, 19 Nov 2019 11:44:21 +0000 (UTC)", "from fmsmga002.fm.intel.com ([10.253.24.26])\n\tby fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t19 Nov 2019 03:44:21 -0800", "from ccdlinuxdev08.iil.intel.com ([143.185.161.150])\n\tby fmsmga002.fm.intel.com with ESMTP; 19 Nov 2019 03:44:20 -0800" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.68,322,1569308400\"; d=\"scan'208\";a=\"237302032\"", "From": "Sasha Neftin <sasha.neftin@intel.com>", "To": "intel-wired-lan@lists.osuosl.org", "Date": "Tue, 19 Nov 2019 13:44:19 +0200", "Message-Id": "<20191119114419.42064-1-sasha.neftin@intel.com>", "X-Mailer": "git-send-email 2.11.0", "Subject": "[Intel-wired-lan] [PATCH v1 06/15] igc: Remove no need declaration\n\tof the igc_set_interrupt_capability", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "We want to avoid forward-declarations of function if possible.\nRearrange the igc_set_interrupt_capability function implementation.\n\nSigned-off-by: Sasha Neftin <sasha.neftin@intel.com>\n---\n drivers/net/ethernet/intel/igc/igc_main.c | 142 +++++++++++++++---------------\n 1 file changed, 70 insertions(+), 72 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/igc/igc_main.c b/drivers/net/ethernet/intel/igc/igc_main.c\nindex d26875592937..a1746be345b9 100644\n--- a/drivers/net/ethernet/intel/igc/igc_main.c\n+++ b/drivers/net/ethernet/intel/igc/igc_main.c\n@@ -57,8 +57,6 @@ static void igc_set_rx_mode(struct net_device *netdev);\n static void igc_write_itr(struct igc_q_vector *q_vector);\n static void igc_assign_vector(struct igc_q_vector *q_vector, int msix_vector);\n static void igc_free_q_vector(struct igc_adapter *adapter, int v_idx);\n-static void igc_set_interrupt_capability(struct igc_adapter *adapter,\n-\t\t\t\t\t bool msix);\n static void igc_free_q_vectors(struct igc_adapter *adapter);\n static void igc_irq_disable(struct igc_adapter *adapter);\n static void igc_irq_enable(struct igc_adapter *adapter);\n@@ -2999,6 +2997,76 @@ static void igc_reset_interrupt_capability(struct igc_adapter *adapter)\n }\n \n /**\n+ * igc_set_interrupt_capability - set MSI or MSI-X if supported\n+ * @adapter: Pointer to adapter structure\n+ * @msix: boolean value for MSI-X capability\n+ *\n+ * Attempt to configure interrupts using the best available\n+ * capabilities of the hardware and kernel.\n+ */\n+static void igc_set_interrupt_capability(struct igc_adapter *adapter,\n+\t\t\t\t\t bool msix)\n+{\n+\tint numvecs, i;\n+\tint err;\n+\n+\tif (!msix)\n+\t\tgoto msi_only;\n+\tadapter->flags |= IGC_FLAG_HAS_MSIX;\n+\n+\t/* Number of supported queues. */\n+\tadapter->num_rx_queues = adapter->rss_queues;\n+\n+\tadapter->num_tx_queues = adapter->rss_queues;\n+\n+\t/* start with one vector for every Rx queue */\n+\tnumvecs = adapter->num_rx_queues;\n+\n+\t/* if Tx handler is separate add 1 for every Tx queue */\n+\tif (!(adapter->flags & IGC_FLAG_QUEUE_PAIRS))\n+\t\tnumvecs += adapter->num_tx_queues;\n+\n+\t/* store the number of vectors reserved for queues */\n+\tadapter->num_q_vectors = numvecs;\n+\n+\t/* add 1 vector for link status interrupts */\n+\tnumvecs++;\n+\n+\tadapter->msix_entries = kcalloc(numvecs, sizeof(struct msix_entry),\n+\t\t\t\t\tGFP_KERNEL);\n+\n+\tif (!adapter->msix_entries)\n+\t\treturn;\n+\n+\t/* populate entry values */\n+\tfor (i = 0; i < numvecs; i++)\n+\t\tadapter->msix_entries[i].entry = i;\n+\n+\terr = pci_enable_msix_range(adapter->pdev,\n+\t\t\t\t adapter->msix_entries,\n+\t\t\t\t numvecs,\n+\t\t\t\t numvecs);\n+\tif (err > 0)\n+\t\treturn;\n+\n+\tkfree(adapter->msix_entries);\n+\tadapter->msix_entries = NULL;\n+\n+\tigc_reset_interrupt_capability(adapter);\n+\n+msi_only:\n+\tadapter->flags &= ~IGC_FLAG_HAS_MSIX;\n+\n+\tadapter->rss_queues = 1;\n+\tadapter->flags |= IGC_FLAG_QUEUE_PAIRS;\n+\tadapter->num_rx_queues = 1;\n+\tadapter->num_tx_queues = 1;\n+\tadapter->num_q_vectors = 1;\n+\tif (!pci_enable_msi(adapter->pdev))\n+\t\tadapter->flags |= IGC_FLAG_HAS_MSI;\n+}\n+\n+/**\n * igc_clear_interrupt_scheme - reset the device to a state of no interrupts\n * @adapter: Pointer to adapter structure\n *\n@@ -3630,76 +3698,6 @@ static int igc_poll(struct napi_struct *napi, int budget)\n \treturn min(work_done, budget - 1);\n }\n \n-/**\n- * igc_set_interrupt_capability - set MSI or MSI-X if supported\n- * @adapter: Pointer to adapter structure\n- * @msix: boolean value for MSI-X capability\n- *\n- * Attempt to configure interrupts using the best available\n- * capabilities of the hardware and kernel.\n- */\n-static void igc_set_interrupt_capability(struct igc_adapter *adapter,\n-\t\t\t\t\t bool msix)\n-{\n-\tint numvecs, i;\n-\tint err;\n-\n-\tif (!msix)\n-\t\tgoto msi_only;\n-\tadapter->flags |= IGC_FLAG_HAS_MSIX;\n-\n-\t/* Number of supported queues. */\n-\tadapter->num_rx_queues = adapter->rss_queues;\n-\n-\tadapter->num_tx_queues = adapter->rss_queues;\n-\n-\t/* start with one vector for every Rx queue */\n-\tnumvecs = adapter->num_rx_queues;\n-\n-\t/* if Tx handler is separate add 1 for every Tx queue */\n-\tif (!(adapter->flags & IGC_FLAG_QUEUE_PAIRS))\n-\t\tnumvecs += adapter->num_tx_queues;\n-\n-\t/* store the number of vectors reserved for queues */\n-\tadapter->num_q_vectors = numvecs;\n-\n-\t/* add 1 vector for link status interrupts */\n-\tnumvecs++;\n-\n-\tadapter->msix_entries = kcalloc(numvecs, sizeof(struct msix_entry),\n-\t\t\t\t\tGFP_KERNEL);\n-\n-\tif (!adapter->msix_entries)\n-\t\treturn;\n-\n-\t/* populate entry values */\n-\tfor (i = 0; i < numvecs; i++)\n-\t\tadapter->msix_entries[i].entry = i;\n-\n-\terr = pci_enable_msix_range(adapter->pdev,\n-\t\t\t\t adapter->msix_entries,\n-\t\t\t\t numvecs,\n-\t\t\t\t numvecs);\n-\tif (err > 0)\n-\t\treturn;\n-\n-\tkfree(adapter->msix_entries);\n-\tadapter->msix_entries = NULL;\n-\n-\tigc_reset_interrupt_capability(adapter);\n-\n-msi_only:\n-\tadapter->flags &= ~IGC_FLAG_HAS_MSIX;\n-\n-\tadapter->rss_queues = 1;\n-\tadapter->flags |= IGC_FLAG_QUEUE_PAIRS;\n-\tadapter->num_rx_queues = 1;\n-\tadapter->num_tx_queues = 1;\n-\tadapter->num_q_vectors = 1;\n-\tif (!pci_enable_msi(adapter->pdev))\n-\t\tadapter->flags |= IGC_FLAG_HAS_MSI;\n-}\n-\n static void igc_add_ring(struct igc_ring *ring,\n \t\t\t struct igc_ring_container *head)\n {\n", "prefixes": [ "v1", "06/15" ] }