Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/1197405/?format=api
{ "id": 1197405, "url": "http://patchwork.ozlabs.org/api/patches/1197405/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20191119114401.41842-1-sasha.neftin@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20191119114401.41842-1-sasha.neftin@intel.com>", "list_archive_url": null, "date": "2019-11-19T11:44:01", "name": "[v1,04/15] igc: Remove no need declaration of the igc_configure", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "f0281af5310e429443640514e2e15b7fbc32a7fb", "submitter": { "id": 69860, "url": "http://patchwork.ozlabs.org/api/people/69860/?format=api", "name": "Sasha Neftin", "email": "sasha.neftin@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20191119114401.41842-1-sasha.neftin@intel.com/mbox/", "series": [ { "id": 143759, "url": "http://patchwork.ozlabs.org/api/series/143759/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=143759", "date": "2019-11-19T11:43:32", "name": "[v1,01/15] igc: Remove no need declaration of the igc_clean_tx_ring", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/143759/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/1197405/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/1197405/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": [ "ozlabs.org; spf=pass (sender SPF authorized)\n\tsmtp.mailfrom=osuosl.org (client-ip=140.211.166.138;\n\thelo=whitealder.osuosl.org;\n\tenvelope-from=intel-wired-lan-bounces@osuosl.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org;\n\tdmarc=fail (p=none dis=none) header.from=intel.com" ], "Received": [ "from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 47HP9j6JXlz9sPj\n\tfor <incoming@patchwork.ozlabs.org>;\n\tTue, 19 Nov 2019 22:44:09 +1100 (AEDT)", "from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 6C9C887034;\n\tTue, 19 Nov 2019 11:44:08 +0000 (UTC)", "from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id Ih7A4+yTM8J9; Tue, 19 Nov 2019 11:44:06 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 94D46872E9;\n\tTue, 19 Nov 2019 11:44:06 +0000 (UTC)", "from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\tby ash.osuosl.org (Postfix) with ESMTP id B602A1BF83B\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tTue, 19 Nov 2019 11:44:05 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id B19AF22744\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tTue, 19 Nov 2019 11:44:05 +0000 (UTC)", "from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id 4z0zsHhfQ4ey for <intel-wired-lan@lists.osuosl.org>;\n\tTue, 19 Nov 2019 11:44:04 +0000 (UTC)", "from mga05.intel.com (mga05.intel.com [192.55.52.43])\n\tby silver.osuosl.org (Postfix) with ESMTPS id AD24622703\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tTue, 19 Nov 2019 11:44:04 +0000 (UTC)", "from orsmga001.jf.intel.com ([10.7.209.18])\n\tby fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t19 Nov 2019 03:44:04 -0800", "from ccdlinuxdev08.iil.intel.com ([143.185.161.150])\n\tby orsmga001.jf.intel.com with ESMTP; 19 Nov 2019 03:44:03 -0800" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.68,322,1569308400\"; d=\"scan'208\";a=\"289580965\"", "From": "Sasha Neftin <sasha.neftin@intel.com>", "To": "intel-wired-lan@lists.osuosl.org", "Date": "Tue, 19 Nov 2019 13:44:01 +0200", "Message-Id": "<20191119114401.41842-1-sasha.neftin@intel.com>", "X-Mailer": "git-send-email 2.11.0", "Subject": "[Intel-wired-lan] [PATCH v1 04/15] igc: Remove no need declaration\n\tof the igc_configure", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "We want to avoid forward-declarations of function if possible.\nRearrange the igc_configure function implementation.\n\nSigned-off-by: Sasha Neftin <sasha.neftin@intel.com>\n---\n drivers/net/ethernet/intel/igc/igc_main.c | 91 +++++++++++++++----------------\n 1 file changed, 45 insertions(+), 46 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/igc/igc_main.c b/drivers/net/ethernet/intel/igc/igc_main.c\nindex 4484e7ab0a53..8a2baf8ad956 100644\n--- a/drivers/net/ethernet/intel/igc/igc_main.c\n+++ b/drivers/net/ethernet/intel/igc/igc_main.c\n@@ -53,7 +53,6 @@ MODULE_DEVICE_TABLE(pci, igc_pci_tbl);\n \n /* forward declaration */\n static int igc_sw_init(struct igc_adapter *);\n-static void igc_configure(struct igc_adapter *adapter);\n static void igc_set_rx_mode(struct net_device *netdev);\n static void igc_write_itr(struct igc_q_vector *q_vector);\n static void igc_assign_vector(struct igc_q_vector *q_vector, int msix_vector);\n@@ -1985,6 +1984,51 @@ static bool igc_clean_tx_irq(struct igc_q_vector *q_vector, int napi_budget)\n \treturn !!budget;\n }\n \n+static void igc_nfc_filter_restore(struct igc_adapter *adapter)\n+{\n+\tstruct igc_nfc_filter *rule;\n+\n+\tspin_lock(&adapter->nfc_lock);\n+\n+\thlist_for_each_entry(rule, &adapter->nfc_filter_list, nfc_node)\n+\t\tigc_add_filter(adapter, rule);\n+\n+\tspin_unlock(&adapter->nfc_lock);\n+}\n+\n+/**\n+ * igc_configure - configure the hardware for RX and TX\n+ * @adapter: private board structure\n+ */\n+static void igc_configure(struct igc_adapter *adapter)\n+{\n+\tstruct net_device *netdev = adapter->netdev;\n+\tint i = 0;\n+\n+\tigc_get_hw_control(adapter);\n+\tigc_set_rx_mode(netdev);\n+\n+\tigc_setup_tctl(adapter);\n+\tigc_setup_mrqc(adapter);\n+\tigc_setup_rctl(adapter);\n+\n+\tigc_nfc_filter_restore(adapter);\n+\tigc_configure_tx(adapter);\n+\tigc_configure_rx(adapter);\n+\n+\tigc_rx_fifo_flush_base(&adapter->hw);\n+\n+\t/* call igc_desc_unused which always leaves\n+\t * at least 1 descriptor unused to make sure\n+\t * next_to_use != next_to_clean\n+\t */\n+\tfor (i = 0; i < adapter->num_rx_queues; i++) {\n+\t\tstruct igc_ring *ring = adapter->rx_ring[i];\n+\n+\t\tigc_alloc_rx_buffers(ring, igc_desc_unused(ring));\n+\t}\n+}\n+\n /**\n * igc_up - Open the interface and prepare it to handle traffic\n * @adapter: board private structure\n@@ -2206,18 +2250,6 @@ static void igc_nfc_filter_exit(struct igc_adapter *adapter)\n \tspin_unlock(&adapter->nfc_lock);\n }\n \n-static void igc_nfc_filter_restore(struct igc_adapter *adapter)\n-{\n-\tstruct igc_nfc_filter *rule;\n-\n-\tspin_lock(&adapter->nfc_lock);\n-\n-\thlist_for_each_entry(rule, &adapter->nfc_filter_list, nfc_node)\n-\t\tigc_add_filter(adapter, rule);\n-\n-\tspin_unlock(&adapter->nfc_lock);\n-}\n-\n /**\n * igc_down - Close the interface\n * @adapter: board private structure\n@@ -2441,39 +2473,6 @@ igc_features_check(struct sk_buff *skb, struct net_device *dev,\n \treturn features;\n }\n \n-/**\n- * igc_configure - configure the hardware for RX and TX\n- * @adapter: private board structure\n- */\n-static void igc_configure(struct igc_adapter *adapter)\n-{\n-\tstruct net_device *netdev = adapter->netdev;\n-\tint i = 0;\n-\n-\tigc_get_hw_control(adapter);\n-\tigc_set_rx_mode(netdev);\n-\n-\tigc_setup_tctl(adapter);\n-\tigc_setup_mrqc(adapter);\n-\tigc_setup_rctl(adapter);\n-\n-\tigc_nfc_filter_restore(adapter);\n-\tigc_configure_tx(adapter);\n-\tigc_configure_rx(adapter);\n-\n-\tigc_rx_fifo_flush_base(&adapter->hw);\n-\n-\t/* call igc_desc_unused which always leaves\n-\t * at least 1 descriptor unused to make sure\n-\t * next_to_use != next_to_clean\n-\t */\n-\tfor (i = 0; i < adapter->num_rx_queues; i++) {\n-\t\tstruct igc_ring *ring = adapter->rx_ring[i];\n-\n-\t\tigc_alloc_rx_buffers(ring, igc_desc_unused(ring));\n-\t}\n-}\n-\n /* If the filter to be added and an already existing filter express\n * the same address and address type, it should be possible to only\n * override the other configurations, for example the queue to steer\n", "prefixes": [ "v1", "04/15" ] }