Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/1197403/?format=api
{ "id": 1197403, "url": "http://patchwork.ozlabs.org/api/patches/1197403/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20191119114341.41725-1-sasha.neftin@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20191119114341.41725-1-sasha.neftin@intel.com>", "list_archive_url": null, "date": "2019-11-19T11:43:41", "name": "[v1,02/15] igc: Remove no need declaration of the igc_power_down_link", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "654b38be37b8344d12cfb0e8570e921fc6e5993d", "submitter": { "id": 69860, "url": "http://patchwork.ozlabs.org/api/people/69860/?format=api", "name": "Sasha Neftin", "email": "sasha.neftin@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20191119114341.41725-1-sasha.neftin@intel.com/mbox/", "series": [ { "id": 143759, "url": "http://patchwork.ozlabs.org/api/series/143759/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=143759", "date": "2019-11-19T11:43:32", "name": "[v1,01/15] igc: Remove no need declaration of the igc_clean_tx_ring", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/143759/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/1197403/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/1197403/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": [ "ozlabs.org; spf=pass (sender SPF authorized)\n\tsmtp.mailfrom=osuosl.org (client-ip=140.211.166.137;\n\thelo=fraxinus.osuosl.org;\n\tenvelope-from=intel-wired-lan-bounces@osuosl.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org;\n\tdmarc=fail (p=none dis=none) header.from=intel.com" ], "Received": [ "from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 47HP9L4XHhz9sPj\n\tfor <incoming@patchwork.ozlabs.org>;\n\tTue, 19 Nov 2019 22:43:50 +1100 (AEDT)", "from localhost (localhost [127.0.0.1])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id DAB5C86896;\n\tTue, 19 Nov 2019 11:43:47 +0000 (UTC)", "from fraxinus.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id uhC1qdgxHEAp; Tue, 19 Nov 2019 11:43:45 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id EC65A86508;\n\tTue, 19 Nov 2019 11:43:45 +0000 (UTC)", "from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\tby ash.osuosl.org (Postfix) with ESMTP id 030F81BF83B\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tTue, 19 Nov 2019 11:43:44 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id F3A7A22703\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tTue, 19 Nov 2019 11:43:43 +0000 (UTC)", "from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id 50rDSeuXpcmP for <intel-wired-lan@lists.osuosl.org>;\n\tTue, 19 Nov 2019 11:43:43 +0000 (UTC)", "from mga17.intel.com (mga17.intel.com [192.55.52.151])\n\tby silver.osuosl.org (Postfix) with ESMTPS id 3969A2266F\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tTue, 19 Nov 2019 11:43:43 +0000 (UTC)", "from fmsmga003.fm.intel.com ([10.253.24.29])\n\tby fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t19 Nov 2019 03:43:42 -0800", "from ccdlinuxdev08.iil.intel.com ([143.185.161.150])\n\tby FMSMGA003.fm.intel.com with ESMTP; 19 Nov 2019 03:43:42 -0800" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.68,322,1569308400\"; d=\"scan'208\";a=\"258701116\"", "From": "Sasha Neftin <sasha.neftin@intel.com>", "To": "intel-wired-lan@lists.osuosl.org", "Date": "Tue, 19 Nov 2019 13:43:41 +0200", "Message-Id": "<20191119114341.41725-1-sasha.neftin@intel.com>", "X-Mailer": "git-send-email 2.11.0", "Subject": "[Intel-wired-lan] [PATCH v1 02/15] igc: Remove no need declaration\n\tof the igc_power_down_link", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "We want to avoid forward-declarations of function if possible.\nRearrange the igc_power_down_link function implementation.\n\nSigned-off-by: Sasha Neftin <sasha.neftin@intel.com>\n---\n drivers/net/ethernet/intel/igc/igc_main.c | 21 ++++++++++-----------\n 1 file changed, 10 insertions(+), 11 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/igc/igc_main.c b/drivers/net/ethernet/intel/igc/igc_main.c\nindex ed71d8bdf47d..87823a04427e 100644\n--- a/drivers/net/ethernet/intel/igc/igc_main.c\n+++ b/drivers/net/ethernet/intel/igc/igc_main.c\n@@ -54,7 +54,6 @@ MODULE_DEVICE_TABLE(pci, igc_pci_tbl);\n /* forward declaration */\n static int igc_sw_init(struct igc_adapter *);\n static void igc_configure(struct igc_adapter *adapter);\n-static void igc_power_down_link(struct igc_adapter *adapter);\n static void igc_set_default_mac_filter(struct igc_adapter *adapter);\n static void igc_set_rx_mode(struct net_device *netdev);\n static void igc_write_itr(struct igc_q_vector *q_vector);\n@@ -76,6 +75,16 @@ enum latency_range {\n \tlatency_invalid = 255\n };\n \n+/**\n+ * igc_power_down_link - Power down the phy/serdes link\n+ * @adapter: address of board private structure\n+ */\n+static void igc_power_down_link(struct igc_adapter *adapter)\n+{\n+\tif (adapter->hw.phy.media_type == igc_media_type_copper)\n+\t\tigc_power_down_phy_copper_base(&adapter->hw);\n+}\n+\n void igc_reset(struct igc_adapter *adapter)\n {\n \tstruct pci_dev *pdev = adapter->pdev;\n@@ -128,16 +137,6 @@ static void igc_power_up_link(struct igc_adapter *adapter)\n }\n \n /**\n- * igc_power_down_link - Power down the phy/serdes link\n- * @adapter: address of board private structure\n- */\n-static void igc_power_down_link(struct igc_adapter *adapter)\n-{\n-\tif (adapter->hw.phy.media_type == igc_media_type_copper)\n-\t\tigc_power_down_phy_copper_base(&adapter->hw);\n-}\n-\n-/**\n * igc_release_hw_control - release control of the h/w to f/w\n * @adapter: address of board private structure\n *\n", "prefixes": [ "v1", "02/15" ] }