Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/1197402/?format=api
{ "id": 1197402, "url": "http://patchwork.ozlabs.org/api/patches/1197402/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20191119114332.41655-1-sasha.neftin@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20191119114332.41655-1-sasha.neftin@intel.com>", "list_archive_url": null, "date": "2019-11-19T11:43:32", "name": "[v1,01/15] igc: Remove no need declaration of the igc_clean_tx_ring", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "eb957d9c14f23d76a8aefb609e94cd5013a09d6a", "submitter": { "id": 69860, "url": "http://patchwork.ozlabs.org/api/people/69860/?format=api", "name": "Sasha Neftin", "email": "sasha.neftin@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20191119114332.41655-1-sasha.neftin@intel.com/mbox/", "series": [ { "id": 143759, "url": "http://patchwork.ozlabs.org/api/series/143759/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=143759", "date": "2019-11-19T11:43:32", "name": "[v1,01/15] igc: Remove no need declaration of the igc_clean_tx_ring", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/143759/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/1197402/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/1197402/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": [ "ozlabs.org; spf=pass (sender SPF authorized)\n\tsmtp.mailfrom=osuosl.org (client-ip=140.211.166.136;\n\thelo=silver.osuosl.org;\n\tenvelope-from=intel-wired-lan-bounces@osuosl.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org;\n\tdmarc=fail (p=none dis=none) header.from=intel.com" ], "Received": [ "from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 47HP9929Mxz9sPj\n\tfor <incoming@patchwork.ozlabs.org>;\n\tTue, 19 Nov 2019 22:43:40 +1100 (AEDT)", "from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id E799222703;\n\tTue, 19 Nov 2019 11:43:38 +0000 (UTC)", "from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id amveQom3FyGd; Tue, 19 Nov 2019 11:43:36 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby silver.osuosl.org (Postfix) with ESMTP id 8C51F2266F;\n\tTue, 19 Nov 2019 11:43:36 +0000 (UTC)", "from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n\tby ash.osuosl.org (Postfix) with ESMTP id 6F3EA1BF83B\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tTue, 19 Nov 2019 11:43:35 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id 52A5F86505\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tTue, 19 Nov 2019 11:43:35 +0000 (UTC)", "from fraxinus.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id Jh4bNtSZGShF for <intel-wired-lan@lists.osuosl.org>;\n\tTue, 19 Nov 2019 11:43:34 +0000 (UTC)", "from mga01.intel.com (mga01.intel.com [192.55.52.88])\n\tby fraxinus.osuosl.org (Postfix) with ESMTPS id 78540864EA\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tTue, 19 Nov 2019 11:43:34 +0000 (UTC)", "from fmsmga004.fm.intel.com ([10.253.24.48])\n\tby fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t19 Nov 2019 03:43:34 -0800", "from ccdlinuxdev08.iil.intel.com ([143.185.161.150])\n\tby fmsmga004.fm.intel.com with ESMTP; 19 Nov 2019 03:43:33 -0800" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.68,322,1569308400\"; d=\"scan'208\";a=\"231504127\"", "From": "Sasha Neftin <sasha.neftin@intel.com>", "To": "intel-wired-lan@lists.osuosl.org", "Date": "Tue, 19 Nov 2019 13:43:32 +0200", "Message-Id": "<20191119114332.41655-1-sasha.neftin@intel.com>", "X-Mailer": "git-send-email 2.11.0", "Subject": "[Intel-wired-lan] [PATCH v1 01/15] igc: Remove no need declaration\n\tof the igc_clean_tx_ring", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "We want to avoid forward-declarations of function if possible.\nRearrange the igc_clean_tx_ring function implementation.\n\nSigned-off-by: Sasha Neftin <sasha.neftin@intel.com>\n---\n drivers/net/ethernet/intel/igc/igc_main.c | 75 +++++++++++++++----------------\n 1 file changed, 37 insertions(+), 38 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/igc/igc_main.c b/drivers/net/ethernet/intel/igc/igc_main.c\nindex ca7b8d6791f1..ed71d8bdf47d 100644\n--- a/drivers/net/ethernet/intel/igc/igc_main.c\n+++ b/drivers/net/ethernet/intel/igc/igc_main.c\n@@ -52,7 +52,6 @@ static const struct pci_device_id igc_pci_tbl[] = {\n MODULE_DEVICE_TABLE(pci, igc_pci_tbl);\n \n /* forward declaration */\n-static void igc_clean_tx_ring(struct igc_ring *tx_ring);\n static int igc_sw_init(struct igc_adapter *);\n static void igc_configure(struct igc_adapter *adapter);\n static void igc_power_down_link(struct igc_adapter *adapter);\n@@ -177,43 +176,6 @@ static void igc_get_hw_control(struct igc_adapter *adapter)\n }\n \n /**\n- * igc_free_tx_resources - Free Tx Resources per Queue\n- * @tx_ring: Tx descriptor ring for a specific queue\n- *\n- * Free all transmit software resources\n- */\n-void igc_free_tx_resources(struct igc_ring *tx_ring)\n-{\n-\tigc_clean_tx_ring(tx_ring);\n-\n-\tvfree(tx_ring->tx_buffer_info);\n-\ttx_ring->tx_buffer_info = NULL;\n-\n-\t/* if not set, then don't free */\n-\tif (!tx_ring->desc)\n-\t\treturn;\n-\n-\tdma_free_coherent(tx_ring->dev, tx_ring->size,\n-\t\t\t tx_ring->desc, tx_ring->dma);\n-\n-\ttx_ring->desc = NULL;\n-}\n-\n-/**\n- * igc_free_all_tx_resources - Free Tx Resources for All Queues\n- * @adapter: board private structure\n- *\n- * Free all transmit software resources\n- */\n-static void igc_free_all_tx_resources(struct igc_adapter *adapter)\n-{\n-\tint i;\n-\n-\tfor (i = 0; i < adapter->num_tx_queues; i++)\n-\t\tigc_free_tx_resources(adapter->tx_ring[i]);\n-}\n-\n-/**\n * igc_clean_tx_ring - Free Tx Buffers\n * @tx_ring: ring to be cleaned\n */\n@@ -275,6 +237,43 @@ static void igc_clean_tx_ring(struct igc_ring *tx_ring)\n }\n \n /**\n+ * igc_free_tx_resources - Free Tx Resources per Queue\n+ * @tx_ring: Tx descriptor ring for a specific queue\n+ *\n+ * Free all transmit software resources\n+ */\n+void igc_free_tx_resources(struct igc_ring *tx_ring)\n+{\n+\tigc_clean_tx_ring(tx_ring);\n+\n+\tvfree(tx_ring->tx_buffer_info);\n+\ttx_ring->tx_buffer_info = NULL;\n+\n+\t/* if not set, then don't free */\n+\tif (!tx_ring->desc)\n+\t\treturn;\n+\n+\tdma_free_coherent(tx_ring->dev, tx_ring->size,\n+\t\t\t tx_ring->desc, tx_ring->dma);\n+\n+\ttx_ring->desc = NULL;\n+}\n+\n+/**\n+ * igc_free_all_tx_resources - Free Tx Resources for All Queues\n+ * @adapter: board private structure\n+ *\n+ * Free all transmit software resources\n+ */\n+static void igc_free_all_tx_resources(struct igc_adapter *adapter)\n+{\n+\tint i;\n+\n+\tfor (i = 0; i < adapter->num_tx_queues; i++)\n+\t\tigc_free_tx_resources(adapter->tx_ring[i]);\n+}\n+\n+/**\n * igc_clean_all_tx_rings - Free Tx Buffers for all queues\n * @adapter: board private structure\n */\n", "prefixes": [ "v1", "01/15" ] }