Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/1194444/?format=api
{ "id": 1194444, "url": "http://patchwork.ozlabs.org/api/patches/1194444/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20191113192817.531297-1-jeffrey.t.kirsher@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20191113192817.531297-1-jeffrey.t.kirsher@intel.com>", "list_archive_url": null, "date": "2019-11-13T19:28:17", "name": "i40e: Fix virtchnl_queue_select bitmap validation", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "7cb25f7bb3aee70f930a0e8a484269edead8acaf", "submitter": { "id": 473, "url": "http://patchwork.ozlabs.org/api/people/473/?format=api", "name": "Kirsher, Jeffrey T", "email": "jeffrey.t.kirsher@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20191113192817.531297-1-jeffrey.t.kirsher@intel.com/mbox/", "series": [ { "id": 142682, "url": "http://patchwork.ozlabs.org/api/series/142682/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=142682", "date": "2019-11-13T19:28:17", "name": "i40e: Fix virtchnl_queue_select bitmap validation", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/142682/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/1194444/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/1194444/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": [ "ozlabs.org; spf=pass (sender SPF authorized)\n\tsmtp.mailfrom=osuosl.org (client-ip=140.211.166.136;\n\thelo=silver.osuosl.org;\n\tenvelope-from=intel-wired-lan-bounces@osuosl.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org;\n\tdmarc=fail (p=none dis=none) header.from=intel.com" ], "Received": [ "from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 47CvmB21Wxz9sP6\n\tfor <incoming@patchwork.ozlabs.org>;\n\tThu, 14 Nov 2019 06:28:26 +1100 (AEDT)", "from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id C390622803;\n\tWed, 13 Nov 2019 19:28:24 +0000 (UTC)", "from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id EzgfVZj0IQkv; Wed, 13 Nov 2019 19:28:22 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby silver.osuosl.org (Postfix) with ESMTP id 8A064227F8;\n\tWed, 13 Nov 2019 19:28:22 +0000 (UTC)", "from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\tby ash.osuosl.org (Postfix) with ESMTP id 0DEF71BF41B\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 13 Nov 2019 19:28:21 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 0261087F8E\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 13 Nov 2019 19:28:21 +0000 (UTC)", "from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id woads3EIlQCw for <intel-wired-lan@lists.osuosl.org>;\n\tWed, 13 Nov 2019 19:28:20 +0000 (UTC)", "from mga06.intel.com (mga06.intel.com [134.134.136.31])\n\tby hemlock.osuosl.org (Postfix) with ESMTPS id 2F3F88818E\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 13 Nov 2019 19:28:20 +0000 (UTC)", "from orsmga007.jf.intel.com ([10.7.209.58])\n\tby orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t13 Nov 2019 11:28:19 -0800", "from jtkirshe-desk1.jf.intel.com ([134.134.177.74])\n\tby orsmga007.jf.intel.com with ESMTP; 13 Nov 2019 11:28:19 -0800" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.68,301,1569308400\"; d=\"scan'208\";a=\"194777565\"", "From": "Jeff Kirsher <jeffrey.t.kirsher@intel.com>", "To": "intel-wired-lan@lists.osuosl.org", "Date": "Wed, 13 Nov 2019 11:28:17 -0800", "Message-Id": "<20191113192817.531297-1-jeffrey.t.kirsher@intel.com>", "X-Mailer": "git-send-email 2.23.0", "MIME-Version": "1.0", "Subject": "[Intel-wired-lan] [PATCH] i40e: Fix virtchnl_queue_select bitmap\n\tvalidation", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "Cc": "Brett Creeley <brett.creeley@intel.com>,\n\tArkady Gilinksky <arkady.gilinsky@harmonicinc.com>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "From: Brett Creeley <brett.creeley@intel.com>\n\nCurrently in i40e_vc_disable_queues_msg() we are incorrectly\nvalidating the virtchnl queue select bitmaps. The\nvirtchnl_queue_select rx_queues and tx_queue bitmap is being\ncompared against ICE_MAX_VF_QUEUES, but the problem is that\nthese bitmaps can have a value greater than I40E_MAX_VF_QUEUES.\nFix this by comparing the bitmaps against BIT(I40E_MAX_VF_QUEUES).\n\nAlso, add the function i40e_vc_validate_vqs_bitmaps() that checks to see\nif both virtchnl_queue_select bitmaps are empty along with checking that\nthe bitmaps only have valid bits set. This function can then be used in\nboth the queue enable and disable flows.\n\nSuggested-by: Arkady Gilinksky <arkady.gilinsky@harmonicinc.com>\nSigned-off-by: Brett Creeley <brett.creeley@intel.com>\n---\n .../ethernet/intel/i40e/i40e_virtchnl_pf.c | 22 +++++++++++++++----\n 1 file changed, 18 insertions(+), 4 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c b/drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c\nindex 6d75a35acb67..275702d8cf7a 100644\n--- a/drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c\n+++ b/drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c\n@@ -2321,6 +2321,22 @@ static int i40e_ctrl_vf_rx_rings(struct i40e_vsi *vsi, unsigned long q_map,\n \treturn ret;\n }\n \n+/**\n+ * i40e_vc_validate_vqs_bitmaps - validate Rx/Tx queue bitmaps from VIRTHCHNL\n+ * @vqs: virtchnl_queue_select structure containing bitmaps to validate\n+ *\n+ * Returns true if validation was successful, else false.\n+ */\n+static bool i40e_vc_validate_vqs_bitmaps(struct virtchnl_queue_select *vqs)\n+{\n+\tif ((!vqs->rx_queues && !vqs->tx_queues) ||\n+\t vqs->rx_queue >= BIT(I40E_MAX_VF_QUEUES) ||\n+\t vqs->tx_queue >= BIT(I40E_MAX_VF_QUEUES))\n+\t return false;\n+\n+\treturn true;\n+}\n+\n /**\n * i40e_vc_enable_queues_msg\n * @vf: pointer to the VF info\n@@ -2346,7 +2362,7 @@ static int i40e_vc_enable_queues_msg(struct i40e_vf *vf, u8 *msg)\n \t\tgoto error_param;\n \t}\n \n-\tif ((0 == vqs->rx_queues) && (0 == vqs->tx_queues)) {\n+\tif (i40e_vc_validate_vqs_bitmaps(vqs)) {\n \t\taq_ret = I40E_ERR_PARAM;\n \t\tgoto error_param;\n \t}\n@@ -2408,9 +2424,7 @@ static int i40e_vc_disable_queues_msg(struct i40e_vf *vf, u8 *msg)\n \t\tgoto error_param;\n \t}\n \n-\tif ((vqs->rx_queues == 0 && vqs->tx_queues == 0) ||\n-\t vqs->rx_queues > I40E_MAX_VF_QUEUES ||\n-\t vqs->tx_queues > I40E_MAX_VF_QUEUES) {\n+\tif (i40e_vc_validate_vqs_bitmaps(vqs)) {\n \t\taq_ret = I40E_ERR_PARAM;\n \t\tgoto error_param;\n \t}\n", "prefixes": [] }