Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/1193626/?format=api
{ "id": 1193626, "url": "http://patchwork.ozlabs.org/api/patches/1193626/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20191112151332.5893-1-sasha.neftin@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20191112151332.5893-1-sasha.neftin@intel.com>", "list_archive_url": null, "date": "2019-11-12T15:13:32", "name": "[v1] igc: Fix parameter descriptions for a several functions", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "4caa2971346a03f7c43006f4e27c7d6d02a08729", "submitter": { "id": 69860, "url": "http://patchwork.ozlabs.org/api/people/69860/?format=api", "name": "Sasha Neftin", "email": "sasha.neftin@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20191112151332.5893-1-sasha.neftin@intel.com/mbox/", "series": [ { "id": 142363, "url": "http://patchwork.ozlabs.org/api/series/142363/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=142363", "date": "2019-11-12T15:13:32", "name": "[v1] igc: Fix parameter descriptions for a several functions", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/142363/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/1193626/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/1193626/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": [ "ozlabs.org; spf=pass (sender SPF authorized)\n\tsmtp.mailfrom=osuosl.org (client-ip=140.211.166.136;\n\thelo=silver.osuosl.org;\n\tenvelope-from=intel-wired-lan-bounces@osuosl.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org;\n\tdmarc=fail (p=none dis=none) header.from=intel.com" ], "Received": [ "from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 47CB8n4j9Qz9sP4\n\tfor <incoming@patchwork.ozlabs.org>;\n\tWed, 13 Nov 2019 02:13:43 +1100 (AEDT)", "from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id 7CD4520390;\n\tTue, 12 Nov 2019 15:13:40 +0000 (UTC)", "from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id Ugi7426XAv1I; Tue, 12 Nov 2019 15:13:36 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby silver.osuosl.org (Postfix) with ESMTP id BC7CD20381;\n\tTue, 12 Nov 2019 15:13:36 +0000 (UTC)", "from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\tby ash.osuosl.org (Postfix) with ESMTP id 7EA6B1BF59D\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tTue, 12 Nov 2019 15:13:35 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 3E12E8731E\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tTue, 12 Nov 2019 15:13:35 +0000 (UTC)", "from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id 3Kw-c5L6Ttwo for <intel-wired-lan@lists.osuosl.org>;\n\tTue, 12 Nov 2019 15:13:34 +0000 (UTC)", "from mga01.intel.com (mga01.intel.com [192.55.52.88])\n\tby hemlock.osuosl.org (Postfix) with ESMTPS id 678A08533D\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tTue, 12 Nov 2019 15:13:34 +0000 (UTC)", "from fmsmga005.fm.intel.com ([10.253.24.32])\n\tby fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t12 Nov 2019 07:13:33 -0800", "from ccdlinuxdev08.iil.intel.com ([143.185.161.150])\n\tby fmsmga005.fm.intel.com with ESMTP; 12 Nov 2019 07:13:32 -0800" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.68,296,1569308400\"; d=\"scan'208\";a=\"404273404\"", "From": "Sasha Neftin <sasha.neftin@intel.com>", "To": "intel-wired-lan@lists.osuosl.org", "Date": "Tue, 12 Nov 2019 17:13:32 +0200", "Message-Id": "<20191112151332.5893-1-sasha.neftin@intel.com>", "X-Mailer": "git-send-email 2.11.0", "Subject": "[Intel-wired-lan] [PATCH v1] igc: Fix parameter descriptions for a\n\tseveral functions", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "igc_watchdog, igc_set_interrupt_capability, igc_init_interrupt_scheme,\n__igc_open and __igc_close parameter desriptions has not reflected\nfunctions meaning. Add meaningful description.\n\nSigned-off-by: Sasha Neftin <sasha.neftin@intel.com>\n---\n drivers/net/ethernet/intel/igc/igc_main.c | 10 +++++++---\n 1 file changed, 7 insertions(+), 3 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/igc/igc_main.c b/drivers/net/ethernet/intel/igc/igc_main.c\nindex 5d3023ea8a44..fe9edcce42e8 100644\n--- a/drivers/net/ethernet/intel/igc/igc_main.c\n+++ b/drivers/net/ethernet/intel/igc/igc_main.c\n@@ -3110,7 +3110,7 @@ bool igc_has_link(struct igc_adapter *adapter)\n \n /**\n * igc_watchdog - Timer Call-back\n- * @data: pointer to adapter cast into an unsigned long\n+ * @t: timer for the watchdog\n */\n static void igc_watchdog(struct timer_list *t)\n {\n@@ -3639,6 +3639,7 @@ static int igc_poll(struct napi_struct *napi, int budget)\n /**\n * igc_set_interrupt_capability - set MSI or MSI-X if supported\n * @adapter: Pointer to adapter structure\n+ * @msix: boolean value for MSI-X capability\n *\n * Attempt to configure interrupts using the best available\n * capabilities of the hardware and kernel.\n@@ -3907,6 +3908,7 @@ static void igc_cache_ring_register(struct igc_adapter *adapter)\n /**\n * igc_init_interrupt_scheme - initialize interrupts, allocate queues/vectors\n * @adapter: Pointer to adapter structure\n+ * @msix: boolean for MSI-X capability\n *\n * This function initializes the interrupts and allocates all of the queues.\n */\n@@ -4074,8 +4076,9 @@ static void igc_write_itr(struct igc_q_vector *q_vector)\n }\n \n /**\n- * igc_open - Called when a network interface is made active\n+ * __igc_open - Called when a network interface is made active\n * @netdev: network interface device structure\n+ * @resuming: boolean indicating if the device is resuming\n *\n * Returns 0 on success, negative value on failure\n *\n@@ -4165,8 +4168,9 @@ static int igc_open(struct net_device *netdev)\n }\n \n /**\n- * igc_close - Disables a network interface\n+ * __igc_close - Disables a network interface\n * @netdev: network interface device structure\n+ * @suspending: boolean indicating the device is suspending\n *\n * Returns 0, this is not allowed to fail\n *\n", "prefixes": [ "v1" ] }