Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/1192005/?format=api
{ "id": 1192005, "url": "http://patchwork.ozlabs.org/api/patches/1192005/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linuxppc-dev/patch/20191108130123.6839-45-linux@rasmusvillemoes.dk/", "project": { "id": 2, "url": "http://patchwork.ozlabs.org/api/projects/2/?format=api", "name": "Linux PPC development", "link_name": "linuxppc-dev", "list_id": "linuxppc-dev.lists.ozlabs.org", "list_email": "linuxppc-dev@lists.ozlabs.org", "web_url": "https://github.com/linuxppc/wiki/wiki", "scm_url": "https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git", "webscm_url": "https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git/", "list_archive_url": "https://lore.kernel.org/linuxppc-dev/", "list_archive_url_format": "https://lore.kernel.org/linuxppc-dev/{}/", "commit_url_format": "https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git/commit/?id={}" }, "msgid": "<20191108130123.6839-45-linux@rasmusvillemoes.dk>", "list_archive_url": "https://lore.kernel.org/linuxppc-dev/20191108130123.6839-45-linux@rasmusvillemoes.dk/", "date": "2019-11-08T13:01:20", "name": "[v4,44/47] net/wan/fsl_ucc_hdlc: fix reading of __be16 registers", "commit_ref": null, "pull_url": null, "state": "not-applicable", "archived": false, "hash": "dc943729d3209dab5476d6e61bc3d6fd26c4e497", "submitter": { "id": 27394, "url": "http://patchwork.ozlabs.org/api/people/27394/?format=api", "name": "Rasmus Villemoes", "email": "linux@rasmusvillemoes.dk" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/linuxppc-dev/patch/20191108130123.6839-45-linux@rasmusvillemoes.dk/mbox/", "series": [ { "id": 141654, "url": "http://patchwork.ozlabs.org/api/series/141654/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linuxppc-dev/list/?series=141654", "date": "2019-11-08T13:00:38", "name": "QUICC Engine support on ARM and ARM64", "version": 4, "mbox": "http://patchwork.ozlabs.org/series/141654/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/1192005/comments/", "check": "success", "checks": "http://patchwork.ozlabs.org/api/patches/1192005/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org>", "X-Original-To": [ "patchwork-incoming@ozlabs.org", "linuxppc-dev@lists.ozlabs.org" ], "Delivered-To": [ "patchwork-incoming@ozlabs.org", "linuxppc-dev@lists.ozlabs.org" ], "Received": [ "from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\tkey-exchange X25519 server-signature RSA-PSS (4096 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 478kxd4Xr1z9sNT\n\tfor <patchwork-incoming@ozlabs.org>;\n\tSat, 9 Nov 2019 02:40:37 +1100 (AEDT)", "from bilbo.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 478kxd3C2MzF6yj\n\tfor <patchwork-incoming@ozlabs.org>;\n\tSat, 9 Nov 2019 02:40:37 +1100 (AEDT)", "from mail-lf1-x141.google.com (mail-lf1-x141.google.com\n\t[IPv6:2a00:1450:4864:20::141])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\tkey-exchange X25519 server-signature RSA-PSS (2048 bits)\n\tserver-digest SHA256) (No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 478gR60q6KzF6qp\n\tfor <linuxppc-dev@lists.ozlabs.org>;\n\tSat, 9 Nov 2019 00:02:26 +1100 (AEDT)", "by mail-lf1-x141.google.com with SMTP id y6so4423518lfj.2\n\tfor <linuxppc-dev@lists.ozlabs.org>;\n\tFri, 08 Nov 2019 05:02:25 -0800 (PST)", "from prevas-ravi.prevas.se ([81.216.59.226])\n\tby smtp.gmail.com with ESMTPSA id\n\td28sm2454725lfn.33.2019.11.08.05.02.21\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tFri, 08 Nov 2019 05:02:22 -0800 (PST)" ], "Authentication-Results": [ "ozlabs.org; dmarc=none (p=none dis=none)\n\theader.from=rasmusvillemoes.dk", "ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=rasmusvillemoes.dk header.i=@rasmusvillemoes.dk\n\theader.b=\"fbtFc25Q\"; dkim-atps=neutral", "lists.ozlabs.org; spf=pass (sender SPF authorized)\n\tsmtp.mailfrom=rasmusvillemoes.dk (client-ip=2a00:1450:4864:20::141;\n\thelo=mail-lf1-x141.google.com; envelope-from=linux@rasmusvillemoes.dk;\n\treceiver=<UNKNOWN>)", "lists.ozlabs.org; dmarc=none (p=none dis=none)\n\theader.from=rasmusvillemoes.dk", "lists.ozlabs.org; dkim=pass (1024-bit key;\n\tunprotected) header.d=rasmusvillemoes.dk header.i=@rasmusvillemoes.dk\n\theader.b=\"fbtFc25Q\"; dkim-atps=neutral" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=rasmusvillemoes.dk; s=google;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=SKjk4xtgUQ/kA6JZGPtMJVtONpNy6V4lFIeGBwHjI8g=;\n\tb=fbtFc25QQKF1HYy9EJWgNQgGlj4NvVM/SZQzlg+mehsa55gfaar01ZvOzQEFiHiJS8\n\tNIWL01E4b4KculB+YonomNkzR6/ye1LnowBIkbJ9/0ahn29mzO+PzUdzYz/FKdLUGozG\n\t3Bl1Mlzo2VusjD/D//znojGiimZguwgG2m4r0=", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=SKjk4xtgUQ/kA6JZGPtMJVtONpNy6V4lFIeGBwHjI8g=;\n\tb=I0fBpwunk1XiAhqnb9rAd9BxInJDNWmxQL+SUSv36dT54RnZSCL77wecXDfhiZqwZn\n\tgtL6inHJlanUOs+l4sfF5jj4O5JS9K8LjP16HP+IjFMdIht8Ky9yr42fj2h1TWpR+EU5\n\tT7smWNRyDjo+LLayoJe/7qwk9ww8WtWLbCoVb77Cd7FAT7dMi+W9JG1UWJRHPVCXLKH6\n\tNByycgFq6XW3E+A/4g4AfmZJbqenpdYYUlC1xkic+F3eIrdQHjQGkliKcAopCB0Aemyn\n\tUq8Vbks6IG70nfgTFFtLBzEl0uhYOg4TzlgAPRCK/GXSnuDP6Hs9FFNgzM9HWjM4zHXE\n\t/DIQ==", "X-Gm-Message-State": "APjAAAVghvqSDwVJi3bvgRfpuaULUhNyrI0kAkLgI9Ve9KsB4cQBpELn\n\t59iKWv/W6iKzCJGO9S2JwuPypQ==", "X-Google-Smtp-Source": "APXvYqwH4Au0vtX7CvDcjAgRV7H9RHuuGAfZs53rG3gF/CjSF6Puxm/KMJghDcukVOdVzQRBjC2v/w==", "X-Received": "by 2002:a19:f107:: with SMTP id p7mr6505066lfh.91.1573218142811; \n\tFri, 08 Nov 2019 05:02:22 -0800 (PST)", "From": "Rasmus Villemoes <linux@rasmusvillemoes.dk>", "To": "Qiang Zhao <qiang.zhao@nxp.com>, Li Yang <leoyang.li@nxp.com>,\n\tChristophe Leroy <christophe.leroy@c-s.fr>", "Subject": "[PATCH v4 44/47] net/wan/fsl_ucc_hdlc: fix reading of __be16\n\tregisters", "Date": "Fri, 8 Nov 2019 14:01:20 +0100", "Message-Id": "<20191108130123.6839-45-linux@rasmusvillemoes.dk>", "X-Mailer": "git-send-email 2.23.0", "In-Reply-To": "<20191108130123.6839-1-linux@rasmusvillemoes.dk>", "References": "<20191108130123.6839-1-linux@rasmusvillemoes.dk>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "linuxppc-dev@lists.ozlabs.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "Linux on PowerPC Developers Mail List\n\t<linuxppc-dev.lists.ozlabs.org>", "List-Unsubscribe": "<https://lists.ozlabs.org/options/linuxppc-dev>,\n\t<mailto:linuxppc-dev-request@lists.ozlabs.org?subject=unsubscribe>", "List-Archive": "<http://lists.ozlabs.org/pipermail/linuxppc-dev/>", "List-Post": "<mailto:linuxppc-dev@lists.ozlabs.org>", "List-Help": "<mailto:linuxppc-dev-request@lists.ozlabs.org?subject=help>", "List-Subscribe": "<https://lists.ozlabs.org/listinfo/linuxppc-dev>,\n\t<mailto:linuxppc-dev-request@lists.ozlabs.org?subject=subscribe>", "Cc": "netdev@vger.kernel.org, Rasmus Villemoes <linux@rasmusvillemoes.dk>,\n\tlinux-kernel@vger.kernel.org, Scott Wood <oss@buserror.net>,\n\tlinuxppc-dev@lists.ozlabs.org, linux-arm-kernel@lists.infradead.org", "Errors-To": "linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org", "Sender": "\"Linuxppc-dev\"\n\t<linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org>" }, "content": "When releasing the allocated muram resource, we rely on reading back\nthe offsets from the riptr/tiptr registers. But those registers are\n__be16 (and we indeed write them using iowrite16be), so we can't just\nread them back with a normal C dereference.\n\nThis is not currently a real problem, since for now the driver is\nPPC32-only. But it will soon be allowed to be used on arm and arm64 as\nwell.\n\nSigned-off-by: Rasmus Villemoes <linux@rasmusvillemoes.dk>\n---\n drivers/net/wan/fsl_ucc_hdlc.c | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)", "diff": "diff --git a/drivers/net/wan/fsl_ucc_hdlc.c b/drivers/net/wan/fsl_ucc_hdlc.c\nindex 405b24a5a60d..8d13586bb774 100644\n--- a/drivers/net/wan/fsl_ucc_hdlc.c\n+++ b/drivers/net/wan/fsl_ucc_hdlc.c\n@@ -732,8 +732,8 @@ static int uhdlc_open(struct net_device *dev)\n \n static void uhdlc_memclean(struct ucc_hdlc_private *priv)\n {\n-\tqe_muram_free(priv->ucc_pram->riptr);\n-\tqe_muram_free(priv->ucc_pram->tiptr);\n+\tqe_muram_free(ioread16be(&priv->ucc_pram->riptr));\n+\tqe_muram_free(ioread16be(&priv->ucc_pram->tiptr));\n \n \tif (priv->rx_bd_base) {\n \t\tdma_free_coherent(priv->dev,\n", "prefixes": [ "v4", "44/47" ] }