Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/1192004/?format=api
{ "id": 1192004, "url": "http://patchwork.ozlabs.org/api/patches/1192004/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linuxppc-dev/patch/20191108130123.6839-44-linux@rasmusvillemoes.dk/", "project": { "id": 2, "url": "http://patchwork.ozlabs.org/api/projects/2/?format=api", "name": "Linux PPC development", "link_name": "linuxppc-dev", "list_id": "linuxppc-dev.lists.ozlabs.org", "list_email": "linuxppc-dev@lists.ozlabs.org", "web_url": "https://github.com/linuxppc/wiki/wiki", "scm_url": "https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git", "webscm_url": "https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git/", "list_archive_url": "https://lore.kernel.org/linuxppc-dev/", "list_archive_url_format": "https://lore.kernel.org/linuxppc-dev/{}/", "commit_url_format": "https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git/commit/?id={}" }, "msgid": "<20191108130123.6839-44-linux@rasmusvillemoes.dk>", "list_archive_url": "https://lore.kernel.org/linuxppc-dev/20191108130123.6839-44-linux@rasmusvillemoes.dk/", "date": "2019-11-08T13:01:19", "name": "[v4,43/47] net/wan/fsl_ucc_hdlc: avoid use of IS_ERR_VALUE()", "commit_ref": null, "pull_url": null, "state": "not-applicable", "archived": false, "hash": "c36ab282693d1853dc1794607b1bee6c008d65e2", "submitter": { "id": 27394, "url": "http://patchwork.ozlabs.org/api/people/27394/?format=api", "name": "Rasmus Villemoes", "email": "linux@rasmusvillemoes.dk" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/linuxppc-dev/patch/20191108130123.6839-44-linux@rasmusvillemoes.dk/mbox/", "series": [ { "id": 141654, "url": "http://patchwork.ozlabs.org/api/series/141654/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linuxppc-dev/list/?series=141654", "date": "2019-11-08T13:00:38", "name": "QUICC Engine support on ARM and ARM64", "version": 4, "mbox": "http://patchwork.ozlabs.org/series/141654/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/1192004/comments/", "check": "success", "checks": "http://patchwork.ozlabs.org/api/patches/1192004/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org>", "X-Original-To": [ "patchwork-incoming@ozlabs.org", "linuxppc-dev@lists.ozlabs.org" ], "Delivered-To": [ "patchwork-incoming@ozlabs.org", "linuxppc-dev@lists.ozlabs.org" ], "Received": [ "from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\tkey-exchange X25519 server-signature RSA-PSS (4096 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 478ktf56PSz9sP3\n\tfor <patchwork-incoming@ozlabs.org>;\n\tSat, 9 Nov 2019 02:38:02 +1100 (AEDT)", "from bilbo.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 478ktf3kyszDqYh\n\tfor <patchwork-incoming@ozlabs.org>;\n\tSat, 9 Nov 2019 02:38:02 +1100 (AEDT)", "from mail-lf1-x143.google.com (mail-lf1-x143.google.com\n\t[IPv6:2a00:1450:4864:20::143])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\tkey-exchange X25519 server-signature RSA-PSS (2048 bits)\n\tserver-digest SHA256) (No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 478gR51H0LzF6qp\n\tfor <linuxppc-dev@lists.ozlabs.org>;\n\tSat, 9 Nov 2019 00:02:25 +1100 (AEDT)", "by mail-lf1-x143.google.com with SMTP id j14so4395340lfb.8\n\tfor <linuxppc-dev@lists.ozlabs.org>;\n\tFri, 08 Nov 2019 05:02:24 -0800 (PST)", "from prevas-ravi.prevas.se ([81.216.59.226])\n\tby smtp.gmail.com with ESMTPSA id\n\td28sm2454725lfn.33.2019.11.08.05.02.20\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tFri, 08 Nov 2019 05:02:21 -0800 (PST)" ], "Authentication-Results": [ "ozlabs.org; dmarc=none (p=none dis=none)\n\theader.from=rasmusvillemoes.dk", "ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=rasmusvillemoes.dk header.i=@rasmusvillemoes.dk\n\theader.b=\"XGWfSCSU\"; dkim-atps=neutral", "lists.ozlabs.org; spf=pass (sender SPF authorized)\n\tsmtp.mailfrom=rasmusvillemoes.dk (client-ip=2a00:1450:4864:20::143;\n\thelo=mail-lf1-x143.google.com; envelope-from=linux@rasmusvillemoes.dk;\n\treceiver=<UNKNOWN>)", "lists.ozlabs.org; dmarc=none (p=none dis=none)\n\theader.from=rasmusvillemoes.dk", "lists.ozlabs.org; dkim=pass (1024-bit key;\n\tunprotected) header.d=rasmusvillemoes.dk header.i=@rasmusvillemoes.dk\n\theader.b=\"XGWfSCSU\"; dkim-atps=neutral" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=rasmusvillemoes.dk; s=google;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=IVdoGLW+H0ZKnJRayTBX6GqWyaD6YHKGaBDMMFO7/WI=;\n\tb=XGWfSCSUEAVnpUU/P6J3Qpi258NYlF3UJQSunn16SlUdmsp2q+W8Bk2e/nwHBQtUA0\n\tfTuY1Ravcq9bFl1d3rl/f799vNBuCYFEgPCX2t9OqCPlkEeIvRZyKcQb8orXRDyeqpLG\n\tr3uSJRO/BS/Xt5o6Y8WDp/Fl9289KO+LrOKYM=", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=IVdoGLW+H0ZKnJRayTBX6GqWyaD6YHKGaBDMMFO7/WI=;\n\tb=VdUQ8H+akBvK6wI0EfOguXn++yek6K2MxNk9tSdLNl1AWKiOZk/x3VO7FgA6dgR1n0\n\tPic6mbk/Ojp02Xsq+X6cJITVecYXUPGTrZd0qHPrVZqk0nJ02mP5aLUsZVwcf27sxCMC\n\t4aYaQM108wBhVsT0F4ne0beU0wV8GfCviWJoA6N2UX+pEYMhsDD7wA6je66FM3mZ5xCn\n\tB4Ayd/JM9dGbZO6auzEIfLMMx3yVi03p6uVeWIE/ABpniwuuRD0+Rc/TccPq1q1OBVcZ\n\tS5fjK4M8EWRO+ndUUNCq3bRSL7el12/zQ6h+z9QWvZMP0aHHAGv7A0Nt/2eqA4bmH/ZV\n\tIC7A==", "X-Gm-Message-State": "APjAAAU4AvFdoLHwSxY6m6ZT5fF9tlXNbQ4cp1I9B8HzHD8HX4vAOIGM\n\tXSmbTMXHkQy4oVUKFeM0AfuvqA==", "X-Google-Smtp-Source": "APXvYqwfxfaitvaPMgKPzDm4mZzVxujIi4YRrNIWmv3dBUm4XchC7Z1ld8b5BxN/rmHZMQ6u7CZ4hg==", "X-Received": "by 2002:a19:148:: with SMTP id 69mr6994219lfb.76.1573218141700; \n\tFri, 08 Nov 2019 05:02:21 -0800 (PST)", "From": "Rasmus Villemoes <linux@rasmusvillemoes.dk>", "To": "Qiang Zhao <qiang.zhao@nxp.com>, Li Yang <leoyang.li@nxp.com>,\n\tChristophe Leroy <christophe.leroy@c-s.fr>", "Subject": "[PATCH v4 43/47] net/wan/fsl_ucc_hdlc: avoid use of IS_ERR_VALUE()", "Date": "Fri, 8 Nov 2019 14:01:19 +0100", "Message-Id": "<20191108130123.6839-44-linux@rasmusvillemoes.dk>", "X-Mailer": "git-send-email 2.23.0", "In-Reply-To": "<20191108130123.6839-1-linux@rasmusvillemoes.dk>", "References": "<20191108130123.6839-1-linux@rasmusvillemoes.dk>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "linuxppc-dev@lists.ozlabs.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "Linux on PowerPC Developers Mail List\n\t<linuxppc-dev.lists.ozlabs.org>", "List-Unsubscribe": "<https://lists.ozlabs.org/options/linuxppc-dev>,\n\t<mailto:linuxppc-dev-request@lists.ozlabs.org?subject=unsubscribe>", "List-Archive": "<http://lists.ozlabs.org/pipermail/linuxppc-dev/>", "List-Post": "<mailto:linuxppc-dev@lists.ozlabs.org>", "List-Help": "<mailto:linuxppc-dev-request@lists.ozlabs.org?subject=help>", "List-Subscribe": "<https://lists.ozlabs.org/listinfo/linuxppc-dev>,\n\t<mailto:linuxppc-dev-request@lists.ozlabs.org?subject=subscribe>", "Cc": "netdev@vger.kernel.org, Rasmus Villemoes <linux@rasmusvillemoes.dk>,\n\tlinux-kernel@vger.kernel.org, Scott Wood <oss@buserror.net>,\n\tlinuxppc-dev@lists.ozlabs.org, linux-arm-kernel@lists.infradead.org", "Errors-To": "linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org", "Sender": "\"Linuxppc-dev\"\n\t<linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org>" }, "content": "When building this on a 64-bit platform gcc rightly warns that the\nerror checking is broken (-ENOMEM stored in an u32 does not compare\ngreater than (unsigned long)-MAX_ERRNO). Instead, now that\nqe_muram_alloc() returns s32, use that type to store the return value\nand use standard kernel style \"ret < 0\".\n\nSigned-off-by: Rasmus Villemoes <linux@rasmusvillemoes.dk>\n---\n drivers/net/wan/fsl_ucc_hdlc.c | 10 +++++-----\n drivers/net/wan/fsl_ucc_hdlc.h | 2 +-\n 2 files changed, 6 insertions(+), 6 deletions(-)", "diff": "diff --git a/drivers/net/wan/fsl_ucc_hdlc.c b/drivers/net/wan/fsl_ucc_hdlc.c\nindex ce6af7d5380f..405b24a5a60d 100644\n--- a/drivers/net/wan/fsl_ucc_hdlc.c\n+++ b/drivers/net/wan/fsl_ucc_hdlc.c\n@@ -84,8 +84,8 @@ static int uhdlc_init(struct ucc_hdlc_private *priv)\n \tint ret, i;\n \tvoid *bd_buffer;\n \tdma_addr_t bd_dma_addr;\n-\tu32 riptr;\n-\tu32 tiptr;\n+\ts32 riptr;\n+\ts32 tiptr;\n \tu32 gumr;\n \n \tut_info = priv->ut_info;\n@@ -195,7 +195,7 @@ static int uhdlc_init(struct ucc_hdlc_private *priv)\n \tpriv->ucc_pram_offset = qe_muram_alloc(sizeof(struct ucc_hdlc_param),\n \t\t\t\tALIGNMENT_OF_UCC_HDLC_PRAM);\n \n-\tif (IS_ERR_VALUE(priv->ucc_pram_offset)) {\n+\tif (priv->ucc_pram_offset < 0) {\n \t\tdev_err(priv->dev, \"Can not allocate MURAM for hdlc parameter.\\n\");\n \t\tret = -ENOMEM;\n \t\tgoto free_tx_bd;\n@@ -233,14 +233,14 @@ static int uhdlc_init(struct ucc_hdlc_private *priv)\n \n \t/* Alloc riptr, tiptr */\n \triptr = qe_muram_alloc(32, 32);\n-\tif (IS_ERR_VALUE(riptr)) {\n+\tif (riptr < 0) {\n \t\tdev_err(priv->dev, \"Cannot allocate MURAM mem for Receive internal temp data pointer\\n\");\n \t\tret = -ENOMEM;\n \t\tgoto free_tx_skbuff;\n \t}\n \n \ttiptr = qe_muram_alloc(32, 32);\n-\tif (IS_ERR_VALUE(tiptr)) {\n+\tif (tiptr < 0) {\n \t\tdev_err(priv->dev, \"Cannot allocate MURAM mem for Transmit internal temp data pointer\\n\");\n \t\tret = -ENOMEM;\n \t\tgoto free_riptr;\ndiff --git a/drivers/net/wan/fsl_ucc_hdlc.h b/drivers/net/wan/fsl_ucc_hdlc.h\nindex 8b3507ae1781..71d5ad0a7b98 100644\n--- a/drivers/net/wan/fsl_ucc_hdlc.h\n+++ b/drivers/net/wan/fsl_ucc_hdlc.h\n@@ -98,7 +98,7 @@ struct ucc_hdlc_private {\n \n \tunsigned short tx_ring_size;\n \tunsigned short rx_ring_size;\n-\tu32 ucc_pram_offset;\n+\ts32 ucc_pram_offset;\n \n \tunsigned short encoding;\n \tunsigned short parity;\n", "prefixes": [ "v4", "43/47" ] }