Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/1191961/?format=api
{ "id": 1191961, "url": "http://patchwork.ozlabs.org/api/patches/1191961/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linuxppc-dev/patch/20191108130123.6839-36-linux@rasmusvillemoes.dk/", "project": { "id": 2, "url": "http://patchwork.ozlabs.org/api/projects/2/?format=api", "name": "Linux PPC development", "link_name": "linuxppc-dev", "list_id": "linuxppc-dev.lists.ozlabs.org", "list_email": "linuxppc-dev@lists.ozlabs.org", "web_url": "https://github.com/linuxppc/wiki/wiki", "scm_url": "https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git", "webscm_url": "https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git/", "list_archive_url": "https://lore.kernel.org/linuxppc-dev/", "list_archive_url_format": "https://lore.kernel.org/linuxppc-dev/{}/", "commit_url_format": "https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git/commit/?id={}" }, "msgid": "<20191108130123.6839-36-linux@rasmusvillemoes.dk>", "list_archive_url": "https://lore.kernel.org/linuxppc-dev/20191108130123.6839-36-linux@rasmusvillemoes.dk/", "date": "2019-11-08T13:01:11", "name": "[v4,35/47] soc: fsl: qe: make cpm_muram_free() return void", "commit_ref": null, "pull_url": null, "state": "not-applicable", "archived": false, "hash": "5a94ff30045adb5fa5d6944d4fb85d5f4e498271", "submitter": { "id": 27394, "url": "http://patchwork.ozlabs.org/api/people/27394/?format=api", "name": "Rasmus Villemoes", "email": "linux@rasmusvillemoes.dk" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/linuxppc-dev/patch/20191108130123.6839-36-linux@rasmusvillemoes.dk/mbox/", "series": [ { "id": 141654, "url": "http://patchwork.ozlabs.org/api/series/141654/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linuxppc-dev/list/?series=141654", "date": "2019-11-08T13:00:38", "name": "QUICC Engine support on ARM and ARM64", "version": 4, "mbox": "http://patchwork.ozlabs.org/series/141654/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/1191961/comments/", "check": "success", "checks": "http://patchwork.ozlabs.org/api/patches/1191961/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org>", "X-Original-To": [ "patchwork-incoming@ozlabs.org", "linuxppc-dev@lists.ozlabs.org" ], "Delivered-To": [ "patchwork-incoming@ozlabs.org", "linuxppc-dev@lists.ozlabs.org" ], "Received": [ "from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\tkey-exchange X25519 server-signature RSA-PSS (4096 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 478kJ356GFz9sNT\n\tfor <patchwork-incoming@ozlabs.org>;\n\tSat, 9 Nov 2019 02:11:31 +1100 (AEDT)", "from bilbo.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 478kJ32CqkzF7RP\n\tfor <patchwork-incoming@ozlabs.org>;\n\tSat, 9 Nov 2019 02:11:31 +1100 (AEDT)", "from mail-lj1-x242.google.com (mail-lj1-x242.google.com\n\t[IPv6:2a00:1450:4864:20::242])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\tkey-exchange X25519 server-signature RSA-PSS (2048 bits)\n\tserver-digest SHA256) (No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 478gQv6dKxzF6tB\n\tfor <linuxppc-dev@lists.ozlabs.org>;\n\tSat, 9 Nov 2019 00:02:15 +1100 (AEDT)", "by mail-lj1-x242.google.com with SMTP id e9so6091326ljp.13\n\tfor <linuxppc-dev@lists.ozlabs.org>;\n\tFri, 08 Nov 2019 05:02:15 -0800 (PST)", "from prevas-ravi.prevas.se ([81.216.59.226])\n\tby smtp.gmail.com with ESMTPSA id\n\td28sm2454725lfn.33.2019.11.08.05.02.11\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tFri, 08 Nov 2019 05:02:11 -0800 (PST)" ], "Authentication-Results": [ "ozlabs.org; dmarc=none (p=none dis=none)\n\theader.from=rasmusvillemoes.dk", "ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=rasmusvillemoes.dk header.i=@rasmusvillemoes.dk\n\theader.b=\"fk496dIk\"; dkim-atps=neutral", "lists.ozlabs.org; spf=pass (sender SPF authorized)\n\tsmtp.mailfrom=rasmusvillemoes.dk (client-ip=2a00:1450:4864:20::242;\n\thelo=mail-lj1-x242.google.com; envelope-from=linux@rasmusvillemoes.dk;\n\treceiver=<UNKNOWN>)", "lists.ozlabs.org; dmarc=none (p=none dis=none)\n\theader.from=rasmusvillemoes.dk", "lists.ozlabs.org; dkim=pass (1024-bit key;\n\tunprotected) header.d=rasmusvillemoes.dk header.i=@rasmusvillemoes.dk\n\theader.b=\"fk496dIk\"; dkim-atps=neutral" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=rasmusvillemoes.dk; s=google;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=SSxgB5KIjK5mxonoS/fefEEoV3TflMkJtsEIHhJIAiQ=;\n\tb=fk496dIkjJfWH0puX1BW4RjJCK7c9+JJhG6U1/TBsTulBpHSVx/cGc7sFqAR1iTMdP\n\t3zAZ/TuYQluQEe1pVxIJkHHxw9OOzJCOlbYv+gbMR/iAwaLh7N8FW415kYYBe+C4WJ5A\n\t/Kx/gFiuFB5pPYGCEIG3XIPCX/uSVcJG6J9u4=", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=SSxgB5KIjK5mxonoS/fefEEoV3TflMkJtsEIHhJIAiQ=;\n\tb=Ix34uBJkpjHfHCAB4OmTMq92pE2t7ugqi+dk9/kRU8a1kt8pNy1qzhpjDvgdwojjCB\n\tY8aR1QzqmUNtQ8p0uafEqL6gykM2L47hEKR4eMvCxLi5F2fA1LU6S+sbWFxhAxlqNiWR\n\tzTzhoXSxlcqGelxuSavdJs0Kp+fIM2MrApBJ0301gZ3okEA74FywGbJIhDs4NuzT3xoy\n\ti1ERJK2Oj+3i7F1S18ouqqLrmBKp2DPkJotjyFc1RPZ50FT++lzpSf+YCeaJcsnxI004\n\tsfCS/vvCjLDeoMEvS5vnADyEbNblUiA8AtC5+f6su7ea82TsUE+Y6Bm/LkKmFyTCc3EH\n\tIuPQ==", "X-Gm-Message-State": "APjAAAXxnsRNZ2I0LTchu197VVjc70JRakQ5Cyru64CbfmSsx70FUzoo\n\t3U9/wuY00fsmfA1mIW7HSnjmPg==", "X-Google-Smtp-Source": "APXvYqyN3aQ4nQtTkau8BsbSSPycHGak0w9LA6qtdzQsU05epYq+dRlpxU2naE9iUDHNYf8Cdc+Wdg==", "X-Received": "by 2002:a2e:98c6:: with SMTP id s6mr6115616ljj.235.1573218132535;\n\tFri, 08 Nov 2019 05:02:12 -0800 (PST)", "From": "Rasmus Villemoes <linux@rasmusvillemoes.dk>", "To": "Qiang Zhao <qiang.zhao@nxp.com>, Li Yang <leoyang.li@nxp.com>,\n\tChristophe Leroy <christophe.leroy@c-s.fr>", "Subject": "[PATCH v4 35/47] soc: fsl: qe: make cpm_muram_free() return void", "Date": "Fri, 8 Nov 2019 14:01:11 +0100", "Message-Id": "<20191108130123.6839-36-linux@rasmusvillemoes.dk>", "X-Mailer": "git-send-email 2.23.0", "In-Reply-To": "<20191108130123.6839-1-linux@rasmusvillemoes.dk>", "References": "<20191108130123.6839-1-linux@rasmusvillemoes.dk>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "linuxppc-dev@lists.ozlabs.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "Linux on PowerPC Developers Mail List\n\t<linuxppc-dev.lists.ozlabs.org>", "List-Unsubscribe": "<https://lists.ozlabs.org/options/linuxppc-dev>,\n\t<mailto:linuxppc-dev-request@lists.ozlabs.org?subject=unsubscribe>", "List-Archive": "<http://lists.ozlabs.org/pipermail/linuxppc-dev/>", "List-Post": "<mailto:linuxppc-dev@lists.ozlabs.org>", "List-Help": "<mailto:linuxppc-dev-request@lists.ozlabs.org?subject=help>", "List-Subscribe": "<https://lists.ozlabs.org/listinfo/linuxppc-dev>,\n\t<mailto:linuxppc-dev-request@lists.ozlabs.org?subject=subscribe>", "Cc": "Scott Wood <oss@buserror.net>,\n\tRasmus Villemoes <linux@rasmusvillemoes.dk>, \n\tlinuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org,\n\tlinux-arm-kernel@lists.infradead.org", "Errors-To": "linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org", "Sender": "\"Linuxppc-dev\"\n\t<linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org>" }, "content": "Nobody uses the return value from cpm_muram_free, and functions that\nfree resources usually return void. One could imagine a use for a \"how\nmuch have I allocated\" a la ksize(), but knowing how much one had\naccess to after the fact is useless.\n\nSigned-off-by: Rasmus Villemoes <linux@rasmusvillemoes.dk>\n---\n drivers/soc/fsl/qe/qe_common.c | 3 +--\n include/soc/fsl/qe/qe.h | 5 ++---\n 2 files changed, 3 insertions(+), 5 deletions(-)", "diff": "diff --git a/drivers/soc/fsl/qe/qe_common.c b/drivers/soc/fsl/qe/qe_common.c\nindex 50be59678903..ea9bef1d2c77 100644\n--- a/drivers/soc/fsl/qe/qe_common.c\n+++ b/drivers/soc/fsl/qe/qe_common.c\n@@ -170,7 +170,7 @@ EXPORT_SYMBOL(cpm_muram_alloc);\n * cpm_muram_free - free a chunk of multi-user ram\n * @offset: The beginning of the chunk as returned by cpm_muram_alloc().\n */\n-int cpm_muram_free(s32 offset)\n+void cpm_muram_free(s32 offset)\n {\n \tunsigned long flags;\n \tint size;\n@@ -188,7 +188,6 @@ int cpm_muram_free(s32 offset)\n \t}\n \tgen_pool_free(muram_pool, offset + GENPOOL_OFFSET, size);\n \tspin_unlock_irqrestore(&cpm_muram_lock, flags);\n-\treturn size;\n }\n EXPORT_SYMBOL(cpm_muram_free);\n \ndiff --git a/include/soc/fsl/qe/qe.h b/include/soc/fsl/qe/qe.h\nindex f589ae3f1216..e282ac01ec08 100644\n--- a/include/soc/fsl/qe/qe.h\n+++ b/include/soc/fsl/qe/qe.h\n@@ -99,7 +99,7 @@ int cpm_muram_init(void);\n \n #if defined(CONFIG_CPM) || defined(CONFIG_QUICC_ENGINE)\n s32 cpm_muram_alloc(unsigned long size, unsigned long align);\n-int cpm_muram_free(s32 offset);\n+void cpm_muram_free(s32 offset);\n s32 cpm_muram_alloc_fixed(unsigned long offset, unsigned long size);\n void __iomem *cpm_muram_addr(unsigned long offset);\n unsigned long cpm_muram_offset(void __iomem *addr);\n@@ -111,9 +111,8 @@ static inline s32 cpm_muram_alloc(unsigned long size,\n \treturn -ENOSYS;\n }\n \n-static inline int cpm_muram_free(s32 offset)\n+static inline void cpm_muram_free(s32 offset)\n {\n-\treturn -ENOSYS;\n }\n \n static inline s32 cpm_muram_alloc_fixed(unsigned long offset,\n", "prefixes": [ "v4", "35/47" ] }