Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/1191909/?format=api
{ "id": 1191909, "url": "http://patchwork.ozlabs.org/api/patches/1191909/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linuxppc-dev/patch/20191108130123.6839-19-linux@rasmusvillemoes.dk/", "project": { "id": 2, "url": "http://patchwork.ozlabs.org/api/projects/2/?format=api", "name": "Linux PPC development", "link_name": "linuxppc-dev", "list_id": "linuxppc-dev.lists.ozlabs.org", "list_email": "linuxppc-dev@lists.ozlabs.org", "web_url": "https://github.com/linuxppc/wiki/wiki", "scm_url": "https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git", "webscm_url": "https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git/", "list_archive_url": "https://lore.kernel.org/linuxppc-dev/", "list_archive_url_format": "https://lore.kernel.org/linuxppc-dev/{}/", "commit_url_format": "https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git/commit/?id={}" }, "msgid": "<20191108130123.6839-19-linux@rasmusvillemoes.dk>", "list_archive_url": "https://lore.kernel.org/linuxppc-dev/20191108130123.6839-19-linux@rasmusvillemoes.dk/", "date": "2019-11-08T13:00:54", "name": "[v4,18/47] soc: fsl: qe: don't use NO_IRQ in qe_ic.c", "commit_ref": null, "pull_url": null, "state": "not-applicable", "archived": false, "hash": "c0d39253c622b899d1837cd70fa9e30bc3ac89d9", "submitter": { "id": 27394, "url": "http://patchwork.ozlabs.org/api/people/27394/?format=api", "name": "Rasmus Villemoes", "email": "linux@rasmusvillemoes.dk" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/linuxppc-dev/patch/20191108130123.6839-19-linux@rasmusvillemoes.dk/mbox/", "series": [ { "id": 141654, "url": "http://patchwork.ozlabs.org/api/series/141654/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linuxppc-dev/list/?series=141654", "date": "2019-11-08T13:00:38", "name": "QUICC Engine support on ARM and ARM64", "version": 4, "mbox": "http://patchwork.ozlabs.org/series/141654/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/1191909/comments/", "check": "success", "checks": "http://patchwork.ozlabs.org/api/patches/1191909/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org>", "X-Original-To": [ "patchwork-incoming@ozlabs.org", "linuxppc-dev@lists.ozlabs.org" ], "Delivered-To": [ "patchwork-incoming@ozlabs.org", "linuxppc-dev@lists.ozlabs.org" ], "Received": [ "from lists.ozlabs.org (lists.ozlabs.org [203.11.71.2])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\tkey-exchange X25519 server-signature RSA-PSS (4096 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 478j0Y6WJQz9sNH\n\tfor <patchwork-incoming@ozlabs.org>;\n\tSat, 9 Nov 2019 01:13:01 +1100 (AEDT)", "from bilbo.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 478j0Y4KRSzF0fh\n\tfor <patchwork-incoming@ozlabs.org>;\n\tSat, 9 Nov 2019 01:13:01 +1100 (AEDT)", "from mail-lj1-x244.google.com (mail-lj1-x244.google.com\n\t[IPv6:2a00:1450:4864:20::244])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\tkey-exchange X25519 server-signature RSA-PSS (2048 bits)\n\tserver-digest SHA256) (No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 478gQW13rWzF6sj\n\tfor <linuxppc-dev@lists.ozlabs.org>;\n\tSat, 9 Nov 2019 00:01:55 +1100 (AEDT)", "by mail-lj1-x244.google.com with SMTP id g3so6103607ljl.11\n\tfor <linuxppc-dev@lists.ozlabs.org>;\n\tFri, 08 Nov 2019 05:01:54 -0800 (PST)", "from prevas-ravi.prevas.se ([81.216.59.226])\n\tby smtp.gmail.com with ESMTPSA id\n\td28sm2454725lfn.33.2019.11.08.05.01.50\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tFri, 08 Nov 2019 05:01:50 -0800 (PST)" ], "Authentication-Results": [ "ozlabs.org; dmarc=none (p=none dis=none)\n\theader.from=rasmusvillemoes.dk", "ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=rasmusvillemoes.dk header.i=@rasmusvillemoes.dk\n\theader.b=\"bDajsWfp\"; dkim-atps=neutral", "lists.ozlabs.org; spf=pass (sender SPF authorized)\n\tsmtp.mailfrom=rasmusvillemoes.dk (client-ip=2a00:1450:4864:20::244;\n\thelo=mail-lj1-x244.google.com; envelope-from=linux@rasmusvillemoes.dk;\n\treceiver=<UNKNOWN>)", "lists.ozlabs.org; dmarc=none (p=none dis=none)\n\theader.from=rasmusvillemoes.dk", "lists.ozlabs.org; dkim=pass (1024-bit key;\n\tunprotected) header.d=rasmusvillemoes.dk header.i=@rasmusvillemoes.dk\n\theader.b=\"bDajsWfp\"; dkim-atps=neutral" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=rasmusvillemoes.dk; s=google;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=E9MniY1Iee5HGhOe/xollIck0/KPXWyQbXSm1b3gOvo=;\n\tb=bDajsWfplKpWFRgWa9+5AcH5s7mUz+tVMUeaGmAnvs5lygB0KRw7gr+WcsNLD3m45P\n\tOesGBRU+qKygYqbmr7NvuAz/1ADHbOQOtfbg6TDLC3bz0eJkZBjhtqcGfNWNP2qQPqb6\n\tNx8PqBDNb/gTB/zdoksaHza3n6jEEkzx8ZNfk=", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=E9MniY1Iee5HGhOe/xollIck0/KPXWyQbXSm1b3gOvo=;\n\tb=ex0Jbf45UYE5q7jHbIBgh+lw/k1lB+UEvLvIqEEAXv8/5g9BYzzKQ4I9AhQk7cjmIJ\n\txM9fSck8vLJKXleo1adKRH0GBWtq3POGxcgvAgwUtT/WbCkVPAerl0CgeVZthGCkaxsR\n\t1b7hlQkdY2zRqd6QGS07ZsS99CifDUENGsOniIRYxudyNkUuvk9jUdJSilhXEmjX0Cst\n\ttDfsErZ97ltar9we1R4TE1pVWjZHxnoMG5GTLiENupNx/KB3cvfq9KUfsGnbWmoquWk+\n\tVTVk+5oKXA8NwzX7Nm70yZDe/3/9+sbylMtxJRM/pfW38an6YfsMwlZzcMwtWWOUxqHc\n\t5i2A==", "X-Gm-Message-State": "APjAAAWZ92KGZEclKBXi9OkffKhPsCr3IxqJ530DX0on5KQbxamsV/AB\n\tuBusRtfEh5Ijk2otCsP5vAXuMA==", "X-Google-Smtp-Source": "APXvYqyKyV6JCnPD+aPYjT+LGUqDe3jck22G3eNjzM5okv/Y25KvJX+MpQ3r3uUDO8m/KbOIvP1OsA==", "X-Received": "by 2002:a2e:994f:: with SMTP id r15mr6795909ljj.18.1573218111413;\n\tFri, 08 Nov 2019 05:01:51 -0800 (PST)", "From": "Rasmus Villemoes <linux@rasmusvillemoes.dk>", "To": "Qiang Zhao <qiang.zhao@nxp.com>, Li Yang <leoyang.li@nxp.com>,\n\tChristophe Leroy <christophe.leroy@c-s.fr>", "Subject": "[PATCH v4 18/47] soc: fsl: qe: don't use NO_IRQ in qe_ic.c", "Date": "Fri, 8 Nov 2019 14:00:54 +0100", "Message-Id": "<20191108130123.6839-19-linux@rasmusvillemoes.dk>", "X-Mailer": "git-send-email 2.23.0", "In-Reply-To": "<20191108130123.6839-1-linux@rasmusvillemoes.dk>", "References": "<20191108130123.6839-1-linux@rasmusvillemoes.dk>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "linuxppc-dev@lists.ozlabs.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "Linux on PowerPC Developers Mail List\n\t<linuxppc-dev.lists.ozlabs.org>", "List-Unsubscribe": "<https://lists.ozlabs.org/options/linuxppc-dev>,\n\t<mailto:linuxppc-dev-request@lists.ozlabs.org?subject=unsubscribe>", "List-Archive": "<http://lists.ozlabs.org/pipermail/linuxppc-dev/>", "List-Post": "<mailto:linuxppc-dev@lists.ozlabs.org>", "List-Help": "<mailto:linuxppc-dev-request@lists.ozlabs.org?subject=help>", "List-Subscribe": "<https://lists.ozlabs.org/listinfo/linuxppc-dev>,\n\t<mailto:linuxppc-dev-request@lists.ozlabs.org?subject=subscribe>", "Cc": "Scott Wood <oss@buserror.net>,\n\tRasmus Villemoes <linux@rasmusvillemoes.dk>, \n\tlinuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org,\n\tlinux-arm-kernel@lists.infradead.org", "Errors-To": "linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org", "Sender": "\"Linuxppc-dev\"\n\t<linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org>" }, "content": "This driver is currently PPC-only, and on powerpc, NO_IRQ is 0, so\nthis doesn't change functionality. However, not every architecture\ndefines NO_IRQ, and some define it as -1, so the detection of a failed\nirq_of_parse_and_map() (which returns 0 on failure) would be wrong on\nthose. So to prepare for allowing this driver to build on other\narchitectures, drop all references to NO_IRQ.\n\nSigned-off-by: Rasmus Villemoes <linux@rasmusvillemoes.dk>\n---\n drivers/soc/fsl/qe/qe_ic.c | 21 ++++++++++-----------\n 1 file changed, 10 insertions(+), 11 deletions(-)", "diff": "diff --git a/drivers/soc/fsl/qe/qe_ic.c b/drivers/soc/fsl/qe/qe_ic.c\nindex 4839dcd5c5d3..8f74bc6efd5c 100644\n--- a/drivers/soc/fsl/qe/qe_ic.c\n+++ b/drivers/soc/fsl/qe/qe_ic.c\n@@ -282,7 +282,7 @@ static const struct irq_domain_ops qe_ic_host_ops = {\n \t.xlate = irq_domain_xlate_onetwocell,\n };\n \n-/* Return an interrupt vector or NO_IRQ if no interrupt is pending. */\n+/* Return an interrupt vector or 0 if no interrupt is pending. */\n unsigned int qe_ic_get_low_irq(struct qe_ic *qe_ic)\n {\n \tint irq;\n@@ -293,12 +293,12 @@ unsigned int qe_ic_get_low_irq(struct qe_ic *qe_ic)\n \tirq = qe_ic_read(qe_ic->regs, QEIC_CIVEC) >> 26;\n \n \tif (irq == 0)\n-\t\treturn NO_IRQ;\n+\t\treturn 0;\n \n \treturn irq_linear_revmap(qe_ic->irqhost, irq);\n }\n \n-/* Return an interrupt vector or NO_IRQ if no interrupt is pending. */\n+/* Return an interrupt vector or 0 if no interrupt is pending. */\n unsigned int qe_ic_get_high_irq(struct qe_ic *qe_ic)\n {\n \tint irq;\n@@ -309,7 +309,7 @@ unsigned int qe_ic_get_high_irq(struct qe_ic *qe_ic)\n \tirq = qe_ic_read(qe_ic->regs, QEIC_CHIVEC) >> 26;\n \n \tif (irq == 0)\n-\t\treturn NO_IRQ;\n+\t\treturn 0;\n \n \treturn irq_linear_revmap(qe_ic->irqhost, irq);\n }\n@@ -320,7 +320,7 @@ static void qe_ic_cascade_low(struct irq_desc *desc)\n \tunsigned int cascade_irq = qe_ic_get_low_irq(qe_ic);\n \tstruct irq_chip *chip = irq_desc_get_chip(desc);\n \n-\tif (cascade_irq != NO_IRQ)\n+\tif (cascade_irq != 0)\n \t\tgeneric_handle_irq(cascade_irq);\n \n \tif (chip->irq_eoi)\n@@ -333,7 +333,7 @@ static void qe_ic_cascade_high(struct irq_desc *desc)\n \tunsigned int cascade_irq = qe_ic_get_high_irq(qe_ic);\n \tstruct irq_chip *chip = irq_desc_get_chip(desc);\n \n-\tif (cascade_irq != NO_IRQ)\n+\tif (cascade_irq != 0)\n \t\tgeneric_handle_irq(cascade_irq);\n \n \tif (chip->irq_eoi)\n@@ -347,10 +347,10 @@ static void qe_ic_cascade_muxed_mpic(struct irq_desc *desc)\n \tstruct irq_chip *chip = irq_desc_get_chip(desc);\n \n \tcascade_irq = qe_ic_get_high_irq(qe_ic);\n-\tif (cascade_irq == NO_IRQ)\n+\tif (cascade_irq == 0)\n \t\tcascade_irq = qe_ic_get_low_irq(qe_ic);\n \n-\tif (cascade_irq != NO_IRQ)\n+\tif (cascade_irq != 0)\n \t\tgeneric_handle_irq(cascade_irq);\n \n \tchip->irq_eoi(&desc->irq_data);\n@@ -386,7 +386,7 @@ static void __init qe_ic_init(struct device_node *node, unsigned int flags)\n \tqe_ic->virq_high = irq_of_parse_and_map(node, 0);\n \tqe_ic->virq_low = irq_of_parse_and_map(node, 1);\n \n-\tif (qe_ic->virq_low == NO_IRQ) {\n+\tif (!qe_ic->virq_low) {\n \t\tprintk(KERN_ERR \"Failed to map QE_IC low IRQ\\n\");\n \t\tkfree(qe_ic);\n \t\treturn;\n@@ -423,8 +423,7 @@ static void __init qe_ic_init(struct device_node *node, unsigned int flags)\n \tirq_set_handler_data(qe_ic->virq_low, qe_ic);\n \tirq_set_chained_handler(qe_ic->virq_low, low_handler);\n \n-\tif (qe_ic->virq_high != NO_IRQ &&\n-\t\t\tqe_ic->virq_high != qe_ic->virq_low) {\n+\tif (qe_ic->virq_high && qe_ic->virq_high != qe_ic->virq_low) {\n \t\tirq_set_handler_data(qe_ic->virq_high, qe_ic);\n \t\tirq_set_chained_handler(qe_ic->virq_high, high_handler);\n \t}\n", "prefixes": [ "v4", "18/47" ] }