Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/1191905/?format=api
{ "id": 1191905, "url": "http://patchwork.ozlabs.org/api/patches/1191905/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linuxppc-dev/patch/20191108130123.6839-16-linux@rasmusvillemoes.dk/", "project": { "id": 2, "url": "http://patchwork.ozlabs.org/api/projects/2/?format=api", "name": "Linux PPC development", "link_name": "linuxppc-dev", "list_id": "linuxppc-dev.lists.ozlabs.org", "list_email": "linuxppc-dev@lists.ozlabs.org", "web_url": "https://github.com/linuxppc/wiki/wiki", "scm_url": "https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git", "webscm_url": "https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git/", "list_archive_url": "https://lore.kernel.org/linuxppc-dev/", "list_archive_url_format": "https://lore.kernel.org/linuxppc-dev/{}/", "commit_url_format": "https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git/commit/?id={}" }, "msgid": "<20191108130123.6839-16-linux@rasmusvillemoes.dk>", "list_archive_url": "https://lore.kernel.org/linuxppc-dev/20191108130123.6839-16-linux@rasmusvillemoes.dk/", "date": "2019-11-08T13:00:51", "name": "[v4,15/47] soc: fsl: qe: move qe_ic_cascade_* functions to qe_ic.c", "commit_ref": null, "pull_url": null, "state": "not-applicable", "archived": false, "hash": "28d6418709477ff94c1a1304c3aa620c7b3d42f0", "submitter": { "id": 27394, "url": "http://patchwork.ozlabs.org/api/people/27394/?format=api", "name": "Rasmus Villemoes", "email": "linux@rasmusvillemoes.dk" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/linuxppc-dev/patch/20191108130123.6839-16-linux@rasmusvillemoes.dk/mbox/", "series": [ { "id": 141654, "url": "http://patchwork.ozlabs.org/api/series/141654/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linuxppc-dev/list/?series=141654", "date": "2019-11-08T13:00:38", "name": "QUICC Engine support on ARM and ARM64", "version": 4, "mbox": "http://patchwork.ozlabs.org/series/141654/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/1191905/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/1191905/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org>", "X-Original-To": [ "patchwork-incoming@ozlabs.org", "linuxppc-dev@lists.ozlabs.org" ], "Delivered-To": [ "patchwork-incoming@ozlabs.org", "linuxppc-dev@lists.ozlabs.org" ], "Received": [ "from lists.ozlabs.org (lists.ozlabs.org [203.11.71.2])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\tkey-exchange X25519 server-signature RSA-PSS (4096 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 478hlz0ghZz9s4Y\n\tfor <patchwork-incoming@ozlabs.org>;\n\tSat, 9 Nov 2019 01:02:07 +1100 (AEDT)", "from bilbo.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 478hly5QFxzF79B\n\tfor <patchwork-incoming@ozlabs.org>;\n\tSat, 9 Nov 2019 01:02:06 +1100 (AEDT)", "from mail-lf1-x141.google.com (mail-lf1-x141.google.com\n\t[IPv6:2a00:1450:4864:20::141])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\tkey-exchange X25519 server-signature RSA-PSS (2048 bits)\n\tserver-digest SHA256) (No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 478gQR1Df0zF6vT\n\tfor <linuxppc-dev@lists.ozlabs.org>;\n\tSat, 9 Nov 2019 00:01:51 +1100 (AEDT)", "by mail-lf1-x141.google.com with SMTP id f5so4430328lfp.1\n\tfor <linuxppc-dev@lists.ozlabs.org>;\n\tFri, 08 Nov 2019 05:01:51 -0800 (PST)", "from prevas-ravi.prevas.se ([81.216.59.226])\n\tby smtp.gmail.com with ESMTPSA id\n\td28sm2454725lfn.33.2019.11.08.05.01.46\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tFri, 08 Nov 2019 05:01:47 -0800 (PST)" ], "Authentication-Results": [ "ozlabs.org; dmarc=none (p=none dis=none)\n\theader.from=rasmusvillemoes.dk", "ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=rasmusvillemoes.dk header.i=@rasmusvillemoes.dk\n\theader.b=\"PbhKDYM0\"; dkim-atps=neutral", "lists.ozlabs.org; spf=pass (sender SPF authorized)\n\tsmtp.mailfrom=rasmusvillemoes.dk (client-ip=2a00:1450:4864:20::141;\n\thelo=mail-lf1-x141.google.com; envelope-from=linux@rasmusvillemoes.dk;\n\treceiver=<UNKNOWN>)", "lists.ozlabs.org; dmarc=none (p=none dis=none)\n\theader.from=rasmusvillemoes.dk", "lists.ozlabs.org; dkim=pass (1024-bit key;\n\tunprotected) header.d=rasmusvillemoes.dk header.i=@rasmusvillemoes.dk\n\theader.b=\"PbhKDYM0\"; dkim-atps=neutral" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=rasmusvillemoes.dk; s=google;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=I90vJMFtkMg4SHfbJTMtwkyg7nT+nson2WyIsvh49PY=;\n\tb=PbhKDYM0OBT3xksAul3h1OM/o3gXPaDY1kEE4xazagRV/L8j/vBTOJsN/q/lCeLrIQ\n\t+Ce/u3WfXWThHBB36VZhxR/l13x2XffGQ66TkA+Jr+prYmzkAZaoBC3DW3y8j/4RPrBt\n\tHf82PAq3Fui3TzL3AVvkgWkK0lDssi+UB5SG8=", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=I90vJMFtkMg4SHfbJTMtwkyg7nT+nson2WyIsvh49PY=;\n\tb=Bgd5v1E3azB96gSO7cmQuaw/5tQEZ0F1JecWxmWbtqeS4YtGnIVUEAxRkSBig7RJg2\n\tTjqbAiSyykaYSFXuOcisB2x9ekikmQFVPZj65AtESdMIgj/RMR/nkgKrqgSI5kscLo4E\n\tIHkW9tSAYEPU+yK+rWPxBFlpvDdIZqqJClkTY6O7RC3d57grwCXkURu2MaRb1YpABq46\n\t2sDj4x+rvwaFyoaTgyTJBMjcJG3GrBWnP5Zbfc8cQ/Fq3PiMh0GUAo1jBSm71vcwBRF3\n\t+cYTw18keUz4Dkjj2n9r1rmST89k+aXBCRFBOrrs06UyYEJonl8N4QPH2Ht3y3LXjYwm\n\tYUTA==", "X-Gm-Message-State": "APjAAAXXS4Ry4dhLH9Mx12zLneFWCfnPIRYZdd+GJNyW8cHj7LVUSvPp\n\ttDaan8NHIFXIXuZ5w/hpyCjdbA==", "X-Google-Smtp-Source": "APXvYqy5XxK2Kh+3zn+wtnSMU7+2TFP71J3bOdA5BPAOGLsWx/rNli/FFbBzsOPZd9lzqA9TnU67gw==", "X-Received": "by 2002:a19:4f4c:: with SMTP id a12mr6597151lfk.18.1573218107886;\n\tFri, 08 Nov 2019 05:01:47 -0800 (PST)", "From": "Rasmus Villemoes <linux@rasmusvillemoes.dk>", "To": "Qiang Zhao <qiang.zhao@nxp.com>, Li Yang <leoyang.li@nxp.com>,\n\tChristophe Leroy <christophe.leroy@c-s.fr>", "Subject": "[PATCH v4 15/47] soc: fsl: qe: move qe_ic_cascade_* functions to\n\tqe_ic.c", "Date": "Fri, 8 Nov 2019 14:00:51 +0100", "Message-Id": "<20191108130123.6839-16-linux@rasmusvillemoes.dk>", "X-Mailer": "git-send-email 2.23.0", "In-Reply-To": "<20191108130123.6839-1-linux@rasmusvillemoes.dk>", "References": "<20191108130123.6839-1-linux@rasmusvillemoes.dk>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "linuxppc-dev@lists.ozlabs.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "Linux on PowerPC Developers Mail List\n\t<linuxppc-dev.lists.ozlabs.org>", "List-Unsubscribe": "<https://lists.ozlabs.org/options/linuxppc-dev>,\n\t<mailto:linuxppc-dev-request@lists.ozlabs.org?subject=unsubscribe>", "List-Archive": "<http://lists.ozlabs.org/pipermail/linuxppc-dev/>", "List-Post": "<mailto:linuxppc-dev@lists.ozlabs.org>", "List-Help": "<mailto:linuxppc-dev-request@lists.ozlabs.org?subject=help>", "List-Subscribe": "<https://lists.ozlabs.org/listinfo/linuxppc-dev>,\n\t<mailto:linuxppc-dev-request@lists.ozlabs.org?subject=subscribe>", "Cc": "Scott Wood <oss@buserror.net>,\n\tRasmus Villemoes <linux@rasmusvillemoes.dk>, \n\tlinuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org,\n\tlinux-arm-kernel@lists.infradead.org", "Errors-To": "linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org", "Sender": "\"Linuxppc-dev\"\n\t<linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org>" }, "content": "These functions are only ever called through a function pointer, and\ntherefore it makes no sense for them to be \"static inline\" - gcc has\nno choice but to emit a copy in each translation unit that takes the\naddress of one of these. Since they are now only referenced from\nqe_ic.c, just make them local to that file.\n\nSigned-off-by: Rasmus Villemoes <linux@rasmusvillemoes.dk>\n---\n drivers/soc/fsl/qe/qe_ic.c | 42 ++++++++++++++++++++++++++++++++++++++\n include/soc/fsl/qe/qe_ic.h | 42 --------------------------------------\n 2 files changed, 42 insertions(+), 42 deletions(-)", "diff": "diff --git a/drivers/soc/fsl/qe/qe_ic.c b/drivers/soc/fsl/qe/qe_ic.c\nindex a062efac398b..94ccbeeb1ad1 100644\n--- a/drivers/soc/fsl/qe/qe_ic.c\n+++ b/drivers/soc/fsl/qe/qe_ic.c\n@@ -314,6 +314,48 @@ unsigned int qe_ic_get_high_irq(struct qe_ic *qe_ic)\n \treturn irq_linear_revmap(qe_ic->irqhost, irq);\n }\n \n+static void qe_ic_cascade_low_mpic(struct irq_desc *desc)\n+{\n+\tstruct qe_ic *qe_ic = irq_desc_get_handler_data(desc);\n+\tunsigned int cascade_irq = qe_ic_get_low_irq(qe_ic);\n+\tstruct irq_chip *chip = irq_desc_get_chip(desc);\n+\n+\tif (cascade_irq != NO_IRQ)\n+\t\tgeneric_handle_irq(cascade_irq);\n+\n+\tif (chip->irq_eoi)\n+\t\tchip->irq_eoi(&desc->irq_data);\n+}\n+\n+static void qe_ic_cascade_high_mpic(struct irq_desc *desc)\n+{\n+\tstruct qe_ic *qe_ic = irq_desc_get_handler_data(desc);\n+\tunsigned int cascade_irq = qe_ic_get_high_irq(qe_ic);\n+\tstruct irq_chip *chip = irq_desc_get_chip(desc);\n+\n+\tif (cascade_irq != NO_IRQ)\n+\t\tgeneric_handle_irq(cascade_irq);\n+\n+\tif (chip->irq_eoi)\n+\t\tchip->irq_eoi(&desc->irq_data);\n+}\n+\n+static void qe_ic_cascade_muxed_mpic(struct irq_desc *desc)\n+{\n+\tstruct qe_ic *qe_ic = irq_desc_get_handler_data(desc);\n+\tunsigned int cascade_irq;\n+\tstruct irq_chip *chip = irq_desc_get_chip(desc);\n+\n+\tcascade_irq = qe_ic_get_high_irq(qe_ic);\n+\tif (cascade_irq == NO_IRQ)\n+\t\tcascade_irq = qe_ic_get_low_irq(qe_ic);\n+\n+\tif (cascade_irq != NO_IRQ)\n+\t\tgeneric_handle_irq(cascade_irq);\n+\n+\tchip->irq_eoi(&desc->irq_data);\n+}\n+\n static void __init qe_ic_init(struct device_node *node, unsigned int flags)\n {\n \tvoid (*low_handler)(struct irq_desc *desc);\ndiff --git a/include/soc/fsl/qe/qe_ic.h b/include/soc/fsl/qe/qe_ic.h\nindex a47a0d26acbd..43e4ce95c6a0 100644\n--- a/include/soc/fsl/qe/qe_ic.h\n+++ b/include/soc/fsl/qe/qe_ic.h\n@@ -67,46 +67,4 @@ void qe_ic_set_highest_priority(unsigned int virq, int high);\n int qe_ic_set_priority(unsigned int virq, unsigned int priority);\n int qe_ic_set_high_priority(unsigned int virq, unsigned int priority, int high);\n \n-static inline void qe_ic_cascade_low_mpic(struct irq_desc *desc)\n-{\n-\tstruct qe_ic *qe_ic = irq_desc_get_handler_data(desc);\n-\tunsigned int cascade_irq = qe_ic_get_low_irq(qe_ic);\n-\tstruct irq_chip *chip = irq_desc_get_chip(desc);\n-\n-\tif (cascade_irq != NO_IRQ)\n-\t\tgeneric_handle_irq(cascade_irq);\n-\n-\tif (chip->irq_eoi)\n-\t\tchip->irq_eoi(&desc->irq_data);\n-}\n-\n-static inline void qe_ic_cascade_high_mpic(struct irq_desc *desc)\n-{\n-\tstruct qe_ic *qe_ic = irq_desc_get_handler_data(desc);\n-\tunsigned int cascade_irq = qe_ic_get_high_irq(qe_ic);\n-\tstruct irq_chip *chip = irq_desc_get_chip(desc);\n-\n-\tif (cascade_irq != NO_IRQ)\n-\t\tgeneric_handle_irq(cascade_irq);\n-\n-\tif (chip->irq_eoi)\n-\t\tchip->irq_eoi(&desc->irq_data);\n-}\n-\n-static inline void qe_ic_cascade_muxed_mpic(struct irq_desc *desc)\n-{\n-\tstruct qe_ic *qe_ic = irq_desc_get_handler_data(desc);\n-\tunsigned int cascade_irq;\n-\tstruct irq_chip *chip = irq_desc_get_chip(desc);\n-\n-\tcascade_irq = qe_ic_get_high_irq(qe_ic);\n-\tif (cascade_irq == NO_IRQ)\n-\t\tcascade_irq = qe_ic_get_low_irq(qe_ic);\n-\n-\tif (cascade_irq != NO_IRQ)\n-\t\tgeneric_handle_irq(cascade_irq);\n-\n-\tchip->irq_eoi(&desc->irq_data);\n-}\n-\n #endif /* _ASM_POWERPC_QE_IC_H */\n", "prefixes": [ "v4", "15/47" ] }