Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/1191904/?format=api
{ "id": 1191904, "url": "http://patchwork.ozlabs.org/api/patches/1191904/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linuxppc-dev/patch/20191108130123.6839-15-linux@rasmusvillemoes.dk/", "project": { "id": 2, "url": "http://patchwork.ozlabs.org/api/projects/2/?format=api", "name": "Linux PPC development", "link_name": "linuxppc-dev", "list_id": "linuxppc-dev.lists.ozlabs.org", "list_email": "linuxppc-dev@lists.ozlabs.org", "web_url": "https://github.com/linuxppc/wiki/wiki", "scm_url": "https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git", "webscm_url": "https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git/", "list_archive_url": "https://lore.kernel.org/linuxppc-dev/", "list_archive_url_format": "https://lore.kernel.org/linuxppc-dev/{}/", "commit_url_format": "https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git/commit/?id={}" }, "msgid": "<20191108130123.6839-15-linux@rasmusvillemoes.dk>", "list_archive_url": "https://lore.kernel.org/linuxppc-dev/20191108130123.6839-15-linux@rasmusvillemoes.dk/", "date": "2019-11-08T13:00:50", "name": "[v4,14/47] powerpc/85xx: remove mostly pointless mpc85xx_qe_init()", "commit_ref": null, "pull_url": null, "state": "not-applicable", "archived": false, "hash": "3732b3d9eff6c0ac36fd19804015cfe1193927ea", "submitter": { "id": 27394, "url": "http://patchwork.ozlabs.org/api/people/27394/?format=api", "name": "Rasmus Villemoes", "email": "linux@rasmusvillemoes.dk" }, "delegate": { "id": 1707, "url": "http://patchwork.ozlabs.org/api/users/1707/?format=api", "username": "scottwood", "first_name": "Scott", "last_name": "Wood", "email": "scottwood@freescale.com" }, "mbox": "http://patchwork.ozlabs.org/project/linuxppc-dev/patch/20191108130123.6839-15-linux@rasmusvillemoes.dk/mbox/", "series": [ { "id": 141654, "url": "http://patchwork.ozlabs.org/api/series/141654/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linuxppc-dev/list/?series=141654", "date": "2019-11-08T13:00:38", "name": "QUICC Engine support on ARM and ARM64", "version": 4, "mbox": "http://patchwork.ozlabs.org/series/141654/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/1191904/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/1191904/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org>", "X-Original-To": [ "patchwork-incoming@ozlabs.org", "linuxppc-dev@lists.ozlabs.org" ], "Delivered-To": [ "patchwork-incoming@ozlabs.org", "linuxppc-dev@lists.ozlabs.org" ], "Received": [ "from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\tkey-exchange X25519 server-signature RSA-PSS (4096 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 478hh93c2zz9sPK\n\tfor <patchwork-incoming@ozlabs.org>;\n\tSat, 9 Nov 2019 00:58:49 +1100 (AEDT)", "from bilbo.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 478hh85z6fzF6T2\n\tfor <patchwork-incoming@ozlabs.org>;\n\tSat, 9 Nov 2019 00:58:48 +1100 (AEDT)", "from mail-lj1-x241.google.com (mail-lj1-x241.google.com\n\t[IPv6:2a00:1450:4864:20::241])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\tkey-exchange X25519 server-signature RSA-PSS (2048 bits)\n\tserver-digest SHA256) (No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 478gQP6NQmzF6vT\n\tfor <linuxppc-dev@lists.ozlabs.org>;\n\tSat, 9 Nov 2019 00:01:49 +1100 (AEDT)", "by mail-lj1-x241.google.com with SMTP id v8so6131535ljh.5\n\tfor <linuxppc-dev@lists.ozlabs.org>;\n\tFri, 08 Nov 2019 05:01:49 -0800 (PST)", "from prevas-ravi.prevas.se ([81.216.59.226])\n\tby smtp.gmail.com with ESMTPSA id\n\td28sm2454725lfn.33.2019.11.08.05.01.45\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tFri, 08 Nov 2019 05:01:46 -0800 (PST)" ], "Authentication-Results": [ "ozlabs.org; dmarc=none (p=none dis=none)\n\theader.from=rasmusvillemoes.dk", "ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=rasmusvillemoes.dk header.i=@rasmusvillemoes.dk\n\theader.b=\"KccFI/3G\"; dkim-atps=neutral", "lists.ozlabs.org; spf=pass (sender SPF authorized)\n\tsmtp.mailfrom=rasmusvillemoes.dk (client-ip=2a00:1450:4864:20::241;\n\thelo=mail-lj1-x241.google.com; envelope-from=linux@rasmusvillemoes.dk;\n\treceiver=<UNKNOWN>)", "lists.ozlabs.org; dmarc=none (p=none dis=none)\n\theader.from=rasmusvillemoes.dk", "lists.ozlabs.org; dkim=pass (1024-bit key;\n\tunprotected) header.d=rasmusvillemoes.dk header.i=@rasmusvillemoes.dk\n\theader.b=\"KccFI/3G\"; dkim-atps=neutral" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=rasmusvillemoes.dk; s=google;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=ALLDdvAQ5LNMRJEx4JjrDqX3dC2+C2shaJm9tn1b0pg=;\n\tb=KccFI/3GaKAoQobc70NX/i6oW+HrrX0pUL/gIKrjKKrpOqtxDSmpb5uuQS0+es4ria\n\tH6meLyWBaIv+qyTi8GiSt9Mg8M+ehrNayrK1rikyK2tRG+NomPv8TIMb0R+8oU6k9/71\n\t++28OkGsJQfVw1KZ/2De0kjfdxbGnD6485PtY=", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=ALLDdvAQ5LNMRJEx4JjrDqX3dC2+C2shaJm9tn1b0pg=;\n\tb=OLiO3rj34LtPAT8PJgSL0VhQQfuBG/+h8UC4ASl29wlDrpTehfCa6VCDZJnR70+60P\n\tJHVgNKVjEWz76JYUS6Kvy8yFpGvuCWKccrlIB1cPd2ztKJGNC+Oix/3fnaDfUZmccFac\n\t57P2CrTQeX0kkl1zrVpW55RI0M8G3Iu27AfJD84NlO6ijtVh+Bq9c1WavCWOm0ITx88G\n\tiOMgguHIxtA7/JTpOkIYNhVVkxYIlSFtpflx5rG+5PuPjTf+VWPE7cRGuW8NIdOOmudK\n\tu0z5isr3vV2ADsvt5rfTc6gTEOb84xOY/F6D8aI2TY0XYfJ/xxHOqdky+4zK4/b+BldD\n\tOA2g==", "X-Gm-Message-State": "APjAAAW56btlGDfS6rSlZWarJpu9Pe8DXb8/ighbFYYufEsrBHXrhZjE\n\tEZAdWwxb5leq9dn3DigiZshZXg==", "X-Google-Smtp-Source": "APXvYqyPJ7+j0XrnR3VvM/RefmXTzMkX53Jjn3rVz3ZpRQRqWrTsNNSlcp1DhvW1RAIILfsLRZPyPA==", "X-Received": "by 2002:a2e:8695:: with SMTP id l21mr2346203lji.53.1573218106712;\n\tFri, 08 Nov 2019 05:01:46 -0800 (PST)", "From": "Rasmus Villemoes <linux@rasmusvillemoes.dk>", "To": "Qiang Zhao <qiang.zhao@nxp.com>, Li Yang <leoyang.li@nxp.com>,\n\tChristophe Leroy <christophe.leroy@c-s.fr>", "Subject": "[PATCH v4 14/47] powerpc/85xx: remove mostly pointless\n\tmpc85xx_qe_init()", "Date": "Fri, 8 Nov 2019 14:00:50 +0100", "Message-Id": "<20191108130123.6839-15-linux@rasmusvillemoes.dk>", "X-Mailer": "git-send-email 2.23.0", "In-Reply-To": "<20191108130123.6839-1-linux@rasmusvillemoes.dk>", "References": "<20191108130123.6839-1-linux@rasmusvillemoes.dk>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "linuxppc-dev@lists.ozlabs.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "Linux on PowerPC Developers Mail List\n\t<linuxppc-dev.lists.ozlabs.org>", "List-Unsubscribe": "<https://lists.ozlabs.org/options/linuxppc-dev>,\n\t<mailto:linuxppc-dev-request@lists.ozlabs.org?subject=unsubscribe>", "List-Archive": "<http://lists.ozlabs.org/pipermail/linuxppc-dev/>", "List-Post": "<mailto:linuxppc-dev@lists.ozlabs.org>", "List-Help": "<mailto:linuxppc-dev-request@lists.ozlabs.org?subject=help>", "List-Subscribe": "<https://lists.ozlabs.org/listinfo/linuxppc-dev>,\n\t<mailto:linuxppc-dev-request@lists.ozlabs.org?subject=subscribe>", "Cc": "Scott Wood <oss@buserror.net>,\n\tRasmus Villemoes <linux@rasmusvillemoes.dk>, \n\tlinuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org,\n\tlinux-arm-kernel@lists.infradead.org", "Errors-To": "linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org", "Sender": "\"Linuxppc-dev\"\n\t<linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org>" }, "content": "Since commit 302c059f2e7b (QE: use subsys_initcall to init qe),\nmpc85xx_qe_init() has done nothing apart from possibly emitting a\npr_err(). As part of reducing the amount of QE-related code in\narch/powerpc/ (and eventually support QE on other architectures),\nremove this low-hanging fruit.\n\nSigned-off-by: Rasmus Villemoes <linux@rasmusvillemoes.dk>\n---\n arch/powerpc/platforms/85xx/common.c | 23 -------------------\n arch/powerpc/platforms/85xx/corenet_generic.c | 2 --\n arch/powerpc/platforms/85xx/mpc85xx.h | 2 --\n arch/powerpc/platforms/85xx/mpc85xx_mds.c | 1 -\n arch/powerpc/platforms/85xx/mpc85xx_rdb.c | 1 -\n arch/powerpc/platforms/85xx/twr_p102x.c | 1 -\n 6 files changed, 30 deletions(-)", "diff": "diff --git a/arch/powerpc/platforms/85xx/common.c b/arch/powerpc/platforms/85xx/common.c\nindex fe0606439b5a..a554b6d87cf7 100644\n--- a/arch/powerpc/platforms/85xx/common.c\n+++ b/arch/powerpc/platforms/85xx/common.c\n@@ -86,29 +86,6 @@ void __init mpc85xx_cpm2_pic_init(void)\n #endif\n \n #ifdef CONFIG_QUICC_ENGINE\n-void __init mpc85xx_qe_init(void)\n-{\n-\tstruct device_node *np;\n-\n-\tnp = of_find_compatible_node(NULL, NULL, \"fsl,qe\");\n-\tif (!np) {\n-\t\tnp = of_find_node_by_name(NULL, \"qe\");\n-\t\tif (!np) {\n-\t\t\tpr_err(\"%s: Could not find Quicc Engine node\\n\",\n-\t\t\t\t\t__func__);\n-\t\t\treturn;\n-\t\t}\n-\t}\n-\n-\tif (!of_device_is_available(np)) {\n-\t\tof_node_put(np);\n-\t\treturn;\n-\t}\n-\n-\tof_node_put(np);\n-\n-}\n-\n void __init mpc85xx_qe_par_io_init(void)\n {\n \tstruct device_node *np;\ndiff --git a/arch/powerpc/platforms/85xx/corenet_generic.c b/arch/powerpc/platforms/85xx/corenet_generic.c\nindex 8c1bb3941642..27ac38f7e1a9 100644\n--- a/arch/powerpc/platforms/85xx/corenet_generic.c\n+++ b/arch/powerpc/platforms/85xx/corenet_generic.c\n@@ -56,8 +56,6 @@ void __init corenet_gen_setup_arch(void)\n \tswiotlb_detect_4g();\n \n \tpr_info(\"%s board\\n\", ppc_md.name);\n-\n-\tmpc85xx_qe_init();\n }\n \n static const struct of_device_id of_device_ids[] = {\ndiff --git a/arch/powerpc/platforms/85xx/mpc85xx.h b/arch/powerpc/platforms/85xx/mpc85xx.h\nindex fa23f9b0592c..cb84c5c56c36 100644\n--- a/arch/powerpc/platforms/85xx/mpc85xx.h\n+++ b/arch/powerpc/platforms/85xx/mpc85xx.h\n@@ -10,10 +10,8 @@ static inline void __init mpc85xx_cpm2_pic_init(void) {}\n #endif /* CONFIG_CPM2 */\n \n #ifdef CONFIG_QUICC_ENGINE\n-extern void mpc85xx_qe_init(void);\n extern void mpc85xx_qe_par_io_init(void);\n #else\n-static inline void __init mpc85xx_qe_init(void) {}\n static inline void __init mpc85xx_qe_par_io_init(void) {}\n #endif\n \ndiff --git a/arch/powerpc/platforms/85xx/mpc85xx_mds.c b/arch/powerpc/platforms/85xx/mpc85xx_mds.c\nindex 4bc49e5ec0b6..fb05b4d5bf1e 100644\n--- a/arch/powerpc/platforms/85xx/mpc85xx_mds.c\n+++ b/arch/powerpc/platforms/85xx/mpc85xx_mds.c\n@@ -237,7 +237,6 @@ static void __init mpc85xx_mds_qe_init(void)\n {\n \tstruct device_node *np;\n \n-\tmpc85xx_qe_init();\n \tmpc85xx_qe_par_io_init();\n \tmpc85xx_mds_reset_ucc_phys();\n \ndiff --git a/arch/powerpc/platforms/85xx/mpc85xx_rdb.c b/arch/powerpc/platforms/85xx/mpc85xx_rdb.c\nindex 14b5a61d49c1..80a80174768c 100644\n--- a/arch/powerpc/platforms/85xx/mpc85xx_rdb.c\n+++ b/arch/powerpc/platforms/85xx/mpc85xx_rdb.c\n@@ -72,7 +72,6 @@ static void __init mpc85xx_rdb_setup_arch(void)\n \tfsl_pci_assign_primary();\n \n #ifdef CONFIG_QUICC_ENGINE\n-\tmpc85xx_qe_init();\n \tmpc85xx_qe_par_io_init();\n #if defined(CONFIG_UCC_GETH) || defined(CONFIG_SERIAL_QE)\n \tif (machine_is(p1025_rdb)) {\ndiff --git a/arch/powerpc/platforms/85xx/twr_p102x.c b/arch/powerpc/platforms/85xx/twr_p102x.c\nindex b099f5607120..9abb1e9f73c4 100644\n--- a/arch/powerpc/platforms/85xx/twr_p102x.c\n+++ b/arch/powerpc/platforms/85xx/twr_p102x.c\n@@ -57,7 +57,6 @@ static void __init twr_p1025_setup_arch(void)\n \tfsl_pci_assign_primary();\n \n #ifdef CONFIG_QUICC_ENGINE\n-\tmpc85xx_qe_init();\n \tmpc85xx_qe_par_io_init();\n \n #if IS_ENABLED(CONFIG_UCC_GETH) || IS_ENABLED(CONFIG_SERIAL_QE)\n", "prefixes": [ "v4", "14/47" ] }