Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/1191890/?format=api
{ "id": 1191890, "url": "http://patchwork.ozlabs.org/api/patches/1191890/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linuxppc-dev/patch/20191108130123.6839-12-linux@rasmusvillemoes.dk/", "project": { "id": 2, "url": "http://patchwork.ozlabs.org/api/projects/2/?format=api", "name": "Linux PPC development", "link_name": "linuxppc-dev", "list_id": "linuxppc-dev.lists.ozlabs.org", "list_email": "linuxppc-dev@lists.ozlabs.org", "web_url": "https://github.com/linuxppc/wiki/wiki", "scm_url": "https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git", "webscm_url": "https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git/", "list_archive_url": "https://lore.kernel.org/linuxppc-dev/", "list_archive_url_format": "https://lore.kernel.org/linuxppc-dev/{}/", "commit_url_format": "https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git/commit/?id={}" }, "msgid": "<20191108130123.6839-12-linux@rasmusvillemoes.dk>", "list_archive_url": "https://lore.kernel.org/linuxppc-dev/20191108130123.6839-12-linux@rasmusvillemoes.dk/", "date": "2019-11-08T13:00:47", "name": "[v4,11/47] soc: fsl: qe: use qe_ic_cascade_{low, high}_mpic also on 83xx", "commit_ref": null, "pull_url": null, "state": "not-applicable", "archived": false, "hash": "49ab0c30c765ea0334bb82a705ca8f36ee05aa34", "submitter": { "id": 27394, "url": "http://patchwork.ozlabs.org/api/people/27394/?format=api", "name": "Rasmus Villemoes", "email": "linux@rasmusvillemoes.dk" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/linuxppc-dev/patch/20191108130123.6839-12-linux@rasmusvillemoes.dk/mbox/", "series": [ { "id": 141654, "url": "http://patchwork.ozlabs.org/api/series/141654/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linuxppc-dev/list/?series=141654", "date": "2019-11-08T13:00:38", "name": "QUICC Engine support on ARM and ARM64", "version": 4, "mbox": "http://patchwork.ozlabs.org/series/141654/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/1191890/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/1191890/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org>", "X-Original-To": [ "patchwork-incoming@ozlabs.org", "linuxppc-dev@lists.ozlabs.org" ], "Delivered-To": [ "patchwork-incoming@ozlabs.org", "linuxppc-dev@lists.ozlabs.org" ], "Received": [ "from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\tkey-exchange X25519 server-signature RSA-PSS (4096 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 478hLm0MMHz9s7T\n\tfor <patchwork-incoming@ozlabs.org>;\n\tSat, 9 Nov 2019 00:43:44 +1100 (AEDT)", "from bilbo.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 478hLl6FbfzF1dP\n\tfor <patchwork-incoming@ozlabs.org>;\n\tSat, 9 Nov 2019 00:43:43 +1100 (AEDT)", "from mail-lj1-x243.google.com (mail-lj1-x243.google.com\n\t[IPv6:2a00:1450:4864:20::243])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\tkey-exchange X25519 server-signature RSA-PSS (2048 bits)\n\tserver-digest SHA256) (No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 478gQJ5WDDzF6vP\n\tfor <linuxppc-dev@lists.ozlabs.org>;\n\tSat, 9 Nov 2019 00:01:44 +1100 (AEDT)", "by mail-lj1-x243.google.com with SMTP id y23so6100608ljh.10\n\tfor <linuxppc-dev@lists.ozlabs.org>;\n\tFri, 08 Nov 2019 05:01:44 -0800 (PST)", "from prevas-ravi.prevas.se ([81.216.59.226])\n\tby smtp.gmail.com with ESMTPSA id\n\td28sm2454725lfn.33.2019.11.08.05.01.40\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tFri, 08 Nov 2019 05:01:41 -0800 (PST)" ], "Authentication-Results": [ "ozlabs.org; dmarc=none (p=none dis=none)\n\theader.from=rasmusvillemoes.dk", "ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=rasmusvillemoes.dk header.i=@rasmusvillemoes.dk\n\theader.b=\"iMPvlmMC\"; dkim-atps=neutral", "lists.ozlabs.org; spf=pass (sender SPF authorized)\n\tsmtp.mailfrom=rasmusvillemoes.dk (client-ip=2a00:1450:4864:20::243;\n\thelo=mail-lj1-x243.google.com; envelope-from=linux@rasmusvillemoes.dk;\n\treceiver=<UNKNOWN>)", "lists.ozlabs.org; dmarc=none (p=none dis=none)\n\theader.from=rasmusvillemoes.dk", "lists.ozlabs.org; dkim=pass (1024-bit key;\n\tunprotected) header.d=rasmusvillemoes.dk header.i=@rasmusvillemoes.dk\n\theader.b=\"iMPvlmMC\"; dkim-atps=neutral" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=rasmusvillemoes.dk; s=google;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=XBMri+/30LVPDwr/Z+UtZHm4sLSriiAUm4o/nxS90ZM=;\n\tb=iMPvlmMCvod0FN1nC9Xfoxe9VFeVCDr0/g0n1DjjJ5HKuIql2dY5TK/RIBodr7QFJs\n\tGe4srl9274vy84VVa9W68VDsl5HRT/aXz0epnb7/pl/5sxWGOmiQgiFZDxKPPg/v3DMz\n\tVTs+/nLr5ZN2XdFAOiQVRTIUukU0xvF1sugEg=", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=XBMri+/30LVPDwr/Z+UtZHm4sLSriiAUm4o/nxS90ZM=;\n\tb=G3gtTd0oUB/T34kbFuwtAV20ZTZyf1327HYO7FNlpmKKjkb/8Ceqe8usJAahgxi9/7\n\tKQ0/YsnxV08PV9tMKAXExSl61yCRrkCQL26rtO5aDVq8+NWB8/vWJ90Mwh1krUtmOyW/\n\trSdWxA5ywMMDbgiao53T5lgv0AYDMVYVOCQCWgBtt/URhxCW1wT/PvBJ5QvKdf/xDzs/\n\trz9dWJRIps3DTqPK/Xr+XTBsJsau0Mo3e1p9SvrJPGqmkYJeDd6A7beP9gToafLvOOsf\n\tauOmMWOy2dvpzIsf9PTcxXrF5eMYaiySG09AZlc3CCMBAyKQ9Ur4Gk5EaDzNzC83R9x7\n\tu46g==", "X-Gm-Message-State": "APjAAAVTZEdVBRczZksVTiP41hWBfR9Y8+kvTzBzST98YgNraEdVVbil\n\tQttSl6FAUkqSQZO8JtgvVOKJYQ==", "X-Google-Smtp-Source": "APXvYqwZ07+4uYyzJDz1xwrMxLwZbohRXCN2asZuxugqVACf8ojTGp/E6vm7s7NPOAFmelQ3AyTRyw==", "X-Received": "by 2002:a2e:9712:: with SMTP id r18mr6970474lji.12.1573218101817;\n\tFri, 08 Nov 2019 05:01:41 -0800 (PST)", "From": "Rasmus Villemoes <linux@rasmusvillemoes.dk>", "To": "Qiang Zhao <qiang.zhao@nxp.com>, Li Yang <leoyang.li@nxp.com>,\n\tChristophe Leroy <christophe.leroy@c-s.fr>", "Subject": "[PATCH v4 11/47] soc: fsl: qe: use qe_ic_cascade_{low,\n\thigh}_mpic also on 83xx", "Date": "Fri, 8 Nov 2019 14:00:47 +0100", "Message-Id": "<20191108130123.6839-12-linux@rasmusvillemoes.dk>", "X-Mailer": "git-send-email 2.23.0", "In-Reply-To": "<20191108130123.6839-1-linux@rasmusvillemoes.dk>", "References": "<20191108130123.6839-1-linux@rasmusvillemoes.dk>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "linuxppc-dev@lists.ozlabs.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "Linux on PowerPC Developers Mail List\n\t<linuxppc-dev.lists.ozlabs.org>", "List-Unsubscribe": "<https://lists.ozlabs.org/options/linuxppc-dev>,\n\t<mailto:linuxppc-dev-request@lists.ozlabs.org?subject=unsubscribe>", "List-Archive": "<http://lists.ozlabs.org/pipermail/linuxppc-dev/>", "List-Post": "<mailto:linuxppc-dev@lists.ozlabs.org>", "List-Help": "<mailto:linuxppc-dev-request@lists.ozlabs.org?subject=help>", "List-Subscribe": "<https://lists.ozlabs.org/listinfo/linuxppc-dev>,\n\t<mailto:linuxppc-dev-request@lists.ozlabs.org?subject=subscribe>", "Cc": "Scott Wood <oss@buserror.net>,\n\tRasmus Villemoes <linux@rasmusvillemoes.dk>, \n\tlinuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org,\n\tlinux-arm-kernel@lists.infradead.org", "Errors-To": "linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org", "Sender": "\"Linuxppc-dev\"\n\t<linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org>" }, "content": "The *_ipic and *_mpic handlers are almost identical - the only\ndifference is that the latter end with an unconditional\nchip->irq_eoi() call. Since IPIC does not have ->irq_eoi, we can\nreduce some code duplication by calling irq_eoi conditionally.\n\nThis is similar to what is already done in mpc8xxx_gpio_irq_cascade().\n\nThis leaves the functions slightly misnamed, but that will be fixed in\na subsequent patch.\n\nSigned-off-by: Rasmus Villemoes <linux@rasmusvillemoes.dk>\n---\n arch/powerpc/platforms/83xx/misc.c | 2 +-\n include/soc/fsl/qe/qe_ic.h | 24 ++++--------------------\n 2 files changed, 5 insertions(+), 21 deletions(-)", "diff": "diff --git a/arch/powerpc/platforms/83xx/misc.c b/arch/powerpc/platforms/83xx/misc.c\nindex f46d7bf3b140..779791c0570f 100644\n--- a/arch/powerpc/platforms/83xx/misc.c\n+++ b/arch/powerpc/platforms/83xx/misc.c\n@@ -100,7 +100,7 @@ void __init mpc83xx_qe_init_IRQ(void)\n \t\tif (!np)\n \t\t\treturn;\n \t}\n-\tqe_ic_init(np, 0, qe_ic_cascade_low_ipic, qe_ic_cascade_high_ipic);\n+\tqe_ic_init(np, 0, qe_ic_cascade_low_mpic, qe_ic_cascade_high_mpic);\n \tof_node_put(np);\n }\n \ndiff --git a/include/soc/fsl/qe/qe_ic.h b/include/soc/fsl/qe/qe_ic.h\nindex 714a9b890d8d..bfaa233d8328 100644\n--- a/include/soc/fsl/qe/qe_ic.h\n+++ b/include/soc/fsl/qe/qe_ic.h\n@@ -74,24 +74,6 @@ void qe_ic_set_highest_priority(unsigned int virq, int high);\n int qe_ic_set_priority(unsigned int virq, unsigned int priority);\n int qe_ic_set_high_priority(unsigned int virq, unsigned int priority, int high);\n \n-static inline void qe_ic_cascade_low_ipic(struct irq_desc *desc)\n-{\n-\tstruct qe_ic *qe_ic = irq_desc_get_handler_data(desc);\n-\tunsigned int cascade_irq = qe_ic_get_low_irq(qe_ic);\n-\n-\tif (cascade_irq != NO_IRQ)\n-\t\tgeneric_handle_irq(cascade_irq);\n-}\n-\n-static inline void qe_ic_cascade_high_ipic(struct irq_desc *desc)\n-{\n-\tstruct qe_ic *qe_ic = irq_desc_get_handler_data(desc);\n-\tunsigned int cascade_irq = qe_ic_get_high_irq(qe_ic);\n-\n-\tif (cascade_irq != NO_IRQ)\n-\t\tgeneric_handle_irq(cascade_irq);\n-}\n-\n static inline void qe_ic_cascade_low_mpic(struct irq_desc *desc)\n {\n \tstruct qe_ic *qe_ic = irq_desc_get_handler_data(desc);\n@@ -101,7 +83,8 @@ static inline void qe_ic_cascade_low_mpic(struct irq_desc *desc)\n \tif (cascade_irq != NO_IRQ)\n \t\tgeneric_handle_irq(cascade_irq);\n \n-\tchip->irq_eoi(&desc->irq_data);\n+\tif (chip->irq_eoi)\n+\t\tchip->irq_eoi(&desc->irq_data);\n }\n \n static inline void qe_ic_cascade_high_mpic(struct irq_desc *desc)\n@@ -113,7 +96,8 @@ static inline void qe_ic_cascade_high_mpic(struct irq_desc *desc)\n \tif (cascade_irq != NO_IRQ)\n \t\tgeneric_handle_irq(cascade_irq);\n \n-\tchip->irq_eoi(&desc->irq_data);\n+\tif (chip->irq_eoi)\n+\t\tchip->irq_eoi(&desc->irq_data);\n }\n \n static inline void qe_ic_cascade_muxed_mpic(struct irq_desc *desc)\n", "prefixes": [ "v4", "11/47" ] }