Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/1191881/?format=api
{ "id": 1191881, "url": "http://patchwork.ozlabs.org/api/patches/1191881/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linuxppc-dev/patch/20191108130123.6839-8-linux@rasmusvillemoes.dk/", "project": { "id": 2, "url": "http://patchwork.ozlabs.org/api/projects/2/?format=api", "name": "Linux PPC development", "link_name": "linuxppc-dev", "list_id": "linuxppc-dev.lists.ozlabs.org", "list_email": "linuxppc-dev@lists.ozlabs.org", "web_url": "https://github.com/linuxppc/wiki/wiki", "scm_url": "https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git", "webscm_url": "https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git/", "list_archive_url": "https://lore.kernel.org/linuxppc-dev/", "list_archive_url_format": "https://lore.kernel.org/linuxppc-dev/{}/", "commit_url_format": "https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git/commit/?id={}" }, "msgid": "<20191108130123.6839-8-linux@rasmusvillemoes.dk>", "list_archive_url": "https://lore.kernel.org/linuxppc-dev/20191108130123.6839-8-linux@rasmusvillemoes.dk/", "date": "2019-11-08T13:00:43", "name": "[v4,07/47] soc: fsl: qe: qe.c: guard use of pvr_version_is() with CONFIG_PPC32", "commit_ref": null, "pull_url": null, "state": "not-applicable", "archived": false, "hash": "1eee3e17513bc26d3f2cf65fb02ef6a20f2d76ef", "submitter": { "id": 27394, "url": "http://patchwork.ozlabs.org/api/people/27394/?format=api", "name": "Rasmus Villemoes", "email": "linux@rasmusvillemoes.dk" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/linuxppc-dev/patch/20191108130123.6839-8-linux@rasmusvillemoes.dk/mbox/", "series": [ { "id": 141654, "url": "http://patchwork.ozlabs.org/api/series/141654/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linuxppc-dev/list/?series=141654", "date": "2019-11-08T13:00:38", "name": "QUICC Engine support on ARM and ARM64", "version": 4, "mbox": "http://patchwork.ozlabs.org/series/141654/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/1191881/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/1191881/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org>", "X-Original-To": [ "patchwork-incoming@ozlabs.org", "linuxppc-dev@lists.ozlabs.org" ], "Delivered-To": [ "patchwork-incoming@ozlabs.org", "linuxppc-dev@lists.ozlabs.org" ], "Received": [ "from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\tkey-exchange X25519 server-signature RSA-PSS (4096 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 478h7K0spqz9s4Y\n\tfor <patchwork-incoming@ozlabs.org>;\n\tSat, 9 Nov 2019 00:33:49 +1100 (AEDT)", "from bilbo.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 478h7H3GfWzF57C\n\tfor <patchwork-incoming@ozlabs.org>;\n\tSat, 9 Nov 2019 00:33:47 +1100 (AEDT)", "from mail-lf1-x142.google.com (mail-lf1-x142.google.com\n\t[IPv6:2a00:1450:4864:20::142])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\tkey-exchange X25519 server-signature RSA-PSS (2048 bits)\n\tserver-digest SHA256) (No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 478gQD2cNqzF6qJ\n\tfor <linuxppc-dev@lists.ozlabs.org>;\n\tSat, 9 Nov 2019 00:01:40 +1100 (AEDT)", "by mail-lf1-x142.google.com with SMTP id m6so4421115lfl.3\n\tfor <linuxppc-dev@lists.ozlabs.org>;\n\tFri, 08 Nov 2019 05:01:40 -0800 (PST)", "from prevas-ravi.prevas.se ([81.216.59.226])\n\tby smtp.gmail.com with ESMTPSA id\n\td28sm2454725lfn.33.2019.11.08.05.01.35\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tFri, 08 Nov 2019 05:01:36 -0800 (PST)" ], "Authentication-Results": [ "ozlabs.org; dmarc=none (p=none dis=none)\n\theader.from=rasmusvillemoes.dk", "ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=rasmusvillemoes.dk header.i=@rasmusvillemoes.dk\n\theader.b=\"HJOJZkxw\"; dkim-atps=neutral", "lists.ozlabs.org; spf=pass (sender SPF authorized)\n\tsmtp.mailfrom=rasmusvillemoes.dk (client-ip=2a00:1450:4864:20::142;\n\thelo=mail-lf1-x142.google.com; envelope-from=linux@rasmusvillemoes.dk;\n\treceiver=<UNKNOWN>)", "lists.ozlabs.org; dmarc=none (p=none dis=none)\n\theader.from=rasmusvillemoes.dk", "lists.ozlabs.org; dkim=pass (1024-bit key;\n\tunprotected) header.d=rasmusvillemoes.dk header.i=@rasmusvillemoes.dk\n\theader.b=\"HJOJZkxw\"; dkim-atps=neutral" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=rasmusvillemoes.dk; s=google;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=KU/n1Q/VNXJbWwIQys/qt9rGcT4PXz5RLqrj6x2UwvM=;\n\tb=HJOJZkxwDS0medOsmpThvkVAMPgReePyoCZfeE53ipRTRMDB0W6c5pAuf6ddW16YzH\n\tbTOd+bBAagLh5RkQgulpK6Rx2eot8KegFwHr4WplwoCtgkFmTv4Kl1wWcO7q9ySV5I6z\n\tpMMrXUWvpVqVoyCYDeiFszP4vKVSXYmeRZehM=", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=KU/n1Q/VNXJbWwIQys/qt9rGcT4PXz5RLqrj6x2UwvM=;\n\tb=rfB5cfr9SeNKR5pe+njomnvM2ZvoZhnjWMg/f6BpM7deNUCggNJVbAu7ZQsgE7AD/2\n\tPl1GLWIhR7QiG7a16MM35iYHZOv6l2Oo3xq/cQH7Wo5IjNCCUR0vJeuXcuztdLo1ZoQp\n\ttwFeuSMrimdOmbMMdxYsRJYSk5FI3KdD8eqJQtj2fD12Ma+CYSK0kFVui0VgZhBdM/8P\n\tw7a4U4k4dILv8imdwvz2aTx7HIz3N5QQitLE5nhqdnWKAkLc73kspFb+O/zWF9Zyr6DM\n\tjigwLGzYdg1nvB7dLaugmhCPsbxnmglAxszk7A9mQXYlIlmf/kS6s5LmoCWPufQ1z9DJ\n\tOvsw==", "X-Gm-Message-State": "APjAAAXcBttVj2vI4hx20+BdI21tSGJvIECYdNfIrOU309JTMppRsqNk\n\t6KQEEeuS0JxP/0iqwIlsB4llMw==", "X-Google-Smtp-Source": "APXvYqwV1QSJeo2zO51t+HaG52pdBxkjO72k8ABUQOFAqLzD+fyt+4MoIaNvkXvy8mC20ecsyTXyqQ==", "X-Received": "by 2002:a19:5e53:: with SMTP id\n\tz19mr6167585lfi.111.1573218096769; \n\tFri, 08 Nov 2019 05:01:36 -0800 (PST)", "From": "Rasmus Villemoes <linux@rasmusvillemoes.dk>", "To": "Qiang Zhao <qiang.zhao@nxp.com>, Li Yang <leoyang.li@nxp.com>,\n\tChristophe Leroy <christophe.leroy@c-s.fr>", "Subject": "[PATCH v4 07/47] soc: fsl: qe: qe.c: guard use of pvr_version_is()\n\twith CONFIG_PPC32", "Date": "Fri, 8 Nov 2019 14:00:43 +0100", "Message-Id": "<20191108130123.6839-8-linux@rasmusvillemoes.dk>", "X-Mailer": "git-send-email 2.23.0", "In-Reply-To": "<20191108130123.6839-1-linux@rasmusvillemoes.dk>", "References": "<20191108130123.6839-1-linux@rasmusvillemoes.dk>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "linuxppc-dev@lists.ozlabs.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "Linux on PowerPC Developers Mail List\n\t<linuxppc-dev.lists.ozlabs.org>", "List-Unsubscribe": "<https://lists.ozlabs.org/options/linuxppc-dev>,\n\t<mailto:linuxppc-dev-request@lists.ozlabs.org?subject=unsubscribe>", "List-Archive": "<http://lists.ozlabs.org/pipermail/linuxppc-dev/>", "List-Post": "<mailto:linuxppc-dev@lists.ozlabs.org>", "List-Help": "<mailto:linuxppc-dev-request@lists.ozlabs.org?subject=help>", "List-Subscribe": "<https://lists.ozlabs.org/listinfo/linuxppc-dev>,\n\t<mailto:linuxppc-dev-request@lists.ozlabs.org?subject=subscribe>", "Cc": "Scott Wood <oss@buserror.net>,\n\tRasmus Villemoes <linux@rasmusvillemoes.dk>, \n\tlinuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org,\n\tlinux-arm-kernel@lists.infradead.org", "Errors-To": "linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org", "Sender": "\"Linuxppc-dev\"\n\t<linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org>" }, "content": "Commit e5c5c8d23fef (soc/fsl/qe: only apply QE_General4 workaround on\naffected SoCs) introduced use of pvr_version_is(), saying\n\n The QE_General4 workaround is only valid for the MPC832x and MPC836x\n SoCs. The other SoCs that embed a QUICC engine are not affected by this\n hardware bug and thus can use the computed divisors (this was\n successfully tested on the T1040).\n\nI'm reading the above as saying that the errata does not apply to the\nARM-based SOCs with QUICC engine. In any case, use of pvr_version_is()\nmust be guarded by CONFIG_PPC32 before we can remove the PPC32\ndependency from CONFIG_QUICC_ENGINE, so introduce qe_general4_errata()\nto keep the necessary #ifdeffery localized to a trivial helper.\n\nSigned-off-by: Rasmus Villemoes <linux@rasmusvillemoes.dk>\n---\n drivers/soc/fsl/qe/qe.c | 10 +++++++++-\n 1 file changed, 9 insertions(+), 1 deletion(-)", "diff": "diff --git a/drivers/soc/fsl/qe/qe.c b/drivers/soc/fsl/qe/qe.c\nindex 85737e6f5b62..1d8aa62c7ddf 100644\n--- a/drivers/soc/fsl/qe/qe.c\n+++ b/drivers/soc/fsl/qe/qe.c\n@@ -197,6 +197,14 @@ EXPORT_SYMBOL(qe_get_brg_clk);\n #define PVR_VER_836x\t0x8083\n #define PVR_VER_832x\t0x8084\n \n+static bool qe_general4_errata(void)\n+{\n+#ifdef CONFIG_PPC32\n+\treturn pvr_version_is(PVR_VER_836x) || pvr_version_is(PVR_VER_832x);\n+#endif\n+\treturn false;\n+}\n+\n /* Program the BRG to the given sampling rate and multiplier\n *\n * @brg: the BRG, QE_BRG1 - QE_BRG16\n@@ -223,7 +231,7 @@ int qe_setbrg(enum qe_clock brg, unsigned int rate, unsigned int multiplier)\n \t/* Errata QE_General4, which affects some MPC832x and MPC836x SOCs, says\n \t that the BRG divisor must be even if you're not using divide-by-16\n \t mode. */\n-\tif (pvr_version_is(PVR_VER_836x) || pvr_version_is(PVR_VER_832x))\n+\tif (qe_general4_errata())\n \t\tif (!div16 && (divisor & 1) && (divisor > 3))\n \t\t\tdivisor++;\n \n", "prefixes": [ "v4", "07/47" ] }