Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/1190611/?format=api
{ "id": 1190611, "url": "http://patchwork.ozlabs.org/api/patches/1190611/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20191106100541.48639-13-anthony.l.nguyen@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20191106100541.48639-13-anthony.l.nguyen@intel.com>", "list_archive_url": null, "date": "2019-11-06T10:05:39", "name": "[S32,v3,13/15] ice: Introduce and use ice_vsi_type_str", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "9e6677b60dbe83698d3bf1d3fc5bd6a36c5765f7", "submitter": { "id": 68875, "url": "http://patchwork.ozlabs.org/api/people/68875/?format=api", "name": "Tony Nguyen", "email": "anthony.l.nguyen@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20191106100541.48639-13-anthony.l.nguyen@intel.com/mbox/", "series": [ { "id": 141151, "url": "http://patchwork.ozlabs.org/api/series/141151/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=141151", "date": "2019-11-06T10:05:27", "name": "[S32,v3,01/15] ice: Use ice_ena_vsi and ice_dis_vsi in DCB configuration flow", "version": 3, "mbox": "http://patchwork.ozlabs.org/series/141151/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/1190611/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/1190611/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": [ "ozlabs.org; spf=pass (sender SPF authorized)\n\tsmtp.mailfrom=osuosl.org (client-ip=140.211.166.133;\n\thelo=hemlock.osuosl.org;\n\tenvelope-from=intel-wired-lan-bounces@osuosl.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org;\n\tdmarc=fail (p=none dis=none) header.from=intel.com" ], "Received": [ "from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 477Zxh0hYtz9sP4\n\tfor <incoming@patchwork.ozlabs.org>;\n\tThu, 7 Nov 2019 05:36:40 +1100 (AEDT)", "from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 867EE8A892;\n\tWed, 6 Nov 2019 18:36:38 +0000 (UTC)", "from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id ly8UZr2RXaRs; Wed, 6 Nov 2019 18:36:35 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 038198A7ED;\n\tWed, 6 Nov 2019 18:36:35 +0000 (UTC)", "from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\tby ash.osuosl.org (Postfix) with ESMTP id 25AA11BF3FB\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 6 Nov 2019 18:36:32 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 200B98A854\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 6 Nov 2019 18:36:32 +0000 (UTC)", "from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id wBHioXdB8hMd for <intel-wired-lan@lists.osuosl.org>;\n\tWed, 6 Nov 2019 18:36:30 +0000 (UTC)", "from mga05.intel.com (mga05.intel.com [192.55.52.43])\n\tby hemlock.osuosl.org (Postfix) with ESMTPS id CA78C8A86D\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 6 Nov 2019 18:36:29 +0000 (UTC)", "from orsmga006.jf.intel.com ([10.7.209.51])\n\tby fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t06 Nov 2019 10:36:29 -0800", "from unknown (HELO localhost.jf.intel.com) ([10.166.244.174])\n\tby orsmga006.jf.intel.com with ESMTP; 06 Nov 2019 10:36:27 -0800" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.68,275,1569308400\"; d=\"scan'208\";a=\"205918164\"", "From": "Tony Nguyen <anthony.l.nguyen@intel.com>", "To": "intel-wired-lan@lists.osuosl.org", "Date": "Wed, 6 Nov 2019 02:05:39 -0800", "Message-Id": "<20191106100541.48639-13-anthony.l.nguyen@intel.com>", "X-Mailer": "git-send-email 2.20.1", "In-Reply-To": "<20191106100541.48639-1-anthony.l.nguyen@intel.com>", "References": "<20191106100541.48639-1-anthony.l.nguyen@intel.com>", "MIME-Version": "1.0", "Subject": "[Intel-wired-lan] [PATCH S32 v3 13/15] ice: Introduce and use\n\tice_vsi_type_str", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "From: Anirudh Venkataramanan <anirudh.venkataramanan@intel.com>\n\nice_vsi_type_str converts an ice_vsi_type enum value to its string\nequivalent. This is expected to help easily identify VSI types from\nmodule print statements.\n\nSigned-off-by: Anirudh Venkataramanan <anirudh.venkataramanan@intel.com>\n---\n drivers/net/ethernet/intel/ice/ice_lib.c | 21 ++++++++++++++++++++-\n drivers/net/ethernet/intel/ice/ice_lib.h | 2 ++\n drivers/net/ethernet/intel/ice/ice_main.c | 16 ++++++++--------\n 3 files changed, 30 insertions(+), 9 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/ice/ice_lib.c b/drivers/net/ethernet/intel/ice/ice_lib.c\nindex c9e0b533da47..af7574b0624b 100644\n--- a/drivers/net/ethernet/intel/ice/ice_lib.c\n+++ b/drivers/net/ethernet/intel/ice/ice_lib.c\n@@ -6,6 +6,24 @@\n #include \"ice_lib.h\"\n #include \"ice_dcb_lib.h\"\n \n+/**\n+ * ice_vsi_type_str - maps VSI type enum to string equivalents\n+ * @type: VSI type enum\n+ */\n+const char *ice_vsi_type_str(enum ice_vsi_type type)\n+{\n+\tswitch (type) {\n+\tcase ICE_VSI_PF:\n+\t\treturn \"ICE_VSI_PF\";\n+\tcase ICE_VSI_VF:\n+\t\treturn \"ICE_VSI_VF\";\n+\tcase ICE_VSI_LB:\n+\t\treturn \"ICE_VSI_LB\";\n+\tdefault:\n+\t\treturn \"unknown\";\n+\t}\n+}\n+\n /**\n * ice_vsi_ctrl_rx_rings - Start or stop a VSI's Rx rings\n * @vsi: the VSI being configured\n@@ -700,7 +718,8 @@ static void ice_set_rss_vsi_ctx(struct ice_vsi_ctx *ctxt, struct ice_vsi *vsi)\n \t\thash_type = ICE_AQ_VSI_Q_OPT_RSS_TPLZ;\n \t\tbreak;\n \tcase ICE_VSI_LB:\n-\t\tdev_dbg(&pf->pdev->dev, \"Unsupported VSI type %d\\n\", vsi->type);\n+\t\tdev_dbg(&pf->pdev->dev, \"Unsupported VSI type %s\\n\",\n+\t\t\tice_vsi_type_str(vsi->type));\n \t\treturn;\n \tdefault:\n \t\tdev_warn(&pf->pdev->dev, \"Unknown VSI type %d\\n\", vsi->type);\ndiff --git a/drivers/net/ethernet/intel/ice/ice_lib.h b/drivers/net/ethernet/intel/ice/ice_lib.h\nindex 1ec2ad98ac46..364588dfc646 100644\n--- a/drivers/net/ethernet/intel/ice/ice_lib.h\n+++ b/drivers/net/ethernet/intel/ice/ice_lib.h\n@@ -6,6 +6,8 @@\n \n #include \"ice.h\"\n \n+const char *ice_vsi_type_str(enum ice_vsi_type type);\n+\n int\n ice_add_mac_to_list(struct ice_vsi *vsi, struct list_head *add_list,\n \t\t const u8 *macaddr);\ndiff --git a/drivers/net/ethernet/intel/ice/ice_main.c b/drivers/net/ethernet/intel/ice/ice_main.c\nindex aaa398759548..ba9a0b74ef0d 100644\n--- a/drivers/net/ethernet/intel/ice/ice_main.c\n+++ b/drivers/net/ethernet/intel/ice/ice_main.c\n@@ -4635,8 +4635,8 @@ static int ice_vsi_rebuild_by_type(struct ice_pf *pf, enum ice_vsi_type type)\n \t\terr = ice_vsi_rebuild(vsi);\n \t\tif (err) {\n \t\t\tdev_err(&pf->pdev->dev,\n-\t\t\t\t\"rebuild VSI failed, err %d, VSI index %d, type %d\\n\",\n-\t\t\t\terr, vsi->idx, type);\n+\t\t\t\t\"rebuild VSI failed, err %d, VSI index %d, type %s\\n\",\n+\t\t\t\terr, vsi->idx, ice_vsi_type_str(type));\n \t\t\treturn err;\n \t\t}\n \n@@ -4644,8 +4644,8 @@ static int ice_vsi_rebuild_by_type(struct ice_pf *pf, enum ice_vsi_type type)\n \t\tstatus = ice_replay_vsi(&pf->hw, vsi->idx);\n \t\tif (status) {\n \t\t\tdev_err(&pf->pdev->dev,\n-\t\t\t\t\"replay VSI failed, status %d, VSI index %d, type %d\\n\",\n-\t\t\t\tstatus, vsi->idx, type);\n+\t\t\t\t\"replay VSI failed, status %d, VSI index %d, type %s\\n\",\n+\t\t\t\tstatus, vsi->idx, ice_vsi_type_str(type));\n \t\t\treturn -EIO;\n \t\t}\n \n@@ -4658,13 +4658,13 @@ static int ice_vsi_rebuild_by_type(struct ice_pf *pf, enum ice_vsi_type type)\n \t\terr = ice_ena_vsi(vsi, false);\n \t\tif (err) {\n \t\t\tdev_err(&pf->pdev->dev,\n-\t\t\t\t\"enable VSI failed, err %d, VSI index %d, type %d\\n\",\n-\t\t\t\terr, vsi->idx, type);\n+\t\t\t\t\"enable VSI failed, err %d, VSI index %d, type %s\\n\",\n+\t\t\t\terr, vsi->idx, ice_vsi_type_str(type));\n \t\t\treturn err;\n \t\t}\n \n-\t\tdev_info(&pf->pdev->dev, \"VSI rebuilt. VSI index %d, type %d\\n\",\n-\t\t\t vsi->idx, type);\n+\t\tdev_info(&pf->pdev->dev, \"VSI rebuilt. VSI index %d, type %s\\n\",\n+\t\t\t vsi->idx, ice_vsi_type_str(type));\n \t}\n \n \treturn 0;\n", "prefixes": [ "S32", "v3", "13/15" ] }