Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/1190556/?format=api
{ "id": 1190556, "url": "http://patchwork.ozlabs.org/api/patches/1190556/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20191106171823.30554-1-jacob.e.keller@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20191106171823.30554-1-jacob.e.keller@intel.com>", "list_archive_url": null, "date": "2019-11-06T17:18:23", "name": "[net] igb/igc: use ktime accessors for skb->tstamp", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "b8a1e36c70eca4fa07d645ffd04deed08846c05d", "submitter": { "id": 9784, "url": "http://patchwork.ozlabs.org/api/people/9784/?format=api", "name": "Jacob Keller", "email": "jacob.e.keller@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20191106171823.30554-1-jacob.e.keller@intel.com/mbox/", "series": [ { "id": 141132, "url": "http://patchwork.ozlabs.org/api/series/141132/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=141132", "date": "2019-11-06T17:18:23", "name": "[net] igb/igc: use ktime accessors for skb->tstamp", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/141132/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/1190556/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/1190556/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": [ "ozlabs.org; spf=pass (sender SPF authorized)\n\tsmtp.mailfrom=osuosl.org (client-ip=140.211.166.136;\n\thelo=silver.osuosl.org;\n\tenvelope-from=intel-wired-lan-bounces@osuosl.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org;\n\tdmarc=fail (p=none dis=none) header.from=intel.com" ], "Received": [ "from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 477YCY1Gn8z9sPv\n\tfor <incoming@patchwork.ozlabs.org>;\n\tThu, 7 Nov 2019 04:18:32 +1100 (AEDT)", "from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id 35EB5229A3;\n\tWed, 6 Nov 2019 17:18:31 +0000 (UTC)", "from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id JWTGYbrn7lwQ; Wed, 6 Nov 2019 17:18:29 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby silver.osuosl.org (Postfix) with ESMTP id A35A3228EC;\n\tWed, 6 Nov 2019 17:18:29 +0000 (UTC)", "from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\tby ash.osuosl.org (Postfix) with ESMTP id 9A1331BF580\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 6 Nov 2019 17:18:26 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id 6CDD9228EC\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 6 Nov 2019 17:18:26 +0000 (UTC)", "from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id RtHtI-4BT7Tq for <intel-wired-lan@lists.osuosl.org>;\n\tWed, 6 Nov 2019 17:18:25 +0000 (UTC)", "from mga11.intel.com (mga11.intel.com [192.55.52.93])\n\tby silver.osuosl.org (Postfix) with ESMTPS id 74F712042C\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 6 Nov 2019 17:18:25 +0000 (UTC)", "from orsmga002.jf.intel.com ([10.7.209.21])\n\tby fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t06 Nov 2019 09:18:24 -0800", "from jekeller-desk.amr.corp.intel.com (HELO\n\tjekeller-desk.jekeller.internal) ([10.166.244.172])\n\tby orsmga002.jf.intel.com with ESMTP; 06 Nov 2019 09:18:24 -0800" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.68,275,1569308400\"; d=\"scan'208\";a=\"214312105\"", "From": "Jacob Keller <jacob.e.keller@intel.com>", "To": "Intel Wired LAN <intel-wired-lan@lists.osuosl.org>", "Date": "Wed, 6 Nov 2019 09:18:23 -0800", "Message-Id": "<20191106171823.30554-1-jacob.e.keller@intel.com>", "X-Mailer": "git-send-email 2.23.0.245.gf157bbb9169d", "MIME-Version": "1.0", "Subject": "[Intel-wired-lan] [net] igb/igc: use ktime accessors for skb->tstamp", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "When implementing launch time support in the igb and igc drivers, the\nskb->tstamp value is assumed to be a s64, but it's declared as a ktime_t\nvalue.\n\nAlthough ktime_t is typedef'd to s64 it wasn't always, and the kernel\nprovides accessors for ktime_t values.\n\nUse the ktime_to_timespec64 and ktime_set accessors instead of directly\nassuming that the variable is always an s64.\n\nThis improves portability if the code is ever moved to another kernel\nversion, or if the definition of ktime_t ever changes again in the\nfuture.\n\nSigned-off-by: Jacob Keller <jacob.e.keller@intel.com>\n---\n drivers/net/ethernet/intel/igb/igb_main.c | 4 ++--\n drivers/net/ethernet/intel/igc/igc_main.c | 4 ++--\n 2 files changed, 4 insertions(+), 4 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/igb/igb_main.c b/drivers/net/ethernet/intel/igb/igb_main.c\nindex 9148c62d9ac5..ed7e667d7eb2 100644\n--- a/drivers/net/ethernet/intel/igb/igb_main.c\n+++ b/drivers/net/ethernet/intel/igb/igb_main.c\n@@ -5675,8 +5675,8 @@ static void igb_tx_ctxtdesc(struct igb_ring *tx_ring,\n \t * should have been handled by the upper layers.\n \t */\n \tif (tx_ring->launchtime_enable) {\n-\t\tts = ns_to_timespec64(first->skb->tstamp);\n-\t\tfirst->skb->tstamp = 0;\n+\t\tts = ktime_to_timespec64(first->skb->tstamp);\n+\t\tfirst->skb->tstamp = ktime_set(0, 0);\n \t\tcontext_desc->seqnum_seed = cpu_to_le32(ts.tv_nsec / 32);\n \t} else {\n \t\tcontext_desc->seqnum_seed = 0;\ndiff --git a/drivers/net/ethernet/intel/igc/igc_main.c b/drivers/net/ethernet/intel/igc/igc_main.c\nindex 8e424dfab12e..24888676f69b 100644\n--- a/drivers/net/ethernet/intel/igc/igc_main.c\n+++ b/drivers/net/ethernet/intel/igc/igc_main.c\n@@ -824,8 +824,8 @@ static void igc_tx_ctxtdesc(struct igc_ring *tx_ring,\n \t * should have been handled by the upper layers.\n \t */\n \tif (tx_ring->launchtime_enable) {\n-\t\tts = ns_to_timespec64(first->skb->tstamp);\n-\t\tfirst->skb->tstamp = 0;\n+\t\tts = ktime_to_timespec64(first->skb->tstamp);\n+\t\tfirst->skb->tstamp = ktime_set(0, 0);\n \t\tcontext_desc->launch_time = cpu_to_le32(ts.tv_nsec / 32);\n \t} else {\n \t\tcontext_desc->launch_time = 0;\n", "prefixes": [ "net" ] }