Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/1189478/?format=api
{ "id": 1189478, "url": "http://patchwork.ozlabs.org/api/patches/1189478/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20191105094413.1405-1-sasha.neftin@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20191105094413.1405-1-sasha.neftin@intel.com>", "list_archive_url": null, "date": "2019-11-05T09:44:13", "name": "[v1] igc: Improve the DMA mapping flow", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "b642a5fce7ab92516d18764a453ad214b49f9081", "submitter": { "id": 69860, "url": "http://patchwork.ozlabs.org/api/people/69860/?format=api", "name": "Sasha Neftin", "email": "sasha.neftin@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20191105094413.1405-1-sasha.neftin@intel.com/mbox/", "series": [ { "id": 140682, "url": "http://patchwork.ozlabs.org/api/series/140682/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=140682", "date": "2019-11-05T09:44:13", "name": "[v1] igc: Improve the DMA mapping flow", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/140682/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/1189478/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/1189478/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": [ "ozlabs.org; spf=pass (sender SPF authorized)\n\tsmtp.mailfrom=osuosl.org (client-ip=140.211.166.136;\n\thelo=silver.osuosl.org;\n\tenvelope-from=intel-wired-lan-bounces@osuosl.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org;\n\tdmarc=fail (p=none dis=none) header.from=intel.com" ], "Received": [ "from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 476l9y0d4Hz9s4Y\n\tfor <incoming@patchwork.ozlabs.org>;\n\tTue, 5 Nov 2019 20:44:21 +1100 (AEDT)", "from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id 660D3220D0;\n\tTue, 5 Nov 2019 09:44:19 +0000 (UTC)", "from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id 8TNpZXTVFbSH; Tue, 5 Nov 2019 09:44:16 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby silver.osuosl.org (Postfix) with ESMTP id 8FBAB220B2;\n\tTue, 5 Nov 2019 09:44:16 +0000 (UTC)", "from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n\tby ash.osuosl.org (Postfix) with ESMTP id 1B5681BF2CC\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tTue, 5 Nov 2019 09:44:16 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id 171CE890F7\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tTue, 5 Nov 2019 09:44:16 +0000 (UTC)", "from fraxinus.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id 8noBv7ZOYTKz for <intel-wired-lan@lists.osuosl.org>;\n\tTue, 5 Nov 2019 09:44:15 +0000 (UTC)", "from mga18.intel.com (mga18.intel.com [134.134.136.126])\n\tby fraxinus.osuosl.org (Postfix) with ESMTPS id 8B38A890ED\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tTue, 5 Nov 2019 09:44:15 +0000 (UTC)", "from fmsmga005.fm.intel.com ([10.253.24.32])\n\tby orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t05 Nov 2019 01:44:14 -0800", "from ccdlinuxdev08.iil.intel.com ([143.185.161.150])\n\tby fmsmga005.fm.intel.com with ESMTP; 05 Nov 2019 01:44:13 -0800" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.68,270,1569308400\"; d=\"scan'208\";a=\"401922250\"", "From": "Sasha Neftin <sasha.neftin@intel.com>", "To": "intel-wired-lan@lists.osuosl.org", "Date": "Tue, 5 Nov 2019 11:44:13 +0200", "Message-Id": "<20191105094413.1405-1-sasha.neftin@intel.com>", "X-Mailer": "git-send-email 2.11.0", "Subject": "[Intel-wired-lan] [PATCH v1] igc: Improve the DMA mapping flow", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "Improve the probe flow and set both the DMA mask and the coherent\nto the same thing. Make the flow optimized and cleared.\n\nSigned-off-by: Sasha Neftin <sasha.neftin@intel.com>\n---\n drivers/net/ethernet/intel/igc/igc_main.c | 24 +++++++++---------------\n 1 file changed, 9 insertions(+), 15 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/igc/igc_main.c b/drivers/net/ethernet/intel/igc/igc_main.c\nindex c3266645c95e..648aee679cb6 100644\n--- a/drivers/net/ethernet/intel/igc/igc_main.c\n+++ b/drivers/net/ethernet/intel/igc/igc_main.c\n@@ -4346,32 +4346,26 @@ static int igc_probe(struct pci_dev *pdev,\n \tstruct net_device *netdev;\n \tstruct igc_hw *hw;\n \tconst struct igc_info *ei = igc_info_tbl[ent->driver_data];\n-\tint err;\n+\tint err, pci_using_dac;\n \n \terr = pci_enable_device_mem(pdev);\n \tif (err)\n \t\treturn err;\n \n-\terr = dma_set_mask(&pdev->dev, DMA_BIT_MASK(64));\n+\tpci_using_dac = 0;\n+\terr = dma_set_mask_and_coherent(&pdev->dev, DMA_BIT_MASK(64));\n \tif (!err) {\n-\t\terr = dma_set_coherent_mask(&pdev->dev,\n-\t\t\t\t\t DMA_BIT_MASK(64));\n+\t\tpci_using_dac = 1;\n \t} else {\n-\t\terr = dma_set_mask(&pdev->dev, DMA_BIT_MASK(32));\n+\t\terr = dma_set_mask_and_coherent(&pdev->dev, DMA_BIT_MASK(32));\n \t\tif (err) {\n-\t\t\terr = dma_set_coherent_mask(&pdev->dev,\n-\t\t\t\t\t\t DMA_BIT_MASK(32));\n-\t\t\tif (err) {\n-\t\t\t\tdev_err(&pdev->dev, \"igc: Wrong DMA config\\n\");\n-\t\t\t\tgoto err_dma;\n-\t\t\t}\n+\t\t\tdev_err(&pdev->dev,\n+\t\t\t\t\"No usable DMA configuration, aborting\\n\");\n+\t\t\tgoto err_dma;\n \t\t}\n \t}\n \n-\terr = pci_request_selected_regions(pdev,\n-\t\t\t\t\t pci_select_bars(pdev,\n-\t\t\t\t\t\t\t IORESOURCE_MEM),\n-\t\t\t\t\t igc_driver_name);\n+\terr = pci_request_mem_regions(pdev, igc_driver_name);\n \tif (err)\n \t\tgoto err_pci_reg;\n \n", "prefixes": [ "v1" ] }