Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/1189089/?format=api
{ "id": 1189089, "url": "http://patchwork.ozlabs.org/api/patches/1189089/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20191104093108.21542-8-anthony.l.nguyen@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20191104093108.21542-8-anthony.l.nguyen@intel.com>", "list_archive_url": null, "date": "2019-11-04T09:31:01", "name": "[S32,v2,08/15] ice: Change max MSI-x vector_id check in cfg_irq_map", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": false, "hash": "c7082e38aa44573d160cd3d636df9d3bebc0cd8e", "submitter": { "id": 68875, "url": "http://patchwork.ozlabs.org/api/people/68875/?format=api", "name": "Tony Nguyen", "email": "anthony.l.nguyen@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20191104093108.21542-8-anthony.l.nguyen@intel.com/mbox/", "series": [ { "id": 140544, "url": "http://patchwork.ozlabs.org/api/series/140544/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=140544", "date": "2019-11-04T09:30:57", "name": "[S32,v2,01/15] ice: Use ice_ena_vsi and ice_dis_vsi in DCB configuration flow", "version": 2, "mbox": "http://patchwork.ozlabs.org/series/140544/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/1189089/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/1189089/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": [ "ozlabs.org; spf=pass (sender SPF authorized)\n\tsmtp.mailfrom=osuosl.org (client-ip=140.211.166.133;\n\thelo=hemlock.osuosl.org;\n\tenvelope-from=intel-wired-lan-bounces@osuosl.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org;\n\tdmarc=fail (p=none dis=none) header.from=intel.com" ], "Received": [ "from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 476LG559PLz9sPT\n\tfor <incoming@patchwork.ozlabs.org>;\n\tTue, 5 Nov 2019 05:01:33 +1100 (AEDT)", "from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id B3C8F8A9EF;\n\tMon, 4 Nov 2019 18:01:31 +0000 (UTC)", "from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id RKvLVhB1PZIs; Mon, 4 Nov 2019 18:01:30 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 8CF078A9EA;\n\tMon, 4 Nov 2019 18:01:30 +0000 (UTC)", "from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\tby ash.osuosl.org (Postfix) with ESMTP id 393091BF388\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tMon, 4 Nov 2019 18:01:28 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id 338CB20475\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tMon, 4 Nov 2019 18:01:28 +0000 (UTC)", "from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id qTYWlz8D5cDe for <intel-wired-lan@lists.osuosl.org>;\n\tMon, 4 Nov 2019 18:01:27 +0000 (UTC)", "from mga05.intel.com (mga05.intel.com [192.55.52.43])\n\tby silver.osuosl.org (Postfix) with ESMTPS id 2700420386\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tMon, 4 Nov 2019 18:01:27 +0000 (UTC)", "from fmsmga008.fm.intel.com ([10.253.24.58])\n\tby fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t04 Nov 2019 10:01:26 -0800", "from unknown (HELO localhost.jf.intel.com) ([10.166.244.174])\n\tby fmsmga008.fm.intel.com with ESMTP; 04 Nov 2019 10:01:26 -0800" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.68,267,1569308400\"; d=\"scan'208\";a=\"200098405\"", "From": "Tony Nguyen <anthony.l.nguyen@intel.com>", "To": "intel-wired-lan@lists.osuosl.org", "Date": "Mon, 4 Nov 2019 01:31:01 -0800", "Message-Id": "<20191104093108.21542-8-anthony.l.nguyen@intel.com>", "X-Mailer": "git-send-email 2.20.1", "In-Reply-To": "<20191104093108.21542-1-anthony.l.nguyen@intel.com>", "References": "<20191104093108.21542-1-anthony.l.nguyen@intel.com>", "MIME-Version": "1.0", "Subject": "[Intel-wired-lan] [PATCH S32 v2 08/15] ice: Change max MSI-x\n\tvector_id check in cfg_irq_map", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "From: Brett Creeley <brett.creeley@intel.com>\n\nCurrently we check to make sure the vector_id passed down from iavf\nis less than or equal to pf->hw.func_caps.common_caps.num_msix_vectors.\nThis is incorrect because the vector_id is always 0-based and never\ngreater than or equal to the ICE_MAX_INTR_PER_VF. Fix this by checking\nto make sure the vector_id is less than the max allowed interrupts per\nVF (ICE_MAX_INTR_PER_VF).\n\nSigned-off-by: Brett Creeley <brett.creeley@intel.com>\n---\n drivers/net/ethernet/intel/ice/ice_virtchnl_pf.c | 8 +++++---\n 1 file changed, 5 insertions(+), 3 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/ice/ice_virtchnl_pf.c b/drivers/net/ethernet/intel/ice/ice_virtchnl_pf.c\nindex 537377448bef..eb526144a237 100644\n--- a/drivers/net/ethernet/intel/ice/ice_virtchnl_pf.c\n+++ b/drivers/net/ethernet/intel/ice/ice_virtchnl_pf.c\n@@ -2179,9 +2179,11 @@ static int ice_vc_cfg_irq_map_msg(struct ice_vf *vf, u8 *msg)\n \n \t\tvector_id = map->vector_id;\n \t\tvsi_id = map->vsi_id;\n-\t\t/* validate msg params */\n-\t\tif (!(vector_id < pf->hw.func_caps.common_cap\n-\t\t .num_msix_vectors) || !ice_vc_isvalid_vsi_id(vf, vsi_id) ||\n+\t\t/* vector_id is always 0-based for each VF, and can never be\n+\t\t * larger than or equal to the max allowed interrupts per VF\n+\t\t */\n+\t\tif (!(vector_id < ICE_MAX_INTR_PER_VF) ||\n+\t\t !ice_vc_isvalid_vsi_id(vf, vsi_id) ||\n \t\t (!vector_id && (map->rxq_map || map->txq_map))) {\n \t\t\tv_ret = VIRTCHNL_STATUS_ERR_PARAM;\n \t\t\tgoto error_param;\n", "prefixes": [ "S32", "v2", "08/15" ] }