Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/1188052/?format=api
{ "id": 1188052, "url": "http://patchwork.ozlabs.org/api/patches/1188052/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20191101140017.16646-1-colin.king@canonical.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20191101140017.16646-1-colin.king@canonical.com>", "list_archive_url": null, "date": "2019-11-01T14:00:17", "name": "ice: fix potential infinite loop because loop counter being too small", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "70b816ab57f062bb87c2ed86827048944aa7793f", "submitter": { "id": 2900, "url": "http://patchwork.ozlabs.org/api/people/2900/?format=api", "name": "Colin Ian King", "email": "colin.king@canonical.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20191101140017.16646-1-colin.king@canonical.com/mbox/", "series": [ { "id": 140118, "url": "http://patchwork.ozlabs.org/api/series/140118/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=140118", "date": "2019-11-01T14:00:17", "name": "ice: fix potential infinite loop because loop counter being too small", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/140118/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/1188052/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/1188052/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": [ "ozlabs.org; spf=pass (sender SPF authorized)\n\tsmtp.mailfrom=osuosl.org (client-ip=140.211.166.137;\n\thelo=fraxinus.osuosl.org;\n\tenvelope-from=intel-wired-lan-bounces@osuosl.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org; dmarc=fail (p=none dis=none)\n\theader.from=canonical.com" ], "Received": [ "from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 474P3J4vhMz9sRD\n\tfor <incoming@patchwork.ozlabs.org>;\n\tSat, 2 Nov 2019 01:00:27 +1100 (AEDT)", "from localhost (localhost [127.0.0.1])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id E4B0786AB5;\n\tFri, 1 Nov 2019 14:00:25 +0000 (UTC)", "from fraxinus.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id 0bvDUvXmffO4; Fri, 1 Nov 2019 14:00:24 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id 6698E86AAA;\n\tFri, 1 Nov 2019 14:00:24 +0000 (UTC)", "from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\tby ash.osuosl.org (Postfix) with ESMTP id BDB361BF846\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tFri, 1 Nov 2019 14:00:23 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id AA28B20412\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tFri, 1 Nov 2019 14:00:23 +0000 (UTC)", "from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id nnZRISEzM6zn for <intel-wired-lan@lists.osuosl.org>;\n\tFri, 1 Nov 2019 14:00:23 +0000 (UTC)", "from youngberry.canonical.com (youngberry.canonical.com\n\t[91.189.89.112])\n\tby silver.osuosl.org (Postfix) with ESMTPS id E3364203D9\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tFri, 1 Nov 2019 14:00:22 +0000 (UTC)", "from 1.general.cking.uk.vpn ([10.172.193.212] helo=localhost)\n\tby youngberry.canonical.com with esmtpsa\n\t(TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.86_2)\n\t(envelope-from <colin.king@canonical.com>)\n\tid 1iQXTN-00055Z-FX; Fri, 01 Nov 2019 14:00:17 +0000" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "From": "Colin King <colin.king@canonical.com>", "To": "Jeff Kirsher <jeffrey.t.kirsher@intel.com>,\n\t\"David S . Miller\" <davem@davemloft.net>,\n\tAnirudh Venkataramanan <anirudh.venkataramanan@intel.com>,\n\tintel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org", "Date": "Fri, 1 Nov 2019 14:00:17 +0000", "Message-Id": "<20191101140017.16646-1-colin.king@canonical.com>", "X-Mailer": "git-send-email 2.20.1", "MIME-Version": "1.0", "Subject": "[Intel-wired-lan] [PATCH] ice: fix potential infinite loop because\n\tloop counter being too small", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "Cc": "kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "From: Colin Ian King <colin.king@canonical.com>\n\nCurrently the for-loop counter i is a u8 however it is being checked\nagainst a maximum value hw->num_tx_sched_layers which is a u16. Hence\nthere is a potential wrap-around of counter i back to zero if\nhw->num_tx_sched_layers is greater than 255. Fix this by making i\na u16.\n\nAddresses-Coverity: (\"Infinite loop\")\nFixes: b36c598c999c (\"ice: Updates to Tx scheduler code\")\nSigned-off-by: Colin Ian King <colin.king@canonical.com>\n---\n drivers/net/ethernet/intel/ice/ice_sched.c | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)", "diff": "diff --git a/drivers/net/ethernet/intel/ice/ice_sched.c b/drivers/net/ethernet/intel/ice/ice_sched.c\nindex fc624b73d05d..2fde9653a608 100644\n--- a/drivers/net/ethernet/intel/ice/ice_sched.c\n+++ b/drivers/net/ethernet/intel/ice/ice_sched.c\n@@ -1036,7 +1036,7 @@ enum ice_status ice_sched_query_res_alloc(struct ice_hw *hw)\n \tstruct ice_aqc_query_txsched_res_resp *buf;\n \tenum ice_status status = 0;\n \t__le16 max_sibl;\n-\tu8 i;\n+\tu16 i;\n \n \tif (hw->layer_info)\n \t\treturn status;\n", "prefixes": [] }