Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/1187612/?format=api
{ "id": 1187612, "url": "http://patchwork.ozlabs.org/api/patches/1187612/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20191031165537.24154.48242.stgit@localhost.localdomain/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20191031165537.24154.48242.stgit@localhost.localdomain>", "list_archive_url": null, "date": "2019-10-31T16:58:51", "name": "[next-queue/net-next] e1000e: Use netdev_info instead of pr_info for link messages", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "eccc66253c69f0393d92b6e59e86d35f5d5f26f0", "submitter": { "id": 252, "url": "http://patchwork.ozlabs.org/api/people/252/?format=api", "name": "Alexander Duyck", "email": "alexander.duyck@gmail.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20191031165537.24154.48242.stgit@localhost.localdomain/mbox/", "series": [ { "id": 139925, "url": "http://patchwork.ozlabs.org/api/series/139925/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=139925", "date": "2019-10-31T16:58:51", "name": "[next-queue/net-next] e1000e: Use netdev_info instead of pr_info for link messages", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/139925/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/1187612/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/1187612/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": [ "ozlabs.org; spf=pass (sender SPF authorized)\n\tsmtp.mailfrom=osuosl.org (client-ip=140.211.166.138;\n\thelo=whitealder.osuosl.org;\n\tenvelope-from=intel-wired-lan-bounces@osuosl.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org;\n\tdmarc=fail (p=none dis=none) header.from=gmail.com", "ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"DkSoRXJw\"; dkim-atps=neutral" ], "Received": [ "from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 473s3m2wJBz9sCJ\n\tfor <incoming@patchwork.ozlabs.org>;\n\tFri, 1 Nov 2019 03:58:59 +1100 (AEDT)", "from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 0E3AC87967;\n\tThu, 31 Oct 2019 16:58:57 +0000 (UTC)", "from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id YIP+GMDkDbSx; Thu, 31 Oct 2019 16:58:55 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id C117E8795A;\n\tThu, 31 Oct 2019 16:58:55 +0000 (UTC)", "from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\tby ash.osuosl.org (Postfix) with ESMTP id 27A2C1BF28A\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 31 Oct 2019 16:58:55 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 2201D882F6\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 31 Oct 2019 16:58:55 +0000 (UTC)", "from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id 5bU1rFHKB-IQ for <intel-wired-lan@lists.osuosl.org>;\n\tThu, 31 Oct 2019 16:58:54 +0000 (UTC)", "from mail-pg1-f195.google.com (mail-pg1-f195.google.com\n\t[209.85.215.195])\n\tby hemlock.osuosl.org (Postfix) with ESMTPS id 63A82882F3\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 31 Oct 2019 16:58:54 +0000 (UTC)", "by mail-pg1-f195.google.com with SMTP id p12so4420425pgn.6\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 31 Oct 2019 09:58:54 -0700 (PDT)", "from localhost.localdomain ([2001:470:b:9c3:9e5c:8eff:fe4f:f2d0])\n\tby smtp.gmail.com with ESMTPSA id\n\th9sm4349964pfn.167.2019.10.31.09.58.52\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tThu, 31 Oct 2019 09:58:52 -0700 (PDT)" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=subject:from:to:cc:date:message-id:in-reply-to:references\n\t:user-agent:mime-version:content-transfer-encoding;\n\tbh=f05iF9G/ns17rw6cWJfFu0PgDfLMjLHyebXYR1Ckmlg=;\n\tb=DkSoRXJw1W+71GwuFvu0kD3++jlSponfDd7ClMOLNsxEwkHMn0jd8JKBqtihFBP0Fj\n\t8FvYmMSpvVEb3/+tgTiUHEvX8Cx8Dcc+PLviBuzmNqfs/2u5FSBWMhBF4qljZSF4wzuM\n\tlpx16wijqYPNnd285Yh/IqVKFoASglncCZBa0gp5eG2eExIbOFojDjadlR4v8wBcsX3Y\n\t8hzm0Y+ffSUK/lmDtNGVxc2IPU/QNSpC8Jhmdhmps0mM9FQL/bcD6qTh26G61dhuQnBj\n\tQ3jsEJWUhKP7+xgpo2g+0QDg6dB5Z7SfmK87pFAXgOxBXPXr4Mra0jLePTQv+gHOyD/+\n\trf9A==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:subject:from:to:cc:date:message-id:in-reply-to\n\t:references:user-agent:mime-version:content-transfer-encoding;\n\tbh=f05iF9G/ns17rw6cWJfFu0PgDfLMjLHyebXYR1Ckmlg=;\n\tb=ozyZi0lDEO9Kp5vxvlPaykvxILMtC0AdxV/eMZBomy3IKDp+wjXeeiytV05DveWmwA\n\t4vtodZ7yfrezD6VZGVG2b1RppRmpsrp2DIUMM7VzP926/JlZwG0xlFOETzmTOVyfARl2\n\tw3G9IBiJssORt6esWwLTaNSEM+YANu+Oga4EPBGpO8zGm26A21wBQg7L+rgyNskDH6Kw\n\tQ+kVTQ0giR+Bjh7mJKIIoHRf9YF3tKZM3OPJBA2TJ/ESYJi1vGD639y3fcdKoL+yZk2q\n\tKjEQpJrGhxDS0QbQejWX6lQVTsz3ggd9/t0QRO4TzGiTDS6jVn3AhCvG1kbi/xjop25M\n\ts+dA==", "X-Gm-Message-State": "APjAAAVMLq+DpxSRh2B357eJkB7jHbobICpp6V3vC0aAAn5jpwi0h4dW\n\tAjTFnYgkJf1Xq8zGqYRUy2Q=", "X-Google-Smtp-Source": "APXvYqwFrU1yqpKXXBPuvye6oNxNqBJVeGKNV+dW703NTSZb4ccjtQbJslh1Up020KD8f+yf0tL92A==", "X-Received": "by 2002:a63:3603:: with SMTP id d3mr8094466pga.208.1572541133575;\n\tThu, 31 Oct 2019 09:58:53 -0700 (PDT)", "From": "Alexander Duyck <alexander.duyck@gmail.com>", "To": "joe@perches.com, jeffrey.t.kirsher@intel.com, davem@davemloft.net", "Date": "Thu, 31 Oct 2019 09:58:51 -0700", "Message-ID": "<20191031165537.24154.48242.stgit@localhost.localdomain>", "In-Reply-To": "<cf197ef61703cbaa64ac522cf5d191b4b74f64d6.camel@linux.intel.com>", "References": "<cf197ef61703cbaa64ac522cf5d191b4b74f64d6.camel@linux.intel.com>", "User-Agent": "StGit/0.17.1-dirty", "MIME-Version": "1.0", "Subject": "[Intel-wired-lan] [next-queue/net-next PATCH] e1000e: Use\n\tnetdev_info instead of pr_info for link messages", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "Cc": "zdai@linux.vnet.ibm.com, nhorman@redhat.com, netdev@vger.kernel.org,\n\tsmorumu1@in.ibm.com, intel-wired-lan@lists.osuosl.org,\n\tsassmann@redhat.com", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "From: Alexander Duyck <alexander.h.duyck@linux.intel.com>\n\nReplace the pr_info calls with netdev_info in all cases related to the\nnetdevice link state.\n\nAs a result of this patch the link messages will change as shown below.\nBefore:\ne1000e: ens3 NIC Link is Down\ne1000e: ens3 NIC Link is Up 1000 Mbps Full Duplex, Flow Control: Rx/Tx\n\nAfter:\ne1000e 0000:00:03.0 ens3: NIC Link is Down\ne1000e 0000:00:03.0 ens3: NIC Link is Up 1000 Mbps Full Duplex, Flow Control: Rx/Tx\n\nSuggested-by: Joe Perches <joe@perches.com>\nSigned-off-by: Alexander Duyck <alexander.h.duyck@linux.intel.com>\n---\n\nSince Joe hasn't gotten back to me on if he wanted to do the patch or if\nhe wanted me to do it I just went ahead and did it. This should address the\nconcerns he had about the message formatting in \"e1000e: Use rtnl_lock to\nprevent race\".\n\n drivers/net/ethernet/intel/e1000e/netdev.c | 9 +++++----\n 1 file changed, 5 insertions(+), 4 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/e1000e/netdev.c b/drivers/net/ethernet/intel/e1000e/netdev.c\nindex ef8ca0c134b0..a1aa48168855 100644\n--- a/drivers/net/ethernet/intel/e1000e/netdev.c\n+++ b/drivers/net/ethernet/intel/e1000e/netdev.c\n@@ -4720,7 +4720,7 @@ int e1000e_close(struct net_device *netdev)\n \t\te1000_free_irq(adapter);\n \n \t\t/* Link status message must follow this format */\n-\t\tpr_info(\"%s NIC Link is Down\\n\", netdev->name);\n+\t\tnetdev_info(netdev, \"NIC Link is Down\\n\");\n \t}\n \n \tnapi_disable(&adapter->napi);\n@@ -5070,8 +5070,9 @@ static void e1000_print_link_info(struct e1000_adapter *adapter)\n \tu32 ctrl = er32(CTRL);\n \n \t/* Link status message must follow this format for user tools */\n-\tpr_info(\"%s NIC Link is Up %d Mbps %s Duplex, Flow Control: %s\\n\",\n-\t\tadapter->netdev->name, adapter->link_speed,\n+\tnetdev_info(adapter->netdev,\n+\t\t\"NIC Link is Up %d Mbps %s Duplex, Flow Control: %s\\n\",\n+\t\tadapter->link_speed,\n \t\tadapter->link_duplex == FULL_DUPLEX ? \"Full\" : \"Half\",\n \t\t(ctrl & E1000_CTRL_TFCE) && (ctrl & E1000_CTRL_RFCE) ? \"Rx/Tx\" :\n \t\t(ctrl & E1000_CTRL_RFCE) ? \"Rx\" :\n@@ -5304,7 +5305,7 @@ static void e1000_watchdog_task(struct work_struct *work)\n \t\t\tadapter->link_speed = 0;\n \t\t\tadapter->link_duplex = 0;\n \t\t\t/* Link status message must follow this format */\n-\t\t\tpr_info(\"%s NIC Link is Down\\n\", adapter->netdev->name);\n+\t\t\tnetdev_info(netdev, \"NIC Link is Down\\n\");\n \t\t\tnetif_carrier_off(netdev);\n \t\t\tnetif_stop_queue(netdev);\n \t\t\tif (!test_bit(__E1000_DOWN, &adapter->state))\n", "prefixes": [ "next-queue/net-next" ] }