Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/1184475/?format=api
{ "id": 1184475, "url": "http://patchwork.ozlabs.org/api/patches/1184475/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20191025143441.50151-4-anthony.l.nguyen@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20191025143441.50151-4-anthony.l.nguyen@intel.com>", "list_archive_url": null, "date": "2019-10-25T14:34:30", "name": "[S32,04/15] ice: avoid setting features during reset", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "c91a850ef007838f0924f91a733eee8036d2af91", "submitter": { "id": 68875, "url": "http://patchwork.ozlabs.org/api/people/68875/?format=api", "name": "Tony Nguyen", "email": "anthony.l.nguyen@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20191025143441.50151-4-anthony.l.nguyen@intel.com/mbox/", "series": [ { "id": 138814, "url": "http://patchwork.ozlabs.org/api/series/138814/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=138814", "date": "2019-10-25T14:34:39", "name": "[S32,01/15] ice: Use ice_ena_vsi and ice_dis_vsi in DCB configuration flow", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/138814/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/1184475/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/1184475/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": [ "ozlabs.org; spf=pass (sender SPF authorized)\n\tsmtp.mailfrom=osuosl.org (client-ip=140.211.166.133;\n\thelo=hemlock.osuosl.org;\n\tenvelope-from=intel-wired-lan-bounces@osuosl.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org;\n\tdmarc=fail (p=none dis=none) header.from=intel.com" ], "Received": [ "from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 470KTC12ckz9sPq\n\tfor <incoming@patchwork.ozlabs.org>;\n\tSat, 26 Oct 2019 10:05:18 +1100 (AEDT)", "from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 31B2788471;\n\tFri, 25 Oct 2019 23:05:17 +0000 (UTC)", "from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id 276LcgeAsyIy; Fri, 25 Oct 2019 23:05:16 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 71BAD8845E;\n\tFri, 25 Oct 2019 23:05:16 +0000 (UTC)", "from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\tby ash.osuosl.org (Postfix) with ESMTP id ABE131BF333\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tFri, 25 Oct 2019 23:05:12 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id A313387A68\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tFri, 25 Oct 2019 23:05:12 +0000 (UTC)", "from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id E8Zjgm5MvbLQ for <intel-wired-lan@lists.osuosl.org>;\n\tFri, 25 Oct 2019 23:05:11 +0000 (UTC)", "from mga02.intel.com (mga02.intel.com [134.134.136.20])\n\tby whitealder.osuosl.org (Postfix) with ESMTPS id 9528A87A47\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tFri, 25 Oct 2019 23:05:11 +0000 (UTC)", "from orsmga002.jf.intel.com ([10.7.209.21])\n\tby orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t25 Oct 2019 16:05:09 -0700", "from unknown (HELO localhost.jf.intel.com) ([10.166.244.174])\n\tby orsmga002.jf.intel.com with ESMTP; 25 Oct 2019 16:05:08 -0700" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.68,230,1569308400\"; d=\"scan'208\";a=\"210868739\"", "From": "Tony Nguyen <anthony.l.nguyen@intel.com>", "To": "intel-wired-lan@lists.osuosl.org", "Date": "Fri, 25 Oct 2019 07:34:30 -0700", "Message-Id": "<20191025143441.50151-4-anthony.l.nguyen@intel.com>", "X-Mailer": "git-send-email 2.20.1", "In-Reply-To": "<20191025143441.50151-1-anthony.l.nguyen@intel.com>", "References": "<20191025143441.50151-1-anthony.l.nguyen@intel.com>", "MIME-Version": "1.0", "Subject": "[Intel-wired-lan] [PATCH S32 04/15] ice: avoid setting features\n\tduring reset", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "From: Henry Tieman <henry.w.tieman@intel.com>\n\nCertain subsystems behave very badly when called during reset (core\ndump). This patch returns -EBUSY when reconfiguring some subsystems\nduring reset. With this patch some ethtool functions will not core\ndump during reset.\n\nSigned-off-by: Henry Tieman <henry.w.tieman@intel.com>\n---\n drivers/net/ethernet/intel/ice/ice_main.c | 8 ++++++++\n 1 file changed, 8 insertions(+)", "diff": "diff --git a/drivers/net/ethernet/intel/ice/ice_main.c b/drivers/net/ethernet/intel/ice/ice_main.c\nindex a0a04114d991..94354b307a4e 100644\n--- a/drivers/net/ethernet/intel/ice/ice_main.c\n+++ b/drivers/net/ethernet/intel/ice/ice_main.c\n@@ -3924,6 +3924,7 @@ ice_set_features(struct net_device *netdev, netdev_features_t features)\n {\n \tstruct ice_netdev_priv *np = netdev_priv(netdev);\n \tstruct ice_vsi *vsi = np->vsi;\n+\tstruct ice_pf *pf = vsi->back;\n \tint ret = 0;\n \n \t/* Don't set any netdev advanced features with device in Safe Mode */\n@@ -3933,6 +3934,13 @@ ice_set_features(struct net_device *netdev, netdev_features_t features)\n \t\treturn ret;\n \t}\n \n+\t/* Do not change setting during reset */\n+\tif (ice_is_reset_in_progress(pf->state)) {\n+\t\tdev_err(&vsi->back->pdev->dev,\n+\t\t\t\"Device is resetting, changing advanced netdev features temporarily unavailable.\\n\");\n+\t\treturn -EBUSY;\n+\t}\n+\n \t/* Multiple features can be changed in one call so keep features in\n \t * separate if/else statements to guarantee each feature is checked\n \t */\n", "prefixes": [ "S32", "04/15" ] }