Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/1174133/?format=api
{ "id": 1174133, "url": "http://patchwork.ozlabs.org/api/patches/1174133/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20191009140925.13997-9-anthony.l.nguyen@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20191009140925.13997-9-anthony.l.nguyen@intel.com>", "list_archive_url": null, "date": "2019-10-09T14:09:25", "name": "[S30,9/9] ice: allow 3k MTU for XDP", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "0e39eeef8ccc74c881069dd2f698847c6047f318", "submitter": { "id": 68875, "url": "http://patchwork.ozlabs.org/api/people/68875/?format=api", "name": "Tony Nguyen", "email": "anthony.l.nguyen@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20191009140925.13997-9-anthony.l.nguyen@intel.com/mbox/", "series": [ { "id": 135202, "url": "http://patchwork.ozlabs.org/api/series/135202/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=135202", "date": "2019-10-09T14:09:18", "name": "[S30,1/9] ice: Introduce ice_base.c", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/135202/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/1174133/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/1174133/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": [ "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=osuosl.org\n\t(client-ip=140.211.166.133; helo=hemlock.osuosl.org;\n\tenvelope-from=intel-wired-lan-bounces@osuosl.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org;\n\tdmarc=fail (p=none dis=none) header.from=intel.com" ], "Received": [ "from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 46pTg64vyXz9sN1\n\tfor <incoming@patchwork.ozlabs.org>;\n\tThu, 10 Oct 2019 09:39:46 +1100 (AEDT)", "from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 15E218846B;\n\tWed, 9 Oct 2019 22:39:45 +0000 (UTC)", "from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id OS94wTCTAaxp; Wed, 9 Oct 2019 22:39:44 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 908E5883A1;\n\tWed, 9 Oct 2019 22:39:44 +0000 (UTC)", "from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\tby ash.osuosl.org (Postfix) with ESMTP id 1F6691BF3CC\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 9 Oct 2019 22:39:41 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id EF9258837F\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 9 Oct 2019 22:39:40 +0000 (UTC)", "from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id 5R6LjioT6RMg for <intel-wired-lan@lists.osuosl.org>;\n\tWed, 9 Oct 2019 22:39:39 +0000 (UTC)", "from mga06.intel.com (mga06.intel.com [134.134.136.31])\n\tby hemlock.osuosl.org (Postfix) with ESMTPS id 3E3D8883B8\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 9 Oct 2019 22:39:38 +0000 (UTC)", "from orsmga007.jf.intel.com ([10.7.209.58])\n\tby orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t09 Oct 2019 15:39:34 -0700", "from unknown (HELO localhost.jf.intel.com) ([10.166.244.174])\n\tby orsmga007.jf.intel.com with ESMTP; 09 Oct 2019 15:39:33 -0700" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.67,277,1566889200\"; d=\"scan'208\";a=\"184218362\"", "From": "Tony Nguyen <anthony.l.nguyen@intel.com>", "To": "intel-wired-lan@lists.osuosl.org", "Date": "Wed, 9 Oct 2019 07:09:25 -0700", "Message-Id": "<20191009140925.13997-9-anthony.l.nguyen@intel.com>", "X-Mailer": "git-send-email 2.20.1", "In-Reply-To": "<20191009140925.13997-1-anthony.l.nguyen@intel.com>", "References": "<20191009140925.13997-1-anthony.l.nguyen@intel.com>", "MIME-Version": "1.0", "Subject": "[Intel-wired-lan] [PATCH S30 9/9] ice: allow 3k MTU for XDP", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "From: Maciej Fijalkowski <maciej.fijalkowski@intel.com>\n\nAt this point ice driver is able to work on order 1 pages that are split\nonto two 3k buffers. Let's reflect that when user is setting new mtu\nsize and XDP is present on interface.\n\nSigned-off-by: Maciej Fijalkowski <maciej.fijalkowski@intel.com>\nSigned-off-by: Tony Nguyen <anthony.l.nguyen@intel.com>\n---\n drivers/net/ethernet/intel/ice/ice_main.c | 16 ++++++++++++++--\n 1 file changed, 14 insertions(+), 2 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/ice/ice_main.c b/drivers/net/ethernet/intel/ice/ice_main.c\nindex 66e3b983d94a..88b5941ecf5c 100644\n--- a/drivers/net/ethernet/intel/ice/ice_main.c\n+++ b/drivers/net/ethernet/intel/ice/ice_main.c\n@@ -4765,6 +4765,18 @@ static void ice_rebuild(struct ice_pf *pf, enum ice_reset_req reset_type)\n \tdev_err(dev, \"Rebuild failed, unload and reload driver\\n\");\n }\n \n+/**\n+ * ice_max_xdp_frame_size - returns the maximum allowed frame size for XDP\n+ * @vsi: Pointer to VSI structure\n+ */\n+static int ice_max_xdp_frame_size(struct ice_vsi *vsi)\n+{\n+\tif (PAGE_SIZE >= 8192 || test_bit(ICE_FLAG_LEGACY_RX, vsi->back->flags))\n+\t\treturn ICE_RXBUF_2048 - XDP_PACKET_HEADROOM;\n+\telse\n+\t\treturn ICE_RXBUF_3072;\n+}\n+\n /**\n * ice_change_mtu - NDO callback to change the MTU\n * @netdev: network interface device structure\n@@ -4786,11 +4798,11 @@ static int ice_change_mtu(struct net_device *netdev, int new_mtu)\n \t}\n \n \tif (ice_is_xdp_ena_vsi(vsi)) {\n-\t\tint frame_size = ICE_RXBUF_2048 - XDP_PACKET_HEADROOM;\n+\t\tint frame_size = ice_max_xdp_frame_size(vsi);\n \n \t\tif (new_mtu + ICE_ETH_PKT_HDR_PAD > frame_size) {\n \t\t\tnetdev_err(netdev, \"max MTU for XDP usage is %d\\n\",\n-\t\t\t\t frame_size);\n+\t\t\t\t frame_size - ICE_ETH_PKT_HDR_PAD);\n \t\t\treturn -EINVAL;\n \t\t}\n \t}\n", "prefixes": [ "S30", "9/9" ] }