Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/1173524/?format=api
{ "id": 1173524, "url": "http://patchwork.ozlabs.org/api/patches/1173524/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20191008211644.4575.90683.stgit@localhost.localdomain/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20191008211644.4575.90683.stgit@localhost.localdomain>", "list_archive_url": null, "date": "2019-10-08T21:16:45", "name": "[next-queue,2/2] e1000e: Drop unnecessary __E1000_DOWN bit twiddling", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "ccb47b1a834532946a399ae7bb8f4bbd92ef9b5c", "submitter": { "id": 252, "url": "http://patchwork.ozlabs.org/api/people/252/?format=api", "name": "Alexander Duyck", "email": "alexander.duyck@gmail.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20191008211644.4575.90683.stgit@localhost.localdomain/mbox/", "series": [ { "id": 134947, "url": "http://patchwork.ozlabs.org/api/series/134947/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=134947", "date": "2019-10-08T21:16:32", "name": "Address IRQ related crash seen due to io_perm_failure", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/134947/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/1173524/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/1173524/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": [ "ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=osuosl.org\n\t(client-ip=140.211.166.137; helo=fraxinus.osuosl.org;\n\tenvelope-from=intel-wired-lan-bounces@osuosl.org;\n\treceiver=<UNKNOWN>)", "ozlabs.org;\n\tdmarc=fail (p=none dis=none) header.from=gmail.com", "ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"sz3ldgI+\"; dkim-atps=neutral" ], "Received": [ "from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 46nqst4P8gz9sDB\n\tfor <incoming@patchwork.ozlabs.org>;\n\tWed, 9 Oct 2019 08:16:50 +1100 (AEDT)", "from localhost (localhost [127.0.0.1])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id 06BF68652A;\n\tTue, 8 Oct 2019 21:16:49 +0000 (UTC)", "from fraxinus.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id 81QmJX4nAvHZ; Tue, 8 Oct 2019 21:16:48 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id 7E033864AA;\n\tTue, 8 Oct 2019 21:16:48 +0000 (UTC)", "from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\tby ash.osuosl.org (Postfix) with ESMTP id 6B6CD1BF28E\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tTue, 8 Oct 2019 21:16:47 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 67ED786450\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tTue, 8 Oct 2019 21:16:47 +0000 (UTC)", "from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id AY676-DHFip4 for <intel-wired-lan@lists.osuosl.org>;\n\tTue, 8 Oct 2019 21:16:46 +0000 (UTC)", "from mail-pg1-f196.google.com (mail-pg1-f196.google.com\n\t[209.85.215.196])\n\tby hemlock.osuosl.org (Postfix) with ESMTPS id BCACC85F8E\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tTue, 8 Oct 2019 21:16:46 +0000 (UTC)", "by mail-pg1-f196.google.com with SMTP id p30so8906158pgl.2\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tTue, 08 Oct 2019 14:16:46 -0700 (PDT)", "from localhost.localdomain ([2001:470:b:9c3:9e5c:8eff:fe4f:f2d0])\n\tby smtp.gmail.com with ESMTPSA id\n\ts73sm102895pjb.15.2019.10.08.14.16.45\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tTue, 08 Oct 2019 14:16:45 -0700 (PDT)" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=subject:from:to:cc:date:message-id:in-reply-to:references\n\t:user-agent:mime-version:content-transfer-encoding;\n\tbh=TxlfhWbpcunGBzzfNw2ijs+JMA3LBzP7XlcoEFlBGz0=;\n\tb=sz3ldgI+AoCabCy0dt3u3e14oPscxWCZpcM6rQVoSGDhvGWZLTUwsYUA+7692YcXB+\n\tul6g+wSHsMK156ht3S5CkAijSXWxko9CHurkCHjDUVwqQ0iJiLGIKvpqJ57iacQ/Ol7a\n\tClBzUfhMVKUYYyi7uoujOFW0J+1NIZhxC9eSJQr/6MpceQYF6pSjyoIdiEsDWUfvNvda\n\tKJ5unsSokihuredX8hza2QpuyROWkAFt+4YiibrnQS8ANr2UzGBursDhOzW3xJ/4THZo\n\to+xbicWC9mclAjfzyTLwvgD2BAedY/Mh0zuekN1x6r1E2Wh9m5wN+oQBJUShftokMTyD\n\tttzA==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:subject:from:to:cc:date:message-id:in-reply-to\n\t:references:user-agent:mime-version:content-transfer-encoding;\n\tbh=TxlfhWbpcunGBzzfNw2ijs+JMA3LBzP7XlcoEFlBGz0=;\n\tb=JdDwjcU66ZturKBchFFzfbZcSquSLp2BNevwUHbQrGE+ycZoGlHad2MblRWcU7HU4+\n\tiEH4XSjQJvNsCCoX3jc50lJF9E7iWn0x4bqhP6O4IjzeuSRR4b+bIG5xCjad5gfpjPXQ\n\tI8BSDNMkRS6utFj7bUMckyjKnJ3y0/9EsR0qxsTVlqgH91c0d1c+efS0FTngwfOOGFWK\n\tiRVBDl9JffiXS2ekltzBzLFy91MvOEHTkebPfvFs+8k1BwK5BHHg9ieM72aS3wBtYFQp\n\t6ZpDIdE4GSIFG7wFW4/wymEpl3QmPmgHmxNmsh38kZwd3tJBe8Uh2aTOrRFoO4iOM1QB\n\tczdw==", "X-Gm-Message-State": "APjAAAVAOzz2M7CvAvUxDEyEhrXCFuLHvw8nxEdHaoNr0J3jEToiqg+l\n\tObJE0C+voyxdM1FbXmRUAOk=", "X-Google-Smtp-Source": "APXvYqxvHpDH5MjJEeTSJwoYowxlOtitxd2+6Jh9UJDazvULERueDJfKAg7c3G8DPZWrwHmWXMS0Sw==", "X-Received": "by 2002:a17:90a:7142:: with SMTP id\n\tg2mr8323303pjs.36.1570569406178; \n\tTue, 08 Oct 2019 14:16:46 -0700 (PDT)", "From": "Alexander Duyck <alexander.duyck@gmail.com>", "To": "alexander.h.duyck@linux.intel.com, intel-wired-lan@lists.osuosl.org,\n\tjeffrey.t.kirsher@intel.com", "Date": "Tue, 08 Oct 2019 14:16:45 -0700", "Message-ID": "<20191008211644.4575.90683.stgit@localhost.localdomain>", "In-Reply-To": "<20191008210639.4575.44144.stgit@localhost.localdomain>", "References": "<20191008210639.4575.44144.stgit@localhost.localdomain>", "User-Agent": "StGit/0.17.1-dirty", "MIME-Version": "1.0", "Subject": "[Intel-wired-lan] [next-queue PATCH 2/2] e1000e: Drop unnecessary\n\t__E1000_DOWN bit twiddling", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "Cc": "netdev@vger.kernel.org, zdai@us.ibm.com, zdai@linux.vnet.ibm.com", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "From: Alexander Duyck <alexander.h.duyck@linux.intel.com>\n\nSince we no longer check for __E1000_DOWN in e1000e_close we can drop the\nspot where we were restoring the bit. This saves us a bit of unnecessary\ncomplexity.\n\nSigned-off-by: Alexander Duyck <alexander.h.duyck@linux.intel.com>\n---\n drivers/net/ethernet/intel/e1000e/netdev.c | 7 +------\n 1 file changed, 1 insertion(+), 6 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/e1000e/netdev.c b/drivers/net/ethernet/intel/e1000e/netdev.c\nindex 8b4e589aca36..1e4f69a0f0aa 100644\n--- a/drivers/net/ethernet/intel/e1000e/netdev.c\n+++ b/drivers/net/ethernet/intel/e1000e/netdev.c\n@@ -7409,15 +7409,13 @@ static void e1000_remove(struct pci_dev *pdev)\n {\n \tstruct net_device *netdev = pci_get_drvdata(pdev);\n \tstruct e1000_adapter *adapter = netdev_priv(netdev);\n-\tbool down = test_bit(__E1000_DOWN, &adapter->state);\n \n \te1000e_ptp_remove(adapter);\n \n \t/* The timers may be rescheduled, so explicitly disable them\n \t * from being rescheduled.\n \t */\n-\tif (!down)\n-\t\tset_bit(__E1000_DOWN, &adapter->state);\n+\tset_bit(__E1000_DOWN, &adapter->state);\n \tdel_timer_sync(&adapter->phy_info_timer);\n \n \tcancel_work_sync(&adapter->reset_task);\n@@ -7437,9 +7435,6 @@ static void e1000_remove(struct pci_dev *pdev)\n \t\t}\n \t}\n \n-\t/* Don't lie to e1000_close() down the road. */\n-\tif (!down)\n-\t\tclear_bit(__E1000_DOWN, &adapter->state);\n \tunregister_netdev(netdev);\n \n \tif (pci_dev_run_wake(pdev))\n", "prefixes": [ "next-queue", "2/2" ] }